Dean Herbert
d653335b6f
Add basic skin editor clipboard implementation
2023-02-15 19:28:42 +09:00
Dean Herbert
08ed174f61
Change GameplaySkinComponentLookup's generic to always be an enum
...
And document the class better.
2023-02-15 18:48:14 +09:00
Dean Herbert
a92e42bb84
Rename SkinnableTargetContainer to SkinComponentsContainer
...
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
2023-02-15 18:37:41 +09:00
Dean Herbert
b1cf6d83d8
Move extension methods closer to serialisation classes
2023-02-15 18:37:41 +09:00
Dean Herbert
e61d2d571c
Move the lookup type out of ISserialisableDrawableContainer
2023-02-15 18:37:41 +09:00
Dean Herbert
a7b47f6503
Rename ISkinnableTarget to ISerialisableDrawableContainer
2023-02-15 18:37:41 +09:00
Dean Herbert
d159d6b970
Rename ISkinnableDrawable to ISerialisableDrawable
2023-02-15 18:37:41 +09:00
Dean Herbert
8cb5a51aa7
Add further documentation to skin classes
2023-02-15 18:23:19 +09:00
Dean Herbert
856efd9fd9
Rename SkinnableDrawableInfo to SerialisedDrawableInfo
2023-02-15 18:23:19 +09:00
Dean Herbert
9e651a7ca2
Rename SkinnableInfo to SkinnableDrawableInfo
2023-02-15 18:23:17 +09:00
Dean Herbert
6010dde86e
Move SkinnableInfo to better namespace
2023-02-15 18:23:10 +09:00
Dean Herbert
8bbd00822c
Simplify and rename SkinnableTargetComponentsContainer
2023-02-15 17:30:21 +09:00
Dean Herbert
e71dfd7555
Fix skin export failing if a directory exists with the proposed filename
2023-02-15 16:11:16 +09:00
Dean Herbert
da8ab7143b
Merge branch 'master' into maximum-judgement-offset-in-hit-object
2023-02-15 14:48:15 +09:00
Dean Herbert
9ed068c1e6
Only apply dim changes when background blur is disabled
2023-02-15 14:16:34 +09:00
Dean Herbert
19e3c5d33c
Adjust song select background dimming to be more evenly applied
2023-02-15 13:59:24 +09:00
Bartłomiej Dach
99b78c63a0
Merge branch 'master' into fix-mania-long-note-regression
2023-02-14 21:25:31 +01:00
Dean Herbert
5ec5222d8a
Expose and consume OsuInputManager explicitly
2023-02-14 17:36:07 +09:00
Dean Herbert
b42b5f97cf
Use Overlays container rather than KeyBindingInputManager for flashlight
2023-02-14 17:36:07 +09:00
Dean Herbert
970388d4e2
Move Overlays container to accept input and be frame-stable
2023-02-14 17:35:12 +09:00
Dean Herbert
e6f0a1dec9
Merge pull request #22632 from Joehuu/fix-beatmap-preview-progress
...
Fix beatmap card song preview progress sometimes showing past progress for one frame
2023-02-14 17:06:50 +09:00
Dean Herbert
0217875f3f
Merge branch 'master' into SkinSetOnNotificationClick
2023-02-14 16:04:03 +09:00
Dean Herbert
0ad245e9e0
Rewrite implementation to match other implementations
2023-02-14 16:00:23 +09:00
Dean Herbert
21429e164f
Fix comment grammar
2023-02-14 15:55:32 +09:00
PC
ca2603324c
Change present from skin selection tab to SkinCollection.First()
2023-02-14 09:43:40 +03:00
Joseph Madamba
ea624b8ad0
Reset preview track when stopping instead
2023-02-13 22:39:34 -08:00
Dean Herbert
63f3498762
Restructure UseResumeOverlay to correctly handle a value change before BDL load
2023-02-14 15:11:33 +09:00
Dean Herbert
9e04a36d86
Move test to a mod test and add more resilient test logic
2023-02-14 15:07:45 +09:00
PC
9064391226
Use ChildrenOfType instead of linq
2023-02-14 08:24:03 +03:00
Dean Herbert
51d4ae5241
Merge branch 'master' into footer_V2_implementation
2023-02-14 14:00:53 +09:00
Dean Herbert
f0ebb920b9
Make Actions nullable
2023-02-14 13:54:00 +09:00
Joseph Madamba
24a5a1061f
Fix OsuClickableContainer sounds not being blocked by nested drawables
2023-02-13 15:36:17 -08:00
PC
f8f485e4c8
Move PresentSkinsImport to OsuGame. Replace switch with if statement
2023-02-14 02:29:50 +03:00
MK56
5006dbe3db
Update osu.Game/Screens/Select/FooterV2/FooterButtonV2.cs
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-02-14 00:07:02 +01:00
Bartłomiej Dach
939144fb6c
Merge pull request #22628 from EVAST9919/letterbox-no-containers
...
Remove unnecessary containers in `LetterboxOverlay`
2023-02-13 23:54:48 +01:00
Pasi4K5
e4b84ebd0b
Add UseResumeOverlay and use it for hiding the ResumeOverlay
2023-02-13 23:51:39 +01:00
Joseph Madamba
7f7e72705f
Fix beatmap card song preview progress sometimes showing past progress for one frame
2023-02-13 14:15:37 -08:00
mk56-spn
ae9a17d76b
Add offset to FooterButtonV2.cs shadow
2023-02-13 22:20:41 +01:00
mk56-spn
be52d0a60c
Add note explaining shadow opacity
...
pass ColourProvider in from test, instead of hard coding it in `FooterButtonV2.cs`
2023-02-13 22:18:34 +01:00
mk56-spn
61584ba63c
Fix corner_radius missing in some parts of FooterButtonV2.cs.
...
Adjust shadow radius value to 5 to match figma.
2023-02-13 22:15:29 +01:00
mk56-spn
6e6421caea
Change FooterV2.cs colour to use ColourProvider instead of OsuColour.
...
Remove unnecessary `FillFlowContainer`
2023-02-13 22:12:25 +01:00
PC
10ab228d76
Improve xml doc
2023-02-13 22:47:29 +03:00
PC
46b13f2565
Improve code quality
2023-02-13 22:44:11 +03:00
PC
637b07efe6
Remove Resolved attribute
2023-02-13 22:36:51 +03:00
PC
a22a36bfe0
Add navigation to skin settings on multiple import
2023-02-13 20:31:09 +03:00
Andrei Zavatski
2dee783401
Remove not needed containers
2023-02-13 15:14:25 +03:00
PC
35bc0a29d8
Add setting skin on notification click
2023-02-13 15:11:55 +03:00
Dean Herbert
679df9bf8b
Merge pull request #22604 from Joehuu/abort-dangerous-dialog-button-on-hover-lost
...
Add ability to abort dangerous dialog button on hover lost
2023-02-13 20:40:14 +09:00
Dean Herbert
55358d36c8
Change MinimumColumnWidth to remove setter
2023-02-13 17:50:32 +09:00
Dean Herbert
ca768ca446
Add comment regarding unused enum members in LegacyNoteBodyStyle
2023-02-13 17:43:52 +09:00
Joseph Madamba
cb51b9e350
Use existing ModdingBeatmap activity
2023-02-12 15:01:50 -08:00
Joseph Madamba
bbeef53569
Add TestingBeatmap activity
2023-02-12 13:11:42 -08:00
Joseph Madamba
afb66d8af4
Make user activity class names more specific
2023-02-12 12:32:17 -08:00
Dean Herbert
9d09141ab7
Move taiko-specific property out of DrawableHitObject
2023-02-12 16:09:28 +09:00
Joseph Madamba
8d9245c1d4
Make AbortConfirm() virtual and override with filter logic
2023-02-11 12:54:16 -08:00
Bartłomiej Dach
774eae98cc
Merge branch 'master' into editor-select-timing-on-enter
2023-02-11 16:27:22 +01:00
Bartłomiej Dach
a3cc0d23b3
Fix typo in xmldoc
2023-02-11 16:26:32 +01:00
Bartłomiej Dach
7b2c5ab7eb
Merge pull request #22608 from peppy/update-dependencies
...
Update realm and other dependencies
2023-02-11 12:37:02 +01:00
Bartłomiej Dach
ebf469272f
Merge pull request #22544 from peppy/fix-change-join-leave-loop
...
Attempt to fix channel join / leave loop
2023-02-11 12:26:26 +01:00
Dean Herbert
20f3ab167e
Re-centralise BannedApiAnalysers nuget package
2023-02-11 19:36:40 +09:00
Bartłomiej Dach
8292052dc2
Merge pull request #22598 from peppy/fix-skip-intro-replay
...
Fix "skip" key binding no longer working in replay playback
2023-02-11 11:27:10 +01:00
Dean Herbert
0c5dae5f26
Merge pull request #22529 from ItsShamed/dsc/presence
...
Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`
2023-02-11 17:29:47 +09:00
Dean Herbert
86c8675910
Update realm and other dependencies
2023-02-11 13:52:24 +09:00
Dean Herbert
463e8221e0
Merge pull request #22600 from Terochi/song-progress-time-left-fix
...
Song progress incorrectly displaying `timeLeft` counter after rotation
2023-02-11 13:19:06 +09:00
Joseph Madamba
94d6ab1ec7
Continue confirming when rehovering if mouse is still down
2023-02-10 19:09:30 -08:00
Joseph Madamba
bfd83768c1
Fix skin component previews on toolbox buttons having incorrect size for one frame
2023-02-10 17:58:34 -08:00
Joseph Madamba
d30d054b4c
Add ability to abort dangerous dialog button on hover lost
2023-02-10 14:41:44 -08:00
Bartłomiej Dach
75e19bb89f
Merge branch 'master' into fix-clickable-avatar-bloat
2023-02-10 21:30:40 +01:00
Bartłomiej Dach
11296c4ffe
Use better exception type
2023-02-10 21:25:19 +01:00
Terochi
81c3e0da31
Fixed timeLeft counter in SongProgressInfo being out of bounds after rotation
2023-02-10 17:58:48 +01:00
Dean Herbert
bfbffc4a68
Add parsing support for mania NoteBodyStyle
2023-02-10 19:46:59 +09:00
Dean Herbert
635e225d19
Add correct lookup for WidthForNoteHeightScale
2023-02-10 19:18:41 +09:00
Dean Herbert
5c795f492f
Reorder game key bindings to allow skip overlay to have precedence over replay controls
2023-02-10 18:57:21 +09:00
Dean Herbert
96fbd04698
Add failing test coverage of skip no longer working in replay playback
2023-02-10 18:57:04 +09:00
Dean Herbert
4f7d26b776
Actually apply new parameter
2023-02-10 18:29:39 +09:00
Dean Herbert
6d876fdb9a
Automatically select the closest timing point on entering the timing screen
2023-02-10 17:48:56 +09:00
Dean Herbert
03e623d1d2
Move ControlPointList to own file
2023-02-10 17:37:31 +09:00
Dean Herbert
ad8b01b478
Merge pull request #22589 from sw1tchbl4d3r/file_hitsample_additions
...
Always add to additions soundbank in `convertSoundType`
2023-02-10 17:14:29 +09:00
Dean Herbert
eccde923e5
Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability
...
Improve readability of `AccuracyCircle`
2023-02-10 17:03:46 +09:00
Dean Herbert
1df6fc6311
Use if statements rather than conditional case
2023-02-10 17:03:27 +09:00
Dean Herbert
199fb0fd85
Apply NRT to ClickableAvatar and UpdateableAvatar
2023-02-10 16:32:58 +09:00
Dean Herbert
5866b67a5b
Simplify tooltip implementation
2023-02-10 16:24:44 +09:00
Dean Herbert
68c37585e5
Use string.Empty instead of default
2023-02-10 16:22:06 +09:00
Joseph Madamba
a86f06df96
Add back Enabled checks to TooltipText and OnClick to fix guest case
2023-02-09 17:00:32 -08:00
Bartłomiej Dach
96c1832af4
Fix grammar in xmldoc
...
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2023-02-10 00:07:24 +01:00
sw1tchbl4d3
f0d11f44fc
Always add to additions soundbank in convertSoundType
2023-02-09 22:27:52 +01:00
Joseph Madamba
0b41dbf579
Remove code bloat from ClickableAvatar
2023-02-09 12:59:26 -08:00
Ruki
2c1154afc6
refactor: improve wording
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-02-09 17:15:30 +00:00
Dean Herbert
ab81397119
Merge pull request #22553 from OpenSauce04/taiko-stable-snapping
...
Snap Taiko hit objects to match Stable
2023-02-09 23:28:21 +09:00
Dean Herbert
34d1890f1c
Change snapping to only apply to classic mod
2023-02-09 18:22:14 +09:00
ekrctb
258de3b2d8
Store RawTime in JudgementResult
2023-02-09 17:15:37 +09:00
ekrctb
5f0636c330
Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield
2023-02-09 16:47:58 +09:00
Dean Herbert
28897b6e18
Merge pull request #22566 from Joehuu/profile-tournament-banner
...
Display tournament banner on user profile
2023-02-09 16:06:36 +09:00
Dean Herbert
cf009432cc
Centralise accuracy cutoff constants and add lookup helper methods
2023-02-09 15:41:58 +09:00
Joseph Madamba
f1decb667e
Address todos relating to init-only usages
2023-02-08 17:51:28 -08:00
Walavouchey
57312279f0
adjust RankNotch gap size to match original value
2023-02-09 02:20:05 +01:00
Joseph Madamba
3b5d573db1
Display tournament banner on user profile
2023-02-08 17:16:09 -08:00
Walavouchey
fd93bd3f50
move rank accuracy requirements to class-local constants
2023-02-09 00:46:24 +01:00
Walavouchey
ee40444fd3
use Precision.AlmostEquals for bounds check
2023-02-08 23:59:19 +01:00
Bartłomiej Dach
0a5c4e04bf
Merge branch 'master' into skin-editor-undo-support
2023-02-08 18:43:59 +01:00
Walavouchey
0531c010eb
display RankBadges on on their sector centres
...
the D `RankBadge` does this anyway. the A and S badges are slightly off
centre to prevent overlap with the SS badge
2023-02-08 14:01:40 +01:00
Walavouchey
6ace6bfee1
ensure AccuracyCircle doesn't land in gaps created by RankNotches
2023-02-08 13:20:53 +01:00
Joseph Madamba
0156ff732f
Fix beatmap cards not showing context menu on user profile
2023-02-07 22:56:09 -08:00
Dean Herbert
17ca26ebee
Remove unnecessary null check on targetScreen
2023-02-08 15:44:24 +09:00
Dean Herbert
3a3c2e78a1
Merge branch 'master' into skin-editor-undo-support
2023-02-08 15:41:58 +09:00
Dean Herbert
78eae171ed
Merge pull request #22507 from Joehuu/fix-comment-padding
...
Fix comments having too much padding at the bottom
2023-02-08 15:01:05 +09:00
Dean Herbert
b6809e156b
Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii
...
Implement a sheared slider for the updated design
2023-02-08 15:01:00 +09:00
Dean Herbert
5cd111e6f1
Fix ordering of methods in OsuSliderBar
2023-02-08 14:01:50 +09:00
Dean Herbert
cec1f77e6c
Fix glow flash occurring after releasing mouse and adjust transition slightly
2023-02-08 13:59:09 +09:00
Dean Herbert
ee65c65893
Attempt to fix channel join / leave loop
...
I don't have a solid way to repro the issue, but this should hopefully
help in resolving it. Either way, I think this change brings more
correct behaviour (if a websocket message comes through that we have
left the channel, I don't believe we should be sending a request to
leave that channel again).
2023-02-08 11:31:30 +09:00
Joseph Madamba
277f71d36a
Expire reply editor instead of clearing container
2023-02-07 15:15:51 -08:00
Dean Herbert
0320ba770f
Handle component changes via ISkinnableTarget.Components rather than inside SkinEditor directly
...
Seems saner? Maybe?
2023-02-07 16:23:25 +09:00
Dean Herbert
e162fd56da
Change the way initial state saving works in EditorChangeHandler to be closer to first change
2023-02-07 16:22:51 +09:00
Dean Herbert
dad348111d
Fix holding a selection while changing screens causing a crash
2023-02-07 16:07:33 +09:00
Dean Herbert
71eef238c4
Make OnStateChange non-implemented rather than wrong
2023-02-07 16:04:31 +09:00
tsrk
da10166628
quality: convert getter property to method so that sensible information can be hidden via an argument
2023-02-06 21:30:55 +00:00
tsrk
1baaae35a9
quality: Simplify string
2023-02-06 20:07:16 +00:00
Bartłomiej Dach
12f6d461b9
Merge pull request #22532 from peppy/fix-long-storyboard-outro
...
Fix storyboard outro time potentially running too long
2023-02-06 20:30:36 +01:00
Bartłomiej Dach
179db09075
Merge pull request #22531 from peppy/apply-future-rider-inspection
...
Apply single inspection from newer inspectcode versions
2023-02-06 20:05:49 +01:00
tsrk
bc89f8dc5b
feat: add name and rulset verb display support
2023-02-06 12:44:00 +00:00
Dean Herbert
aaf3ad805c
Fix potential nullref in tests
2023-02-06 19:31:45 +09:00
Dean Herbert
b83c8443ea
Ensure pause sample loop is stopped on exiting player
2023-02-06 18:24:31 +09:00
Dean Herbert
c691a0d3af
Merge branch 'master' into sheared_slider_implementation_clean_ii
2023-02-06 17:49:33 +09:00
Dean Herbert
c078d3a344
Merge pull request #22357 from EXtremeExploit/groups-probationary-badges
...
Make probationary groups a bit transparent
2023-02-06 17:43:57 +09:00
Dean Herbert
ddcc02fdfe
Merge pull request #22505 from Joehuu/fix-hover-click-sounds
...
Fix some clickable elements having no hover and click sounds
2023-02-06 16:52:19 +09:00
Dean Herbert
eabd1a0cc1
Remove unused Duration property to avoid any misunderstandings
2023-02-06 16:42:39 +09:00
Dean Herbert
679ec986d5
Fix storyboard outro time potentially running too long
2023-02-06 16:39:44 +09:00
Dean Herbert
4c868372a2
Correctly handle anchor/origin changes as undo states
2023-02-06 15:05:05 +09:00
Dean Herbert
778b8a9bf7
Fix default settings not being serialised / state tracked correctly
2023-02-06 15:00:42 +09:00
Dean Herbert
7445814fc6
Handle changes to SettingSource skin element settings
2023-02-06 14:42:59 +09:00
Dean Herbert
e5f62b0d2e
Remove public access modifier from interface methods
2023-02-06 14:19:25 +09:00
Dean Herbert
e4b17588f5
Add missing xmldoc to new methods in EditorChangeHandler
2023-02-06 14:11:40 +09:00
Dean Herbert
701d21c26f
Apply single inspection from newer inspectcode verisons
...
As found in rider EAPs. Appears as a warning and is annoying me
occasionally.
2023-02-06 13:52:27 +09:00
Dean Herbert
10ab4d572a
Merge branch 'master' into skin-editor-undo-support
2023-02-06 13:46:50 +09:00
tsrk
b3f38b0f4c
quality: remove redundant Status override
2023-02-06 00:56:11 +00:00
tsrk
bf273597ea
feat: actually support status also for Replays
2023-02-06 00:41:10 +00:00
tsrk
d5b2d9ce97
feat: add support for spectating status
2023-02-05 23:58:08 +00:00
Joseph Madamba
cb8458cceb
Use linq and alpha instead
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-04 20:11:29 -08:00
Joseph Madamba
191259c050
Use equals instead and update other usage
2023-02-04 19:58:48 -08:00
Bartłomiej Dach
ef900bccdf
Merge branch 'master' into BPM_counter_fix
2023-02-04 23:44:58 +01:00
Bartłomiej Dach
cb7540564a
Merge pull request #22504 from peppy/fix-editor-positional-nudge-undo
...
Fix beatmap editor positional nudging not being undoable
2023-02-04 15:52:34 +01:00
Joseph Madamba
4192388b20
Fix expanded beatmap cards getting cut off at the end of profile sections
2023-02-03 21:29:01 -08:00
mk56-spn
88872cf1cf
Use ``GetTrueGameplayRate()`` to remove need for jank
2023-02-04 00:53:54 +01:00
mk56-spn
d9bee958dd
Stop ``BPMCounter.cs``'s value from going to 0 after failing.
2023-02-03 23:56:34 +01:00
Bartłomiej Dach
97afb83394
Merge branch 'master' into carousel
2023-02-03 22:15:44 +01:00
Bartłomiej Dach
63f7d326c2
Merge branch 'master' into fix-editor-positional-nudge-undo
2023-02-03 21:31:05 +01:00
Bartłomiej Dach
4bd43171e8
Merge branch 'master' into fix-skin-editor-padding-weirdness
2023-02-03 20:28:47 +01:00
Bartłomiej Dach
b2a5cf9f2d
Merge branch 'master' into triangles-old-texel
2023-02-03 19:43:34 +01:00
Bartłomiej Dach
59656a7286
Merge branch 'master' into skin-editor-dont-show-save-on-no-change
2023-02-03 19:08:33 +01:00
EXtremeExploit
f9809c9481
the comment
2023-02-03 11:48:11 -03:00
