Firmatorenio
3741c2339a
simplify implementation and adjust the default values
2020-12-13 22:43:36 +06:00
Firmatorenio
2108844319
apply ScorePosition to the judgement container
2020-12-13 22:01:08 +06:00
Firmatorenio
f14e49c72e
fetch ScorePosition from the skin
2020-12-13 21:59:04 +06:00
Firmatorenio
60379b09db
added a container for the judgements to move up or down
2020-12-13 18:14:41 +06:00
ekrctb
e3c035fe9c
Adjust namespace
2020-12-07 12:32:52 +09:00
ekrctb
f3f5ec7665
Fix Column
not calling base.Add
2020-11-26 18:08:40 +09:00
Bartłomiej Dach
24d7fa03d8
Merge branch 'master' into legacy-jugement-match-stable-transforms
2020-11-18 20:33:58 +01:00
Bartłomiej Dach
5156de3a10
Merge branch 'master' into fix-judgement-transform-logic
2020-11-18 19:20:11 +01:00
Dean Herbert
20bb64c627
Fix mania misses not correctly animating (temporary solution)
2020-11-18 19:34:00 +09:00
Dean Herbert
94886a09b2
Remove fades from DrawableJudgement itself
2020-11-18 19:03:34 +09:00
Dean Herbert
8247e6ce91
Move result type to ctor
2020-11-17 15:43:54 +09:00
Dean Herbert
f465dd5a5e
Move all extended animation logic out of DrawableJudgement
2020-11-17 14:59:34 +09:00
smoogipoo
77942af3a6
Fix hold note judgements displaying incorrectly
2020-11-17 13:37:58 +09:00
smoogipoo
626231d906
Completely remove check as it can occur for hits too
2020-11-11 12:53:32 +09:00
smoogipoo
1173ef0890
Fix mania notelock crashing with overlapping hitwindows
2020-11-11 12:37:00 +09:00
smoogipoo
e789e06c86
Don't display hold note tick judgements
2020-09-29 16:33:38 +09:00
smoogipoo
aa151e4cd7
Merge branch 'master' into mania-notelock
2020-08-31 13:31:41 +09:00
smoogipoo
7a5292936e
Add some xmldocs
2020-08-27 21:15:05 +09:00
smoogipoo
6f93df0b9d
Fix ticks causing hold note misses
2020-08-27 21:05:12 +09:00
smoogipoo
deb172bb6c
Implement basic mania hit order policy
2020-08-27 20:24:21 +09:00
smoogipoo
0800e43796
Remove padding from columns
2020-08-25 19:57:49 +09:00
smoogipoo
ff72ccabd8
Rename method
2020-08-25 18:44:32 +09:00
smoogipoo
723e5cafb6
Fix column potentially added at wrong indices
2020-08-25 14:49:04 +09:00
smoogipoo
018523a43a
Rework to remove cross-class pollutions
2020-08-25 01:21:27 +09:00
Jihoon Yang
138dc5929e
Changed MIN_TIME_RANGE as well
2020-08-18 01:46:41 -07:00
Jihoon Yang
4ddc04793f
Changed MAX_TIME_RANGE instead of the single instance
2020-08-18 01:44:30 -07:00
Dean Herbert
f139423786
Merge branch 'master' into mania-hitexplosion-pooling
2020-07-30 10:40:29 +09:00
smoogipoo
5df406a035
Add pooling for mania judgements
2020-07-29 16:41:10 +09:00
smoogipoo
00821e7b65
Re-implement support for small ticks
2020-07-29 16:14:19 +09:00
smoogipoo
7f2e554ad4
Fix animations not being reset
2020-07-29 15:52:25 +09:00
smoogipoo
0f1f4b2b5c
Add pooling for mania hit explosions
2020-07-29 15:36:42 +09:00
smoogipoo
8d9e5db641
Use enum values instead of class override
2020-07-16 21:29:39 +09:00
smoogipoo
03a7b8a6ef
Rename
2020-07-16 21:18:24 +09:00
smoogipoo
18d3685023
Pass in content
2020-07-16 21:17:51 +09:00
smoogipoo
02031cea01
Add newline
2020-07-16 17:42:37 +09:00
smoogipoo
84e2e5677a
Add more info to xmldoc
2020-07-16 17:42:37 +09:00
smoogipoo
d546db0ec9
Fix default coverage
2020-07-16 17:35:00 +09:00
smoogipoo
b7f6ae5db9
Make the cover into a container
2020-07-16 17:26:48 +09:00
smoogipoo
1384e61747
Move cover to a separate file, rename
2020-07-16 17:26:34 +09:00
LastExceed
ca39f2aa24
only insert BufferedContainer when using FI
2020-07-13 13:43:32 +02:00
LastExceed
4b3cffb246
expose hitObjectContainer in HitObjectArea
2020-07-13 11:55:13 +02:00
LastExceed
3606febe31
fix case convention violation
2020-07-12 14:23:55 +02:00
LastExceed
06ed5316c4
expose hitObectArea in Column
2020-07-12 13:57:36 +02:00
LastExceed
0e49bf127b
wrap HitObjectContainer in BufferedContainer
2020-07-12 13:57:06 +02:00
Dean Herbert
2c16619ecd
Move time to position conversion to ScrollingHitObjectContainer
2020-05-25 19:32:39 +09:00
Dean Herbert
6de2597958
Merge branch 'editor-position-snap' into mania-distance-snap-grid
2020-05-22 11:27:36 +09:00
Dean Herbert
8a105bdbcf
Remove unused ColumnAt method
2020-05-22 11:23:39 +09:00
Dean Herbert
7dd3b3eeb5
Remove unused method
2020-05-21 15:16:59 +09:00
Dean Herbert
a756e6d212
Add xmldoc and remove unnecessary parameter
2020-05-21 15:16:30 +09:00
Dean Herbert
ce8b6b7383
Correctly account for blueprint origins
2020-05-21 15:15:24 +09:00
Dean Herbert
bac78707de
Move more logic to column to both clean things up and fix tests
2020-05-21 14:25:37 +09:00
Dean Herbert
5ad7842b91
Move ScreenSpacePositionAtTime to inside Column implementation
2020-05-21 13:33:02 +09:00
Dean Herbert
d9bb90078b
Move grids to inside columns
2020-05-18 17:47:52 +09:00
smoogipoo
16585f767e
Add initial beat snap grid implementation
2020-05-14 19:17:24 +09:00
Dean Herbert
064e5004ed
Merge branch 'master' into fix-mania-selection
2020-04-29 17:15:48 +09:00
smoogipoo
4f332ace14
Use 0 length
2020-04-29 14:27:21 +09:00
smoogipoo
0c95d11fdb
Remove unnecessary value change binding
2020-04-29 13:27:33 +09:00
Dan Balasescu
024f10a494
Use non-generic bindable
...
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2020-04-29 13:24:31 +09:00
smoogipoo
1aaab40228
Fix mods affecting mania scroll speed
2020-04-28 19:34:02 +09:00
smoogipoo
ff3928465c
Add xmldoc
2020-04-28 18:58:29 +09:00
smoogipoo
a7a680b486
Fix horizontal drag not working
2020-04-28 18:34:55 +09:00
smoogipoo
cebc0fc046
Attempt to fix multiple selection movements
2020-04-27 20:35:24 +09:00
Dean Herbert
c51bad0e35
Cache ManiaPlayfield instead
2020-04-13 13:42:21 +09:00
Dean Herbert
cb6372acac
Merge branch 'master' into mania-stage-background-skinning
2020-04-09 15:37:48 +09:00
smoogipoo
d13231eff7
Use ctor for default width
2020-04-08 18:23:24 +09:00
smoogipoo
83db6cebb6
Implement bottom stage image
2020-04-08 16:20:54 +09:00
smoogipoo
cd15b672eb
Implement left and right stage images
2020-04-08 16:20:47 +09:00
smoogipoo
e429c274a9
Initial structure
2020-04-08 15:35:37 +09:00
Dean Herbert
9db996a91f
Increase size of default osu!mania skin's keys to allow clearance with HUD
2020-04-08 14:13:31 +09:00
Dean Herbert
3794b55eef
Rename ManiaStage to Stage
2020-04-08 14:13:31 +09:00
smoogipoo
9cfeb60afc
Fix missed speed removal in mania
2020-04-07 16:30:58 +09:00
Dean Herbert
3289fa7c66
Merge branch 'master' into better-mania-scrollspeed
2020-04-03 23:25:14 +09:00
Dean Herbert
eacbb20d87
Merge branch 'master' into fix-convert-scroll-speed
2020-04-03 22:47:53 +09:00
smoogipoo
1ff2cc31d1
Implement more familiar scroll speed options in mania
2020-04-03 18:25:01 +09:00
smoogipoo
b42d1104b7
Fix mania converts scrolling at incorrect speeds
2020-04-03 13:16:01 +09:00
smoogipoo
1f797207f7
Rework lookups to not require total playfield columns
2020-04-03 12:31:05 +09:00
Dan Balasescu
0f5fd8051c
Merge branch 'master' into mania-hitexplosion-skinning
2020-04-02 23:08:31 +09:00
smoogipoo
5aa4c4f3cb
Remove corner radius
2020-04-02 16:10:09 +09:00
smoogipoo
7ba533b7a4
Expand mania to fit vertical screen bounds
2020-04-02 16:04:09 +09:00
smoogipoo
62f6683a20
Remove unnecessary generic
2020-04-02 15:57:50 +09:00
smoogipoo
c8d161e03a
Fix explosion expiry
2020-04-02 15:57:02 +09:00
smoogipoo
94031b57ea
Split hit explosion positioning from column
2020-04-02 14:37:29 +09:00
Dan Balasescu
33119d38ad
Merge branch 'master' into fix-default-explosion-position
2020-04-01 20:03:23 +09:00
smoogipoo
f4d8defa48
Fix incorrect explosion position on default skin
2020-04-01 20:01:35 +09:00
smoogipoo
59eac34d82
Fix barlines scrolling at different speeds in legacy skins
2020-04-01 18:00:17 +09:00
Dean Herbert
9de348235e
Add comment about legacy fallback widths
2020-04-01 15:30:51 +09:00
smoogipoo
2d6d1a8cc6
Implement column width and column spacing
2020-04-01 13:38:03 +09:00
mcendu
44fcd2613f
Add support for special column
2020-03-31 22:58:04 +08:00
mcendu
c9a81e7f71
Merge branch 'column-type3' into mania-skinning-refactor
2020-03-31 22:33:27 +08:00
smoogipoo
c4f76ffdaf
Implement mania note skinning
2020-03-31 15:29:25 +09:00
smoogipoo
211a8db4c5
Merge branch 'mania-key-area-skinning' into mania-note-skinning
2020-03-31 15:23:59 +09:00
smoogipoo
538dc0c558
Merge branch 'mania-hitobject-area-skinning' into mania-note-skinning
2020-03-31 15:20:56 +09:00
mcendu
2008a7bbec
fix naming
2020-03-31 14:03:11 +08:00
mcendu
3fb044c3b6
rm unnecessary usings
2020-03-31 12:09:04 +08:00
mcendu
323146e4a6
simplify column type check logic
2020-03-31 11:53:17 +08:00
smoogipoo
02237133cb
Implement mania hit target skinning
2020-03-31 12:17:44 +09:00
smoogipoo
cb1513b374
Add mania key area skinning
2020-03-31 11:23:33 +09:00
smoogipoo
44727eb2b8
Implement column background skinning
2020-03-31 10:57:56 +09:00
smoogipoo
6ff2273b64
Make column + stage cached
2020-03-30 23:21:40 +09:00
Dean Herbert
388cf5c83a
Fix catch positional data being incorrectly recorded
2020-03-24 15:38:54 +09:00
Dean Herbert
96a849f897
Add remaining replay recorders
2020-03-24 14:55:49 +09:00
smoogipoo
9f73b2960d
Prevent unnecessary auto-size computations in mania
2020-03-02 20:08:04 +09:00
smoogipoo
7b2f58eb30
Apply OnRelease method signature refactorings
2020-01-22 13:22:34 +09:00
mcendu
76c70a7622
Move hit target bar height def to defaulthittarget
2020-01-11 21:19:46 +08:00
smoogipoo
91735ff367
Update MathUtils namespace usages
2020-01-09 13:43:44 +09:00
mcendu
20c5748342
Use hitTarget in place of stageHint
2019-12-29 23:37:28 +08:00
mcendu
51000765dd
remove override
2019-12-29 23:29:00 +08:00
mcendu
61fb9f5613
Remove class StageHint and usage
2019-12-29 23:18:50 +08:00
mcendu
cdfbe96e9b
Make AccentColour of StageHint virtual
2019-12-29 14:52:51 +08:00
mcendu
5d2b5cc950
correct type of field stageHint
2019-12-28 14:05:46 +08:00
mcendu
bf162f148e
Move mania stage hint to its own class
2019-12-28 13:48:10 +08:00
smoogipoo
49bf8d27d1
Move CreateScoreProcessor() to Ruleset
2019-12-17 20:08:13 +09:00
smoogipoo
5861eca80d
Make DrawableRuleset take a converted beatmap
2019-12-12 15:58:11 +09:00
smoogipoo
48f1dad4aa
Remove abstract ScoreProcessor class
2019-12-11 17:25:06 +09:00
Huo Yaoyuan
7d7b9e36b2
Use compound assignment.
2019-11-12 19:53:50 +08:00
Bartłomiej Dach
8efab559c8
Remove unused using directives
2019-09-25 01:13:42 +02:00
Bartłomiej Dach
9323df26a1
Decouple bar line hitobjects from generator
...
Introduce an IBarLine interface, which together with generic constraints
helps decouple BarLineGenerator from the actual hitobject types it
creates. Thanks to this, all rulesets that want bar lines can provide
an implementation of IBarLine that also derives from the base hitobject
class.
This allows DrawableBarLines in taiko and mania to be migrated back to
DrawableTaikoHitObject and DrawableManiaHitObject base classes
respectively. This in turn resolves #6215 without code duplication,
since the missing anchoring application is now done in mania's
DrawableBarLine through deriving from DrawableManiaHitObject.
2019-09-25 00:36:27 +02:00
Dan Balasescu
f9b64446e9
Merge branch 'master' into mania-note-sizing
2019-09-12 14:20:28 +09:00
smoogipoo
b941f12688
Cleanup
2019-09-12 14:09:21 +09:00
smoogipoo
bbf80f63aa
Publicly expose column width constant
2019-09-12 13:53:05 +09:00
smoogipoo
b1c0b080ec
Fix bad hit explosion anchoring
2019-09-12 13:52:27 +09:00
Dean Herbert
b9e71d26b2
Dim column backgrounds further
2019-09-11 18:21:39 +09:00
Dean Herbert
c7186efd53
Reduce opacity of judgement area
2019-09-11 18:21:29 +09:00
Dean Herbert
6bfdadb22f
Increase column width
2019-09-11 18:20:41 +09:00
Dean Herbert
8f6bc6fd5c
Make osu!mania hit explosions more explodey
2019-09-11 18:19:47 +09:00
Dean Herbert
af3bb5a2cd
Centralise and share bar line generation code between rulesets
2019-09-10 13:30:54 +09:00
smoogipoo
6ab2b20c70
Add an interface for working beatmaps
2019-08-29 19:38:44 +09:00
smoogipoo
e30ae57ea6
Scale mania beat lengths relative to each other
2019-08-26 12:51:23 +09:00
Dean Herbert
48716f8f2b
Update framework
2019-08-21 13:29:50 +09:00
Dean Herbert
8327452fe1
Make AccentColour a bindable
2019-07-22 14:48:59 +09:00
smoogipoo
d7c09e7dbd
Merge remote-tracking branch 'origin/master' into fix-new-inspections
...
# Conflicts:
# osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
# osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
# osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
# osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
# osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
# osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
# osu.Game/Graphics/OsuFont.cs
# osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
# osu.Game/Overlays/Profile/Header/BadgeContainer.cs
# osu.Game/Overlays/Profile/ProfileHeader.cs
# osu.Game/Screens/Select/PlaySongSelect.cs
# osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
Dean Herbert
d40177f97c
Merge branch 'master' into drawnode-composability
2019-04-27 18:41:19 +09:00
smoogipoo
0222424aef
Make mods IReadOnlyList<Mod> gamewide
...
Prevents potential multiple evaluations of enumerable.
2019-04-10 17:20:36 +09:00
smoogipoo
c584967eb1
Remove mods from workingbeatmap
2019-04-09 12:59:32 +09:00
smoogipoo
a56e29347f
Adjust namespaces
2019-04-02 14:51:28 +09:00
Dean Herbert
612db31c38
Apply newline additions
2019-04-01 12:16:32 +09:00
Dean Herbert
42eaabe24c
Fix editor blueprints being misplaced
...
Regressed with PlayfieldAdjustmentContainer changes.
2019-03-31 01:29:37 +09:00
Dean Herbert
14cef94a53
Merge remote-tracking branch 'upstream/master' into hitobject-drawable-representation
2019-03-29 12:59:26 +09:00
Dean Herbert
ed3746e166
Make PlayfieldAdjustmentContainer universal
2019-03-26 13:32:44 +09:00
Dean Herbert
9bf48863b0
Fix DrawableRuleset drawable creation method's name
2019-03-25 00:00:29 +09:00
Dean Herbert
7b6d882ce6
Remove double-generic type
2019-03-20 11:29:16 +09:00
Dean Herbert
baea7230bc
Rename RulesetContainer to DrawableRuleset
2019-03-19 23:47:31 +09:00
Dean Herbert
68f28326a2
Refactor RulesetContainer for readability
2019-03-19 20:21:31 +09:00
David Zhao
3b3b1e51ee
Move hit animation logic into virtual method
2019-03-12 19:41:33 +09:00
David Zhao
12f334035f
Create properties for use in DrawableManiaJudgement
2019-03-12 19:23:24 +09:00
smoogipoo
78596dfe80
Merge remote-tracking branch 'origin/master' into move-osu-settings
...
# Conflicts:
# osu.Game.Rulesets.Mania/UI/ManiaRulesetContainer.cs
# osu.Game.Rulesets.Osu.Tests/TestCaseSlider.cs
2019-03-05 13:25:03 +09:00
andy840119
4b2be4612f
support duel mode in mania beatmap
2019-02-28 19:07:43 +09:00
Dean Herbert
0788a7e9f1
Merge branch 'master' into more-inspections
2019-02-28 14:32:57 +09:00
Dean Herbert
42be7857d1
Use expression body for property get/set where possible
2019-02-28 13:58:19 +09:00
Dean Herbert
26d53d06a9
Fix remaining issues
2019-02-28 13:31:40 +09:00