h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-18 18:52:56 +08:00
Code Issues Releases Wiki Activity
49,005 Commits 3 Branches 657 Tags 361 MiB
5477af08c5
Commit Graph

814 Commits

Author SHA1 Message Date
Dean Herbert
d4e5a612ea Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time 
This allows fetching the correct `DifficultyControlPoint` from the
hitobject. Nothing more.
 2021-09-03 17:11:12 +09:00
Dean Herbert
a3d9ab1e2e Move approach rate to EffectControlPoint 2021-09-03 16:58:16 +09:00
dependabot[bot]
5a1eccd8e3
Bump Microsoft.NET.Test.Sdk from 16.10.0 to 16.11.0 
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.10.0 to 16.11.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.10.0...v16.11.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-09-01 18:17:37 +00:00
Dean Herbert
e15198f077 Update missed tests 2021-08-26 13:47:10 +09:00
Dean Herbert
6dcd9427ac Remove bindable usage in PathControlPoint 
This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.

I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.
 2021-08-26 12:33:53 +09:00
smoogipoo
0d2ab550dd Update SR values in tests 2021-08-11 13:04:32 +09:00
smoogipoo
2196ae9ca2 Merge branch 'master' into display-sr-changes 2021-08-11 13:02:34 +09:00
Salman Ahmed
0d22b9223b Add unit test for inverse muting transferal 2021-08-03 12:50:54 +03:00
Salman Ahmed
ea02571da9 Inline parameterised test case 2021-08-03 12:49:39 +03:00
Salman Ahmed
026c632539 Add test coverage 2021-08-01 20:19:44 +03:00
Bartłomiej Dach
c371e67d70
Update diffcalc test to match ground-truth formula 2021-08-01 15:32:10 +02:00
Dean Herbert
50a2abbe7f
Merge pull request #12683 from frenzibyte/legacy-beatmap-combo-offset 
Apply combo offsets "colour hax" only on beatmap skins
 2021-07-23 14:30:18 +09:00
Salman Ahmed
20adfabc97 Remove unnecessary parentheses 
I... forgot to amend that.
 2021-07-22 16:42:07 +03:00
Salman Ahmed
cd7b90363a Check nested hitobjects while asserting accent colour 2021-07-22 16:40:28 +03:00
emu1337
84fd59777c Merge branch 'master' into diffspike-balance 2021-07-20 19:39:41 +02:00
Salman Ahmed
300b3f22b1 Remove no longer correct usage of "legacy" in offsets 2021-07-20 14:35:21 +03:00
Salman Ahmed
9d92b795fa Revert making ComboOffsets legacy and define BeatmapSkinComboIndex instead 2021-07-20 14:15:43 +03:00
Salman Ahmed
a1001542f3 Update outdated test cases 2021-07-20 10:28:30 +03:00
Salman Ahmed
554652b033 Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset 2021-07-20 10:11:52 +03:00
Naxess
53c0298b5e Add too short spinners check and tests 2021-07-13 10:51:40 +02:00
Naxess
fec9448301 Add too short sliders check and tests 2021-07-13 10:50:41 +02:00
PercyDan54
e1c646b9b2
Remove redundant arguments 2021-07-05 23:52:39 +08:00
dependabot[bot]
0d3de488de
Bump NUnit3TestAdapter from 3.17.0 to 4.0.0 
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 3.17.0 to 4.0.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases)
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.17...V4.0.0)

---
updated-dependencies:
- dependency-name: NUnit3TestAdapter
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-07-01 17:02:17 +00:00
smoogipoo
2c1f788f2d Merge methods 2021-06-30 19:52:25 +09:00
smoogipoo
b94d88be50 Make method static to better define its usage 2021-06-30 19:49:51 +09:00
smoogipoo
e23614556e Fix slider testscene failures 2021-06-30 19:43:34 +09:00
smoogipoo
e9158ccc41 Fix gameplay tests incorrectly seeking via MusicController 2021-06-29 23:23:21 +09:00
Dean Herbert
4cb9c6a842
Merge pull request #13423 from frenzibyte/transformers-per-skin 
Refactor ruleset skin transforming logic to be per-`ISkin` rather than one `ISkinSource`
 2021-06-22 21:24:56 +09:00
Salman Ahmed
ece63b9ba1 Remove unused using directive 2021-06-22 12:03:55 +03:00
Salman Ahmed
31cbb36a64 Implement FindProvider and AllSources properly on all test ISkinSources 2021-06-22 12:03:14 +03:00
Salman Ahmed
b12adc6073 Remove all test skinning changes in favour of the ISkinSource.AllSources path 2021-06-22 10:48:03 +03:00
Dean Herbert
6c3d2315d0
Merge pull request #13606 from Naxesss/low-diff-checks 
Add low difficulty spacing checks
 2021-06-22 16:29:37 +09:00
Dean Herbert
0ad189e357 Expose skin sources via ISkinSource and revert to consuming based on hierarchy 2021-06-22 16:19:55 +09:00
Dean Herbert
1b0aadcc6f Merge branch 'master' into transformers-per-skin 2021-06-22 16:03:15 +09:00
Naxess
629c98e6a0 Add time distance equality tests 2021-06-21 15:34:11 +02:00
Naxess
e11139eadf Add low difficulty overlap tests 
Moq is introduced to mock sliders' end time/position. This is already used similarly in `osu.Game.Tests`.
 2021-06-21 15:33:50 +02:00
Bartłomiej Dach
fe48ddfee3 Also cover slider animation disable 2021-06-18 16:04:11 +02:00
Bartłomiej Dach
e2a370f602 Add coverage for hit circle fade-out duration 2021-06-18 16:04:11 +02:00
Bartłomiej Dach
69c1cd5b34 Add failing test case for hit circle animations disable 2021-06-18 16:04:11 +02:00
Bartłomiej Dach
403909b598 Update SR test values in line with diffspike changes 2021-06-18 12:49:51 +02:00
Dan Balasescu
6cec1145e3
Merge pull request #13523 from ekrctb/applicable-to-dho 
Reduce boilerplate of `IApplicableToDrawableHitObjects` by taking a single DHO instead of an enumerable
 2021-06-17 19:59:06 +09:00
smoogipoo
ccba6b5ac2 Fix test failures 2021-06-17 16:13:47 +09:00
Dean Herbert
6d0b3efa23 Reorganise existing tests into hits and misses 2021-06-17 15:08:09 +09:00
Dean Herbert
249ae3141e Add early/late tests for hit circles 2021-06-17 15:06:56 +09:00
ekrctb
67d8e0059f Use singular IApplicableToDrawableHitObject for consumers 2021-06-16 18:47:04 +09:00
Dean Herbert
4b45d8318e
Merge branch 'master' into transformers-per-skin 2021-06-16 16:37:28 +09:00
Dean Herbert
33aec57238 Replace 1.0 version in old skin test assets with none 2021-06-11 15:45:34 +09:00
Salman Ahmed
680791301f Consume new method rather than caching skin sources on top of Player 2021-06-10 16:36:46 +03:00
Dean Herbert
9ebafb1ec0 Fix cursor trail logic 2021-06-06 22:26:27 +09:00
Dean Herbert
06275a6a7d Merge branch 'master' into legacy-skin-default-fallback 2021-06-04 16:00:30 +09:00
Dean Herbert
52557da335 Add test coverage 2021-06-04 14:14:51 +09:00
Dan Balasescu
c065f761c7
Merge branch 'master' into legacy-skin-default-fallback 2021-06-02 19:08:52 +09:00
Dean Herbert
5366e7f61e
Merge branch 'master' into remove-hud-component-lookup 2021-06-02 16:10:06 +09:00
Dean Herbert
f8ae70e562 Update existing function type rather than adding an override 2021-06-02 16:04:53 +09:00
dependabot[bot]
967a7c3db5
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 16.10.0 
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.9.4 to 16.10.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.9.4...v16.10.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
 2021-06-01 19:59:27 +00:00
Dean Herbert
54338bdcc5 Add test ensuring correct osu! ruleset sample lookups 2021-06-01 18:56:28 +09:00
Dean Herbert
3ff9f9c89d Make FindProvider non-default 2021-05-31 21:29:47 +09:00
Dean Herbert
f60e9cb085 Remove weird override logic in TestCase methods 2021-05-31 20:00:47 +09:00
Dean Herbert
e78391db7a Fix usage of DI before it's ready in combo colour tests 2021-05-31 19:58:19 +09:00
Dean Herbert
8336428574 Add regression test for spinner sample actually transforming its frequency 2021-05-24 15:10:33 +09:00
Dean Herbert
a96603f025
Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints 
Rename hitobject blueprints and tie them to HitObjects
 2021-05-18 16:30:58 +09:00
smoogipoo
532c41c82e Remove nested blueprints from sliders 2021-05-18 14:19:11 +09:00
smoogipoo
ffb6135a1b Rework hitobject blueprints to take in hitobject models 2021-05-13 19:53:32 +09:00
Naxess
19800f5f7f Move IBeatmap arg into context 2021-05-13 11:24:22 +02:00
Naxess
e7c7786db3
Merge branch 'master' into beatmap-verifier-context 2021-05-13 07:40:33 +02:00
Naxess
c13b93e6f1 Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks 
This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.

See next commit for example.
 2021-05-12 02:29:18 +02:00
Dean Herbert
77e422409c Add SkinInfo.InstantiationInfo to allow creating different skin types 2021-05-11 23:37:06 +09:00
Salman Ahmed
71d3b44c78 Add test coverage for legacy beatmap combo offsets 2021-05-05 09:22:19 +03:00
dependabot[bot]
1b3b07d6a9
Bump NUnit from 3.13.1 to 3.13.2 
Bumps [NUnit](https://github.com/nunit/nunit) from 3.13.1 to 3.13.2.
- [Release notes](https://github.com/nunit/nunit/releases)
- [Changelog](https://github.com/nunit/nunit/blob/v3.13.2/CHANGES.md)
- [Commits](https://github.com/nunit/nunit/compare/v3.13.1...v3.13.2)

Signed-off-by: dependabot[bot] <support@github.com>
 2021-04-29 03:51:12 +00:00
smoogipoo
bda8f68da4 Add failing test 2021-04-26 15:03:43 +09:00
Dean Herbert
68807a90ec
Merge pull request #12448 from smoogipoo/gcc-abstraction 
Make GameplayClockContainer abstract and add MasterGameplayClockContainer
 2021-04-22 16:20:52 +09:00
Dan Balasescu
cf55383fff
Merge pull request #12486 from ekrctb/unmanaged-hit-object-entry 
Associate DrawableHitObject with HitObjectLifetimeEntry rather than HitObject
 2021-04-21 17:08:21 +09:00
smoogipoo
31c5fb350f Merge branch 'master' into gcc-abstraction 2021-04-21 16:33:36 +09:00
ekrctb
3fbeadf318 Deprecate old overload of Apply 2021-04-21 14:32:37 +09:00
Naxess
5262d94e21 Fix wrong assert in offscreen test 2021-04-20 13:21:57 +02:00
Naxess
8656176ab8 Add the playable beatmap as check argument 
This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.

So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.

This should be preferred over `workingBeatmap.Beatmap`.
 2021-04-20 01:31:51 +02:00
Naxess
448574e7e6 Use WorkingBeatmap instead of IBeatmap 
This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.

Also improves the structure of the `CheckBackgroundTest` class in the process.
 2021-04-17 17:33:53 +02:00
smoogipoo
5e82f40d67 Merge branch 'master' into gcc-abstraction 2021-04-16 20:14:53 +09:00
Dean Herbert
b413ffae3e Fix test going offscreen in headless execution 2021-04-16 18:54:33 +09:00
Dean Herbert
30e00cc4aa Add test coverage of selection / scaling scenarios 2021-04-16 17:07:20 +09:00
Dean Herbert
401bf368a7 Merge branch 'fix-slider-scale-crash' into fix-slider-zero-length 2021-04-16 16:58:19 +09:00
Dean Herbert
ab1a1a1df4 Add failing test case due to div by zero 2021-04-16 16:55:17 +09:00
Dean Herbert
965a1ead36 Disallow zero-length slider blueprint placements 2021-04-16 14:38:30 +09:00
smoogipoo
1aa36818df Abstractify GameplayClockContainer 2021-04-14 17:47:11 +09:00
Salman Ahmed
4538e4b503 Remove wrong assert 2021-04-14 08:58:25 +03:00
Salman Ahmed
daf198fa77 Add osu! 2007 skin cursor for testing purposes 2021-04-14 08:18:24 +03:00
Salman Ahmed
b060b59dcf Return null values instead of throwing NIE 2021-04-14 08:17:35 +03:00
Salman Ahmed
df991bc0af Refactor gameplay cursor test scene and add visual coverage 2021-04-14 06:36:31 +03:00
Dean Herbert
1ff4e2076f Merge branch 'master' into verify-tab 2021-04-13 23:05:48 +09:00
Naxess
4618728bf0 Add test case 2021-04-13 11:35:12 +02:00
Naxess
98c25b2e71 Remove unused import 2021-04-13 10:33:08 +02:00
Dean Herbert
b45d7de4ec Update asserts to use better nunit specifications 2021-04-13 15:04:01 +09:00
Dean Herbert
4837cef095 Use static for playfield centre positioning 2021-04-13 14:44:52 +09:00
Naxess
6d3f9fa9ce Use is class instead of Equals with template index 
Ensures ordering of `PossibleTemplates` does not affect tests.
 2021-04-13 02:29:25 +02:00
Naxess
8a6dfcfae1 Add CheckOffscreenObjects tests 2021-04-13 01:22:36 +02:00
Dean Herbert
e2470d757e
Merge branch 'master' into legacy-spm-counter 2021-04-12 12:52:52 +09:00
Naxess
0af6d77192 Test for path type transfer 2021-04-09 11:03:38 +02:00
Naxess
2d94484566 Use lambda expression 
Apparently CI dislikes this not being a lambda.
 2021-04-08 12:49:46 +02:00
Naxess
7d2b54ca42 Add change to Bezier test 2021-04-08 12:32:45 +02:00
Naxess
4110d1675d Add path type menu test cases 2021-04-08 11:46:52 +02:00
Dean Herbert
a8839792fd
Merge branch 'master' into circular-arc-freeze 2021-04-08 14:33:03 +09:00
Naxess
9d02930709 Add regression test for type changes 2021-04-07 17:18:55 +02:00
smoogipoo
7d37c4df8c Fix broken osu tests 2021-04-07 20:17:20 +09:00
smoogipoo
42e816fcae Add failing tests 2021-04-05 17:48:29 +09:00
Dan Balasescu
345779b19a
Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay 2021-04-02 20:58:29 +09:00
Naxess
8621a6b4fe Add margin to large segment test 
Test ran fine on my end, but apparently not on the CI. This should make results a bit more consistent, hopefully.
 2021-04-01 20:34:04 +02:00
dependabot-preview[bot]
6a286c5e21
Bump Microsoft.NET.Test.Sdk from 16.9.1 to 16.9.4 
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.9.1 to 16.9.4.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.9.1...v16.9.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2021-04-01 17:16:02 +00:00
Naxess
b8479a979f Remove unused blueprint variable 2021-04-01 18:06:12 +02:00
Naxess
7e47922fb7
Merge branch 'master' into circular-arc-freeze 2021-04-01 17:09:45 +02:00
Naxess
25afae5671 Fix broken test case 
Seems this technically works, but only because of the edge case of being entirely linear, which the framework catches.

This fixes that.
 2021-03-31 20:48:17 +02:00
Naxess
1718084dbc Update/remove determinant tests 
We now only change the path type based on the bounding box.

If the control points are too linear, the framework now handles the fallback to Bezier.
 2021-03-31 20:08:39 +02:00
Salman Ahmed
0bf84e473d Refactor spinner SPM counter for skinning purposes 2021-03-30 04:19:23 +03:00
Salman Ahmed
f49481e308 Add old skin spinner SPM background for testing 2021-03-29 09:32:44 +03:00
smoogipoo
1c1af98144 Update values 2021-03-26 11:47:41 +09:00
smoogipoo
8438fce764 Merge branch 'master' into diffcalc/fix/clockrate-adjusted-decay 2021-03-26 11:47:38 +09:00
Dean Herbert
c715b9b89e Merge branch 'master' into legacy-spinner-bonus 2021-03-25 18:09:25 +09:00
Naxess
0f4314c1d8 Add complete arc test 
Ensures we can still make smaller circles properly.
 2021-03-24 17:24:33 +01:00
Naxess
b4dc35f66b Update large arc tests 
Should now be more robust and readable.
 2021-03-24 17:24:05 +01:00
Naxess
415797aadd Fix broken control point drag test 
Broken for 2 reasons:
- Assert checks the wrong control point.
- The exterior arc is now too big.

This fixes both.
 2021-03-24 06:01:12 +01:00
Naxess
f80b3ada25 Add circular arc size tests 2021-03-24 05:54:48 +01:00
Naxess
7b395ed783 Add exterior arc test 2021-03-24 05:15:50 +01:00
Naxess
23a4d1c135 Shorten recovery test name 2021-03-24 05:15:28 +01:00
Naxess
6fbe530016 Fix coordinates 2021-03-24 05:14:35 +01:00
Naxess
847d44c7d9 Remove unnecessary length asserts 
We don't actually care about the length (as this isn't what we're testing), just the type of the slider.
 2021-03-24 05:13:37 +01:00
Naxess
7bae4ff43d Add control point dragging tests 2021-03-24 05:06:04 +01:00
Dean Herbert
08fcdc8ee4 Update difficulty calculator tests with floating point differences 2021-03-23 15:38:01 +09:00
Naxess
323b875cea Fix newlines/spaces 2021-03-22 17:32:40 +01:00
Naxess
15af57de95 Add path type recovery test 2021-03-22 15:59:59 +01:00
Naxess
3bddc4a75d Add path type test 2021-03-22 15:59:45 +01:00
Bartłomiej Dach
a16c0641b2 Revert EF Core to version 2.2 
This reverts commit f3faad74d5, reversing
changes made to 712e7bc7bf.

Several issues arose after migrating to 5.0, including, but possibly not
limited to, performance regressions in song select, as well as failures
when attempting to save beatmaps after metadata changes in the editor.
 2021-03-21 11:05:15 +01:00
Naxess
a294f328fb Add linear circular arc test 2021-03-21 06:30:17 +01:00
Bartłomiej Dach
aec859b4d1 Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-03-18 19:51:46 +01:00
smoogipoo
7fa5fd5647 Update usages of config with framework changes 2021-03-17 16:10:16 +09:00
Dean Herbert
1573298e68 Update remaining package references to point to efcore5 2021-03-15 13:12:10 +09:00
Salman Ahmed
c4048c9831 Merge branch 'master' into legacy-spinner-bonus 2021-03-13 05:54:34 +03:00
Salman Ahmed
97f56340af Add legacy score font to testing old skin 2021-03-06 20:27:56 +03:00
dependabot-preview[bot]
b03efd6940
Bump Microsoft.NET.Test.Sdk from 16.8.3 to 16.9.1 
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.8.3 to 16.9.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](https://github.com/microsoft/vstest/compare/v16.8.3...v16.9.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2021-03-02 00:43:45 +00:00
smoogipoo
ee6a94273d Merge branch 'master' into fix-unsafe-skinnable-sample-play 2021-02-22 18:31:27 +09:00
Samuel Cattini-Schultz
417bb07b36 Update tests with fixed diffcalc values 2021-02-20 20:23:49 +11:00
Samuel Cattini-Schultz
9d229a5ec2 Add tests for clockrate adjusted difficulty calculations 2021-02-20 16:27:58 +11:00
Dean Herbert
00574a5288 Use ISample everywhere in Skin GetSample lookup path 2021-02-18 18:32:28 +09:00
Dean Herbert
72b2123500 Update nunit in line with framework 2021-02-15 21:42:35 +09:00
smoogipoo
d3f0c0730d Merge branch 'master' into non-concurrent-sample-playback 2021-02-12 17:22:15 +09:00
Dean Herbert
aaa0362b12 Merge branch 'master' into autoplay-rate-independence 2021-02-11 17:39:45 +09:00
smoogipoo
321ca43b61 Update test 2021-02-10 20:28:00 +09:00
Dean Herbert
1cb51fa8d2
Merge branch 'master' into autoplay-rate-independence 2021-02-09 16:05:34 +09:00
Bartłomiej Dach
0df15b4d7a Add test coverage 2021-02-07 19:25:33 +01:00
Bartłomiej Dach
3fabe247b0 Allow OsuModGenerator to accept a mod list 2021-02-07 18:35:34 +01:00
Bartłomiej Dach
68c20a2a37 Allow autoplay score generation to access mod list 2021-02-07 18:35:34 +01:00
smoogipoo
6aece18f8d Add OOHP tests 2021-02-05 15:36:47 +09:00