2243 Commits

Author	SHA1	Message	Date
Dean Herbert	09536cd733	Add logging of WorkingBeatmapCache.Invalidate calls	2021-10-14 14:05:33 +09:00
Dan Balasescu	e49f1f6e6b	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-13 20:17:57 +09:00
Dean Herbert	02689a1b60	Use actual BeatmapInfo rather than PlayableBeatmap.BeatmapInfo for editor writes	2021-10-13 14:50:12 +09:00
Dean Herbert	1373cc02d7	Shallow clone BeatmapInfo during conversion process to avoid overwriting fields	2021-10-12 16:43:56 +09:00
Dean Herbert	6b35ccae95	Fix some cases where interface specifications can be used but weren't	2021-10-11 15:06:24 +09:00
smoogipoo	bc37cb6f43	Merge branch 'master' into no-more-difficulty-control-points-info	2021-10-08 18:41:17 +09:00
Dean Herbert	ee66414e4f	Move difficulty copy inside context retrieval	2021-10-07 17:49:13 +09:00
Dean Herbert	d3efec3c04	Remove unnecessary clone operations	2021-10-07 17:22:10 +09:00
Dean Herbert	0df409c050	Move difficulty copy to BeatmapModelManager.Save	2021-10-07 17:16:45 +09:00
Dean Herbert	4ca97bc60a	Merge branch 'master' into difficulty-move-to-beatmap	2021-10-06 16:14:21 +09:00
Dean Herbert	0ab8dcc2a0	Fix taiko weird difficulty multiplier failing on double convert	2021-10-06 15:18:06 +09:00
Dean Herbert	b339c149d8	Copy BaseDifficulty to Beatmap<T> and move all write operations across	2021-10-06 15:10:45 +09:00
Dan Balasescu	80c8612630	Merge pull request #14977 from peppy/fix-working-beatmap-cache-invalidation ... Fix changes not being reflected immediately after exiting the editor	2021-10-06 13:51:21 +09:00
Dean Herbert	8ffaa491e7	Fix BeatmapModelManager not receiving WorkingBeatmapCache	2021-10-06 12:55:04 +09:00
Dean Herbert	007b33cd88	Add missing methods to interfaces	2021-10-06 12:55:04 +09:00
Dan Balasescu	e837a3511d	Merge branch 'master' into beatmap-difficulty-more-interface-usage	2021-10-06 12:18:51 +09:00
Dan Balasescu	4bbff2ebf7	Merge branch 'master' into new-interfaces	2021-10-06 11:38:17 +09:00
Dan Balasescu	9491e5a547	Merge pull request #14954 from peppy/rename-result-response ... Rename `APIRequest.Result` to `Response`	2021-10-06 10:52:33 +09:00
Dean Herbert	4f59fc15a5	Mark BeatmapSet as nullable for the time being	2021-10-06 05:54:37 +09:00
Dean Herbert	bd84a8b749	Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage	2021-10-05 18:21:21 +09:00
Dean Herbert	599d82e383	Avoid returning a live IEnumerable	2021-10-05 17:01:07 +09:00
Dean Herbert	a5aa32811a	Remove null check suppression and add non-null fallback	2021-10-05 14:49:59 +09:00
Dean Herbert	d3b9660148	Move common interface implementations to extension methods	2021-10-05 14:41:14 +09:00
Dean Herbert	b41fa41c85	Rename APIRequest.Result to Response	2021-10-05 14:28:56 +09:00
smoogipoo	593da79bbc	Further asyncify load process	2021-10-05 11:26:13 +09:00
Dean Herbert	1d99bc280f	Merge branch 'master' into new-interfaces	2021-10-04 20:42:40 +09:00
smoogipoo	031c5a441e	Merge branch 'master' into realtime-pp-display	2021-10-04 20:19:37 +09:00
smoogipoo	4871db2f86	Merge branch 'master' into importer-returns-live	2021-10-04 19:42:36 +09:00
Dean Herbert	f293e008d9	Move BeatmapInfo's SearchableTerms implementation to interface	2021-10-04 17:01:02 +09:00
Dean Herbert	51b7dce16f	Remove reference to osu-web-10	2021-10-04 16:55:51 +09:00
Dean Herbert	4df5f93152	Inline single usage of StoryboardFile to avoid interface default method woes	2021-10-04 16:55:02 +09:00
Dean Herbert	8bfdfe3672	Add literal string marker ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-04 16:54:00 +09:00
Dean Herbert	63f0b0c932	Rename out of place interface name	2021-10-04 16:35:55 +09:00
Dean Herbert	916342c837	Merge branch 'master' into importer-returns-live	2021-10-04 16:24:26 +09:00
smoogipoo	69c2b7dc59	Merge branch 'master' into rename-beatmap-info-beatmap-fields	2021-10-04 16:03:22 +09:00
smoogipoo	4e1322effa	Fix typo	2021-10-04 16:02:45 +09:00
Dean Herbert	ec61c3c5ee	Rename all remaining cases	2021-10-03 00:55:29 +09:00
Dean Herbert	20e3f7fec4	Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage	2021-10-02 13:08:02 +09:00
Dean Herbert	dcd7d7a709	Add JsonIgnore rule for StoryboardFile ... Not sure why this is required, doesn't make much sense.	2021-10-02 03:05:06 +09:00
Dean Herbert	d6dbdc911f	Merge branch 'master' into storyboard-fixes	2021-10-02 00:35:51 +09:00
Dan Balasescu	6a172d54d5	Merge branch 'master' into model-downloader-split	2021-10-01 22:34:39 +09:00
Dan Balasescu	154c412f34	Merge branch 'master' into beatmap-manager-split	2021-10-01 21:46:27 +09:00
Dean Herbert	4c28749d73	Fix incorrect legacy decoder usage	2021-10-01 19:05:08 +09:00
Dean Herbert	3faafd7200	Rename parameter to repeatCount and add guards	2021-10-01 18:26:29 +09:00
Dean Herbert	0daf8937e3	Add missing xmldoc	2021-10-01 17:36:44 +09:00
Dean Herbert	d6618a99a3	Redirect more methods to interface implementations	2021-10-01 17:36:44 +09:00
Dean Herbert	9dae92e78c	Add missing backlink to BeatmapSet from Beatmap and fix non-explicit implementations	2021-10-01 17:22:25 +09:00
Dean Herbert	00e33a1da7	Fix incorrect OnlineID mappings	2021-10-01 17:06:09 +09:00
Dean Herbert	05996cc2e9	Add changes that got forgotted in branch surgery	2021-10-01 17:04:53 +09:00
Dean Herbert	a92d499d7a	Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo	2021-10-01 16:55:50 +09:00
Dean Herbert	8595eb2d11	Switch BeatmapDifficulty usages to use interface type	2021-10-01 16:55:50 +09:00
Dean Herbert	d309636460	Update all EF based models to implement new read only interfaces	2021-10-01 16:55:50 +09:00
Dean Herbert	619dfe0690	Add new interface base types for models	2021-10-01 16:55:47 +09:00
Dean Herbert	c71cf1e220	Fix incomplete xmldoc	2021-10-01 01:51:31 +09:00
Dean Herbert	3ddb348252	Merge branch 'online-lookup-cache-separation' into beatmap-manager-split	2021-10-01 01:49:31 +09:00
Dean Herbert	2ed28f625a	Pass whole queue in rather than function	2021-10-01 01:46:37 +09:00
Dean Herbert	428c7830d9	Pass online lookup queue in as a whole, rather than function	2021-10-01 01:45:21 +09:00
Dean Herbert	dde19f2e81	Fix unbalanced brackets ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-01 01:37:51 +09:00
Dean Herbert	a2e61883e3	Initial push to use ILive in import process	2021-09-30 22:55:25 +09:00
Dean Herbert	3e3b9bc963	Split out IModelDownloader and also split apart ScoreManager	2021-09-30 18:25:20 +09:00
Dean Herbert	fd13142a15	Add missing interface to BeatmapManager	2021-09-30 18:21:24 +09:00
Dean Herbert	7a72747d88	Add back optional online lookups	2021-09-30 17:18:39 +09:00
Dean Herbert	90225f2082	Hook up all required interfaces to new BeatmapManager	2021-09-30 17:18:39 +09:00
smoogipoo	84bddf0885	Initial PP counter implementation	2021-09-30 17:00:24 +09:00
Dean Herbert	d21139b03e	Split out database portion from BeatmapManager	2021-09-30 15:43:49 +09:00
Dean Herbert	e7e0473323	Split out WorkingBeatmapCache from BeatmapManager	2021-09-30 15:40:41 +09:00
Dean Herbert	8a6501fa58	Add basic component level xmldoc	2021-09-30 14:46:07 +09:00
Dean Herbert	6ffd9fdcfa	Split out BeatmapOnlineLookupQueue from BeatmapManager	2021-09-30 14:46:01 +09:00
Dean Herbert	46bafb6252	Merge branch 'master' into no-more-difficulty-control-points-info	2021-09-28 13:53:56 +09:00
Dean Herbert	d4310f5d9a	Move database connection string operations local ... In line with framework changes in https://github.com/ppy/osu-framework/pull/4793.	2021-09-27 17:32:41 +09:00
Bartłomiej Dach	80197bae48	Revert not decoding legacy difficulty points on scrolling rulesets for now	2021-09-18 15:32:08 +02:00
Bartłomiej Dach	76ccdd1340	Collect and sort points from nested objects before extracting	2021-09-18 14:38:38 +02:00
Bartłomiej Dach	8026968939	Move difficulty -> effect point conversion back to decoder	2021-09-18 14:38:38 +02:00
Bartłomiej Dach	5969e2b852	Add TODO comment about lack of in-gameplay support	2021-09-13 00:13:07 +02:00
Bartłomiej Dach	1be8cb452f	Make new beatmaps' samples match playback rate by default	2021-09-12 16:57:21 +02:00
Bartłomiej Dach	af7c2b93e6	Add encoding support for SamplesMatchPlaybackRate	2021-09-12 16:47:38 +02:00
Bartłomiej Dach	cd181452be	Add decoding support for SamplesMatchPlaybackRate	2021-09-12 16:45:27 +02:00
Bartłomiej Dach	925b455330	Add "samples match playback rate" setting to beatmap info	2021-09-12 16:40:52 +02:00
Dean Herbert	943e0d49f7	Handle control point flattening of nested hit objects	2021-09-10 17:29:09 +09:00
Dean Herbert	34f875187c	Copy time between ControlPoints	2021-09-10 14:36:38 +09:00
Dean Herbert	212c3c699c	Reword xmldoc slightly	2021-09-10 12:58:12 +09:00
ekrctb	7543f9dfb0	Add featured artist track ID online info	2021-09-08 12:21:24 +09:00
Dean Herbert	eabca016d4	Throw rather than ignore on invalid control point addition	2021-09-06 22:04:37 +09:00
Dean Herbert	693ecdf62a	Refactor some incorrect/outdated terminology	2021-09-06 21:32:43 +09:00
Dean Herbert	3c7a34bdbd	Move mania-specific conversion to converter	2021-09-06 21:06:13 +09:00
Dean Herbert	766d789845	Rename ApproachRate to ScrollSpeed for now (to reduce complexity/confusion)	2021-09-06 21:06:13 +09:00
Dean Herbert	0e6660da30	Replace todo with permanent comment	2021-09-03 17:11:12 +09:00
Dean Herbert	8f24ea54ee	Change SamplePoints to be SortedList for conformity	2021-09-03 17:11:12 +09:00
Dean Herbert	2b9157987e	Fix regression in SampleControlPoint add logic	2021-09-03 17:11:12 +09:00
Dean Herbert	d587dc6203	Populate new approach rate where required	2021-09-03 17:11:12 +09:00
Dean Herbert	a3d9ab1e2e	Move approach rate to EffectControlPoint	2021-09-03 16:58:16 +09:00
Dean Herbert	4eb09ea1a9	Update decoder to also extract DifficultyControlPoints from HitObjects	2021-09-03 16:58:16 +09:00
Dean Herbert	db3fc1d4af	Move DifficultyControlPoints list to LegacyControlPointInfo	2021-09-03 16:58:16 +09:00
Dan Balasescu	6c649b7bbe	Merge branch 'master' into no-more-sample-control-points-info	2021-09-02 18:09:05 +09:00
Dean Herbert	f0b128b6ec	Merge pull request #14592 from frenzibyte/cleanup-tooltips ... Update remaining tooltip implementations to use generics	2021-09-01 17:03:59 +09:00
Dean Herbert	edf29e405b	Merge pull request #14581 from bdach/setup-screen-countdown-settings ... Add countdown settings to setup screen	2021-09-01 15:35:46 +09:00
Dan Balasescu	e715b21ca7	Merge pull request #14586 from peppy/remove-ijsonserializable ... Remove IJsonSerializable interface	2021-09-01 14:17:32 +09:00
Bartłomiej Dach	1e4fa87648	Merge branch 'master' into setup-screen-countdown-settings	2021-08-31 22:43:18 +02:00
Salman Ahmed	505824d8ea	Constrain difficulty icon tooltip to internal accessibility" ... This reverts the reverted commit cd356b8eae. Sorry for the revert-unrevert, rushly pushed without realizing it doesn't even build.	2021-08-31 21:16:17 +03:00
Salman Ahmed	cd356b8eae	Revert "Constrain difficulty icon tooltip to internal accessibility" ... This reverts commit 4a590a041c.	2021-08-31 20:57:47 +03:00
Salman Ahmed	4a590a041c	Constrain difficulty icon tooltip to internal accessibility	2021-08-31 20:57:36 +03:00
Salman Ahmed	da7ff4b160	Update remaining tooltip implementations to use generics	2021-08-31 20:01:13 +03:00
Dean Herbert	a254624373	Avoid performing beatmap metadata lookups when entering the editor ... If none of the lookup parameters are available, skip the lookup completely.	2021-08-31 17:18:05 +09:00
Dean Herbert	d988aa1680	Actually serialise SampleControlPoints along with HitObjects	2021-08-31 15:14:03 +09:00
Dean Herbert	448c58c35d	Remove unnecessary variable discard ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-08-31 15:08:07 +09:00
Dean Herbert	9fa8bee094	Remove outdated TODO	2021-08-31 14:51:19 +09:00
Dean Herbert	ce0d7cce2d	Merge branch 'remove-ijsonserializable' into no-more-sample-control-points-info	2021-08-31 14:40:54 +09:00
Dean Herbert	c25ab6835c	Remove IJsonSerializable interface ... Was pretty pointless and made it hard to use the custom serialisation terms arbitrarily in tests.	2021-08-31 14:39:20 +09:00
Bartłomiej Dach	b43ee2d61c	Add descriptions to enum members	2021-08-30 22:51:42 +02:00
Dean Herbert	a2cff75fc0	Fix editor not cloning control points as expected	2021-08-30 21:55:08 +09:00
Dan Balasescu	b95da3ca27	Merge pull request #14576 from peppy/update-framework ... Update framework	2021-08-30 21:09:58 +09:00
Dean Herbert	1aaea7011a	Fix early return causing event loss in case of multiple control points in group	2021-08-30 18:33:05 +09:00
Dean Herbert	015df282fe	Simplify copy operations	2021-08-30 18:32:55 +09:00
Dean Herbert	d35c4da906	Add new control point to legacy regeneration logic	2021-08-30 17:14:53 +09:00
Dean Herbert	6ee4a6526c	Don't block sample points from still being added to ControlPointInfo	2021-08-30 17:14:53 +09:00
Dean Herbert	6fd24a5d92	Remove redundant null coalesce	2021-08-30 17:14:53 +09:00
Dean Herbert	ccacf56dd8	Move to legacy namespace	2021-08-30 17:14:53 +09:00
Dean Herbert	7257aae7f2	Move samples to LegacyControlPointInfo	2021-08-30 17:14:53 +09:00
Dean Herbert	da7a871afa	Update inline comment to point to new variable location ... Co-authored-by: PercyDan <50285552+PercyDan54@users.noreply.github.com>	2021-08-30 16:27:24 +09:00
Dean Herbert	fa2bf42188	Update tooltip implementations	2021-08-30 16:05:00 +09:00
Dean Herbert	6a6dac609c	Fix instability of taiko double conversion ... Until now, the taiko speed multiplier was potentially applied more than once if conversion was run multiple times.	2021-08-30 15:30:18 +09:00
Dean Herbert	ee49305cad	Move taiko legacy speed multiplier to osu.Game project ... Allows it to be used in local case in `LegacyBeatmapEncoder`.	2021-08-30 15:13:31 +09:00
Salman Ahmed	e374ef163d	Update localisable formattable extensions usages inline with framework change	2021-08-29 15:00:28 +03:00
Dean Herbert	6dcd9427ac	Remove bindable usage in PathControlPoint ... This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class. I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.	2021-08-26 12:33:53 +09:00
Dean Herbert	414457ba57	Add basic xmldoc explaining CountdownOffset	2021-08-25 13:24:52 +09:00
Bartłomiej Dach	a6c2cbd2e5	Add countdown settings to beatmap info model	2021-08-24 21:55:10 +02:00
Dan Balasescu	dfd61e413a	Merge branch 'master' into difficulty-cache-difficulty-adjust	2021-08-24 12:08:52 +09:00
Dean Herbert	d17f7b5c8b	Side WidescreenStoryboard to on by default for new beatmaps	2021-08-23 17:40:41 +09:00
Bartłomiej Dach	d602dc9d90	Enable epilepsy warning setting persistence in encoder	2021-08-22 17:43:20 +02:00
Bartłomiej Dach	995338029c	Fix difficulty cache lookups sharing underlying mod instances ... `DifficultyCacheLookup`s were storing raw `Mod` instances into their `OrderedMods` field. This could cause the cache lookups to wrongly succeed in cases of mods with settings. The particular case that triggered this fix was Difficulty Adjust. Because the difficulty cache is backed by a dictionary, there are two stages to the lookup; first `GetHashCode()` is used to find the appropriate hash bucket to look in, and then items from that hash bucket are compared against the key being searched for via the implementation of `Equals()`. As it turns out, the first hashing step ended up being the saving grace in most cases, as the hash computation included the values of the mod settings. But the Difficulty Adjust failure case was triggered by the quirk that `GetHashCode(0) == GetHashCode(null) == 0`. In such a case, the `Equals()` fallback was used. But as it turns out, because the `Mod` instance stored to lookups was not cloned and therefore potentially externally mutable, it could be polluted after being stored to the dictionary, and therefore breaking the equality check. Even though all of the setting values were compared, the hash bucket didn't match the actual contents of the lookup anymore (because they were mutated externally, e.g. by the user changing the mod setting values in the mod settings overlay). To resolve, clone out the mod structure before creating all difficulty lookups.	2021-08-21 15:50:33 +02:00
Dean Herbert	77149044a5	Allow intro screen to retrieve beatmap even if rulesets is not loaded	2021-08-20 19:43:48 +09:00
Salman Ahmed	6d57a240ac	Add animation support for the star rating display	2021-08-19 07:17:43 +03:00
Salman Ahmed	102320f8ae	Merge branch 'master' into mod-settings-difficulty-cache	2021-08-19 06:35:13 +03:00
Salman Ahmed	d2df09432f	Center the star rating display text rather than left	2021-08-18 11:49:33 +03:00
Salman Ahmed	5e91ec73e3	Handle star rating range display sizing	2021-08-18 11:36:27 +03:00
Dean Herbert	9d2664cbb1	Merge branch 'master' into star-rating-display-v2	2021-08-18 17:22:33 +09:00
Salman Ahmed	74d6c26520	Refactor star rating display layout with flexibility in mind	2021-08-18 11:03:35 +03:00
Salman Ahmed	32ba525555	Track changes to mod settings in beatmap difficulty cache with 100ms debouncing	2021-08-17 05:46:05 +03:00
Salman Ahmed	0291cd5ae2	Consider mod equality in difficulty cache lookup rather than acronym	2021-08-17 04:27:43 +03:00
Bartłomiej Dach	e744629a41	Fix broken obsoletion message	2021-08-16 01:01:56 +02:00
Bartłomiej Dach	6108451449	Retrieve separated skin instance from working beatmap for editing	2021-08-15 21:18:09 +02:00
Bartłomiej Dach	7c88a1c6de	Add a way to change custom combo colours via IHasComboColours ... `IHasComboColours` was already mutable (via a strange `AddComboColours()` method) and exposing a straight list is easier to work with. `IHasCustomColours` is also similarly externally mutable (in a way which is not easily removable).	2021-08-15 20:06:06 +02:00
Salman Ahmed	b01893d3f2	Merge branch 'master' into star-rating-display-v2	2021-08-06 13:51:34 +03:00
Dean Herbert	7d670c6d35	Fix gap in fill colour	2021-08-06 18:05:24 +09:00
Salman Ahmed	b63d472594	Adjust font size to match designs ... Looks silly when using `12f`, I've added a todo comment so that this specific case does not get forgotten when CSS-compatible font sizing gets supported. The todo comment may not be 100% required but very unsure about silently changing it and forgetting about it.	2021-08-04 18:19:37 +03:00
Salman Ahmed	b2332eb5b3	Use new difficulty colours permanently	2021-08-04 18:19:37 +03:00
Salman Ahmed	284fa49646	Bring margins of components closer to existing designs	2021-08-04 18:19:28 +03:00
Salman Ahmed	42370e48ec	Disable shadow on star display text	2021-08-04 18:19:28 +03:00
Salman Ahmed	d4399f10f9	Merge both variants of the star rating display	2021-08-04 18:19:28 +03:00
Salman Ahmed	14da5ab813	Remove defined size from the star rating display	2021-08-04 17:12:20 +03:00