Dean Herbert
|
2346644c04
|
Switch DelayedLoadUnloadWrappers to DelayedLoadWrappers
Due to pooling usage, there is no time we need to unload. Switching to
DelayedLoadWrapper cleans up the code and reduces overhead
substantially.
|
2020-10-13 18:47:40 +09:00 |
|
Dean Herbert
|
a1801f8ae4
|
Unmark todo for now
|
2020-10-13 18:47:36 +09:00 |
|
Dean Herbert
|
40a0ab7aaa
|
Avoid allocating CarouselItems for bounds checks
|
2020-10-13 18:33:31 +09:00 |
|
Dean Herbert
|
4f4f222514
|
Remove unnecessary fade (already applied by base DrawableCarouselItem)
|
2020-10-13 18:28:28 +09:00 |
|
Dean Herbert
|
83358d487f
|
Remove logging
|
2020-10-13 18:18:22 +09:00 |
|
Dean Herbert
|
3d9ea852ec
|
Remove masking override (no longer needed as our size is now correct)
|
2020-10-13 18:14:23 +09:00 |
|
Dean Herbert
|
69650c16fc
|
Simplify vertical position calculations by including spacing in height definition
|
2020-10-13 18:13:36 +09:00 |
|
Dean Herbert
|
b1ddb08a4e
|
Fix right click context menus appearing in incorrect locations
|
2020-10-13 18:01:12 +09:00 |
|
Dean Herbert
|
d9a6a6b245
|
Split content out into own class
|
2020-10-13 18:01:12 +09:00 |
|
Dean Herbert
|
9b2ebb8f0f
|
Fix main content DelayedLoadUnloadWrapper not getting a valid size before load
|
2020-10-13 17:45:41 +09:00 |
|
Dean Herbert
|
f3b937e358
|
Fix masking issues with certain aspect ratio displays
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
fdd4d95cdc
|
Fix difficulties being at incorrect vertical positions after filter is applied
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
1f0aa974dd
|
Fix failing tests
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
b536f571fd
|
Move header height propagation to update for safety
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
ded09b78cb
|
Avoid usage of AutoSize for DrawableCarouselItems in general
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
cecdf14f53
|
Avoid reconstructing beatmap difficulties that were recently displayed
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
1da49073ab
|
Calculate content height automatically
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
c08b5e8d03
|
Align beatmap difficulties correctly
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
cfec4f4fc1
|
Extract header element from base DrawableCarouselItem class
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
2aad482545
|
Fix x offsets of difficulties not being updated
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
1b7e3397c6
|
Use expiry to avoid ToArray
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
075bf23714
|
Better track off-screen drawables (and return to pool less often)
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
29983afcef
|
Replace pool/cleanup logic with simplest form possible
This will temporarily break panels that go off-screen, as they will
disappear immediately
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
06e84c8eb3
|
Add comments and split out update steps into a more logical flow
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
20b54fb904
|
Move transform clean-up to pooling free call
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
f6aa448523
|
Store y positions inside items rather than in a separate array
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
b92c22ad42
|
Add logging
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
9814e9ba7f
|
Split classes out to reduce loc burder on DrawableCarouselBeatmapSet
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
975cd5a840
|
Add back beatmap difficulty appear/disappear movement
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
fd8654cff3
|
Add back difficulty panel spacing
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
ce67f65084
|
Fix single results not showing up
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
220c8ba2c4
|
Fix incorrect vertical offsets when difficulties are filtered away
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
82f9ca3de9
|
Bind to filter event changes in base drawable item
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
813ee19728
|
Use existing event flow for rendering beatmap difficulties
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
8847cedf29
|
Add initial pass of vertical transforms
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
15325f5f51
|
Base bounds checks on +1 (to avoid worrying about current item heights)
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
bb03c5d77c
|
Temporarily disable masking temporarily to fix panels disappearing at extents
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
524419d5e4
|
Fix filtered items being considered for height calculation
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
0a144a1388
|
Correctly free panels after use to avoid finalizer disposal of subtree
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
c5a6f4b453
|
Fix scroll to selected beatmap
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
5c29aa8cce
|
Fix multiple difficulties being expanded at once
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
5c2f134665
|
Add back left offset for selected set
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
3cfc0dc82d
|
Add safeties to beatmap panel loading code
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
954d43ef56
|
Debounce state application events
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
ca1f5dcada
|
Add back panel padding
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
0400b34349
|
Load more components asynchronously after pool resolution
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
f3b24b9bb5
|
Avoid performing eager selection constantly on adding ranges of new children
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
0a978c6131
|
Add basic pooling setup
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
f17d661c1a
|
Add basic range-based invalidation
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
3143224e5b
|
Refactor how drawable carousel items are constructed
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
9193f5b0ba
|
Expose panel height from non-drawable models
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
a393bbe8f7
|
Remove direct drawable storage from carousel models
|
2020-10-13 17:37:33 +09:00 |
|
Dean Herbert
|
73c238fae3
|
Add the ability to search for local beatmaps via online IDs
Closes #10470.
|
2020-10-10 21:34:11 +09:00 |
|
Joehu
|
c6386ea605
|
Remember leaderboard mods filter selection in song select
|
2020-09-15 21:53:35 -07:00 |
|
Dean Herbert
|
3c70b3127c
|
Fix potential nullref in FilterControl during asynchronous load
|
2020-09-15 23:19:31 +09:00 |
|
Dan Balasescu
|
6cbff98295
|
Merge branch 'master' into add-collections-to-beatmap-options
|
2020-09-15 15:23:33 +09:00 |
|
Dean Herbert
|
2c7492d717
|
Add null check in SongSelect disposal for safety
|
2020-09-15 14:34:58 +09:00 |
|
Joehu
|
43daabc982
|
Remove unused using and move dialog to BDL
|
2020-09-14 12:10:00 -07:00 |
|
Joehu
|
c833f5fcc4
|
Reorder buttons to match stable
|
2020-09-14 11:23:41 -07:00 |
|
Joehu
|
57610ddad5
|
Fix beatmap options absorbing input from toolbar ruleset selector
|
2020-09-14 11:22:16 -07:00 |
|
Joehu
|
c30174cea3
|
Add manage collections button to beatmap options
|
2020-09-14 11:21:23 -07:00 |
|
Joehu
|
1a8a7ae7f8
|
Remove hardcoded key param from AddButton
|
2020-09-14 11:19:18 -07:00 |
|
Joehu
|
368aca015a
|
Move override methods to bottom
|
2020-09-14 11:18:00 -07:00 |
|
Bartłomiej Dach
|
a377cccb4d
|
Unsubscribe from track changed event on disposal
|
2020-09-14 17:10:35 +02:00 |
|
Bartłomiej Dach
|
f17b2f1359
|
Ensure track is looping in song select immediately
|
2020-09-12 20:43:17 +02:00 |
|
smoogipoo
|
5b80a7db5f
|
Re-namespace collections dropdown
|
2020-09-11 16:01:01 +09:00 |
|
Dean Herbert
|
033bd82953
|
Merge branch 'master' into fix-filtercontrol-order
|
2020-09-11 13:07:41 +09:00 |
|
Dean Herbert
|
b594a2a507
|
Import collections on initial import-from-stable step
|
2020-09-11 11:16:00 +09:00 |
|
smoogipoo
|
314cd13b74
|
Fix song select filter ordering
|
2020-09-10 23:36:22 +09:00 |
|
Dean Herbert
|
18d96738a1
|
Fix hard crash on deleting a collection with no collection selected
|
2020-09-10 19:52:34 +09:00 |
|
smoogipoo
|
6b56c6e83f
|
Rename to CollectionMenuItem
|
2020-09-09 23:11:19 +09:00 |
|
smoogipoo
|
43525614ad
|
Store raw BeatmapCollection in filter control
|
2020-09-09 23:10:21 +09:00 |
|
smoogipoo
|
1a023d2c88
|
Fix a few more tests
|
2020-09-09 16:33:48 +09:00 |
|
smoogipoo
|
0360f7d845
|
Move CollectionManager to OsuGame
|
2020-09-09 15:39:15 +09:00 |
|
smoogipoo
|
4ddf5f054b
|
Rename BeatmapCollectionManager -> CollectionManager
|
2020-09-09 15:31:08 +09:00 |
|
smoogipoo
|
a5e1e8d043
|
Rename More... to Manage...
|
2020-09-08 18:57:18 +09:00 |
|
smoogipoo
|
ae022d7559
|
Show all items in dropdown, set global max height
|
2020-09-08 18:55:53 +09:00 |
|
smoogipoo
|
4962213cc4
|
Rename manage collections filter/text
|
2020-09-08 18:42:55 +09:00 |
|
smoogipoo
|
f581df47c8
|
Add "New collection..." item to dropdown
|
2020-09-08 18:25:09 +09:00 |
|
smoogipoo
|
c2da3d9c84
|
Fix button input and tests
|
2020-09-08 14:36:38 +09:00 |
|
smoogipoo
|
8a3c8a6185
|
Show button when selected or preselected
|
2020-09-08 14:03:49 +09:00 |
|
smoogipoo
|
32e3f5d091
|
Adjust button styling
|
2020-09-08 13:45:26 +09:00 |
|
Dean Herbert
|
8b770626fa
|
Add missing '...' from some popup menu items
|
2020-09-08 12:18:08 +09:00 |
|
Dean Herbert
|
b15bbc882a
|
Move items up in menu
|
2020-09-08 12:04:35 +09:00 |
|
Dean Herbert
|
3e5ea6c42f
|
Change "Add to" to "Collections"
Doesn't make send to be 'add to' when it can also remove
|
2020-09-08 12:00:00 +09:00 |
|
smoogipoo
|
ca4423af74
|
Fix tests
|
2020-09-08 00:07:12 +09:00 |
|
smoogipoo
|
e37c04cb6d
|
Change back to solid icon
|
2020-09-08 00:04:03 +09:00 |
|
smoogipoo
|
a1214512bc
|
Add filter control tests
|
2020-09-07 23:57:49 +09:00 |
|
smoogipoo
|
98e9c4dc25
|
General refactorings
|
2020-09-07 21:08:48 +09:00 |
|
smoogipoo
|
c1d255a04c
|
Split filter control into separate class
|
2020-09-07 20:44:39 +09:00 |
|
smoogipoo
|
120dfd50a6
|
Fix collection names not updating in dropdown
|
2020-09-07 20:29:28 +09:00 |
|
smoogipoo
|
b91a376f0a
|
Split dropdown into separate file
|
2020-09-07 20:06:38 +09:00 |
|
smoogipoo
|
6cc4517600
|
Merge branch 'master' into collection-database
|
2020-09-07 20:03:11 +09:00 |
|
smoogipoo
|
4b4dd02942
|
Make collection name a bindable
|
2020-09-05 04:43:59 +09:00 |
|
smoogipoo
|
345fb9d8e0
|
Rename classes
|
2020-09-05 03:55:43 +09:00 |
|
smoogipoo
|
ebd11ae0b7
|
Add a collection management dialog
|
2020-09-05 03:52:07 +09:00 |
|
Dan Balasescu
|
743c888986
|
Merge branch 'master' into expose-wedge-icons
|
2020-09-04 16:22:14 +09:00 |
|
Dan Balasescu
|
b631430a5b
|
Merge pull request #10045 from peppy/add-info-wedge-icons
Update and add missing beatmap statistic icons to info wedge
|
2020-09-04 16:22:01 +09:00 |
|
smoogipoo
|
4399f5976c
|
Fix global mods being retained by rooms
|
2020-09-04 15:20:55 +09:00 |
|
Dean Herbert
|
25e142965d
|
Strongly type and expose default beatmap information icon implementations for other rulesets
|
2020-09-04 15:01:32 +09:00 |
|