Dean Herbert
91c2cadb47
Add missing colon in mod settings tooltip
2023-08-23 19:13:32 +09:00
Dean Herbert
018be4c20f
Fix selection not being retained when switching between split mode
2023-08-22 18:49:02 +09:00
Dean Herbert
ecbf0f138e
Fix incorrect handling when new beatmaps arrive
2023-08-22 18:48:07 +09:00
Dean Herbert
2b1c6ae612
Ensure ID is maintained in temporary BeatmapSetInfos
2023-08-22 18:48:07 +09:00
Dean Herbert
290d18ad69
Split out difficulties in beatmap carousel in a bit of a hacky way
...
Seems like the simplest path forward for now, without a full rewrite.
2023-08-22 18:47:41 +09:00
Bartłomiej Dach
8cd9f0822a
Merge branch 'master' into judge-fix
2023-08-22 09:44:58 +02:00
Bartłomiej Dach
5be5335784
Reword comment to be better
2023-08-22 09:37:54 +02:00
Bartłomiej Dach
142abe1fd0
Make highlight messages important in order to trigger window flash
2023-08-22 09:01:32 +02:00
Bartłomiej Dach
aa29e00578
Remove FlashTaskbar and use IsImportant directly instead
2023-08-22 08:58:48 +02:00
Bartłomiej Dach
be1a712f33
Make OsuGame dependency nullable
2023-08-22 08:54:41 +02:00
Bartłomiej Dach
71b5be2568
Merge branch 'master' into ux/notifications/flash-on-message
2023-08-22 08:20:08 +02:00
Dean Herbert
f09b818418
Update resources
2023-08-22 13:17:12 +09:00
Dan Balasescu
e8337c592a
Update framework and apply changes to support masking SSBO
2023-08-22 12:50:13 +09:00
Dean Herbert
2937dcef1a
Merge pull request #24610 from bdach/remove-global-action-container-hack
...
Remove global action container input queue workaround
2023-08-22 12:44:26 +09:00
tsrk
96c58c86ea
refactor: make flashing available in Notifications
...
This will be used in `NotificationOverlay` when a `Notification` is posted.
2023-08-21 23:36:54 +02:00
Wleter
9f4f81c150
accumulating negative scaling
2023-08-21 19:36:11 +02:00
Bartłomiej Dach
5454d1caa1
Remove global action container input queue workaround
...
As described in #24248 , the workaround employed by
`GlobalActionContainer`, wherein it tried to handle actions with
priority before its children by being placed in front of the children
and not _actually containing_ said children, is blocking the resolution
of some rather major input handling issues that allow key releases to be
received by deparented drawables.
To resolve, migrate `GlobalActionContainer` to use `Prioritised`, which
can be done without regressing certain mouse button flows after
ppy/osu-framework#5966 .
2023-08-21 17:54:08 +02:00
Bartłomiej Dach
273dcf9150
Also update the reference to added flag in schema change breakdown
2023-08-21 17:44:35 +02:00
Bartłomiej Dach
99c862f894
Merge branch 'master' into fix-score-import-fail-fail-fail
2023-08-21 17:28:10 +02:00
Bartłomiej Dach
8533cba0bf
Fix mismatching schema version in comment
2023-08-21 17:27:05 +02:00
Bartłomiej Dach
aa5680a8aa
Merge pull request #24527 from Pasi4K5/fix-slider-reversing
...
Fix sliders being reversed incorrectly in the editor
2023-08-21 17:12:00 +02:00
Bartłomiej Dach
6cd48e9db5
Merge pull request #24604 from peppy/fix-star-fountain-directions
...
Fix star fountain directions not matching stable
2023-08-21 17:00:51 +02:00
tsrk
bdac052631
refactor(MessageNotifier): apply changes required by framework
2023-08-21 15:29:41 +02:00
OliBomby
e283aa2843
Update inline comments
2023-08-21 13:09:31 +02:00
OliBomby
5bc11ed358
Revert "Ensure invariant of monotone time"
...
This reverts commit 5d1ccc2601
2023-08-21 13:02:23 +02:00
OliBomby
c7b1c75379
Revert "Fix typo"
...
This reverts commit 90f2acaf0a
2023-08-21 13:00:01 +02:00
Dean Herbert
b3e7416972
Rename new flag and update xmldoc to match
2023-08-21 19:36:22 +09:00
Dean Herbert
662073c472
Fix some incorrect comments / test step descriptions
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-21 19:35:04 +09:00
Dean Herbert
db893f3dc7
Merge branch 'master' into fix-score-import-fail-fail-fail
2023-08-21 19:34:12 +09:00
Dean Herbert
5f040a991b
Fix potential crash when loading menu items due to cross-thread ops
2023-08-21 19:05:20 +09:00
Dean Herbert
e7d61e0002
Fix star fountain directions not matching stable
2023-08-21 17:59:24 +09:00
Dean Herbert
4915b2563c
Merge pull request #24366 from Joehuu/supporter-playlist-duration
...
Always show supporter-only playlist durations
2023-08-21 17:46:26 +09:00
Bartłomiej Dach
1d657a8844
Merge branch 'master' into fix-slider-reversing
2023-08-21 09:29:46 +02:00
Bartłomiej Dach
90bef267c8
Merge pull request #24581 from OliBomby/fix-segment-ends
...
Fix `SliderPath.GetSegmentEnds`
2023-08-21 09:29:13 +02:00
Bartłomiej Dach
dd1ac461db
Reformat xmldoc
2023-08-21 08:29:51 +02:00
Bartłomiej Dach
c27f06c0a7
Merge branch 'master' into formats-nrt
2023-08-21 08:17:34 +02:00
Bartłomiej Dach
de9a4448fc
Merge branch 'master' into fix-export-slider
2023-08-21 07:28:16 +02:00
Bartłomiej Dach
a942b6ff74
Replace inline comment with actual explanation of what's happening
2023-08-21 07:27:02 +02:00
Wleter
d2798c7a1c
don't allow negative scaling
2023-08-20 17:55:19 +02:00
OliBomby
56b1062c2f
expand xmldoc
2023-08-19 19:39:29 +02:00
Dean Herbert
8120c3f87a
Merge branch 'master' into precise-rotation-2
2023-08-19 23:25:42 +09:00
Bartłomiej Dach
0a55830c16
Add braces for clarification
...
I like no-braces for single-line ifs as much as anyone, but with inline
comments involved it gets rather dicey.
2023-08-19 14:34:20 +02:00
tsrk
548e6dc23b
feat(MessageNotifier): flash window on PM or mention
2023-08-19 03:04:09 +02:00
Pasi4K5
44a85139e4
Update Reverse() based on the changes in #24581
2023-08-19 02:40:18 +02:00
Pasi4K5
47d787b359
Merge remote-tracking branch 'OliBomby/fix-segment-ends' into fix-slider-reversing
2023-08-19 02:38:34 +02:00
Pasi4K5
0e691d5935
Revert changes in SliderPath
2023-08-19 00:16:05 +02:00
OliBomby
ff07fbae15
fix GetSegmentEnds
2023-08-18 12:20:40 +02:00
Dean Herbert
cbee7c7146
Merge branch 'master' into import-stable-date-added
2023-08-18 18:01:06 +09:00
Dean Herbert
5e0b89a1a8
Rename GetPath to GetFullPath to better match expectations
2023-08-18 17:56:43 +09:00
Dean Herbert
864f1bdb3e
Move population of import time to the Populate method
...
Feels like a better place to be doing this. I think we want to keep any
kind of potentially expensive work in the `Populate` method.
2023-08-18 17:56:11 +09:00
Dean Herbert
eb2460d180
Remove dead metadata transfer code
2023-08-18 17:40:00 +09:00
Dean Herbert
9023059bc0
Convert to switch statement
2023-08-18 17:27:09 +09:00
Dean Herbert
75750957c7
Add note about why pop in samples are disabled for PasswordEntryPopover
2023-08-18 17:11:30 +09:00
Dean Herbert
fc2fac577f
Inverse and xmldoc ShearedToggleButton sample allowance bool
2023-08-18 17:05:25 +09:00
Pasi4K5
3481c41a22
Fix segmentEnds being calculated incorrectly
2023-08-18 04:34:10 +02:00
OliBomby
360f9750e1
Allow selecting empty control point groups
2023-08-17 16:30:18 +02:00
Dean Herbert
c811546868
Update resources
2023-08-17 21:09:50 +09:00
Jamie Taylor
d10d7b6ea4
Change some component samples to go better with overlay pop-in samples
2023-08-17 18:36:37 +09:00
Jamie Taylor
3d7ba0e18c
Add pop-in/pop-out sfx to more overlays
2023-08-17 18:36:37 +09:00
Jamie Taylor
04a1f6a508
Add panning to certain overlay pop-in/pop-outs
2023-08-17 18:36:37 +09:00
Jamie Taylor
b15a54c914
Use new overlay pop-in/pop-out samples
2023-08-17 18:36:36 +09:00
Dean Herbert
e2cb0d7afb
Update framework
2023-08-17 17:59:22 +09:00
Dean Herbert
a78c03bd5b
Merge branch 'master' into precise-rotation-2
2023-08-17 17:59:13 +09:00
Krzysztof Gutkowski
59abb59ee8
Set correct date added value when importing stable beatmapsets
2023-08-17 00:49:48 +02:00
OliBomby
8686b6b1e6
fix The last slider point has effect on previous inherited
2023-08-16 16:44:08 +02:00
Dean Herbert
59a31cc868
Merge pull request #24431 from bdach/slider-with-textbox-instantaneous
...
Add instantaneous mode to `SliderWithTextBoxInput`
2023-08-16 20:10:52 +09:00
Bartłomiej Dach
ed84be2f26
Merge pull request #24566 from peppy/multiplayer-spectator-score-diff
...
Add score difference display to multiplayer spectator
2023-08-16 12:57:17 +02:00
Dean Herbert
49fc9655d2
Apply NRT to osu.Game.Betamaps.Formats namespace
2023-08-16 19:37:24 +09:00
Bartłomiej Dach
f9ca7f3e0e
Merge pull request #24564 from peppy/multi-spectator-test-improvements
...
Add various testing improvements to various tournament components
2023-08-16 12:29:36 +02:00
Bartłomiej Dach
19f892687a
Add precise rotation control to osu! editor
2023-08-16 11:37:52 +02:00
Bartłomiej Dach
bdf87e43db
Merge branch 'master' into slider-with-textbox-instantaneous
2023-08-16 10:48:45 +02:00
Bartłomiej Dach
35af15f491
Merge branch 'master' into multi-spectator-fix-startup-delay
2023-08-16 10:34:20 +02:00
Dean Herbert
8b9759c569
Apply nullability to MatchScoreDisplay
2023-08-16 17:26:10 +09:00
Dean Herbert
ab826c35b7
Add score diff display to multiplayer spectator
...
Basically pulling changes over from the tournament client implementation
2023-08-16 17:26:10 +09:00
Dean Herbert
56eb44d15b
Change TestSpectatorClient to provide some better fake data for score / acc
2023-08-16 17:14:42 +09:00
Bartłomiej Dach
add1ef77d0
Fix typo in comment
2023-08-16 10:07:12 +02:00
Bartłomiej Dach
4f47b196c1
Merge branch 'master' into fix-unsafe-realm-access
2023-08-16 09:59:17 +02:00
Bartłomiej Dach
d70a9a5bc4
Fill out xmldoc and adjust inline commentary
2023-08-16 09:40:46 +02:00
Dean Herbert
bb98f10ff6
Use CurrentTime instead of StartTime for hotfix seek (and update comment)
2023-08-16 16:38:49 +09:00
Dean Herbert
184eabb902
Merge branch 'master' into multi-spectator-fix-startup-delay
2023-08-16 16:27:49 +09:00
Dean Herbert
caf0fd0742
Refactor migration to read the same as previous one
2023-08-16 16:21:42 +09:00
Dean Herbert
68db112882
Re-date migration
2023-08-16 16:20:17 +09:00
Dean Herbert
c885b71f3a
Add leaderboard toggle as tracked setting to give better use visibility
2023-08-16 16:17:56 +09:00
Dean Herbert
31c2b7f925
Merge branch 'master' into leaderboard-toggle
2023-08-16 15:49:55 +09:00
Dean Herbert
6e11162ab1
Add helper method for safer realm Find<T>
2023-08-16 15:37:09 +09:00
Bartłomiej Dach
88295a49aa
Fix invalid reference in xmldoc
2023-08-16 07:38:31 +02:00
Bartłomiej Dach
6c4c76350f
Remove unused using directive
2023-08-16 07:36:56 +02:00
Dean Herbert
531794b26b
Fix ModelManager not correctly re-retrieving realm objects before performing operations
...
Falls into the age-old trap of attempting to retrieve an item from realm
without first ensuring that realm is in an up-to-date state.
Consider this scenario:
- Editor is entered from main menu, causing it to create a new beatmap
from its async `load()` method.
- Editor opens correctly, then main thread performs a file operations on
the same beatmap.
- Main thread is potentially not refreshed yet, and will result in `null`
instance when performing the re-fetch in `performFileOperation`.
I've fixed this by using the safe implementation inside `RealmLive<T>`.
Feels like we want this is one place which is always used as the correct
method.
On a quick search, there are 10-20 other usages of `Realm.Find<T>` which
could also have similar issues, but it'll be a bit of a pain to go
through and fix each of these. In 99.9% of cases, the accesses are on
instances which couldn't have just been created (or the usage of
recently-imported/created is blocked by realm subscription flows, ie.
baetmap import) so I'm not touching them for now.
Something to keep in mind when working with realm going forward though.
2023-08-16 14:23:32 +09:00
Dean Herbert
5bd7370439
Add log output when editor is creating a fresh beatmap
2023-08-16 14:23:17 +09:00
Dean Herbert
502844a858
Add ability to construct RealmLive from ID
2023-08-16 14:23:01 +09:00
Dean Herbert
6001f7e5c7
Rename "dummy" local user to something more descriptive
...
This created weird cases in logs which are very hard to understand. The
one which really got me was this:
```
[runtime] 2023-08-13 07:48:27 [verbose]: Invalidating working beatmap cache for unknown artist - unknown title (Dummy)
```
Which looks like a dummy working beatmap was invalidated, but it turns
out that's just the local user which was populated when creating a new
local beatmap.
2023-08-16 13:52:27 +09:00
Pasi4K5
58bffa13cd
Fix possible IndexOutOfRangeException
2023-08-16 01:19:41 +02:00
Pasi4K5
e7e0c49f42
Replace .Distinct() with truncateEndingDuplicates()
2023-08-16 01:14:25 +02:00
Pasi4K5
6346872c39
Improve code readability and add assertion to test scene
2023-08-15 23:27:12 +02:00
Dean Herbert
e8bde6504a
Fix score being cloned in async method causing random crashes
...
Closes https://github.com/ppy/osu/issues/24445 .
2023-08-15 16:08:13 +09:00
Dean Herbert
526a145b93
Merge pull request #24546 from peppy/update-framework
...
Update framework
2023-08-15 15:34:56 +09:00
Bartłomiej Dach
ab1d523528
Fix kiai stars flickering on and off during gameplay
...
Closes #24503 .
The problematic reset of `lastParticleAdded` has been moved to a place
that should hopefully (a) not cause such problems and (b) be much more
explicit about what's happening.
2023-08-15 07:44:05 +02:00
Dean Herbert
8c14ff674e
Update framework
2023-08-15 14:33:21 +09:00
Pasi4K5
449bee98cc
Code cleanup
2023-08-14 21:56:08 +02:00
Pasi4K5
19c8b74a47
Remove unnecessary circle arc approximation
2023-08-14 21:09:58 +02:00
Bartłomiej Dach
9e7cc05138
Merge branch 'master' into remove-fps-fade-in-out
2023-08-14 18:46:30 +02:00
Dan Balasescu
90d7e46e20
Fix incorrect truncation to int
2023-08-15 00:58:13 +09:00
Dean Herbert
34c761946c
Don't completely fade FPS counter out when running at full FPS
...
I've heard multiple times from uses that this is distracting or
confusing.
2023-08-14 23:55:57 +09:00
Pasi4K5
55ac942e7a
Fix IndexOutOfRangeException when trying to reverse a zero-length slider
2023-08-14 14:09:08 +02:00
Pasi4K5
f42b3603b3
Fix linear sliders sometimes being reversed incorrectly
...
Extract control point reversing to separate method
2023-08-14 14:08:02 +02:00
Dan Balasescu
d1a4a46fd3
Temporarily allow new difficulty attributes to not exist
2023-08-14 16:59:01 +09:00
Pasi4K5
8912a0e91e
Fix sliders being reversed incorrectly in the editor.
2023-08-12 20:30:48 +02:00
QuantumSno
a0543d97bd
Merge branch 'master' into leaderboard-toggle
2023-08-12 11:21:02 -04:00
Dean Herbert
0eaa383120
Update framework
2023-08-12 17:54:05 +09:00
Bartłomiej Dach
253392409e
Fix LegacyBeatmapExporter not converting beatmap between decode and re-encode
2023-08-12 00:50:31 +02:00
Bartłomiej Dach
37361cd683
Repurpose Flat{File -> }WorkingBeatmap
2023-08-12 00:49:42 +02:00
OliBomby
90f2acaf0a
Fix typo
2023-08-11 23:50:00 +02:00
OliBomby
5d1ccc2601
Ensure invariant of monotone time
2023-08-11 23:39:28 +02:00
OliBomby
d2f5e696e7
Fix DrawableHitObject state not synchronizing with hitobject edits
2023-08-11 22:34:04 +02:00
Dean Herbert
896cbb0ba0
Update framework
2023-08-11 21:34:59 +09:00
Bartłomiej Dach
2b738edb93
Reword / fix comments
2023-08-10 22:55:02 +02:00
Bartłomiej Dach
1b3806539a
Merge branch 'master' into leaderboard-toggle
2023-08-10 22:50:55 +02:00
QuantumSno
5d6ebb4df9
Removed comments organizing GlobalActionContainer.cs, since they were incorrectly grouping actions
2023-08-10 10:18:15 -04:00
QuantumSno
71c42167e7
Updated wording on realm comments
2023-08-10 10:17:12 -04:00
Bartłomiej Dach
2698ec9206
Merge branch 'master' into block-exit-if-save-failed
2023-08-08 23:41:03 +02:00
Bartłomiej Dach
500a1363ec
Merge branch 'master' into fix-break-info-decimal-separator
2023-08-08 22:49:00 +02:00
Joseph Madamba
49f5d6813e
Block beatmap editor from testing/exiting/exporting when saving fails
2023-08-04 22:08:25 -07:00
Joseph Madamba
d179fe3d96
Add support for changelog entries with url attached
2023-08-03 23:24:37 -07:00
Bartłomiej Dach
785d2ed9b1
Merge branch 'master' into multi-spectator-better-start-time
2023-08-03 22:07:47 +02:00
Bartłomiej Dach
52b1073d93
Fix playfield skin layer not rotating correctly with barrel roll mod
2023-08-03 21:08:00 +02:00
Bartłomiej Dach
dde03b7d46
Merge branch 'master' into playfield-skin-layer
2023-08-03 20:42:15 +02:00
Dean Herbert
d39ef48b71
Return null intead of FileNotFoundException on missing file in ZipArchiveReader
2023-08-03 09:01:11 +09:00
Dean Herbert
71f6e5731d
Fix potential null reference if no frames found
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-03 08:58:19 +09:00
Dean Herbert
f38b21110f
Add missing parenthesis to comment
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-08-03 08:57:43 +09:00
Bartłomiej Dach
f48b1ebdbf
Merge branch 'master' into fix-transparent-player-background
2023-08-03 00:41:42 +02:00
Joseph Madamba
aab462fd95
Fix valueText being replaced even if current is not binding to anything
2023-08-02 09:40:22 -07:00
Dean Herbert
87fee001c7
Fix multiplayer spectator potentially taking too long to start
...
When watching from the middle of gameplay, due to a series of failures,
`SpectatorClock` would not get seeked to the current time, causing all
clients to look like they were out of sync.
This is a hotfix for the issue. A better fix will require framework
changes or considerable restructuring.
I'd recommend testing this works in practice and agreeing that while it
is a hack, it's likely not going to cause issues and is something we
want to see fixed sooner rather than later.
2023-08-02 19:05:43 +09:00
Dean Herbert
75c1d5ad7f
Add lenience to FramedBeatmapClock workaround
2023-08-02 18:49:24 +09:00
Dean Herbert
14d87e49c7
Improve choice of where to start playback of multiplayer spectator
2023-08-02 18:46:35 +09:00
Dean Herbert
0e510088f9
Ensure background of gameplay is black when storyboard is overriding background display
2023-08-02 15:50:15 +09:00
Dean Herbert
a618ed140e
Move StoryboardReplacesBackground bindable more local to usage
2023-08-02 15:29:18 +09:00
QuantumSno
5443f89dca
Assuming its still set to tab, removes binding for toggle chat so itll be set to the new default
2023-08-01 16:58:52 -04:00
QuantumSno
426bc52fd5
Updated schema_version number and added braces around some migration cases to help with re-using variable names
2023-08-01 14:27:37 -04:00
Bartłomiej Dach
5b6c3321cf
Merge branch 'master' into multi-spectator-flow-fixes
2023-08-01 19:03:48 +02:00
Bartłomiej Dach
a75f42f5a9
Merge branch 'master' into multi-spectator-extended-results
2023-08-01 18:25:41 +02:00
Bartłomiej Dach
d65f08a048
Merge pull request #24427 from peppy/fix-skin-editor-crash-multi-spectator
...
Fix game crashing when entering skin editor in multiplayer spectator
2023-08-01 18:25:11 +02:00
Bartłomiej Dach
f7d5ac9f92
Privatise setter
2023-08-01 18:09:48 +02:00
QuantumSno
054ca5e59c
Merge branch 'master' into leaderboard-toggle
2023-08-01 10:06:03 -04:00
Dean Herbert
70bd1d3cf4
Fix centred player not animating correctly
2023-08-01 20:18:21 +09:00
Dean Herbert
df504e1fc2
Show extended statistics in multiplayer spectator automatically
2023-08-01 20:02:36 +09:00
Dean Herbert
fe47dc291b
Fix onLoadRequested getting early-exited too early in spectator scenarios
...
In some scenarios, multiplayer spectator would not tick over to the next
beatmap.
Here's an example:
- Room has two items queued
- Local user starts download of both
- First beatmap starts and download is complete
- First beatmap ends (spectating is active)
- Second beatmap starts but download is not complete
In this scenario, the local client will get stuck at the spectator
screen due to the `onLoadRequested`-invoked screen change being early
exited.
It would require manual recovery (clicking back button) to return to a
sane state.
2023-08-01 19:22:41 +09:00
Dean Herbert
9fe9ea2c90
Fix potential crash on multiple StartGameplay calls in multiplayer spectator
2023-08-01 19:22:41 +09:00
Bartłomiej Dach
4fb0ff8800
Implement instantaneous SliderWithTextBoxInput mode
2023-08-01 01:02:16 +02:00
Bartłomiej Dach
ca81f23356
Add test covering non-instantaneous behaviour
2023-08-01 01:01:37 +02:00
Bartłomiej Dach
2e2b0c4e41
Move SliderWithTextBoxInput to more general namespace
2023-08-01 01:01:36 +02:00
