4989 Commits

Author	SHA1	Message	Date
Poyo	d9cd546377	Use rate fallback in DrawableHitObject	2023-11-18 12:09:37 -08:00
Dean Herbert	6fa7b4f552	Merge branch 'master' into hp-drain-v1-2	2023-11-17 18:33:03 +09:00
Dean Herbert	9172632b0b	Rename method and adjust xmldoc to be very explicit about how wrong this is	2023-11-17 17:04:20 +09:00
Poyo	a73c870712	Allow GameplayRate to be nullable and assert before use	2023-11-15 17:00:35 -08:00
cs	520642975b	Fix control point hover text and context menu	2023-11-15 07:45:09 +01:00
Poyo	f5e1734de9	Use soft-cast to access IGameplayClock	2023-11-14 13:51:55 -08:00
Bartłomiej Dach	69c2c0e427	Fix touch device mod declared valid for multiplayer ... Mostly matters for web, so that it doesn't permit creation of playlist items with touch device inside.	2023-11-14 16:30:10 +09:00
Dan Balasescu	e3137d575b	Fix osu! and base HP processor break time implementation	2023-11-14 01:11:17 +09:00
cs	fa976a5aa0	Fix code style/quality issues	2023-11-13 08:25:27 +01:00
Dan Balasescu	98e6b7744b	Cleanup	2023-11-13 13:46:47 +09:00
Poyo	f794d4dc83	Allow gameplayClock to be null	2023-11-12 13:29:40 -08:00
Poyo	e67725f5d6	Use IGameplayClock for rate	2023-11-12 12:14:19 -08:00
ratinfx	fab6fc9adb	Updated comments, renamed method	2023-11-12 15:09:15 +01:00
Dean Herbert	6bd5eda2a0	Merge branch 'master' into arod_rate_adjust	2023-11-12 15:49:07 +09:00
ratinfx	c367697559	Changed TIME_REGEX to accept everything in the parentheses ... - changed osu-web link to the current value	2023-11-11 16:14:26 +01:00
cs	54b8244a18	CI Fixup	2023-11-11 15:02:06 +01:00
ratinfx	4e1e19728c	Refactor HitObject selection in Composer	2023-11-11 14:02:42 +01:00
cs	3f85aa79c5	Add free-hand drawing of sliders to the editor	2023-11-11 13:33:25 +01:00
Thomas Müller-Höhne	926636cc03	Generalize Bezier curves to BSplines of Nth degree	2023-11-11 13:32:53 +01:00
Poyo	064857c40b	Calculate unstable rate using rate-adjusted offsets	2023-11-10 19:57:44 -08:00
Givikap120	d0d334a371	Update Ruleset.cs	2023-11-10 15:05:26 +02:00
Givikap120	9ef34fa51a	FIxed stated problems	2023-11-10 15:02:15 +02:00
Dan Balasescu	fecc6f580b	Add legacy reference health processor	2023-11-10 18:40:21 +09:00
Dean Herbert	1c63f1f89d	Merge pull request #25348 from bdach/less-basic-touchscreen-detection ... Implement basic touchscreen detection	2023-11-10 18:01:40 +09:00
Dean Herbert	92043f45a4	Merge branch 'master' into slider-combo-matching-2	2023-11-09 18:45:37 +09:00
Bartłomiej Dach	13b599b9b6	Merge branch 'master' into less-basic-touchscreen-detection	2023-11-09 17:36:48 +09:00
Dean Herbert	c00a1d948a	Merge branch 'master' into better-touch-settings	2023-11-07 23:21:59 +09:00
ratinfx	aa87e0a44d	HitObject Selection logic and separation for gamemodes ... + moved time_regex into EditorTimestampParser	2023-11-07 01:36:58 +01:00
Susko3	05d9418718	Rename setting to TouchDisableGameplayTaps for better visibility when searching	2023-11-07 00:13:46 +01:00
Susko3	ea357bafdd	Fix tests by using the correct setting for touch input	2023-11-06 20:53:22 +01:00
Bartłomiej Dach	a136f272cf	Just use yellow for system mods	2023-11-06 16:40:57 +01:00
Bartłomiej Dach	4bc36a6c90	Fix unused variable	2023-11-06 12:18:02 +01:00
Bartłomiej Dach	6deac9a5a4	Use better colours for system mods	2023-11-06 11:41:23 +01:00
Bartłomiej Dach	204cd541e2	Use placeholder mod icon for touch device	2023-11-06 10:14:56 +01:00
Givikap120	57170501cd	Improve code quality	2023-11-04 17:25:09 +02:00
Bartłomiej Dach	8e9006b5d5	Declare Touch Device incompatible with Autopilot ... With Autopilot active, Touch Device no longer matters.	2023-11-02 22:57:05 +01:00
Bartłomiej Dach	8784dd42c0	Do not attempt to turn on Touch Device in song select with autoplay active	2023-11-02 22:56:43 +01:00
Bartłomiej Dach	2f6ff893b5	Automatically activate and deactivate touch device mod in song select	2023-11-02 19:45:48 +01:00
Bartłomiej Dach	68efb3c110	Mark ModTouchDevice as always valid for submission	2023-11-02 19:25:57 +01:00
Bartłomiej Dach	9f11a04cc7	Generalise notion of 'touch device' mod	2023-11-02 19:14:05 +01:00
Dean Herbert	818432fab4	Fix non-classic osu! combo not matching expectations	2023-11-02 19:27:55 +09:00
Dean Herbert	57d8b5ddc9	Merge pull request #25328 from bdach/mod-cleanups-docs ... Clean up mod usability flags	2023-11-01 15:48:47 +09:00
Bartłomiej Dach	a90f8dd4f6	Seal a few more multiplayer playability flags of rate-changing mods ... Not really changing anything, just tightening things down to curb possible funny business.	2023-10-31 16:20:33 +01:00
Bartłomiej Dach	955e2ed051	Seal UnknownMod ... Not a class for extension.	2023-10-31 16:18:09 +01:00
Bartłomiej Dach	a644c75957	Mark ModScoreV2 as invalid for multiplayer ... Doesn't do much for the client; mostly a safety for osu-web's sake, as without the change it could theoretically fail to validate the mod properly in multiplayer contexts.	2023-10-31 16:16:59 +01:00
Bartłomiej Dach	456f4ebba2	Seal ModScoreV2 ... Nobody should ever need to extend it.	2023-10-31 16:16:14 +01:00
Bartłomiej Dach	3a2645efb1	Seal ModAutoplay playability flags ... Can't do much more than that due to the unfortunate fact of Cinema inheriting from Autoplay.	2023-10-31 16:15:10 +01:00
Bartłomiej Dach	7ea298a1b6	Add xmldoc to Mod playability flags	2023-10-31 16:13:44 +01:00
Dean Herbert	a91b704d21	Fix some new nullable inspections	2023-10-30 15:10:10 +09:00
Bartłomiej Dach	79910df959	Fix catch distance snap provider not hiding slider properly ... Regressed in https://github.com/ppy/osu/pull/25171. The old code was kinda dependent on correct order of setting `Disabled`. `CatchHitObjectComposer` would disable distance spacing in its BDL, and then via the base `DistancedHitObjectComposer.LoadComplete()`, the slider would be faded out. The switch to composition broke that ordering. To fix, stop relying on ordering and just respond to changes as they come. That's what bindables are for.	2023-10-26 15:46:32 +02:00
Dean Herbert	34505b3933	Merge pull request #25185 from bdach/minimum-sample-volume	2023-10-24 22:04:43 +09:00
Bartłomiej Dach	b321d556b6	Enforce minimum gameplay sample volume of 5%	2023-10-20 15:50:13 +02:00
Dean Herbert	906b700aca	Fix fudge not being applied	2023-10-20 20:18:14 +09:00
Dean Herbert	3fb74cb5f9	Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch ... As discussed, it isn't used in stable like this. Was a mistake.	2023-10-20 18:57:14 +09:00
Dean Herbert	686c45e21b	Merge branch 'master' into legacy-tick-test-coverage	2023-10-20 16:41:32 +09:00
Bartłomiej Dach	2c6bf9e346	Remove unused using directive	2023-10-19 20:45:47 +02:00
Dean Herbert	013b5fa916	Move beat snap grid implementation details to ScrollingHitObjectComposer	2023-10-19 23:54:34 +09:00
Dean Herbert	52c2eb93de	Merge branch 'master' into taiko-beat-snap-grid	2023-10-19 23:53:01 +09:00
Bartłomiej Dach	144ef5a87c	Remove DistancedHitObjectComposer	2023-10-19 11:46:30 +02:00
Bartłomiej Dach	dcfd6a0a8a	Remove DistancedHitObjectComposer inheritance from osu! composer	2023-10-19 11:46:30 +02:00
Bartłomiej Dach	3ab083b696	Split IPositionSnapProvider from IDistanceSnapProvider ... In preparation to remove `DistancedHitObjectComposer`, split off `IPositionSnapProvider` from `IDistanceSnapProvider`. `DistancedHitObjectComposer` was not touching `IPositionSnapProvider`'s only interface member at all, it was just forwarding it for subclasses to override to their own leisure.	2023-10-19 11:45:24 +02:00
Bartłomiej Dach	cff69d63a6	Add inline commentary in Mod{Day,Night}core about different speed adjustments	2023-10-18 12:27:16 +02:00
Dean Herbert	9907adc337	Take in IBindables and tidy up multiplier handling	2023-10-18 17:39:13 +09:00
Dean Herbert	161890292f	Move audio adjustment hookup to own method for clarity	2023-10-18 17:38:11 +09:00
Dean Herbert	e56ff33271	Also share ScoreMultiplier implementation	2023-10-18 17:23:50 +09:00
Dean Herbert	43238b0cee	Split common functionality from rate adjust mods into helper class	2023-10-18 17:23:50 +09:00
Dean Herbert	eabfcfbf2a	Merge branch 'master' into pitch_change	2023-10-18 16:33:03 +09:00
Dan Balasescu	939b55020c	Merge branch 'master' into legacy-tick-test-coverage	2023-10-18 15:21:31 +09:00
Bartłomiej Dach	e927267c4d	Merge pull request #25155 from peppy/fix-new-inspections ... Fix various new rider EAP inspections	2023-10-17 17:04:39 +02:00
Dean Herbert	d9fc532a9f	Merge pull request #25152 from bdach/key-binding-deduplication ... Clear pre-existing bindings of same key combination to single action	2023-10-17 17:49:51 +09:00
Dean Herbert	e081fa48a2	Fix various other inspections	2023-10-17 17:48:51 +09:00
Bartłomiej Dach	7abd7fe658	Remove redundant explicit array type specification	2023-10-17 10:26:02 +02:00
Dean Herbert	4885c55ef0	Merge branch 'master' into key-binding-deduplication	2023-10-17 17:17:44 +09:00
Dean Herbert	4381169a3f	Combine selection and input handling logic for beat snap grids across all rulesets	2023-10-17 17:09:42 +09:00
Dean Herbert	d26d4b8b79	Cache IScrollingInfo at a HitObjectComposer level automatically	2023-10-17 16:42:22 +09:00
Dean Herbert	165cd07428	Persist the state of "show speed changes" between editor sessions ... Addresses https://github.com/ppy/osu/discussions/25149.	2023-10-17 16:01:02 +09:00
Dan Balasescu	d2a3f14d5b	Merge branch 'master' into mania-bonus-refactor	2023-10-17 13:28:04 +09:00
Bartłomiej Dach	9c6166ec3d	Add migration to remove duplicate bindings	2023-10-16 22:20:26 +02:00
Bartłomiej Dach	639c96e60c	Prevent ruleset input managers from reading duplicate bindings	2023-10-16 21:02:24 +02:00
Bartłomiej Dach	f2436a5ecb	Remove no longer used scoring difficulty attributes	2023-10-16 12:36:58 +02:00
Bartłomiej Dach	c762241268	Merge branch 'master' into fix-hr-cs-mania-adjustment	2023-10-13 14:08:05 +02:00
Dean Herbert	3787348448	Change Perfect judgement to not give extra score	2023-10-13 16:29:02 +09:00
Dean Herbert	aabed8b6e5	Merge pull request #25093 from Joehuu/mod-switch-tiny-extended-info ... Add extended info support to tiny mod switches	2023-10-13 13:40:24 +09:00
Dean Herbert	3849b11644	Fix "Hard Rock" mod affecting CS/AR in osu!mania ... Closes https://github.com/ppy/osu/issues/25090. Not sure if there are other exceptions we should account for here.	2023-10-12 19:48:47 +09:00
Joseph Madamba	764f641bc9	Add extended info support to tiny mod switches	2023-10-11 12:47:12 -07:00
Bartłomiej Dach	063623b4e6	Merge branch 'master' into remove-hold-note-ticks	2023-10-11 19:47:51 +02:00
Dan Balasescu	a1a46e58fc	Move validation to DHO.ApplyResult()	2023-10-10 21:42:37 +09:00
Dan Balasescu	18d20cad8b	Adjust xmldoc for readability ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2023-10-10 17:04:21 +09:00
Dan Balasescu	04ce223e66	Remove pairings that shouldn't be valid	2023-10-10 10:03:37 +09:00
Dan Balasescu	594bcc2ab5	Apply suggestion to condense method	2023-10-10 09:56:26 +09:00
Bartłomiej Dach	71c4b138fb	Merge branch 'master' into fix-legacy-score-multipliers-2	2023-10-09 10:53:14 +02:00
Dan Balasescu	326702165f	Update HitResult helpers with new judgement	2023-10-09 11:50:17 +09:00
Dan Balasescu	65ac617be4	Actually validate judgements	2023-10-09 10:45:29 +09:00
Dan Balasescu	9415fe4446	Add mania hold note body + combo break judgement	2023-10-09 09:47:00 +09:00
Dean Herbert	cfb18e18c0	Add better commenting around legacy last tick edge case	2023-10-04 13:45:26 +09:00
Dan Balasescu	da2a4681d9	Add method to retrieve legacy score multiplier	2023-10-02 16:52:01 +09:00
Dan Balasescu	b4b7a7ea5e	Add LegacyBeatmapConversionDifficultyInfo abstraction	2023-10-02 16:52:01 +09:00
Dean Herbert	62bcb62842	Document remaining pieces of LastTick and add back legacy prefix for generation flow	2023-09-29 16:58:17 +09:00
Dean Herbert	81485c548c	Move LegacyLastTickOffset specification to generation code and stop passing everywhere	2023-09-29 14:32:29 +09:00
Bartłomiej Dach	8215c4cb0e	Merge branch 'master' into mods-stable-ordering	2023-09-28 18:30:56 +02:00