h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-13 08:32:57 +08:00
Code Issues Releases Wiki Activity

Actually validate judgements

Browse Source
This commit is contained in:
Dan Balasescu 2023-10-09 10:45:29 +09:00
parent 9415fe4446
commit 65ac617be4
No known key found for this signature in database
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Rulesets/Judgements/Judgement.cs
View File

@ -91,10 +91,6 @@ namespace osu.Game.Rulesets.Judgements
}
}
public Judgement()
{
}
/// <summary>
/// The numeric score representation for the maximum achievable result.
/// </summary>

2
osu.Game/Rulesets/Scoring/JudgementProcessor.cs
View File

@ -151,6 +151,8 @@ namespace osu.Game.Rulesets.Scoring
{
var judgement = obj.CreateJudgement();
HitResultExtensions.ValidateHitResultPair(judgement.MaxResult, judgement.MinResult);
var result = CreateResult(obj, judgement);
if (result == null)
throw new InvalidOperationException($"{GetType().ReadableName()} must provide a {nameof(JudgementResult)} through {nameof(CreateResult)}.");