smoogipoo
|
2a1bb2f578
|
Fix selected item potentially changing during gameplay
|
2021-02-17 21:40:21 +09:00 |
|
Dean Herbert
|
403536ef80
|
Fix ModDisplay potentially being operated on before loaded completely
Closes https://github.com/ppy/osu/issues/11810.
|
2021-02-17 21:11:46 +09:00 |
|
Dean Herbert
|
9c298fac4a
|
Merge pull request #11801 from peppy/fix-import-always-importing
Fix intro beatmap always being imported even if already in a good state
|
2021-02-17 20:59:33 +09:00 |
|
smoogipoo
|
8930ff4465
|
Merge branch 'master' into multiplayer-no-playlist-mangling
|
2021-02-17 19:29:01 +09:00 |
|
Dean Herbert
|
c1620ce21b
|
Fix intro beatmap always being imported even if already in a good state
|
2021-02-17 19:19:49 +09:00 |
|
smoogipoo
|
604add04e4
|
Fix song select mods being reset incorrectly
|
2021-02-17 19:06:37 +09:00 |
|
smoogipoo
|
70a995919c
|
Update comments
|
2021-02-17 17:58:24 +09:00 |
|
Dan Balasescu
|
57ede6eb37
|
Merge branch 'master' into fix-multiplayer-mod-propagation-race
|
2021-02-17 16:22:51 +09:00 |
|
Dean Herbert
|
86faa7f465
|
Merge pull request #11798 from smoogipoo/multiplayer-long-types
Use long type where required in multiplayer
|
2021-02-17 15:50:12 +09:00 |
|
Salman Ahmed
|
a845e96b7a
|
Replace Ranks.Global completely with a GlobalRank property
|
2021-02-17 08:52:04 +03:00 |
|
Salman Ahmed
|
d7c91a7c6f
|
Merge branch 'fix-tournament-user-population' into multiplayer-participant-rank
|
2021-02-17 08:42:59 +03:00 |
|
Bartłomiej Dach
|
8f72631c31
|
Fix typo in comment
|
2021-02-16 21:48:19 +01:00 |
|
smoogipoo
|
100097d78f
|
Fix playlist not being handled correctly for non-joined cases
|
2021-02-16 21:32:35 +09:00 |
|
Dan Balasescu
|
bef0e5cfa1
|
Merge pull request #11790 from peppy/playlists-show-remaining-attempts
Display remaining attempts for playlist rooms with room-level attempt limits
|
2021-02-16 21:10:19 +09:00 |
|
Dan Balasescu
|
ffa90c1a23
|
Remove whitespace
|
2021-02-16 20:23:19 +09:00 |
|
Dan Balasescu
|
8e077c2857
|
Merge pull request #11791 from peppy/rooms-container-fix-click-deselection
Add the ability to deselect the currently selected room via clicking away
|
2021-02-16 20:22:24 +09:00 |
|
smoogipoo
|
379393fe10
|
Merge branch 'multiplayer-long-types' into multiplayer-no-playlist-mangling
|
2021-02-16 19:37:55 +09:00 |
|
smoogipoo
|
3e802531d3
|
Use long type where required in multiplayer
|
2021-02-16 19:34:01 +09:00 |
|
smoogipoo
|
e24a5949c5
|
Fix resolve
|
2021-02-16 19:26:51 +09:00 |
|
smoogipoo
|
2a1096a3c8
|
Make BeatmapSelectionControl use the selected item
|
2021-02-16 19:02:16 +09:00 |
|
smoogipoo
|
3ff9e14e35
|
Make StatefulMultiplayerClient control current playlist item
|
2021-02-16 18:56:13 +09:00 |
|
smoogipoo
|
855d24dce7
|
Cache selected item bindable from RoomSubScreen
|
2021-02-16 17:38:33 +09:00 |
|
smoogipoo
|
f25b5147ef
|
Select last playlist item in match subscreen
|
2021-02-16 15:37:45 +09:00 |
|
Dean Herbert
|
fdcb6384cb
|
Add user mod selection to playlists room screen
|
2021-02-16 15:14:56 +09:00 |
|
Dean Herbert
|
97a7572cb8
|
Move UserModSelectOverlay to RoomSubScreen for Playlists consumption
|
2021-02-16 15:14:48 +09:00 |
|
Dean Herbert
|
fff1cb0b35
|
Fix allowed mods not being copied when populating playlist items
|
2021-02-16 15:14:21 +09:00 |
|
Dean Herbert
|
da42c6d282
|
Expose FreeMods from OnlinePlaySongSelect
|
2021-02-16 15:14:21 +09:00 |
|
Dean Herbert
|
52e544aa67
|
Revert "Remove redundant double call to ValueChanged on UserMods change"
This reverts commit 9ed45ce1ca.
|
2021-02-16 14:42:31 +09:00 |
|
Dean Herbert
|
9ed45ce1ca
|
Remove redundant double call to ValueChanged on UserMods change
|
2021-02-16 14:31:00 +09:00 |
|
Dean Herbert
|
0ca747b39f
|
Merge branch 'master' into fix-multiplayer-mod-propagation-race
|
2021-02-16 14:25:27 +09:00 |
|
Dean Herbert
|
31a5cdd8ac
|
Fix current selection not updating visually after creating a new playlist
|
2021-02-16 14:02:21 +09:00 |
|
Dean Herbert
|
e969ca8974
|
Remove unused using statement that rider could not identify
|
2021-02-16 13:52:42 +09:00 |
|
Dean Herbert
|
e82922f8c5
|
Add the ability to deselect the currently selected room via clicking away
Always felt wrong that you couldn't do this until now.
|
2021-02-16 13:44:37 +09:00 |
|
Salman Ahmed
|
0e7f52b5cc
|
Always use JSON property global_rank for global ranks instead
|
2021-02-16 07:33:16 +03:00 |
|
Salman Ahmed
|
5b4999e8af
|
Update user statistics retrieval with API changes
|
2021-02-16 07:33:13 +03:00 |
|
Dean Herbert
|
02417697e9
|
Display remaining attempts for playlist rooms with room-level attempt limits
|
2021-02-16 13:32:14 +09:00 |
|
Salman Ahmed
|
d15ffff9a5
|
Simplifiy user statistics retrieval to one-time on deserialization
|
2021-02-16 04:48:36 +03:00 |
|
Salman Ahmed
|
a1496cd8f3
|
Remove necessity of using CurrentModeRank as a fallback
|
2021-02-16 04:48:36 +03:00 |
|
Salman Ahmed
|
90aa6256d7
|
Merge branch 'master' into multiplayer-participant-rank
|
2021-02-16 04:44:57 +03:00 |
|
Dean Herbert
|
2e646882fa
|
Merge branch 'master' into non-concurrent-sample-playback
|
2021-02-15 21:22:21 +09:00 |
|
Dan Balasescu
|
6bfc7da671
|
Fix sample potentially playing at the wrong frequency
Co-authored-by: Dean Herbert <pe@ppy.sh>
|
2021-02-15 18:10:45 +09:00 |
|
Dean Herbert
|
de52b8a5ba
|
Fix test failures in PerformFromScreen tests
|
2021-02-15 17:14:41 +09:00 |
|
Dean Herbert
|
9cba350337
|
Refactor again to better cover cases where the pause dialog should definitely be shown
|
2021-02-15 15:57:36 +09:00 |
|
Dean Herbert
|
1aea840504
|
Add missing return in early exit scenario (MakeCurrent isn't compatible with the following Exit)
|
2021-02-15 15:03:12 +09:00 |
|
smoogipoo
|
c6ed3efa4a
|
Merge branch 'master' into non-concurrent-sample-playback
|
2021-02-15 14:47:32 +09:00 |
|
Dean Herbert
|
2b69c7b325
|
Fix incorrect order of operation in pause blocking logic
|
2021-02-15 14:24:08 +09:00 |
|
Joehu
|
b28a906197
|
Fix extra mod settings overflowing from screen
|
2021-02-12 10:29:29 -08:00 |
|
Joehu
|
52975c5185
|
Remove hardcoded padding from main content
|
2021-02-12 10:23:33 -08:00 |
|
smoogipoo
|
d3f0c0730d
|
Merge branch 'master' into non-concurrent-sample-playback
|
2021-02-12 17:22:15 +09:00 |
|
Dean Herbert
|
4ab16694d1
|
Fix classic "welcome" intro not looping as expected
|
2021-02-12 16:22:19 +09:00 |
|
Dan Balasescu
|
cb4d119f23
|
Merge pull request #11740 from peppy/editor-fix-slider-samples-new-placement
Fix newly placed sliders in the editor not playing hitsounds
|
2021-02-12 13:31:00 +09:00 |
|
Dean Herbert
|
cd01591dda
|
Consume new debounce logic in carousel header
|
2021-02-12 12:22:35 +09:00 |
|
Dean Herbert
|
e9730d4782
|
Move default sample addition to inside PlacementBlueprint
This isn't actually required to fix the behaviour but it does feel like
a better place to put this logic.
|
2021-02-11 17:16:18 +09:00 |
|
Dean Herbert
|
98c5b0220c
|
Merge pull request #11725 from smoogipoo/freemods-user-settings
Add local user customisation for freemod mod settings
|
2021-02-11 16:02:24 +09:00 |
|
Dean Herbert
|
889a99c49c
|
Use AddOnce everywhere to reduce potential call count
|
2021-02-11 16:00:52 +09:00 |
|
Dean Herbert
|
549e7520c5
|
Move scheduler logic to client callback rather than inside the update method
|
2021-02-11 16:00:52 +09:00 |
|
Dean Herbert
|
21f66a19fd
|
Make server authoritative in which mods the client should be using when gameplay starts
|
2021-02-11 15:55:18 +09:00 |
|
Dean Herbert
|
3344e9f27f
|
Merge pull request #11720 from nekodex/new-buttonsystem-edit-sound
Use unique sample for edit button click (ButtonSystem)
|
2021-02-11 15:10:35 +09:00 |
|
Dean Herbert
|
eaa7b4cb93
|
Rename second usage variable name to match
|
2021-02-11 14:54:50 +09:00 |
|
Dean Herbert
|
2afea88a25
|
Merge branch 'new-carousel-sounds' into update-resources
|
2021-02-11 14:20:20 +09:00 |
|
smoogipoo
|
86682cdb34
|
Add client/room null check
|
2021-02-10 20:16:26 +09:00 |
|
smoogipoo
|
6fff7c39da
|
Ensure tracker is disposed
|
2021-02-10 20:09:45 +09:00 |
|
smoogipoo
|
822c66033f
|
Add local-user freemod configuration
|
2021-02-10 19:56:59 +09:00 |
|
smoogipoo
|
393cd6c74a
|
Add helper class for tracking changes to mod settings
|
2021-02-10 19:40:07 +09:00 |
|
Jamie Taylor
|
996f1098f6
|
Use alternate sample on the downbeat while hovering OsuLogo
|
2021-02-10 18:17:48 +09:00 |
|
Jamie Taylor
|
bc7f4a4f88
|
Use a single sample for CarouselHeader on-hover with randomised pitch instead of multiple samples
|
2021-02-10 17:53:47 +09:00 |
|
Jamie Taylor
|
22995c216d
|
Use unique sample for edit button click (ButtonSystem)
|
2021-02-10 17:23:55 +09:00 |
|
Dan Balasescu
|
92599aa02b
|
Merge branch 'master' into user-beatmap-downloading-states-2
|
2021-02-09 21:06:09 +09:00 |
|
Dean Herbert
|
2c052d70e8
|
Only trigger pause cooldown on pause (not exit)
|
2021-02-09 17:29:18 +09:00 |
|
Dean Herbert
|
cba116ff09
|
Fix incorrect call parameter for quick exit
|
2021-02-09 17:28:57 +09:00 |
|
Dean Herbert
|
61b9539864
|
Fix regression in quick exit logic
|
2021-02-09 17:14:16 +09:00 |
|
Dean Herbert
|
5bd4f74ddf
|
Fix a potential crash when exiting play during the results screen transition
|
2021-02-09 16:24:29 +09:00 |
|
smoogipoo
|
3ce605b5e5
|
Small refactoring to use .Trim() instead
|
2021-02-09 12:00:03 +09:00 |
|
Salman Ahmed
|
d101add159
|
Display user global rank for selected ruleset in participants panel
|
2021-02-08 21:25:50 +03:00 |
|
Joehu
|
414e05affd
|
Fix editor effect attribute tooltip having unnecessary whitespace when only one is enabled
|
2021-02-08 10:16:16 -08:00 |
|
Dean Herbert
|
2cac373365
|
Merge pull request #11706 from smoogipoo/fix-failing-test
Fix failing test
|
2021-02-08 20:57:38 +09:00 |
|
Dean Herbert
|
0dd1b1026c
|
Merge pull request #11495 from smoogipoo/more-accurate-most-common-bpm
Make most common BPM more accurate
|
2021-02-08 20:08:58 +09:00 |
|
Dean Herbert
|
156f5bd5df
|
Add newline between statements
|
2021-02-08 20:05:16 +09:00 |
|
smoogipoo
|
19368f87fb
|
Fix failing test
|
2021-02-08 19:59:07 +09:00 |
|
Dan Balasescu
|
7bc6010d90
|
Merge pull request #11703 from Joehuu/fix-timing-editor-attribute-column
Fix attributes header not being aligned with content in editor timing mode
|
2021-02-08 19:38:59 +09:00 |
|
Dean Herbert
|
5fbed05d04
|
Merge pull request #11551 from smoogipoo/fix-leave-room-race-2
Fix client potentially not leaving a room on exiting multiplayer
|
2021-02-08 19:23:14 +09:00 |
|
smoogipoo
|
a08c51f213
|
Remove duplicate code
|
2021-02-08 19:23:10 +09:00 |
|
smoogipoo
|
6e34e7d750
|
Merge branch 'master' into user-beatmap-downloading-states-2
|
2021-02-08 19:08:53 +09:00 |
|
smoogipoo
|
69ca440ae5
|
Merge branch 'master' into more-accurate-most-common-bpm
|
2021-02-08 18:40:58 +09:00 |
|
Joehu
|
5e7823b289
|
Fix attributes content being zero size and disappearing after being half off-screen
|
2021-02-08 01:37:34 -08:00 |
|
Joehu
|
6b26a18a23
|
Fix attributes header not being aligned with content in editor timing mode
|
2021-02-08 01:34:32 -08:00 |
|
Dean Herbert
|
59dc148a48
|
Merge pull request #11680 from frenzibyte/instant-pause-on-focus-loss
Make pausing on window focus loss instantaneous
|
2021-02-08 17:00:17 +09:00 |
|
Dean Herbert
|
9e0724b138
|
Remove unnecessary double resolution of OsuGame
|
2021-02-08 15:58:41 +09:00 |
|
Dan Balasescu
|
e8f08b09dc
|
Merge pull request #11552 from vmaggioli/zero-spinner-slider
Fix being able to set zero or negative hitobject duration via timeline
|
2021-02-08 14:52:35 +09:00 |
|
Dean Herbert
|
93f1a3c1bf
|
Merge branch 'master' into instant-pause-on-focus-loss
|
2021-02-08 14:31:40 +09:00 |
|
Joehu
|
d74a1437be
|
Fix player loader metadata not being centred
|
2021-02-07 15:14:08 -08:00 |
|
Salman Ahmed
|
d0ca2b99a8
|
Remove unnecessary injected dependency
|
2021-02-06 20:57:01 +03:00 |
|
Salman Ahmed
|
40ddccf0c7
|
Do not consider replays for "pause on focus lost"
Replays are not pausable as can be seen in the `canPause` check.
|
2021-02-06 20:56:08 +03:00 |
|
Salman Ahmed
|
c9db0bf886
|
Call break time update when loaded
|
2021-02-06 20:54:13 +03:00 |
|
Salman Ahmed
|
f29938e15d
|
Make last binding game activity more sensible
|
2021-02-05 20:39:57 +03:00 |
|
Dean Herbert
|
34a1918d03
|
Merge branch 'master' into user-beatmap-downloading-states-2
|
2021-02-06 00:27:55 +09:00 |
|
Vincent Maggioli
|
96652e07cd
|
Merge branch 'master' into zero-spinner-slider
|
2021-02-05 09:40:55 -05:00 |
|
Dean Herbert
|
dd4207cb4e
|
Merge pull request #11661 from peppy/playlist-max-room-attempts
Add support for setting the maximum attempt count for a playlist
|
2021-02-05 23:40:38 +09:00 |
|
vmaggioli
|
5061231e59
|
Switch to beat length
|
2021-02-05 09:39:14 -05:00 |
|
Dean Herbert
|
7f82a06a61
|
Remove no longer used using directive
|
2021-02-05 23:08:31 +09:00 |
|
Dean Herbert
|
0679901e4d
|
Update error handling
|
2021-02-05 22:53:40 +09:00 |
|
Dean Herbert
|
3ca64a1cb2
|
Merge branch 'master' into playlist-max-room-attempts
|
2021-02-05 22:13:13 +09:00 |
|
smoogipoo
|
95ad7ea8f7
|
Fix mods on participant panels flashing when changed
|
2021-02-05 18:44:33 +09:00 |
|
Dean Herbert
|
f338fa114b
|
Merge branch 'master' into user-beatmap-downloading-states-2
|
2021-02-05 18:02:40 +09:00 |
|
Dean Herbert
|
791cbb7f03
|
Don't reset ready state if the map is locally available
|
2021-02-05 17:17:29 +09:00 |
|
Dean Herbert
|
3e750feaa4
|
Subclass LocalPlayerModSelectOverlay to correctly deselect incompatible mods on free mod selection
|
2021-02-05 16:42:35 +09:00 |
|
Salman Ahmed
|
8d18c7e929
|
Fix BreakTracker.IsBreakTime not updated properly on breaks set
Causes a pause from focus lose when playing a beatmap that has a break section at the beginning, due to `IsBreakTime` incorrectly set to `false`
|
2021-02-05 10:28:35 +03:00 |
|
Salman Ahmed
|
e1789c29b1
|
Use Pause() instead of performUserRequestedExit() to avoid unexpected operations
|
2021-02-05 10:28:13 +03:00 |
|
Dean Herbert
|
be91f54349
|
Add back edge case with comment
|
2021-02-05 16:19:45 +09:00 |
|
Dean Herbert
|
9ba5ae3db7
|
Remove lots of unnecessary client side logic
|
2021-02-05 16:17:02 +09:00 |
|
Dean Herbert
|
1b6a052798
|
Refactor logic to suck a bit less
|
2021-02-05 15:46:03 +09:00 |
|
Dean Herbert
|
d1f9aa52a4
|
Inline variable
|
2021-02-05 15:33:48 +09:00 |
|
Dean Herbert
|
9e9e382bee
|
Merge branch 'master' into user-beatmap-downloading-states-2
|
2021-02-05 15:27:17 +09:00 |
|
Dean Herbert
|
2fc3a97f56
|
Merge pull request #11516 from frenzibyte/ready-button-clean-up
Replace ready button beatmap logic with using `MultiplayerBeatmapTracker` instead
|
2021-02-05 15:09:25 +09:00 |
|
Salman Ahmed
|
730e66f0ee
|
Make pausing on window focus lose instant
|
2021-02-05 09:07:59 +03:00 |
|
Dean Herbert
|
de8724b1f6
|
Use AddRangeInternal for simplicity, but disallow ClearInternal for safety
|
2021-02-05 14:39:25 +09:00 |
|
Dean Herbert
|
fc37d8b7df
|
Refactor content redirection logic to be easier to parse
|
2021-02-05 14:25:19 +09:00 |
|
Dean Herbert
|
9258836f10
|
Merge pull request #11641 from smoogipoo/freemods
Add support for optional per-user mods in multiplayer (aka freemod)
|
2021-02-05 13:59:30 +09:00 |
|
Salman Ahmed
|
78ea2d50bb
|
Merge branch 'master' into ready-button-clean-up
|
2021-02-05 07:23:11 +03:00 |
|
smoogipoo
|
df2da5950f
|
Add back vertical spacer
|
2021-02-05 13:09:13 +09:00 |
|
smoogipoo
|
2e85ce5b82
|
Rename UserMods -> Mods for MultiplayerRoomUser
|
2021-02-05 12:40:16 +09:00 |
|
Dan Balasescu
|
a71d6a4c97
|
Merge branch 'master' into multiplayer-beatmap-tracker
|
2021-02-05 12:25:36 +09:00 |
|
smoogipoo
|
a2fdba3e51
|
Rename to OnlinePlayBeatmapAvailabilityTracker
|
2021-02-05 12:24:38 +09:00 |
|
smoogipoo
|
cf5233c6ab
|
Merge branch 'master' into freemods
|
2021-02-05 00:27:14 +09:00 |
|
Dean Herbert
|
f23ca7c7cf
|
Centralise selection animation logic
|
2021-02-04 18:10:55 +09:00 |
|
Dean Herbert
|
daf7ab9422
|
Apply the expected font to the checkbox's label
|
2021-02-04 16:58:15 +09:00 |
|
Dean Herbert
|
48a58e790e
|
Don't specify arbitrary width
|
2021-02-04 16:57:39 +09:00 |
|
Bartłomiej Dach
|
cb87da2bb8
|
Merge branch 'master' into freemod-select-overlay
|
2021-02-03 22:19:35 +01:00 |
|
Dean Herbert
|
b06f4ee124
|
Merge branch 'master' into solo-mod-select-overlay
|
2021-02-03 23:44:08 +09:00 |
|
Dean Herbert
|
17072a5dda
|
Merge pull request #11664 from smoogipoo/modselect-dynamic-isvalid
Make it possible to change IsValidMod in mod selection
|
2021-02-03 23:43:36 +09:00 |
|
Dean Herbert
|
2a52851e68
|
Merge branch 'master' into modselect-dynamic-isvalid
|
2021-02-03 22:11:33 +09:00 |
|
Dean Herbert
|
9d7164816c
|
Add reverse binding for max attempts (currently unused but good for safety)
|
2021-02-03 22:02:40 +09:00 |
|
Dean Herbert
|
3fe190cfbe
|
Show original error message on web exceptions (or is no message is returned)
|
2021-02-03 22:00:16 +09:00 |
|
Dan Balasescu
|
f24a6178bc
|
Merge branch 'master' into ongoing-tracker-fix-more
|
2021-02-03 21:00:45 +09:00 |
|
smoogipoo
|
21d5f842fc
|
Re-layout to reduce movement
|
2021-02-03 14:53:55 +09:00 |
|
Dan Balasescu
|
2a4488c11b
|
Merge branch 'master' into freemods
|
2021-02-03 14:12:39 +09:00 |
|
Bartłomiej Dach
|
fc84ec1313
|
Move anchor specification to central place
|
2021-02-02 22:18:14 +01:00 |
|
Bartłomiej Dach
|
181d2c672b
|
Fix outdated comment
|
2021-02-02 22:05:25 +01:00 |
|
Bartłomiej Dach
|
fe7f4f7222
|
Merge branch 'master' into playlists-item-visual-improvements
|
2021-02-02 21:26:16 +01:00 |
|
Salman Ahmed
|
50d57a3931
|
Move tracker loading into BDL
|
2021-02-02 17:22:48 +03:00 |
|
smoogipoo
|
aeb3ed8bb3
|
Renamespace footer button
|
2021-02-02 21:46:22 +09:00 |
|
smoogipoo
|
6453367a9c
|
Merge branch 'freemod-select-overlay' into freemods
|
2021-02-02 21:43:35 +09:00 |
|
smoogipoo
|
097ce37e96
|
Merge branch 'fix-mod-icon' into freemods
|
2021-02-02 21:37:24 +09:00 |
|
smoogipoo
|
6ff8e8dd37
|
Disable a few mods by default
|
2021-02-02 21:29:08 +09:00 |
|
smoogipoo
|
5a56e2ba4b
|
Fix sound duplication due to checkbox
|
2021-02-02 21:29:00 +09:00 |
|
smoogipoo
|
643c0605d8
|
Implement the freemod selection overlay
|
2021-02-02 21:14:38 +09:00 |
|
smoogipoo
|
e58ece9e10
|
Make ModSelectOverlay abstract
|
2021-02-02 21:06:04 +09:00 |
|
smoogipoo
|
10ceddf3ff
|
Make IsValidMod adjustable
|
2021-02-02 20:47:50 +09:00 |
|
smoogipoo
|
a2e3b1c0e4
|
Move Mods reset code to OnlinePlaySongSelect
|
2021-02-02 19:02:39 +09:00 |
|
Dean Herbert
|
fc3adaf612
|
Show maximum attempt count in room display (when not unlimited)
|
2021-02-02 18:45:05 +09:00 |
|