177 Commits

• Adjust combo accounting in score processor to be order-agnostic

  Closes https://github.com/ppy/osu/issues/21732.
  
  While the problem of multiple judgements in one frame and ordering of
  `RevertResult()` calls as described in the issue is a real one, this
  commit is a bit of a sidestep of the entire issue.
  
  The idea here that while *snapshots* of instantaneous combo values are
  susceptible to such ordering foibles on revert, *deltas* are not - and
  such, when deltas are using to update the combo counts on revert,
  ordering stops mattering so much.

  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  237de1ef72
• Rename GameplaySkinComponentLookup -> SkinComponentLookup
  Dean Herbert · 2024-08-22 18:46:03 +09:00
  36b4013fa6
• Remove legacy non-pooled pathway to DrawableJudgement
  Dean Herbert · 2024-08-13 21:03:00 +09:00
  2221c4891f
• Add log output when judgements aren't being pooled
  Dean Herbert · 2024-08-13 20:57:23 +09:00
  bb0c9e2497
• Never call prepareDrawables from unsafe context

  I can't mentally figure out *what* is causing the issue here, but in the
  case where `prepareDrawables` is called from
  `JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario),
  things go very wrong.
  
  I think a smell test is enough for anyone to agree that the flow was
  very bad. Removing this call doesn't seem to cause any issues.
  
  `runAnimation` should always be called in `PrepareForUse` (both pooled
  and non-pooled scenarios) so things should still always be in a correct
  state.
  
  Closes #29398.

  Dean Herbert · 2024-08-13 20:57:20 +09:00
  d74ac57092
• Don't rely on single-use properties
  Dan Balasescu · 2024-07-18 19:07:02 +09:00
  a7e110f669
• Fix judgement animation getting cut early
  Dan Balasescu · 2024-07-16 17:32:59 +09:00
  bd4f3e28d9
• Use hopefully safer implementation of anchoring judgements to objects
  Bartłomiej Dach · 2024-05-29 11:11:43 +02:00
  a6c776dac8
• Merge pull request #26694 from chandler14362/hit-object-result-allocations

  Avoid closure allocations when applying hit object results

  Dan Balasescu · 2024-02-06 17:49:26 +09:00
  c18cd65081
• Merge branch 'master' into hit-object-result-allocations
  Bartłomiej Dach · 2024-02-05 13:24:10 +01:00
  39fe078984
• Refactor result application around again to remove requirement for fields

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-02-05 13:21:01 +01:00
  efe6bb25b1
• Adjust default min result of SliderTailHit, remove override
  Dan Balasescu · 2024-01-31 18:01:29 +09:00
  0642a0ee11
• Revert "Merge pull request #26870 from smoogipoo/adjust-default-minresult"

  This reverts commit 1acff746ee, reversing
  changes made to 696ecda398.

  Dean Herbert · 2024-01-31 17:51:38 +09:00
  fbc923b47e
• Adjust default min result of SliderTailHit, remove override
  Dan Balasescu · 2024-01-31 16:12:05 +09:00
  9b1bbe5f48
• Update triangles skin judgment display
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  107b37494e
• Rename JudgementPiece to TextJudgementPiece
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  dda96d7106
• Fix non-miss drawable judgements fading out instantly on triangles skin

  `else if` proves to be insidious once again.

  Bartłomiej Dach · 2024-01-22 14:23:46 +01:00
  17d05b0fdf
• Adjust slider tick / end miss animations to be less busy
  Dean Herbert · 2024-01-22 18:48:48 +09:00
  47e9846315
• Add helper method to bypass judgement woes
  Dean Herbert · 2024-01-16 15:52:05 +09:00
  57a6025a2c
• Add HitResult.SliderTailHit
  Dan Balasescu · 2023-12-30 10:38:47 +09:00
  807443b648
• Update argon and triangles to match display style
  Dean Herbert · 2023-12-25 17:37:28 +09:00
  8e6ea2dd9b
• Relocate HitResult numeric score to ScoreProcessor
  Dan Balasescu · 2023-12-21 14:52:31 +09:00
  4e3b994142
• Add support for showing tick misses
  Dean Herbert · 2023-12-20 20:23:19 +09:00
  9b383e3276
• Allow GameplayRate to be nullable and assert before use
  Poyo · 2023-11-15 17:00:35 -08:00
  a73c870712
• Calculate unstable rate using rate-adjusted offsets
  Poyo · 2023-11-10 19:57:44 -08:00
  064857c40b
• Change Perfect judgement to not give extra score
  Dean Herbert · 2023-10-13 16:29:02 +09:00
  3787348448
• Adjust xmldoc for readability

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2023-10-10 17:04:21 +09:00
  18d20cad8b
• Remove pairings that shouldn't be valid
  Dan Balasescu · 2023-10-10 10:03:37 +09:00
  04ce223e66
• Actually validate judgements
  Dan Balasescu · 2023-10-09 10:45:29 +09:00
  65ac617be4
• Add mania hold note body + combo break judgement
  Dan Balasescu · 2023-10-09 09:47:00 +09:00
  9415fe4446
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Fix TestSceneScoring and incorrect combo calculations
  Dan Balasescu · 2023-05-19 14:09:19 +09:00
  7cbf48ffcf
• Store RawTime in JudgementResult
  ekrctb · 2023-02-09 17:15:37 +09:00
  258de3b2d8
• Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield
  ekrctb · 2023-02-09 16:47:58 +09:00
  5f0636c330
• Remove JudgementResultEntry

  It is not needed anymore as TimeAbsolute is stored raw.

  ekrctb · 2023-01-27 19:35:44 +09:00
  27578c48f5
• Store Result.TimeAbsolute separately from offset

  Calculating from TimeOffset is bad because it loses precision.
  The result time won't change anymore
  even If `HitObject.GetEndTime()` changes later.

  ekrctb · 2023-01-24 15:35:06 +09:00
  efef97d5be
• Remove unused code
  ekrctb · 2023-01-24 14:15:17 +09:00
  e66e43e17c
• Move judgement result revert logic to Playfield

  Previously, some judgement results were not reverted
  when the source DHO is not alive (e.g. frames skipped in editor).
  Now, all results are reverted in the exact reverse order.

  ekrctb · 2023-01-19 19:57:13 +09:00
  812a4b412a
• Fix judgement text never being added to hierarchy
  Bartłomiej Dach · 2022-12-24 09:37:40 +01:00
  80de5dac66
• Remove unused resolved member
  Bartłomiej Dach · 2022-12-24 09:34:30 +01:00
  f973befcd4
• Move judgement text creation to base class and tidy things up
  Dean Herbert · 2022-12-24 12:22:36 +08:00
  5e9fb1063a
• Combine base class for JudgementPiece
  Dean Herbert · 2022-12-24 03:32:13 +08:00
  727ac00f6d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Merge branch 'master' into taiko-judgement-fixes
  Dan Balasescu · 2022-11-11 15:48:33 +09:00
  5bdbf56f43
• Add "Component" prefix to lookup naming
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  1aa0e40f2f
• Rename ISkinComponent to ISkinLookup
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  c908969d9b
• Apply nullability to skinning support classes
  Dean Herbert · 2022-11-09 13:59:13 +09:00
  bf26dbffc2
• Remove unnecessary centering logic in DrawableJudgement
  Dean Herbert · 2022-11-07 17:19:32 +09:00
  2b72c3833b
• Update usages of RemoveInternal
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  105aa01e7d