mirror of
https://github.com/ppy/osu.git
synced 2024-12-17 10:32:54 +08:00
d74ac57092
I can't mentally figure out *what* is causing the issue here, but in the case where `prepareDrawables` is called from `JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario), things go very wrong. I think a smell test is enough for anyone to agree that the flow was very bad. Removing this call doesn't seem to cause any issues. `runAnimation` should always be called in `PrepareForUse` (both pooled and non-pooled scenarios) so things should still always be in a correct state. Closes #29398. |
||
---|---|---|
.. | ||
DefaultJudgementPiece.cs | ||
DrawableJudgement.cs | ||
IAnimatableJudgement.cs | ||
IgnoreJudgement.cs | ||
Judgement.cs | ||
JudgementResult.cs | ||
TextJudgementPiece.cs |