1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 10:32:54 +08:00
osu-lazer/osu.Game/Rulesets/Judgements
Dean Herbert d74ac57092
Never call prepareDrawables from unsafe context
I can't mentally figure out *what* is causing the issue here, but in the
case where `prepareDrawables` is called from
`JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario),
things go very wrong.

I think a smell test is enough for anyone to agree that the flow was
very bad. Removing this call doesn't seem to cause any issues.

`runAnimation` should always be called in `PrepareForUse` (both pooled
and non-pooled scenarios) so things should still always be in a correct
state.

Closes #29398.
2024-08-13 20:57:20 +09:00
..
DefaultJudgementPiece.cs Update triangles skin judgment display 2024-01-25 19:31:57 +09:00
DrawableJudgement.cs Never call prepareDrawables from unsafe context 2024-08-13 20:57:20 +09:00
IAnimatableJudgement.cs Apply nullability to skinning support classes 2022-11-09 13:59:13 +09:00
IgnoreJudgement.cs Automated pass 2023-06-24 01:00:03 +09:00
Judgement.cs Adjust default min result of SliderTailHit, remove override 2024-01-31 18:01:29 +09:00
JudgementResult.cs Refactor result application around again to remove requirement for fields 2024-02-05 13:21:01 +01:00
TextJudgementPiece.cs Rename JudgementPiece to TextJudgementPiece 2024-01-25 19:31:57 +09:00