1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-13 22:07:25 +08:00
Commit Graph

7723 Commits

Author SHA1 Message Date
mk56-spn
b22363ed8c Fix JudgementCounterDisplay.cs max judgement always showing upon changing display mode 2023-01-19 10:31:02 +01:00
Dean Herbert
56ce8504ae Merge branch 'master' into comment-reply 2023-01-19 16:01:47 +09:00
Dean Herbert
db8084570d
Merge pull request #22285 from bdach/segmented-graph-tint
Apply draw colour to segmented graph
2023-01-19 13:36:19 +09:00
Dean Herbert
e58abf7d1a
Merge pull request #22284 from bdach/judgement-counter-broken
Fix "show max judgement" setting not applying initially on judgement counter display
2023-01-19 09:09:06 +09:00
Bartłomiej Dach
b62ff8d644
Merge branch 'master' into skin/argon-song-progress-cleaner 2023-01-18 23:52:12 +01:00
Bartłomiej Dach
e09b768a99
Add test steps demonstrating failure 2023-01-18 23:07:40 +01:00
Bartłomiej Dach
7299d227d1
Add failing test case 2023-01-18 21:42:22 +01:00
Bartłomiej Dach
06212bca51
Restructure test scene to demonstrate failure 2023-01-18 21:41:00 +01:00
ansel
7f4d8bdcaa Add test 2023-01-18 21:27:42 +03:00
Bartłomiej Dach
4a6f6300c5
Merge branch 'master' into fix-carousel-sort-change-after-play 2023-01-18 17:15:20 +01:00
StanR
8ae82484b5 Usings 2023-01-18 16:38:58 +03:00
StanR
24ed84aad0 Add tiered level badge colouring 2023-01-18 16:25:11 +03:00
Dean Herbert
3b27774561 Remove OnlineID sort consideration 2023-01-18 19:21:02 +09:00
Dean Herbert
43a037c189
Merge pull request #21620 from mk56-spn/JudgementCounter
Add a judgement counter to skin components
2023-01-18 18:43:49 +09:00
Dean Herbert
d4f2cd244d Fix broken test step 2023-01-18 18:12:40 +09:00
Dean Herbert
42e9b2b48c Tidy up clock logic in all SongProgress classes 2023-01-18 16:29:42 +09:00
Dean Herbert
5ead85f461 Limit catch-up speed in test to emulate gameplay 2023-01-18 16:13:43 +09:00
Dean Herbert
8030194cd5 Use actual beatmap's hitobjects in test to better display density 2023-01-18 16:11:46 +09:00
Dean Herbert
bfb75730a9 Prefix subclasses of DefaultSongProgress with Default 2023-01-18 15:45:16 +09:00
Dean Herbert
04c0a5d728 Update TestSceneSongProgress to properly work with new implementation 2023-01-18 15:44:19 +09:00
Dean Herbert
5a272b4bd6
Merge branch 'master' into skin/argon-song-progress-cleaner 2023-01-18 15:25:02 +09:00
Dean Herbert
e8770b84cd Remove no longer necessary interface type 2023-01-18 15:23:55 +09:00
Dean Herbert
f9dd3f6def Switch test to specifically target the argon verison of the progress bar 2023-01-18 15:23:55 +09:00
Dean Herbert
5429979049 Combine common code into SongProgress base class 2023-01-18 15:23:55 +09:00
Dean Herbert
45c5bd8403 Simplify HUD test to not require casting to specific ProgressBar type 2023-01-18 14:37:09 +09:00
Bartłomiej Dach
f5459909f9
Merge branch 'master' into comment-editor-3 2023-01-17 21:31:08 +01:00
Bartłomiej Dach
6f11fbdeed
Merge branch 'master' into fix-carousel-sort-change-after-play 2023-01-17 20:46:06 +01:00
tsrk
66441d4421
test: remove test for ArgonSongProgressGraph 2023-01-17 13:16:11 +00:00
Dean Herbert
181473c5fc Rename flow to better match its purpose 2023-01-17 18:28:08 +09:00
Dean Herbert
35ad66eef9 Give flow container a type to avoid locally casting in every location 2023-01-17 18:27:33 +09:00
Dean Herbert
09c7ab3af6 Rename exposed settings to make more sense 2023-01-17 18:27:15 +09:00
Dean Herbert
f923dc5009 Use framework Direction instead of local enum
It should be stable enough to use.
2023-01-17 18:27:15 +09:00
Dean Herbert
65bd2e74fd Merge branch 'master' into skin/argon-song-progress-cleaner 2023-01-17 18:00:42 +09:00
MK56
a55ce9b586
Merge branch 'master' into JudgementCounter 2023-01-17 09:55:45 +01:00
Dean Herbert
53e7873f6c
Merge branch 'master' into fix-pause-gameplay-action-not-closing 2023-01-17 17:41:16 +09:00
Dean Herbert
a1152fa0db
Merge pull request #22147 from Feodor0090/forbid-negative-snap
Forbid negative time snap in editor
2023-01-17 17:35:45 +09:00
Dean Herbert
92fc439f82 Add test coverage of carousel sort expectations
This covers the fail case of removing and adding items (see
https://github.com/ppy/osu/issues/21926) but also covers the proposed
forward implementation, which now considers `DateAdded` and `OnlineID`.
2023-01-17 16:40:25 +09:00
Dean Herbert
f74bc4ff7c
Merge pull request #22246 from frenzibyte/mark-tests-flaky
Mark remaining frequently-failing intermittent tests with `FlakyTest` attribute
2023-01-17 15:57:58 +09:00
Dean Herbert
776b6fa2e1
Merge pull request #22203 from bdach/fix-new-diff-creation-fail
Fix difficulty creation flow failing for some ruleset combinations
2023-01-17 14:08:34 +09:00
Dean Herbert
1f47def3c4
Merge branch 'master' into skin-editor-loc 2023-01-17 11:53:08 +09:00
Dean Herbert
4cf448ec11 Use ToString() for test instead of linq skip 2023-01-17 11:51:17 +09:00
ansel
0ec608ec5d Select button using its index in test 2023-01-16 22:47:14 +03:00
Bartłomiej Dach
bf58fe21ce
Merge branch 'master' into beatmap-set-converted-beatmaps 2023-01-16 20:46:41 +01:00
Salman Ahmed
f63de55a20 Mark ready-button-pressing multiplayer tests with FlakyTest attribute 2023-01-16 22:34:32 +03:00
Salman Ahmed
1a776eb546 Mark item-mutating queue mode tests with FlakyTest attribute 2023-01-16 22:34:04 +03:00
Salman Ahmed
1552726150 Fix intermittent failure in beatmap options state test 2023-01-16 14:06:02 +03:00
Joseph Madamba
b733f46c6f Apply NRT to BeatmapPicker 2023-01-15 15:09:25 -08:00
Salman Ahmed
13c1b8f5a4 Fix intermittent failure in tests with restarting player instances 2023-01-15 16:06:06 +03:00
ansel
58406cae19 Make test wait for comment loading 2023-01-14 23:42:10 +03:00
ansel
88c3eef8e1 Add test case with no existing comments 2023-01-14 20:59:13 +03:00
Dean Herbert
efe6dae672
Merge pull request #22200 from bdach/user-profile/update-design-basics
Update user profile appearance to closer match web
2023-01-15 02:50:11 +09:00
Bartłomiej Dach
3102044d00
Add failing test for new difficulty creation 2023-01-14 18:46:14 +01:00
Dean Herbert
4906f37109
Merge pull request #22181 from frenzibyte/attempt-fix-song-select-test-failure
Fix intermittent failure in beatmap carousel tests
2023-01-15 02:35:36 +09:00
Bartłomiej Dach
67a3ea2c59
Fix wrong date colour of kudosu history items 2023-01-14 17:50:18 +01:00
Bartłomiej Dach
3fa81a52b4
Add other profile sections to test scene 2023-01-14 16:59:47 +01:00
Bartłomiej Dach
5e1ea8b34f
Merge branch 'master' into move-overlay-ruleset-selectors 2023-01-14 15:22:14 +01:00
ansel
e9995410e8 Merge branch 'master' into comment-editor-3 2023-01-14 02:32:06 +03:00
Bartłomiej Dach
ab3d39a940
Merge branch 'master' into comment-editor-1 2023-01-13 22:41:41 +01:00
Joseph Madamba
5750d82c0a Move overlay ruleset selectors to tab control 2023-01-13 12:50:35 -08:00
Salman Ahmed
b681a0d47f Fix intermittent failure in score submission tests 2023-01-13 22:57:40 +03:00
Salman Ahmed
e6ff262521 Fix potential nullref in certain beatmap carousel tests 2023-01-13 19:42:09 +03:00
Dean Herbert
d2309feec2
Merge branch 'master' into skin/argon-song-progress-cleaner 2023-01-12 19:49:27 +09:00
Dean Herbert
123c477e00
Merge branch 'master' into ui/segmented-graph 2023-01-12 19:02:49 +09:00
tsrk
bb2ece5c71
refactor(SegmentedGraph): adjust tierCount based on passed Colours 2023-01-12 10:57:12 +01:00
tsrk
7cbc03dce6
refactor(SegmentedGraph): use (get/set)ters to expose TierColour 2023-01-12 10:13:16 +01:00
Dean Herbert
7cf58190a9
Merge pull request #22006 from bdach/user-profile/ruleset-switching
Add ruleset switching to user profile overlay
2023-01-12 13:54:13 +09:00
Joseph Madamba
f8fade7967 Add failing beatmap set lookup type test 2023-01-11 19:05:37 -08:00
tsrk
5694487a7b
fix(SegmentedGraph): update graphNeedsUpdate variable during Update() loop 2023-01-12 02:36:35 +01:00
ansel
e8029e6390 Fix unrelated tests 2023-01-12 03:39:27 +03:00
Bartłomiej Dach
52eabbf224
Merge branch 'master' into user-profile/ruleset-switching 2023-01-11 19:11:40 +01:00
tsrk
442b2238b8
test(SegmentedGraph): add concrete application test with beatmap density 2023-01-11 14:37:57 +01:00
tsrk
845cdb3097
test: add visual tests for SegmentedGraph class 2023-01-11 14:03:49 +01:00
MK56
1597bcbb6f
Merge branch 'master' into JudgementCounter 2023-01-11 11:04:37 +01:00
Dean Herbert
08ca62205a
Merge pull request #22123 from stanriders/group-badges
Implement user group badges
2023-01-11 18:42:50 +09:00
Dean Herbert
b1a13286a3 Remove some redundancies 2023-01-11 16:50:37 +09:00
Dean Herbert
eb398de1a6
Merge pull request #22114 from frenzibyte/fix-overlay-not-blocking-scroll
Fix game overlays not blocking scroll properly
2023-01-11 16:30:44 +09:00
Dean Herbert
5a5ea2c54a
Merge pull request #22005 from bdach/user-profile/decouple-from-api-user
Decouple user profile overlay from `APIUser` model
2023-01-11 16:27:00 +09:00
StanR
5441c02a1a Implement user group badges 2023-01-11 07:11:38 +03:00
Joseph Madamba
974a8d520c Add basic toggle pause tests 2023-01-10 15:51:22 -08:00
Joseph Madamba
404d34f592 Refactor pause test to actually use quick exit action keybinding 2023-01-10 15:43:50 -08:00
Joseph Madamba
51dbe2c3a3 Refactor pause test to actually use back action keybinding 2023-01-10 15:43:06 -08:00
Bartłomiej Dach
62e12277d8
Rename things yet again 2023-01-10 19:30:01 +01:00
Bartłomiej Dach
502478614a
Merge branch 'master' into user-profile/decouple-from-api-user 2023-01-10 19:13:33 +01:00
Salman Ahmed
9633a3f58f Add failing test coverage 2023-01-10 21:01:06 +03:00
Bartłomiej Dach
1eaabb5ca8
Merge branch 'master' into carousel_nullability_disabling_removal 2023-01-10 18:39:42 +01:00
tsrk
eac8e9f6fb
test: make test not actually test anything 2023-01-09 22:21:34 +01:00
tsrk
48deef4056
test: adapt and create tests to cover new components 2023-01-09 22:07:18 +01:00
tsrk
0f1fe1d683
refactor(hud/gameplay/SongProgress): Add interface to designate SongProgressBars 2023-01-09 21:48:53 +01:00
ansel
23e4cfb469 Show spinner next to buttons and get rid of EditorCommitButton 2023-01-09 23:37:36 +03:00
mk56-spn
69260ca3c3 remove unnecessary usages of nullable forgiveness, add asserts for debugging 2023-01-09 18:36:55 +01:00
Bartłomiej Dach
0026861bd4
Merge branch 'master' into user-profile/decouple-from-api-user 2023-01-09 17:47:59 +01:00
Bartłomiej Dach
4dec3cae57
Rename UserProfileData-related symbols 2023-01-09 17:46:08 +01:00
Bartłomiej Dach
fdf0d4bd62
Rename UserProfile{ -> Data} 2023-01-09 17:37:28 +01:00
Dean Herbert
54b2fe9df3
Merge branch 'master' into fix-op-non-current-onexiting 2023-01-09 19:12:42 +09:00
Dean Herbert
13b00928c8 Rename loading spinner bool to reflect that it has a setter 2023-01-09 15:52:18 +09:00
Dean Herbert
d2f4ffcc5b Merge branch 'master' into comment-editor-1 2023-01-09 15:52:17 +09:00
mk56-spn
a32c4a64e7 Fix errors in test 2023-01-08 19:18:28 +01:00
mk56-spn
47fb467012 Remove nullable disabling in carousel 2023-01-08 19:02:48 +01:00
Joseph Madamba
93a57b6871 Separate pausing test instead of using test cases 2023-01-07 11:30:02 -08:00
Salman Ahmed
a65466bdac
Merge branch 'master' into previewTime 2023-01-07 15:07:09 +03:00
Salman Ahmed
abca13eb6c Rewrite visualisation piece to bind once and without potential event leak 2023-01-07 14:40:15 +03:00
ansel
4baa267095 warnings 2023-01-07 04:26:52 +03:00
ansel
49ce50878d Add simple test 2023-01-07 04:15:53 +03:00
ansel
387326db0d Make commit action abstract 2023-01-06 22:51:57 +03:00
Dean Herbert
0ab1418aa6
Merge pull request #22034 from frenzibyte/fix-toolbox-group-animation
Fix settings toolbox group not animating on expansion
2023-01-06 19:59:31 +08:00
Dean Herbert
464f251c0c
Merge branch 'master' into beatmap-set-link-genre-language 2023-01-06 17:09:06 +08:00
Salman Ahmed
86b1164e28 Add visual test case 2023-01-05 14:41:26 +03:00
Joseph Madamba
49b0984079 Add failing playlist no selection after deleted test 2023-01-03 11:10:01 -08:00
Bartłomiej Dach
a124c967df
Add proper offline & loading state handling to user profile overlay 2023-01-02 17:23:09 +01:00
Bartłomiej Dach
a2e726502f
Add ruleset selector to profile overlay 2023-01-02 17:23:04 +01:00
Bartłomiej Dach
7683ab68b0
Use UserProfile in profile ruleset selector 2023-01-02 17:23:01 +01:00
Bartłomiej Dach
1722f3a125
Add ruleset to UserProfile 2023-01-02 17:22:55 +01:00
Bartłomiej Dach
ae3a211da7
Rewrite user profile overlay test to not depend on online API 2023-01-02 17:21:12 +01:00
Bartłomiej Dach
d7294ac3e6
Substitute APIUser for UserProfile in overlay 2023-01-02 17:21:09 +01:00
Joseph Madamba
83b8d8ad8c Add failing replay player mouse middle pause test 2023-01-01 18:07:16 -08:00
Bartłomiej Dach
73f14bd14f
Enable NRT in user profile overlay test scenes 2023-01-01 23:49:15 +01:00
Bartłomiej Dach
656bf12b3d
Add all possible timeline elements to test for demonstrative purposes 2023-01-01 19:42:46 +01:00
Bartłomiej Dach
a82f1a6abd
Adjust method naming and copy 2023-01-01 18:50:47 +01:00
Bartłomiej Dach
0e59b55a12
Merge branch 'master' into previewTime 2023-01-01 18:38:19 +01:00
Bartłomiej Dach
2698d58c46
Merge branch 'master' into remember-chat-textbox-per-channel 2023-01-01 17:29:38 +01:00
Bartłomiej Dach
f7febdac5e
Add failing assertion 2022-12-29 23:03:50 +01:00
Bartłomiej Dach
cacc23204d
Add failing test coverage 2022-12-29 13:17:39 +01:00
Joseph Madamba
ffd9359f4a Add tests for chat text box saving / syncing 2022-12-28 15:14:29 -08:00
Feodor0090
930cd15649
Merge branch 'master' into comment-editor-1 2022-12-28 17:46:01 +05:00
Bartłomiej Dach
3c0b8af8f1
Allow unsubscribing from solo statistics updates
This is more of a safety item. To avoid potential duplicate key in
dictionary errors (and also avoid being slightly memory-leaky), allow
`SoloStatisticsWatcher` consumers to dispose of the subscriptions they
take out.
2022-12-28 08:07:48 +01:00
Bartłomiej Dach
e2703bba18
Fix invalid data in test scene 2022-12-27 19:49:08 +01:00
Joseph Madamba
973fd90af2 Fix parameters with the same default value inspection 2022-12-25 16:15:02 -08:00
Joseph Madamba
5232588a1f Use PerformFromScreen to exit sub screens instead 2022-12-24 20:04:45 -08:00
Joseph Madamba
00ed5d6f92 Merge remote-tracking branch 'upstream/master' into fix-op-non-current-onexiting 2022-12-24 14:01:11 -08:00
Dean Herbert
8c7814aaf0 Fix weird using statement 2022-12-24 21:48:04 +08:00
Bartłomiej Dach
cf0b3ec879
Merge branch 'master' into score-stats-display 2022-12-24 14:32:08 +01:00
Dean Herbert
209d44746a
Merge pull request #21762 from bdach/score-stats-updates
Add solo statistics watcher component to deliver incremental global user statistics updates
2022-12-24 21:30:34 +08:00
Bartłomiej Dach
83a50816b6
Remove unused constructor param 2022-12-24 10:44:38 +01:00
Bartłomiej Dach
4e5109a649
Use plain bindable flow instead of binding to watcher directly 2022-12-24 10:27:28 +01:00
Bartłomiej Dach
c7f248e13c
Implement overall ranking display for solo results screen 2022-12-24 00:30:38 +01:00
Bartłomiej Dach
3dfbb47b01
Add test coverage for wrong error message 2022-12-23 16:43:59 +01:00
Bartłomiej Dach
137a32ade6
Remove unused using directive 2022-12-23 16:39:35 +01:00
Dean Herbert
4a69cb4aae Add test coverage of wiki cancellation not causing error 2022-12-23 21:22:47 +08:00
Salman Ahmed
a665013626 Add failing test case 2022-12-23 00:56:38 +03:00
Bartłomiej Dach
27afeb9e30
Add test coverage of merging ignored score updates 2022-12-22 19:59:41 +01:00
Bartłomiej Dach
48dc2332fd
Refactor test to be easier to work with 2022-12-22 19:59:35 +01:00
Bartłomiej Dach
722cf48614
Add test coverage for statistics watcher 2022-12-22 19:59:10 +01:00
Joseph Madamba
e1e6d76f30 Check id for genre/language instead and fallback to name if not defined 2022-12-21 11:02:04 -08:00
Bartłomiej Dach
64a45aa0e0
Merge branch 'master' into wiki-heading-id-attributes 2022-12-20 06:34:47 +01:00
Bartłomiej Dach
30b9f5d92e
Add test coverage for correct operation of flag extension 2022-12-19 21:32:41 +01:00
Bartłomiej Dach
12aa2e96db
Add test case covering failure 2022-12-19 21:29:10 +01:00
Bartłomiej Dach
5fb2a83f12
Add failing test case for footnote link navigation 2022-12-19 19:34:45 +01:00
Bartłomiej Dach
3c1a46605e
Set up test for two-way navigation testing 2022-12-19 19:34:42 +01:00
Bartłomiej Dach
6e55f2f779
Add test for markdown footnotes 2022-12-19 19:17:05 +01:00
MK56
878e2f24c4
Merge branch 'master' into footer_V2_implementation 2022-12-19 13:19:23 +01:00