13530 Commits

Author	SHA1	Message	Date
Joseph Madamba	6c0bd13308	Add xmldoc to newly exposed methods	2023-09-04 00:53:14 -07:00
Joseph Madamba	5abf271b56	Implement beatmap options popover	2023-09-04 00:53:09 -07:00
Hồ Nguyên Minh	d5a89c4c45	Fix formatting	2023-09-04 13:32:42 +07:00
Hồ Nguyên Minh	b17a55d6a8	Add length check for slider velocity	2023-09-04 10:43:05 +07:00
Magnus-Cosmos	d674856e29	Use existing localisations in BeatmapInfoWedge	2023-09-02 22:49:29 -04:00
Givikap120	5e5fe84a88	Update AdvancedStats.cs	2023-09-03 02:19:02 +03:00
Givikap120	0779cd8f4f	minor design fixes	2023-09-03 02:17:04 +03:00
Givikap120	2e2d4d0d60	Merge branch 'map_info_on_mod_settings' of https://github.com/Givikap120/osu into map_info_on_mod_settings	2023-09-03 02:09:18 +03:00
Givikap120	b0398b6259	functionality is done	2023-09-03 02:09:01 +03:00
Bartłomiej Dach	76954f6e91	Merge branch 'master' into skin-editor-selection-negative-scaling	2023-09-01 21:30:24 +02:00
Wleter	fc4069f794	let SelectionBox perform flip with scale handles	2023-09-01 13:01:51 +02:00
Dean Herbert	0f5eff1230	Merge branch 'master' into mania-edit-disable-sv	2023-09-01 19:08:48 +09:00
Dean Herbert	96a5443813	Merge branch 'master' into carousel-difficulty-split	2023-08-30 14:24:30 +09:00
Dean Herbert	cbd4b91feb	Merge pull request #24678 from Nabile-Rahmani/bot-scores ... Fix and use score user's IsBot property in results screen animation	2023-08-30 14:00:35 +09:00
Nabile Rahmani	b658b0e346	Fix and use score user's IsBot property in results screen animation ... While a mod-created replay did flag itself as performed by a bot, the extension method converting it into a Score did not copy all the generated properties. As noted, it might be preferable for ModCreatedUser to inherit APIUser and forward it as-is to the Score instance. Related to PR #24675	2023-08-29 23:28:50 +02:00
Wleter	14ee0ee395	Merge branch 'ppy:master' into skin-editor-selection-negative-scaling	2023-08-29 17:30:55 +02:00
Wleter	d56ab0fe9a	change names	2023-08-29 17:25:52 +02:00
Givikap120	f8adc911cd	Merge branch 'ppy:master' into map_info_on_mod_settings	2023-08-28 23:17:04 +03:00
Givikap120	50235cc245	somewhat working prototype	2023-08-28 23:16:33 +03:00
Wleter	07e126241d	working negative scaling	2023-08-28 16:41:55 +02:00
Bartłomiej Dach	97d1c6e9fc	Merge branch 'master' into carousel-difficulty-split	2023-08-28 11:07:43 +02:00
Bartłomiej Dach	b9795eb3d4	Fix changes to beatmap sets being undone on switching sort mode	2023-08-28 11:02:22 +02:00
Bartłomiej Dach	80ec18d117	Fix incorrect selection restore code in split case ... The fallback to "any of the added sets" needs to be applied after they've all been added, rather than with every added one. Otherwise, in flows that expect a particular difficulty to be selected in the end (such as exiting from editor) would end up switching away from the edited beatmap.	2023-08-28 10:06:26 +02:00
Bartłomiej Dach	0af6cc1394	Fix online ID not being propagated in split difficulty mode ... Would result in failures to re-download the beatmap in update flows, for instance.	2023-08-28 10:05:59 +02:00
Givikap120	8a1fc7c340	Basic stuff (not working for now)	2023-08-26 01:20:41 +03:00
Dean Herbert	10b1450138	Rename remove method to better explain return type being IEnumerable	2023-08-25 18:10:54 +09:00
Dean Herbert	89eeff515b	Reduce complexity of selection restore	2023-08-25 00:52:54 +09:00
Dean Herbert	9e94f38091	Fix typo in local variable	2023-08-24 18:33:15 +09:00
Dean Herbert	081fb308e1	Merge branch 'master' into new-overlay-sfx	2023-08-24 18:29:00 +09:00
Jamie Taylor	2e27a476bb	Re-enable sample playback for PasswordEntryPopover and remove sampleJoin playback instead	2023-08-24 18:04:47 +09:00
Dean Herbert	018be4c20f	Fix selection not being retained when switching between split mode	2023-08-22 18:49:02 +09:00
Dean Herbert	ecbf0f138e	Fix incorrect handling when new beatmaps arrive	2023-08-22 18:48:07 +09:00
Dean Herbert	2b1c6ae612	Ensure ID is maintained in temporary BeatmapSetInfos	2023-08-22 18:48:07 +09:00
Dean Herbert	290d18ad69	Split out difficulties in beatmap carousel in a bit of a hacky way ... Seems like the simplest path forward for now, without a full rewrite.	2023-08-22 18:47:41 +09:00
Dan Balasescu	e8337c592a	Update framework and apply changes to support masking SSBO	2023-08-22 12:50:13 +09:00
Dean Herbert	e7d61e0002	Fix star fountain directions not matching stable	2023-08-21 17:59:24 +09:00
Dean Herbert	4915b2563c	Merge pull request #24366 from Joehuu/supporter-playlist-duration ... Always show supporter-only playlist durations	2023-08-21 17:46:26 +09:00
Dean Herbert	8120c3f87a	Merge branch 'master' into precise-rotation-2	2023-08-19 23:25:42 +09:00
Dan Balasescu	a2fd7707a1	Allow toggling SVs in the editor	2023-08-18 18:55:24 +09:00
Dean Herbert	9023059bc0	Convert to switch statement	2023-08-18 17:27:09 +09:00
Dean Herbert	75750957c7	Add note about why pop in samples are disabled for PasswordEntryPopover	2023-08-18 17:11:30 +09:00
OliBomby	360f9750e1	Allow selecting empty control point groups	2023-08-17 16:30:18 +02:00
Jamie Taylor	d10d7b6ea4	Change some component samples to go better with overlay pop-in samples	2023-08-17 18:36:37 +09:00
Jamie Taylor	3d7ba0e18c	Add pop-in/pop-out sfx to more overlays	2023-08-17 18:36:37 +09:00
Jamie Taylor	b15a54c914	Use new overlay pop-in/pop-out samples	2023-08-17 18:36:36 +09:00
Dean Herbert	a78c03bd5b	Merge branch 'master' into precise-rotation-2	2023-08-17 17:59:13 +09:00
Dean Herbert	59a31cc868	Merge pull request #24431 from bdach/slider-with-textbox-instantaneous ... Add instantaneous mode to `SliderWithTextBoxInput`	2023-08-16 20:10:52 +09:00
Bartłomiej Dach	ed84be2f26	Merge pull request #24566 from peppy/multiplayer-spectator-score-diff ... Add score difference display to multiplayer spectator	2023-08-16 12:57:17 +02:00
Bartłomiej Dach	19f892687a	Add precise rotation control to osu! editor	2023-08-16 11:37:52 +02:00
Bartłomiej Dach	bdf87e43db	Merge branch 'master' into slider-with-textbox-instantaneous	2023-08-16 10:48:45 +02:00
Bartłomiej Dach	35af15f491	Merge branch 'master' into multi-spectator-fix-startup-delay	2023-08-16 10:34:20 +02:00
Dean Herbert	8b9759c569	Apply nullability to MatchScoreDisplay	2023-08-16 17:26:10 +09:00
Dean Herbert	ab826c35b7	Add score diff display to multiplayer spectator ... Basically pulling changes over from the tournament client implementation	2023-08-16 17:26:10 +09:00
Bartłomiej Dach	add1ef77d0	Fix typo in comment	2023-08-16 10:07:12 +02:00
Bartłomiej Dach	4f47b196c1	Merge branch 'master' into fix-unsafe-realm-access	2023-08-16 09:59:17 +02:00
Dean Herbert	bb98f10ff6	Use CurrentTime instead of StartTime for hotfix seek (and update comment)	2023-08-16 16:38:49 +09:00
Dean Herbert	184eabb902	Merge branch 'master' into multi-spectator-fix-startup-delay	2023-08-16 16:27:49 +09:00
Dean Herbert	31c2b7f925	Merge branch 'master' into leaderboard-toggle	2023-08-16 15:49:55 +09:00
Dean Herbert	5bd7370439	Add log output when editor is creating a fresh beatmap	2023-08-16 14:23:17 +09:00
Dean Herbert	e8bde6504a	Fix score being cloned in async method causing random crashes ... Closes https://github.com/ppy/osu/issues/24445.	2023-08-15 16:08:13 +09:00
Bartłomiej Dach	1b3806539a	Merge branch 'master' into leaderboard-toggle	2023-08-10 22:50:55 +02:00
Bartłomiej Dach	2698ec9206	Merge branch 'master' into block-exit-if-save-failed	2023-08-08 23:41:03 +02:00
Bartłomiej Dach	500a1363ec	Merge branch 'master' into fix-break-info-decimal-separator	2023-08-08 22:49:00 +02:00
Joseph Madamba	49f5d6813e	Block beatmap editor from testing/exiting/exporting when saving fails	2023-08-04 22:08:25 -07:00
Bartłomiej Dach	785d2ed9b1	Merge branch 'master' into multi-spectator-better-start-time	2023-08-03 22:07:47 +02:00
Bartłomiej Dach	52b1073d93	Fix playfield skin layer not rotating correctly with barrel roll mod	2023-08-03 21:08:00 +02:00
Bartłomiej Dach	dde03b7d46	Merge branch 'master' into playfield-skin-layer	2023-08-03 20:42:15 +02:00
Dean Herbert	71f6e5731d	Fix potential null reference if no frames found ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-03 08:58:19 +09:00
Dean Herbert	f38b21110f	Add missing parenthesis to comment ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-03 08:57:43 +09:00
Joseph Madamba	aab462fd95	Fix valueText being replaced even if current is not binding to anything	2023-08-02 09:40:22 -07:00
Dean Herbert	87fee001c7	Fix multiplayer spectator potentially taking too long to start ... When watching from the middle of gameplay, due to a series of failures, `SpectatorClock` would not get seeked to the current time, causing all clients to look like they were out of sync. This is a hotfix for the issue. A better fix will require framework changes or considerable restructuring. I'd recommend testing this works in practice and agreeing that while it is a hack, it's likely not going to cause issues and is something we want to see fixed sooner rather than later.	2023-08-02 19:05:43 +09:00
Dean Herbert	14d87e49c7	Improve choice of where to start playback of multiplayer spectator	2023-08-02 18:46:35 +09:00
Dean Herbert	0e510088f9	Ensure background of gameplay is black when storyboard is overriding background display	2023-08-02 15:50:15 +09:00
Dean Herbert	a618ed140e	Move StoryboardReplacesBackground bindable more local to usage	2023-08-02 15:29:18 +09:00
Bartłomiej Dach	5b6c3321cf	Merge branch 'master' into multi-spectator-flow-fixes	2023-08-01 19:03:48 +02:00
Bartłomiej Dach	a75f42f5a9	Merge branch 'master' into multi-spectator-extended-results	2023-08-01 18:25:41 +02:00
Bartłomiej Dach	f7d5ac9f92	Privatise setter	2023-08-01 18:09:48 +02:00
QuantumSno	054ca5e59c	Merge branch 'master' into leaderboard-toggle	2023-08-01 10:06:03 -04:00
Dean Herbert	70bd1d3cf4	Fix centred player not animating correctly	2023-08-01 20:18:21 +09:00
Dean Herbert	df504e1fc2	Show extended statistics in multiplayer spectator automatically	2023-08-01 20:02:36 +09:00
Dean Herbert	fe47dc291b	Fix onLoadRequested getting early-exited too early in spectator scenarios ... In some scenarios, multiplayer spectator would not tick over to the next beatmap. Here's an example: - Room has two items queued - Local user starts download of both - First beatmap starts and download is complete - First beatmap ends (spectating is active) - Second beatmap starts but download is not complete In this scenario, the local client will get stuck at the spectator screen due to the `onLoadRequested`-invoked screen change being early exited. It would require manual recovery (clicking back button) to return to a sane state.	2023-08-01 19:22:41 +09:00
Dean Herbert	9fe9ea2c90	Fix potential crash on multiple StartGameplay calls in multiplayer spectator	2023-08-01 19:22:41 +09:00
Bartłomiej Dach	2e2b0c4e41	Move SliderWithTextBoxInput to more general namespace	2023-08-01 01:01:36 +02:00
Dean Herbert	a3afb198a1	Merge pull request #24341 from bdach/selection-operations-refactor ... Refactor rotation handling in editor to facilitate reuse	2023-07-31 17:18:05 +09:00
Bartłomiej Dach	ebe5dd2ac9	Interface with SelectionRotationHandler via DI rather than explicit passing	2023-07-30 20:21:41 +02:00
Bartłomiej Dach	262f25dce8	Make SelectionRotationHandler a Component	2023-07-30 20:18:33 +02:00
Bartłomiej Dach	821cd08f34	Merge branch 'master' into selection-operations-refactor	2023-07-30 19:29:06 +02:00
Bartłomiej Dach	7763f3dd40	Fix osu! logo suddenly disappearing during rapid exit	2023-07-30 19:05:37 +02:00
Bartłomiej Dach	d3435483eb	Fix multiplayer match screen being exited from when not current ... This was supposed to be fixed by #24255, but has popped up as a regression on Sentry since: https://sentry.ppy.sh/organizations/ppy/issues/22749/?project=2&referrer=regression_activity-email On a fifteen-minute check I cannot figure out how to reproduce, so rather than spending further brain cycles on this, just apply the same explicit guard that like fifteen other places do.	2023-07-30 15:50:10 +02:00
Bartłomiej Dach	1f7f336fd5	Merge branch 'master' into fix-replay-export-queued-op	2023-07-30 14:58:14 +02:00
Bartłomiej Dach	898913f32a	Merge pull request #24415 from peppy/multi-spectator-improvements ... General visual improvements to mutliplayer spectatator screen	2023-07-30 12:43:26 +02:00
Bartłomiej Dach	e208f38bcb	Merge pull request #24361 from peppy/fix-editor-global-music-hotkey-conflicts ... Disallow interacting with the global track state in `Player` and `Editor`	2023-07-30 12:28:53 +02:00
Dean Herbert	6d5b3617b3	Remove pending export operation if active score is changed	2023-07-30 16:41:45 +09:00
Dean Herbert	35ec55c1f6	Don't queue export replay operations if button is disabled	2023-07-30 16:41:33 +09:00
Dean Herbert	45ceaba00d	Disable multiplayer spectator zoom when there's only one player's screen visible	2023-07-30 14:40:58 +09:00
Dean Herbert	945d89e955	Move disables to loading screens for better coverage of edge cases	2023-07-30 13:45:42 +09:00
Joseph Madamba	4ddf05602f	Update BreakInfoLine to formatting standards	2023-07-29 11:05:15 -07:00
Joseph Madamba	6ebfafa9c3	Remove unnecessary text comparison	2023-07-29 11:02:04 -07:00
Joseph Madamba	740898dffb	Remove unnecessary prefix parameter	2023-07-29 10:40:18 -07:00
Joseph Madamba	9d928c0225	Apply NRT to BreakInfoLine	2023-07-29 10:39:50 -07:00