Dean Herbert
31137bebf8
Revert realm to previous release to fix iOS crashes
2022-05-17 14:52:27 +09:00
Dean Herbert
bc294b8157
Add sentry tags for operating system and processor count
...
These would usually be in the log header, but right now that's not
conveyed. An example use case would be better understanding
https://sentry.ppy.sh/organizations/ppy/issues/846/?project=2&query=is%3Aunresolved&sort=freq&statsPeriod=14d ,
where we currently don't know whether it is a desktop or mobile OS.
2022-05-17 12:53:14 +09:00
Dean Herbert
218642c300
Update unsafe file write usages
2022-05-16 18:05:27 +09:00
Dean Herbert
f78eb0066c
Update Storage in line with new methods
2022-05-16 17:51:12 +09:00
Dean Herbert
9331c62306
Also add realm ruleset count
2022-05-16 16:09:50 +09:00
Dean Herbert
5ec05a8653
Add tags for current screen and ruleset
2022-05-16 15:51:32 +09:00
Dean Herbert
8c9edee360
Add ruleset context to sentry error reports
2022-05-16 15:47:00 +09:00
Dan Balasescu
a633501687
Change FilterTerms to use LocalisableString
2022-05-16 14:09:37 +09:00
Jai Sharma
ae5b6c3e10
Use dummy channel to show selector and remove ChannelListSelector
...
Add dummy channel `DummySelectorChannel` which should be set as the
current channel in the channel manager when the selector in the chat
overlay should be shown.
Refactors the `ChannelListItem` to not show mention pill and close
button when the channel is the dummy selector channel.
Ensure that the `ChannelList` selects the dummy channel on clicking the
selector item.
Removes `ChannelListSelector` as it is no longer needed.
Removes the `setCurrent` parameter from `ChannelManager.JoinChannel`
method as it is no longer needed.
2022-05-15 20:24:49 +01:00
Bartłomiej Dach
170df01b46
Adjust difficulty multiplier scale transition on mod overlay
...
The previous transition was supposed to be a center-anchored elastic
scale-in, but this didn't work as intended - because the multiplier
ended up inside of an auto-sized right-aligned container, the animation
itself would end up being anchored right.
Attempts to remove the scale transition resulted in a rather
jarring-looking result, so swap out the elastic scale-in for a sweep-in
effect from the top, to match the header and avoid introducing too many
directions of movement.
Delay values tweaked "to taste" - can be adjusted further if there is an
alternative set of values that feels better.
2022-05-15 20:44:50 +02:00
Dean Herbert
328561f5c8
Merge pull request #18263 from frenzibyte/spotlight-beatmap-badge
...
Add support for "spotlight" label in beatmap overlay/listing
2022-05-15 12:32:20 +09:00
Salman Ahmed
4bb06873d5
Move badge hierarchy declaration to constructor for safer access
2022-05-14 21:54:56 +03:00
Dean Herbert
b6575c216b
Allow selecting all mods at free mod select using ctrl+a
2022-05-15 03:25:14 +09:00
Dean Herbert
8a01050168
Refactor mod select button initialisation to allow shared usage of deselect button
2022-05-15 03:16:43 +09:00
Salman Ahmed
1878578196
Move todo comment to subclasses
2022-05-14 21:05:34 +03:00
Salman Ahmed
441957e18e
Convert get-only virtual properties to avoid DI order dependency
2022-05-14 21:05:34 +03:00
Salman Ahmed
88ba84ac9c
Replace Pill with Badge everywhere
2022-05-14 20:52:38 +03:00
Dean Herbert
6c3a4375c5
Fix case of "toggle mod select" string
2022-05-15 02:51:58 +09:00
Dean Herbert
a759cf2dab
Add key binding to deselect all mods
...
Defaults to `Backspace`.
2022-05-15 02:51:58 +09:00
Salman Ahmed
9bac33ec9f
Integrate spotlight beatmap badge in listing cards
2022-05-14 19:47:31 +03:00
Salman Ahmed
2878a6dcbe
Integrate spotlight beatmap badge in info overlay
2022-05-14 19:47:10 +03:00
Salman Ahmed
56d6cb5764
Add "spotlight" beatmap badge
2022-05-14 19:46:50 +03:00
Salman Ahmed
c8bea6273b
Abstractify beatmap badge logic to own class
2022-05-14 19:46:37 +03:00
Salman Ahmed
d5027cdfbd
Add FeaturedInSpotlight property to API beatmapsets
2022-05-14 19:46:13 +03:00
Jai Sharma
bd68ffa805
Fix textbox focus test in ChatOverlayV2
2022-05-14 12:16:00 +01:00
Jai Sharma
2163a78b7f
Ensure drawable channels removed from the cache are disposed
2022-05-14 00:15:09 +01:00
Jai Sharma
f88e416d1a
Ensure the wrong drawable channel isn't shown after load
2022-05-13 23:39:09 +01:00
Bartłomiej Dach
ab5c736da1
Merge branch 'master' into editor-readability
2022-05-13 21:10:48 +02:00
Dean Herbert
c4871ebcf4
Add editor track traversal keys (Z-V)
2022-05-14 02:50:51 +09:00
Dean Herbert
dec298cccb
Update resources
2022-05-13 21:47:22 +09:00
Dean Herbert
35026ad642
Add missing EditorClock caching
2022-05-13 21:39:54 +09:00
Jai Sharma
9f5351e5a1
Add drawable channel caching to new chat overlay
2022-05-12 23:58:41 +01:00
Dean Herbert
a35c57860c
Resolve colour inline
2022-05-12 23:54:43 +09:00
Dean Herbert
51744e428f
Merge branch 'master' into editor-readability
2022-05-12 22:56:55 +09:00
Dean Herbert
8760e5d884
Merge branch 'master' into new-chat-drawable-channel
2022-05-12 22:36:19 +09:00
Dean Herbert
f22ff4e087
Remove editor animation toggling (replaced by overlap markers)
2022-05-12 19:28:56 +09:00
Dean Herbert
c63e65c677
Don't hide SelectionBlueprints themselves, only their children
2022-05-12 19:26:13 +09:00
Dean Herbert
10e41d018a
Fix toggling hit animations on the editor not applying immediately
2022-05-12 17:36:35 +09:00
Dean Herbert
f7e055dbfe
Move mania note height offset application to a much more suitable location
2022-05-12 16:19:07 +09:00
Dean Herbert
c0abce918f
Add enum to snap method as alternative to mutliple nested invocations
2022-05-12 16:19:07 +09:00
Dan Balasescu
5f2d9bf04c
Merge pull request #18211 from frenzibyte/audio-adjustment-breakage-alt
...
Fix mods potentially adjusting track while not selected
2022-05-12 15:44:19 +09:00
Dan Balasescu
7ab31b8256
Merge pull request #18234 from peppy/distance-snap-no-snap-to-zero
...
Fix distance snap providing zero-distance snaps incorrectly
2022-05-12 15:40:44 +09:00
Salman Ahmed
82c4a5fe9f
Merge branch 'master' into new-chat-visibility-behaviour
2022-05-12 09:04:24 +03:00
Dan Balasescu
c54ca937c5
Fix CI inspections
2022-05-12 14:55:20 +09:00
Dan Balasescu
678cde3310
Merge pull request #18230 from bdach/mod-overlay/data-flow-refactor
...
Restructure data flow in mod select overlay
2022-05-12 14:40:49 +09:00
Dean Herbert
3d64dc53a6
Merge branch 'master' into audio-adjustment-breakage-alt
2022-05-12 14:18:28 +09:00
Dean Herbert
6ba0760b17
Merge branch 'master' into new-chat-visibility-behaviour
2022-05-12 13:59:35 +09:00
Dean Herbert
1d38e5bd33
Add notes about weird local handling in ChannelListSelector
2022-05-12 13:58:10 +09:00
Dean Herbert
2dfed6eda1
Remove selectorActive bindable completely
2022-05-12 13:53:57 +09:00
Dean Herbert
f51607521c
Fix distance snap providing zero-distance snaps incorrectly
2022-05-12 13:11:55 +09:00
Dean Herbert
b794deb5c5
Add null checks to screen context insertion
2022-05-12 12:06:51 +09:00
Jai Sharma
db371ab068
Use CurrentChannel == null to show the channel selector
2022-05-11 22:52:15 +01:00
Jai Sharma
cced8609f6
Add setCurrent param to ChannelManager.JoinChannel
2022-05-11 22:51:15 +01:00
Bartłomiej Dach
981ead68bf
Ensure local mods are constructed in time for Pop{In,Out}()
2022-05-11 22:31:27 +02:00
Bartłomiej Dach
93539160ad
Remove no-longer-necessary guard
2022-05-11 22:31:26 +02:00
Bartłomiej Dach
2266a5c9a0
Remove no-longer-necessary ModColumn.Filter
2022-05-11 22:31:26 +02:00
Bartłomiej Dach
1c0166367d
Fix remaining column operations being coupled to drawables
2022-05-11 22:31:26 +02:00
Bartłomiej Dach
b5a9f1310a
Fix select/deselect all toggle not working correctly after changes
2022-05-11 22:31:26 +02:00
Bartłomiej Dach
52bbce12f1
Fix not being able to set AvailableMods before loaded
2022-05-11 22:31:26 +02:00
Bartłomiej Dach
fc24a56478
Add protection from recursive updates from external selection
2022-05-11 22:31:25 +02:00
Bartłomiej Dach
83ba06e7af
Extract helper property for accessing all mods
2022-05-11 22:31:25 +02:00
Bartłomiej Dach
11ae1da65a
Hoist reference replacement logic to overlay level
2022-05-11 22:26:47 +02:00
Bartłomiej Dach
05a21fbbe0
Hoist ModState to overlay level
2022-05-11 22:26:21 +02:00
Bartłomiej Dach
e86444c4bf
Hoist ModState to column level
2022-05-11 22:03:49 +02:00
Bartłomiej Dach
74599c9c62
Use ModState in mod panels
2022-05-11 22:03:48 +02:00
Bartłomiej Dach
478cfc0b87
Split model class for mod state
2022-05-11 22:03:48 +02:00
Salman Ahmed
2ddef0e46c
Merge branch 'master' into sentry-more-context
2022-05-11 20:29:30 +03:00
Bartłomiej Dach
ddb2d4eef5
Rename FreeModSelect{Screen -> Overlay} reference in inline comment
2022-05-11 18:06:09 +02:00
Bartłomiej Dach
a104277e7f
Rename ModSelect{Screen -> Overlay}Strings
2022-05-11 18:01:33 +02:00
Salman Ahmed
a97986df1c
Merge branch 'master' into update-libraries
2022-05-11 15:58:45 +03:00
Dean Herbert
3cbd19a9ce
Update framework
2022-05-11 21:17:16 +09:00
Dean Herbert
fecf92e16f
Update libraries to latest versions
2022-05-11 19:54:59 +09:00
Dean Herbert
5800d7e99d
Merge pull request #18220 from frenzibyte/control-popover-focus
...
Focus textbox upon opening control point popovers
2022-05-11 19:41:25 +09:00
Dan Balasescu
52c8382138
Merge pull request #18221 from peppy/multiplayer-leaderboard-hiding
...
Change multiplayer leaderboard to always hide during gameplay unless holding-for-HUD
2022-05-11 18:43:55 +09:00
Dean Herbert
d05cd69087
Change multiplayer leaderboard to always hide during gameplay unless holding-for-HUD
2022-05-11 16:12:54 +09:00
Dean Herbert
1c36995606
Expose HoldingForHUD state from HUDOverlay as bindable
2022-05-11 16:09:16 +09:00
Salman Ahmed
96db530de6
Focus textbox on control point popovers
2022-05-11 09:55:34 +03:00
Salman Ahmed
24432dffc4
Add support for focusing intermediate slider-textbox component
2022-05-11 09:53:04 +03:00
Salman Ahmed
0b597e712e
Fix timeline not handling mouse down events
2022-05-11 09:39:27 +03:00
Dean Herbert
be09ec833e
Add global statistics context to sentry
2022-05-11 14:52:08 +09:00
Dean Herbert
f53d42d31f
Add realm context to sentry
2022-05-11 14:51:56 +09:00
Dean Herbert
977a0453cc
Add beatmap context to sentry
2022-05-11 14:50:57 +09:00
Dean Herbert
b136677bb0
Add config and clock time contexts to sentry
2022-05-11 14:50:39 +09:00
Dean Herbert
843e13a471
Add screen stack context to sentry
2022-05-11 14:10:17 +09:00
Dean Herbert
533f4b298f
Add explanation inline for future visitors
2022-05-11 10:40:40 +09:00
Dean Herbert
9dce329e99
Remove build suffix from version when reporting to sentry
2022-05-11 10:38:35 +09:00
Dean Herbert
53259251af
Merge branch 'master' into mod-overlay/rename-new
2022-05-11 10:15:59 +09:00
Dean Herbert
dd316befb4
Merge pull request #18214 from bdach/mod-overlay/delete-old
...
Remove old mod overlay code
2022-05-11 10:09:42 +09:00
Dan Balasescu
7473ff49cb
Merge pull request #18210 from peppy/realm-asycn-import-woes
...
Fix realm refetch operations potentially being unsafe
2022-05-11 09:53:46 +09:00
Bartłomiej Dach
76c63f1d0a
Rename ModSelect{Screen -> Overlay} in place of removed old design
2022-05-10 22:56:50 +02:00
Bartłomiej Dach
33634cba1e
Remove old mod buttons
2022-05-10 21:58:22 +02:00
Bartłomiej Dach
8b0ece1c09
Remove old mod section
2022-05-10 21:55:54 +02:00
Bartłomiej Dach
dfd97701d7
Remove old mod settings container & related controls
2022-05-10 21:53:42 +02:00
Bartłomiej Dach
128468e13d
Remove old base mod select overlay
2022-05-10 21:52:30 +02:00
Bartłomiej Dach
24c59e2f2f
Remove old user mod select overlay
2022-05-10 21:52:17 +02:00
Bartłomiej Dach
4a3447f59f
Remove old free mod select overlay
2022-05-10 21:45:57 +02:00
Salman Ahmed
9446be2511
Remove unnecessary UnbindAdjustments call
...
It is not necessary given that `CurrentTrack` already removes all adjustments first.
2022-05-10 20:49:44 +03:00
Salman Ahmed
36a7644164
Reinstantiate mod adjustments layer for safety against previous mods
2022-05-10 20:46:33 +03:00
Dean Herbert
ec231e0f31
Use more local realm reference
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-05-11 00:45:17 +09:00
Salman Ahmed
725ff93f34
Define local adjustments component for mods in MusicController
...
Isolates `CurrentTrack` from being directly adjusted by the mod, which could lead to issues depending on how the mod adds adjustments (i.e. `ModTimeRamp`, which adds adjustments based on changes to a setting bindable).
2022-05-10 18:24:29 +03:00
Salman Ahmed
82b784ce5a
Change IApplicableToSample to receive adjustable component instead
...
Done for consistency with `IApplicableToTrack`.
2022-05-10 18:06:03 +03:00
Salman Ahmed
4f5001704e
Change IApplicableToTrack to receive adjustable component instead
2022-05-10 18:06:03 +03:00
Salman Ahmed
bbbecbb6b7
Apply time-ramping adjustment using clock instead of track
2022-05-10 18:06:03 +03:00
Dean Herbert
587cc8cdb3
Merge pull request #18204 from frenzibyte/move-soft-handle-exception
2022-05-10 21:57:15 +09:00
Dean Herbert
33f024212f
Fix realm refetch operations potentially being unsafe
...
As seen in test failure https://github.com/ppy/osu/runs/6357384721?check_suite_focus=true .
2022-05-10 21:04:30 +09:00
Dan Balasescu
42fe708225
Fix inspection
2022-05-10 19:56:21 +09:00
Dean Herbert
b2a57c34bb
Move implementation to base
2022-05-10 19:10:34 +09:00
Dean Herbert
4d22f26266
Rename property and improve xmldoc
2022-05-10 19:07:07 +09:00
Dean Herbert
cac6d5569c
Fix incorrect variable reference in log output
2022-05-10 19:07:00 +09:00
Dean Herbert
a578f7a406
Force nested screens to load synchronously
2022-05-10 18:21:35 +09:00
Dean Herbert
a93c63b2b5
Add loading spinner when loading first run screens
2022-05-10 18:21:35 +09:00
Dean Herbert
25c6226ca9
Adjust transition length for a more seamless screen change
2022-05-10 18:21:35 +09:00
Dean Herbert
493798ae5e
Fix nested ui scale example screens no longer fitting
2022-05-10 18:21:35 +09:00
Dean Herbert
63b9e01d38
Fix behaviour screen using old style buttons
2022-05-10 18:21:35 +09:00
Dean Herbert
61313b69ec
Standardise font sizes in first run overlay screens
2022-05-10 18:21:35 +09:00
Dean Herbert
e5204e565d
Move horizontal padding to content level to better align scrollbar
2022-05-10 18:21:35 +09:00
Dean Herbert
bcce9c5e67
Limit the width of first run overlay content
2022-05-10 18:21:35 +09:00
Dean Herbert
9aadc274bf
Show first run dialog on first run of the game
2022-05-10 18:21:35 +09:00
Dan Balasescu
a6674d8c1a
Merge pull request #18205 from peppy/sentry-setup
...
Bring sentry usage up-to-date
2022-05-10 17:11:36 +09:00
Dean Herbert
6a49eb6875
Add breadcrumb level mappings
2022-05-10 16:14:04 +09:00
Dean Herbert
216c68e6d0
Add unobserved exception hinting
2022-05-10 16:09:16 +09:00
Dean Herbert
363643a16d
Remove sentry logger debounce
...
This is probably going to result in a high quantity of exceptions, but I
think this is fine. We can add rules as we go to not log certain
exception types.
2022-05-10 16:09:16 +09:00
Dean Herbert
c6112b3ae7
Add unhandled exception marking
2022-05-10 16:09:16 +09:00
Dean Herbert
99e6d56508
Add finalizer to sentry logger for safety
2022-05-10 16:09:16 +09:00
Dean Herbert
9734d778f4
Update sentry SDK usage in line with more recent specifications
2022-05-10 16:09:16 +09:00
Dean Herbert
3338bffce3
Attach user to sentry later in startup flow
2022-05-10 16:09:16 +09:00
Dean Herbert
a5b454edc7
Remove unnecessary DI caching of SentryLogger
2022-05-10 16:09:16 +09:00
Dean Herbert
64cc6ebddb
Add local user tracking to sentry reporting
2022-05-10 16:09:16 +09:00
Dean Herbert
09c21cde8c
Add log level translation
2022-05-10 16:09:16 +09:00
Dean Herbert
dc3c73f723
Enable sentry session tracking
2022-05-10 16:09:16 +09:00
Salman Ahmed
725f5f4dcb
Allow one more exception per second in OsuGame and TournamentGame
2022-05-10 10:02:45 +03:00
Salman Ahmed
bcd91ac743
Move exception soft-handling logic to OsuGameBase
2022-05-10 10:02:32 +03:00
Dan Balasescu
8ccf2ee075
Add inline comment
2022-05-10 15:07:08 +09:00
Dan Balasescu
2b7eeadac0
Workaround bad performance when selecting all freemods
2022-05-10 14:48:41 +09:00
Dan Balasescu
886a4815fa
Merge pull request #18180 from frenzibyte/fix-toolbox-double-tap
...
Fix `SettingsToolboxGroup` not clearing transforms before updating autosize
2022-05-10 13:48:02 +09:00
Dan Balasescu
8a559ff58a
Merge pull request #18191 from frenzibyte/button-use-overlay-colour
...
Fix buttons no longer coloured using `OverlayColourProvider`
2022-05-10 12:14:10 +09:00
Jai Sharma
2481201a73
Fix selector dismissal behaviour during user actions
2022-05-09 22:58:46 +01:00
Salman Ahmed
96ea4ee7b3
Add explanatory comment
2022-05-09 23:49:05 +03:00
Salman Ahmed
15a04d4225
Merge branch 'master' into fix-dropdown-hover-colour
2022-05-09 21:28:56 +03:00
Salman Ahmed
1fcfeac05f
Fix RoundedButton not using its default background colour
2022-05-09 21:07:43 +03:00
Salman Ahmed
ace25af949
Revert "Move default background colour specification to OsuButton"
...
This reverts commit 172524ff8a
2022-05-09 20:55:26 +03:00
Bartłomiej Dach
626fcd5d35
Merge branch 'master' into column-flow-cq
2022-05-09 19:22:29 +02:00
Salman Ahmed
172524ff8a
Move default background colour specification to OsuButton
2022-05-09 18:21:00 +03:00
Jai Sharma
d4cc2bd7dd
Ensure channel selector is dismissed when the current channel is changed
2022-05-09 12:11:25 +01:00
Dean Herbert
70a90722e8
Fix dropdown item hover colour not being set in time
...
Turns out to be an osu!-side issue. The colour transform was being
shortcutted for the non-displayed case, which meant it was not in a good
state in time for the first hover.
Closes https://github.com/ppy/osu/issues/18163#issuecomment-1120747301
2022-05-09 19:49:45 +09:00
Salman Ahmed
702c6ae658
Fix SettingsToolboxGroup not clearing transforms before updating autosize
2022-05-09 13:49:31 +03:00
Dean Herbert
1c63c27fdf
Merge branch 'master' into new-chat-drawable-channel
2022-05-09 18:23:00 +09:00
Dan Balasescu
a16f2349aa
Fix next queued item not selecting after gameplay
2022-05-09 17:55:42 +09:00
Dean Herbert
ab1d46b71c
Merge pull request #17270 from frenzibyte/multiplayer-disable-adaptive-speed
...
Disable mod "Adaptive Speed" in multiplayer
2022-05-09 17:31:47 +09:00
Dean Herbert
3007d2b9df
Merge pull request #18168 from peppy/update-framework
...
Update framework
2022-05-09 17:31:37 +09:00
