1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-26 23:13:20 +08:00

Remove sentry logger debounce

This is probably going to result in a high quantity of exceptions, but I
think this is fine. We can add rules as we go to not log certain
exception types.
This commit is contained in:
Dean Herbert 2022-05-10 15:08:49 +09:00
parent c6112b3ae7
commit 363643a16d

View File

@ -20,8 +20,6 @@ namespace osu.Game.Utils
/// </summary>
public class SentryLogger : IDisposable
{
private Exception? lastException;
private IBindable<APIUser>? localUser;
private readonly IDisposable? sentrySession;
@ -69,11 +67,6 @@ namespace osu.Game.Utils
{
if (!shouldSubmitException(exception)) return;
// since we let unhandled exceptions go ignored at times, we want to ensure they don't get submitted on subsequent reports.
if (lastException != null && lastException.Message == exception.Message && exception.StackTrace.StartsWith(lastException.StackTrace, StringComparison.Ordinal)) return;
lastException = exception;
// framework does some weird exception redirection which means sentry does not see unhandled exceptions using its automatic methods.
// but all unhandled exceptions still arrive via this pathway. we just need to mark them as unhandled for tagging purposes.
// easiest solution is to check the message matches what the framework logs this as.