1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-31 08:23:22 +08:00
Commit Graph

44851 Commits

Author SHA1 Message Date
Dean Herbert
573aaf6637
Merge pull request #27128 from frenzibyte/user-statistics-provider
Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset
2024-11-27 13:13:47 +09:00
Salman Alshamrani
9083daf363 Fix epic code failure
I wasn't feeling well last night.
2024-11-26 20:04:36 -05:00
Salman Alshamrani
3e1b4f4ac5 Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-11-26 16:52:39 -05:00
HenintsoaSky
80a66085a9 rename and remove again 2024-11-27 00:41:02 +03:00
HenintsoaSky
460471e73f Rename of the setting 2024-11-27 00:27:22 +03:00
HenintsoaSky
df74a177ae Add option to disable star fountain in gameplay 2024-11-27 00:13:32 +03:00
Joseph Madamba
9173a74552
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip 2024-11-26 12:13:08 -08:00
Joseph Madamba
f04862ea74
Edit one more word not using british english 2024-11-26 12:11:29 -08:00
Bartłomiej Dach
33c2eb1af7
Merge pull request #30881 from peppy/fix-editor-state-leaking
Fix hitobjects' samples getting in bad state when changing selection between objects
2024-11-26 13:54:50 +01:00
Bartłomiej Dach
3e373ae85e
Merge pull request #30868 from peppy/ur-perf-fix
Improve performance of UR calculations
2024-11-26 13:54:17 +01:00
Bartłomiej Dach
46d1f00590
Fix Beatmap.Countdown not being copied on conversion 2024-11-26 11:39:03 +01:00
Bartłomiej Dach
cf905d0f5c
Merge branch 'master' into beatmap-info-purge 2024-11-26 10:21:16 +01:00
tsrk.
41c309fb72
chore(MenuTip): update text according to recent changes
Signed-off-by: tsrk. <tsrk@tsrk.me>
2024-11-26 09:35:18 +01:00
Dean Herbert
3ecb3b674d
Don't reset state when changing from one selection to another in the editor
This was causing state pollution in the new selection. I can't see why
this needs to happen when a selection changes to another.

This fixes https://github.com/ppy/osu/issues/30839 and also the same
issue happening for the new combo toggle.

Tests all seem to pass, and I can't immediately find anything broken,
but YMMV.
2024-11-26 17:33:41 +09:00
Dan Balasescu
d3d111de7d
Merge pull request #30832 from peppy/mania-precise-scroll-speed
Allow setting osu!mania scroll speed to single decimal precision
2024-11-26 17:30:56 +09:00
Salman Alshamrani
42c68ba43e Add inline comment 2024-11-26 01:28:58 -05:00
Salman Alshamrani
b76460f100 Schedule the thing
Queuing up requests on change to `api.LocalUser` is bad because the API
state is updated after `LocalUser` is updated, therefore we have to
schhhhhedullllllllleeeeeeeeeeeeeeee.
2024-11-26 01:26:44 -05:00
Dean Herbert
e3ea38a366
Add setting to allow hold-for-pause to still exist
Users have asked for this multiple times since last release.

Not sure on the best default value, but I'm going with the
stable/classic one, at least for the initial release to avoid needing
migrations.

In the future we may reconsider this for new users.
2024-11-26 15:14:19 +09:00
Salman Alshamrani
7201bac60d Remove DailyChallengePlayer 2024-11-26 01:10:19 -05:00
Salman Alshamrani
c1416f9920 Bring back user-based endpoint for viewing result screen from playlists lounge 2024-11-26 01:10:12 -05:00
Salman Alshamrani
d150aeef2b Use score-based endpoint everywhere 2024-11-26 01:01:59 -05:00
Salman Alshamrani
dfa21574fd
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip 2024-11-25 23:52:56 -05:00
Dean Herbert
17347563ee
Fix incorrect null handling 2024-11-26 13:25:57 +09:00
Dean Herbert
f708466a9b
Add test coverage 2024-11-26 13:25:55 +09:00
Dean Herbert
d6cf1db0f5
Add basic xmldoc to results class 2024-11-26 12:16:26 +09:00
Dean Herbert
d903d381d5
Rename NextProcessableIndex to EventCount in line with actual functionality 2024-11-26 12:10:34 +09:00
Dean Herbert
9ca17f9b6b
Merge pull request #30748 from stanriders/scale-profile-beatmaps
Scale down beatmap cards
2024-11-25 22:53:51 +09:00
Bartłomiej Dach
0a3f3c3210
Add guard against fetching statistics for non-legacy rulesets 2024-11-25 13:14:22 +01:00
Dean Herbert
bbe8f2ec44
Only update unstable rate counter when an applicable hitobject is reached 2024-11-25 21:13:18 +09:00
Dean Herbert
ea68d4b33a
Use class instead of record for lower allocations 2024-11-25 21:13:18 +09:00
Dean Herbert
5668258182
Add incremental processing 2024-11-25 21:13:17 +09:00
Bartłomiej Dach
78c01c1b5a
Merge branch 'master' into beatmap-defaults-match-stable 2024-11-25 12:55:08 +01:00
Dean Herbert
33d725e889
Address unstable rate calculations as a list for marginal gains 2024-11-25 19:44:11 +09:00
Dean Herbert
605fe71f46
Make empty hitwindows readonly static and slightly improve comparison performance 2024-11-25 19:17:32 +09:00
Dean Herbert
82bdd8fbfc
Merge pull request #30861 from frenzibyte/fix-multiplayer-missing-hold-delay
Fix pause shortcut on multiplayer no longer requiring hold
2024-11-25 16:22:56 +09:00
Dean Herbert
876c2e468a
Merge pull request #30858 from frenzibyte/fix-match-settings-overlay-typo 2024-11-25 15:58:17 +09:00
tsrk.
cfaf972813
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip 2024-11-24 18:24:43 +01:00
Dean Herbert
c34827a4ed
Merge pull request #30862 from frenzibyte/dont-scare-the-player
Don't play fail animation if restarting on fail
2024-11-24 23:11:19 +09:00
tsrk.
8611ed31c2
refactor(MenuTip): add localisation support
Signed-off-by: tsrk. <tsrk@tsrk.me>
2024-11-24 14:22:56 +01:00
Dean Herbert
888f02e3a6
Merge pull request #30855 from SupDos/tips-remove-fps
Remove FPS shortcut tip
2024-11-24 19:57:08 +09:00
Salman Alshamrani
ae9119eef0 Hide back button when quick-restarting unless load time takes long 2024-11-24 05:40:06 -05:00
Salman Alshamrani
2420793466 Allow controlling back button visibility state from screens 2024-11-24 05:39:43 -05:00
Salman Alshamrani
6d0d7f3e75 Don't play fail animation if restarting on failure 2024-11-24 04:45:48 -05:00
Salman Alshamrani
f3155bfc7d Fix pause shortcut on multiplayer not delayed 2024-11-24 04:24:31 -05:00
Salman Alshamrani
631bfadd68 Replace event subscription with callback in UserStatisticsWatcher
Also no longer cancels previous API requests as there's no actual need to do it.
2024-11-24 04:11:13 -05:00
Salman Alshamrani
956da0383f
Merge branch 'master' into multiplayer-remove-expired-item-removal 2024-11-23 22:19:21 -05:00
Salman Alshamrani
8f5d513d46 Fix room auto start duration setting applied to the wrong component 2024-11-23 22:16:29 -05:00
Salman Alshamrani
6b78553559
Merge branch 'master' into tips-remove-fps 2024-11-23 20:57:14 -05:00
SupDos
2f096f71d3 Remove FPS shortcut tip 2024-11-24 02:34:30 +01:00
Salman Alshamrani
608bda135a
Merge branch 'master' into fix-song-ticker-contrast 2024-11-23 20:14:33 -05:00
Salman Alshamrani
2f45ebeec8 Remove using directive 2024-11-23 20:13:57 -05:00
Salman Alshamrani
eed02c2ab1 Fix daily challenge results screen beginning score fetch from user highest 2024-11-23 15:45:29 -05:00
Sheppsu
3713bb48b7 expand and contract settings from hover 2024-11-23 01:09:58 -05:00
Salman Alshamrani
c9dc6628fc
Merge branch 'master' into remove-macos-recommendation 2024-11-22 23:14:09 -05:00
Dean Herbert
ce41c000a1
Merge pull request #30812 from smoogipoo/playlist-populate-on-enter
Fix joining playlists room sometimes not selecting the first item
2024-11-22 23:57:45 +09:00
Dean Herbert
9930922769
Fix chat channel listing not being ordered to expectations
- Public channels (and announcements) are now alphabetically ordered.
- Private message channels are now ordered by most recent activity.

Closes https://github.com/ppy/osu/issues/30835.
2024-11-22 19:53:26 +09:00
Dean Herbert
c844d65a81
Use TryGetValue wherever possible
Rider says so.
2024-11-22 19:11:16 +09:00
Bartłomiej Dach
ead7e99c59
Fix incorrect comment 2024-11-22 11:06:36 +01:00
Dean Herbert
c590bef4c3
Remove legacy default setter for SamplesMatchPlaybackRate now that it's the default 2024-11-22 19:05:29 +09:00
Dean Herbert
086a34f5c0
Merge branch 'master' into beatmap-info-purge 2024-11-22 18:47:32 +09:00
Dean Herbert
e33e0e16e8
Merge branch 'master' into scale-profile-beatmaps 2024-11-22 18:33:37 +09:00
Dean Herbert
04ed954387
Fix song ticker having very bad contrast against bright backgrounds
Closes #30814.
2024-11-22 18:17:55 +09:00
Bartłomiej Dach
8b68859d9d
Fix Room.CopyFrom() skipping a field
Was making the close button not display when creating a room anew.
2024-11-22 09:57:57 +01:00
Bartłomiej Dach
cfc38df889
Add close button to playlists footer 2024-11-22 09:57:56 +01:00
Bartłomiej Dach
69c2c988a1
Add extra check to ensure closed rooms can't be closed harder 2024-11-22 09:54:56 +01:00
Dean Herbert
29757ffdf2
Allow setting osu!mania scroll speed to single decimal precision
Addresses https://github.com/ppy/osu/discussions/30663.
2024-11-22 17:36:28 +09:00
Dan Balasescu
39504c348d
Cleanup CopyFrom() method
Though the code appears slightly different, it should be semantically
equivalent. APIUser equality is implemented on `Id` and `Host` should
never transition from non-null to null.
2024-11-22 17:22:30 +09:00
Dan Balasescu
e59ac9e7c8
No longer remove expired playlist items from Room model 2024-11-22 17:19:26 +09:00
Bartłomiej Dach
3b2f43012e
Merge branch 'master' into close-playlists 2024-11-22 09:02:41 +01:00
Bartłomiej Dach
479ff7eb41
Merge pull request #30799 from peppy/fix-player-loader-focus-fux
Fix beatmap load not continuing when when settings slider is focused
2024-11-22 08:57:10 +01:00
Dean Herbert
a76b4418b9
Change some beatmap default settings to match stable
- Countdown should [be off by
default](9a07485638/osu!/GameplayElements/Beatmaps/Beatmap.cs#L372)
- Samples match playback rate
[also](9a07485638/osu!/GameplayElements/Beatmaps/Beatmap.cs#L210)
2024-11-22 16:55:37 +09:00
Bartłomiej Dach
512d2c6e3b
Merge branch 'master' into multiplayer-nrt 2024-11-22 08:09:42 +01:00
Bartłomiej Dach
4a129ac0bf
Merge pull request #30766 from Darius-Wattimena/catch-improve-info-on-selected
Add snapping info to the catch selected objects inspector
2024-11-22 08:08:33 +01:00
Dean Herbert
6a0ac4c29e
Merge pull request #29640 from smoogipoo/mania-imperfect-ss
Make mania award SS even if there are GREAT judgements
2024-11-22 14:42:32 +09:00
Dean Herbert
41addaae9a
Rename variable to imply it is now a function 2024-11-22 13:11:32 +09:00
Salman Alshamrani
5dffc322af Recreate beatmap every test run in ModTestScene 2024-11-21 17:48:33 -05:00
Dan Balasescu
2a7266cb23
Fix tests 2024-11-22 01:26:35 +09:00
Dan Balasescu
f738fb2a89
Populate rooms as soon as they're joined 2024-11-21 23:48:04 +09:00
Dan Balasescu
84ac3097c2
Populate parameter description
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-11-21 22:47:46 +09:00
Bartłomiej Dach
74170ea28e
Merge branch 'master' into patch-1 2024-11-21 13:06:19 +01:00
Dan Balasescu
209380cbac
Enable NRT in TestMultiplayerRoomManager 2024-11-21 21:03:12 +09:00
Dan Balasescu
cc59434ea4
Fix crash due to being too forgiving of nulls
This one is super duper annoying to test, because we already have e.g.
`TestScenePlaylistsScreen`. The only way to test it would be to use an
`OsuGameTestScene`.

Maybe this is okay?
2024-11-21 20:52:34 +09:00
Dan Balasescu
dc45816566
Fix inspection 2024-11-21 20:41:14 +09:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists 2024-11-21 20:32:09 +09:00
Bartłomiej Dach
0e4d078beb
Merge branch 'master' into catch-improve-info-on-selected 2024-11-21 12:17:54 +01:00
Dean Herbert
033b7c17d5
Add back macOS precheck 2024-11-21 18:13:00 +09:00
Dan Balasescu
7018672275
Fix playlist room status resetting on enter 2024-11-21 18:11:41 +09:00
Dan Balasescu
fe8e9d455a
Add failing test 2024-11-21 18:09:39 +09:00
Cadence Ember
37394a5027
Use consistent decimal places in BeatmapAttributeText 2024-11-21 14:04:42 +13:00
Dean Herbert
2c0140f865
Merge pull request #30798 from frenzibyte/fix-precision
Add sane precision values to all settings
2024-11-21 03:00:49 +09:00
Dean Herbert
ae98f63b51
Fix beatmap load not continuing when when settings slider is focused
Regressed with recent sliderbar focus changes.

Closes #30716.
2024-11-21 02:28:35 +09:00
Salman Alshamrani
40b95901e3 Fix more cases of settings with no defined precision values 2024-11-20 12:11:38 -05:00
Salman Alshamrani
1ef02fec06 Fix "positional hitsounds level" setting not specifying a precision constraint 2024-11-20 12:08:57 -05:00
Bartłomiej Dach
a679f0736e
Add ability to close playlists within grace period after creation 2024-11-20 12:36:12 +01:00
Fivoka
7726ca02b0 Changed multiplier from 2 to 3.5 2024-11-20 12:29:29 +01:00
Dean Herbert
6fba6de4dc
Merge branch 'master' into multiplayer-remove-cmc-and-composite 2024-11-20 17:24:55 +09:00
Dean Herbert
03de518484
Fix missing updateRoomPlaylist call 2024-11-20 16:56:22 +09:00
Dean Herbert
50089c027e
Update framework 2024-11-20 16:40:33 +09:00
Dean Herbert
b4077fc8a2
Use !FrameworkEnvironment.UseSDL3 instead of removing warning altogether 2024-11-20 16:28:11 +09:00
Dan Balasescu
53f0befc05
Merge pull request #30402 from peppy/import-paused-visibility
Update notification text when import is paused due to gameplay
2024-11-20 16:00:13 +09:00
Dean Herbert
b070a50ac9
Merge pull request #30718 from frenzibyte/initial-key-counter-state
Fix key counter not updating activation state on initial load
2024-11-20 15:39:44 +09:00
Dan Balasescu
a5327aa562
Use properties instead of fields 2024-11-19 18:48:30 +09:00
Bartłomiej Dach
273095fd82
Merge pull request #30757 from peppy/fix-scroll-absolute-pos
Fix right click scroll at song select not quite matching scrollbar position
2024-11-19 10:40:00 +01:00
Darius Wattimena
16158710f9 Made reading of ReadCurrentDistanceSnap public 2024-11-18 23:49:40 +01:00
Dean Herbert
a529cef28b
Merge pull request #30743 from peppy/collection-scroll-etc
Further UX improvements to collection management
2024-11-19 00:32:16 +09:00
Dean Herbert
a2af4cbb50
Fix right click scroll at song select not quite matching scrollbar position
Closes https://github.com/ppy/osu/issues/30744.
2024-11-18 23:54:56 +09:00
Bartłomiej Dach
22b082d968
Fix not being able to scroll to new collection text box when list overflows 2024-11-18 15:28:30 +01:00
Bartłomiej Dach
259e9ecf65
Deactivate new combo toggle on deselecting objects
Closes https://github.com/ppy/osu/issues/30713.

Was a point of discussion doing review:

	https://github.com/ppy/osu/pull/30214#discussion_r1798833139

Given it got pointed out immediately for something so minor, I'm
inclined to believe it's a rather undesirable change.
2024-11-18 15:13:32 +01:00
Salman Alshamrani
0b52080a52 Handle logged out user 2024-11-18 06:47:22 -05:00
Salman Alshamrani
74daf85e48 Replace bindable with an event 2024-11-18 06:47:22 -05:00
StanR
4066186b24 Scale beatmap cards down by ~0.8 2024-11-18 14:48:51 +05:00
Sheppsu
7d4062d2ad remove redundant Scale attribute 2024-11-18 04:04:28 -05:00
StanR
dcf4674c6c Scale down beatmap cards in profile overlay 2024-11-18 14:01:17 +05:00
Sheppsu
29e7adcd3b add player settings to multi spectator screen 2024-11-18 03:57:50 -05:00
Dean Herbert
ebc2cc3570
Ensure cleanup tasks are run even on a cancelled / exceptioned import task 2024-11-18 16:51:46 +09:00
Dean Herbert
5ce1f7679b
Add search bar to collection management dialog 2024-11-18 16:32:56 +09:00
Dean Herbert
a570863854
Scroll to new collection in list when adding a new collection 2024-11-18 16:32:56 +09:00
Dean Herbert
e5778eb1fc
Add scrollbar to manage collections dialog 2024-11-18 16:32:56 +09:00
Dan Balasescu
5276f77ebd
Merge pull request #30684 from Joehuu/source-filter
Add missing source query filter in song select
2024-11-18 16:06:26 +09:00
Salman Alshamrani
b106833663 Fix more test / component breakage 2024-11-17 20:36:12 -05:00
Salman Alshamrani
caf56afba6 Fix various test failures 2024-11-17 19:13:29 -05:00
Salman Alshamrani
1847b679db Only update user rank panel display when ruleset matches
Nothing behaviourally different, just reduce number of redundant calls.
2024-11-17 18:45:07 -05:00
Salman Alshamrani
07609b6267 Fix UserRankPanel not updating on ruleset change 2024-11-17 18:32:17 -05:00
Salman Alshamrani
28f87407f6 Make DifficultyRecommender rely on the statistics provider 2024-11-17 18:32:17 -05:00
Salman Alshamrani
4a628287e2 Decouple game-wide ruleset bindable and refactor LocalUserStatisticsProvider
This also throws away the logic of updating
`API.LocalUser.Value.Statistics`. Components should rely on
`LocalUserStatisticsProvider` instead for proper behaviour and ability
to update on statistics updates.
2024-11-17 18:13:37 -05:00
Salman Alshamrani
6c8a900dcc Merge branch 'master' into user-statistics-provider 2024-11-17 15:34:56 -05:00
Salman Alshamrani
b014bfea3e Fix key counter not updating activation state on initial load 2024-11-17 09:56:19 -05:00
Joseph Madamba
ad9acc5a0f
Add hotkey hints to skin editor menus 2024-11-15 23:03:40 -08:00
Joseph Madamba
706f5b3e55
Add missing clone keybinding to skin editor 2024-11-15 23:03:40 -08:00
Joseph Madamba
465cc716d3
Add missing source query filter in song select 2024-11-15 22:53:23 -08:00
Dean Herbert
0a1f589c80
Fix black layer not fading fast enough when exiting quickly from quick restart 2024-11-16 11:52:02 +09:00
Dean Herbert
a5fab23e44
Update framework 2024-11-16 11:49:19 +09:00
Dean Herbert
c852cf9b8e
Remove macOS "borderless" recommendation
As of SDL3, this is no longer a thing, and fullscreen should be the
preferred execution mode.

Probably hold off merging this until we're sure that macOS isn't broken
for others in this mode (I had issues locally, such as alt-tabbing being
broken sooo...)
2024-11-15 18:29:01 +09:00
Bartłomiej Dach
21d407680b
Merge pull request #30623 from peppy/fix-flash-transition-player
Fix occasional flash when quick exiting / retrying from player
2024-11-15 08:42:43 +01:00
Dan Balasescu
db7def9d34
Remove IDependencyInjectionCandidate interface from Room 2024-11-15 16:05:06 +09:00
Dan Balasescu
1a656d0ec3
Remove CachedModelDependencyContainer usages from online play 2024-11-15 15:59:28 +09:00
Dan Balasescu
bfbae9458a
Remove OnlinePlayComposite 2024-11-15 15:59:28 +09:00
Dan Balasescu
34c0f72dd6
Make Room.Playlist non-bindable 2024-11-15 15:51:01 +09:00
Dan Balasescu
b16edbbf52
Make Room.RecentParticipants non-bindable 2024-11-15 15:25:43 +09:00
Dan Balasescu
dc5337d771
Make Room.UserScore non-bindable 2024-11-15 14:42:46 +09:00
Dan Balasescu
c4f8fd1832
Make Room.DifficultyRange non-bindable 2024-11-15 14:42:46 +09:00
Dan Balasescu
487a010b12
Make Room.PlaylistItemStats non-bindable 2024-11-15 14:42:46 +09:00
Dan Balasescu
80b3e330a6
Make Room.ChannelId non-bindable 2024-11-15 14:42:46 +09:00
Dan Balasescu
6c84e425f8
Make Room.MaxAttempts non-bindable 2024-11-15 14:42:46 +09:00
Dan Balasescu
0ceaafe731
Make Room.Duration & Room.StartDate & Room.EndDate non-bindable 2024-11-15 14:42:45 +09:00
Dan Balasescu
89de4f0f87
Make Room.AutoStartDuration non-bindable 2024-11-15 14:42:45 +09:00
Dan Balasescu
b8bae30b66
Make Room.ParticipantCount & Room.MaxParticipants non-bindable 2024-11-15 14:42:45 +09:00
Dan Balasescu
f001cce24a
Make Room.AutoSkip non-bindable 2024-11-15 14:42:18 +09:00
Dan Balasescu
ec5be6dbc3
Make Room.Password & Room.HasPassword non-bindable 2024-11-15 14:42:18 +09:00
Dan Balasescu
198681e644
Make Room.QueueMode non-bindable 2024-11-15 14:42:18 +09:00