Dean Herbert
|
05797cb9e5
|
Fix enum to STRING????????? conversion (and use bindable flow)
|
2022-09-09 16:30:08 +09:00 |
|
Dean Herbert
|
45239fc737
|
Update TrueGameplayRate accessing
|
2022-09-08 23:03:15 +09:00 |
|
Dean Herbert
|
d4afc3629c
|
Merge branch 'master' into kps
|
2022-09-08 23:00:36 +09:00 |
|
Dan Balasescu
|
9aab502adc
|
Merge pull request #20157 from peppy/true-gameplay-rate
Refactor `TrueGameplayRate` to account for only gameplay adjustments, no matter what
|
2022-09-08 19:54:32 +09:00 |
|
Dan Balasescu
|
4fc03998a1
|
Merge pull request #20189 from peppy/fix-playlist-item-download-button-visibility
Fix playlist items showing download button briefly during initial display
|
2022-09-08 19:47:35 +09:00 |
|
Dean Herbert
|
a98c6b2c1f
|
Add comment metioning why we need to use DrawableRuleset lookup
|
2022-09-08 19:14:23 +09:00 |
|
Mk-56spn
|
07c16224d2
|
Fix Main file issues
|
2022-09-08 11:58:14 +02:00 |
|
Dean Herbert
|
5c2fb3e434
|
Simplify calculation method
|
2022-09-08 18:22:53 +09:00 |
|
Dan Balasescu
|
b559d4ecdf
|
Rename GameplayAdjustments -> AdjustmentsFromMods
|
2022-09-08 17:14:06 +09:00 |
|
Dean Herbert
|
ed81297611
|
Fix playlist items showing download button briefly during initial local presence checks
|
2022-09-08 17:10:45 +09:00 |
|
Salman Ahmed
|
50923b6e5b
|
Move track assignment below
|
2022-09-08 00:25:55 +03:00 |
|
Acid Chicken (硫酸鶏)
|
267465df18
|
chore(osu.Game): combine Osu.Colour.{Draw,Text}ForHitResult into OsuColour.ForHitResult
|
2022-09-07 23:34:46 +09:00 |
|
Dean Herbert
|
e6b449fe0b
|
Fix case of zero rate calculating a zero true gameplay rate
|
2022-09-07 19:23:44 +09:00 |
|
Dean Herbert
|
fa15502384
|
Move full track adjustment flow inside MasterGameplayClockContainer
|
2022-09-07 19:12:16 +09:00 |
|
Dean Herbert
|
75d0deef72
|
Apply proposed changes to remove inheritance from MasterGameplayClockContainer
|
2022-09-07 17:49:05 +09:00 |
|
Dean Herbert
|
66c44f5913
|
Delegate interface to valid target
|
2022-09-06 22:26:46 +09:00 |
|
Dean Herbert
|
bc1212f4e6
|
Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method
|
2022-09-06 22:26:46 +09:00 |
|
Dean Herbert
|
266eb758aa
|
Use new flow to calcaulate TrueGameplayRate
|
2022-09-05 23:37:49 +09:00 |
|
Dean Herbert
|
7084aeee05
|
Add method flow to reset applied adjustments
|
2022-09-05 23:22:38 +09:00 |
|
Dean Herbert
|
e33486a766
|
Implement IAdjustableAudioComponent in MasterGameplayClockContainer
|
2022-09-05 23:20:02 +09:00 |
|
Mk-56spn
|
aace334fb3
|
Fix some test issues
|
2022-09-05 04:49:48 +02:00 |
|
Acid Chicken (硫酸鶏)
|
5f0832ead7
|
refactor(osu.Game): separate OsuColour.ForHitResult by usage
|
2022-09-05 01:58:57 +09:00 |
|
Mk-56spn
|
0c6d8efa28
|
Large code refactor, Implementation of shapes option drop down
|
2022-09-04 17:24:12 +02:00 |
|
Mk-56spn
|
51061c3a12
|
Bug fixing and parameter adjustments
|
2022-09-03 01:27:22 +02:00 |
|
Mk-56spn
|
534c40e18e
|
Initial version
|
2022-09-02 23:07:30 +02:00 |
|
Dean Herbert
|
bc5340e33a
|
Merge branch 'master' into fix_progress_bar_info
|
2022-09-02 18:00:35 +09:00 |
|
Dean Herbert
|
6a35b233e5
|
Merge branch 'master' into remove-dispose-updates
|
2022-09-01 23:03:19 +09:00 |
|
HiddenNode
|
4a630b5384
|
Implemented SizePreservingSpriteText
|
2022-08-31 22:05:06 +01:00 |
|
Dan Balasescu
|
c852c54055
|
Consume auto skip setting during play
|
2022-08-31 20:24:15 +09:00 |
|
Dan Balasescu
|
000412c50f
|
Merge pull request #20014 from peppy/fix-resume-skip-forward
Fix gameplay skipping forward during resume operation
|
2022-08-31 16:30:37 +09:00 |
|
Dan Balasescu
|
ccc08b816c
|
Merge pull request #20030 from peppy/notification-design-update
Update notification overlay design
|
2022-08-31 16:06:59 +09:00 |
|
Dean Herbert
|
7337d4c1aa
|
Merge branch 'master' into kps
|
2022-08-31 15:41:42 +09:00 |
|
Dean Herbert
|
51346e0154
|
Fix skip button getting stuck on screen for certain beatmaps
Closes #20034.
|
2022-08-31 13:22:51 +09:00 |
|
Dean Herbert
|
09aa3e065d
|
Move colouring to full icon content rather than background
|
2022-08-30 18:06:48 +09:00 |
|
Dean Herbert
|
27ad224f13
|
Remove probably unnecessary Seek on start
|
2022-08-30 01:21:44 +09:00 |
|
Dean Herbert
|
1bff540381
|
Remove debug changes
|
2022-08-29 22:14:07 +09:00 |
|
Dean Herbert
|
75531d2d62
|
Fix gameplay skipping forward during resume operation
|
2022-08-29 19:51:16 +09:00 |
|
Dean Herbert
|
105aa01e7d
|
Update usages of RemoveInternal
|
2022-08-29 15:57:40 +09:00 |
|
Dan Balasescu
|
cf6bb3b030
|
Merge pull request #19958 from peppy/fix-fail-freq-stuck
Ensure fail animation sequence isn't run after the player exit sequence has started
|
2022-08-27 00:58:41 +09:00 |
|
Dean Herbert
|
b9d9bf3004
|
Merge pull request #19938 from frenzibyte/fix-multi-spectator-results-screen
Fix multi-spectator potentially getting stuck for passed players
|
2022-08-26 21:53:17 +09:00 |
|
Dean Herbert
|
ed0843aa84
|
Reword xmldoc regarding final clock source to read better
|
2022-08-26 16:46:22 +09:00 |
|
Dean Herbert
|
2c780eab5f
|
Merge branch 'master' into fix_progress_bar_info
|
2022-08-26 16:14:21 +09:00 |
|
Dean Herbert
|
23efec6505
|
Fix naming and comment typos
|
2022-08-26 15:57:36 +09:00 |
|
Dean Herbert
|
9862b79b47
|
Fix typo in long comment
|
2022-08-26 15:20:09 +09:00 |
|
HiddenNode
|
d98357aa57
|
Made text inside SongProgressInfo scale.
|
2022-08-26 01:30:44 +01:00 |
|
Dean Herbert
|
a6ed589db4
|
Remove guard against RemoveFilters running more than once
It turns out this is required to remove some filters immediate, and some
later. Weird.
|
2022-08-25 14:47:33 +09:00 |
|
Dean Herbert
|
ad3dd1c700
|
Fix a couple of oversights regarding track nullability
|
2022-08-25 14:45:00 +09:00 |
|
Dean Herbert
|
ec60e16439
|
Apply NRT to FailAnimation
|
2022-08-25 14:35:42 +09:00 |
|
Dean Herbert
|
8f4a953d11
|
Ensure fail animation sequence isn't run after the player exit sequence has started
|
2022-08-25 14:26:42 +09:00 |
|
Dean Herbert
|
4c45f7d938
|
Ensure FailAnimation can't be Started after filters are already removed
|
2022-08-25 14:26:20 +09:00 |
|
Ryuki
|
5cddc7ed1f
|
Code cleanup (CPS)
|
2022-08-24 17:13:23 +02:00 |
|
Dean Herbert
|
f3847b90fd
|
Tidy up attach logic
|
2022-08-24 19:36:01 +09:00 |
|
Dean Herbert
|
5129716612
|
Merge branch 'master' into kps
|
2022-08-24 18:18:45 +09:00 |
|
Salman Ahmed
|
8f4a2b4936
|
Separate passed/failed states from calling EndGameplay
|
2022-08-24 10:36:13 +03:00 |
|
Dean Herbert
|
29fed0c4a3
|
Avoid setting the source clock until gameplay is ready to start
Without this change, the audio track may audibly seek during load
proceedings.
|
2022-08-23 18:34:17 +09:00 |
|
Dean Herbert
|
ec61a94dc9
|
Merge branch 'master' into no-gameplay-clock-gameplay-offset
|
2022-08-23 17:36:06 +09:00 |
|
HiddenNode
|
1098e24c40
|
Improved UprightUnscaledContainer
|
2022-08-22 14:24:52 +01:00 |
|
Dean Herbert
|
489e172a76
|
Simplify track start/stop/paused tracking
|
2022-08-22 19:43:18 +09:00 |
|
Dean Herbert
|
058d67f8e8
|
Merge pull request #19695 from naoei/ruleset-localization
Change most ruleset-accessible string types to Localisable strings
|
2022-08-22 16:13:23 +09:00 |
|
Dean Herbert
|
e6b669db8e
|
Elaborate with example of GameplayClockContainer managing its own Stop state
|
2022-08-22 14:14:44 +09:00 |
|
Dean Herbert
|
af2e82d7d5
|
Move operation of setting GameplayClockContainer.StartTime to Reset call
|
2022-08-22 14:11:06 +09:00 |
|
Ryuki
|
5cf54a788a
|
Code cleanup for CPS counter
|
2022-08-21 16:00:58 +02:00 |
|
Nao
|
189a407cb1
|
Merge branch 'master' into ruleset-localization
|
2022-08-20 21:39:10 -04:00 |
|
Dean Herbert
|
8566e93c72
|
Guard against SubmittingPlayer potentially getting stuck waiting on request forever
|
2022-08-20 17:19:17 +09:00 |
|
Dean Herbert
|
da407aa827
|
Merge branch 'master' into kps
|
2022-08-20 15:24:58 +09:00 |
|
Dean Herbert
|
7bf318541c
|
Reword comment to hopefully read better
|
2022-08-19 20:57:55 +09:00 |
|
Dean Herbert
|
3f0da14065
|
Delay start operation by one frame to allow children to see initial start time
|
2022-08-19 17:39:51 +09:00 |
|
Dean Herbert
|
3eb1cda6aa
|
Reorganise call order of Start / Reset to make more sense
|
2022-08-19 01:46:36 +09:00 |
|
Ryuki
|
3de35a1518
|
Update calculator and tests to match changes on clocks
|
2022-08-18 18:40:02 +02:00 |
|
Dean Herbert
|
1d774f3f12
|
Remove redundant ProcessFrame calls
Of note, I'm not sure whether the `IsPaused` check was meaningful, but
it's not reimplemented in the new `FramedBeatmapClock`.
|
2022-08-19 01:39:02 +09:00 |
|
Dean Herbert
|
7bc96431a7
|
Remove unnecessary virtual spec from GameplayClockContainer.Seek
|
2022-08-19 01:39:01 +09:00 |
|
Dean Herbert
|
43879633db
|
Ensure setting a StartTime on a GameplayClockContainer always resets to the new time
|
2022-08-18 18:54:10 +09:00 |
|
Dean Herbert
|
343efa1d11
|
Split OffsetCorrectionClock out of MasterGameplayClockContainer
|
2022-08-18 18:54:10 +09:00 |
|
Dean Herbert
|
2c6fd1ec6e
|
Fix `GameplayClockContainer potentially resetting external seeks
|
2022-08-18 18:54:10 +09:00 |
|
Dean Herbert
|
6003afafc7
|
Use FramedBeatmapClock in GameplayClockContainer
|
2022-08-18 18:54:10 +09:00 |
|
Dean Herbert
|
9735728cf6
|
Reverse conditionals to better define intent in addSourceClockAdjustments
|
2022-08-18 15:08:09 +09:00 |
|
Dean Herbert
|
20256aad11
|
Merge branch 'master' into no-gameplay-clock
|
2022-08-17 15:21:20 +09:00 |
|
Dean Herbert
|
63819648df
|
Fix up flow of actual skip operation
|
2022-08-16 14:40:02 +09:00 |
|
Dean Herbert
|
9a1a7bae89
|
Make test actually test things
|
2022-08-16 14:40:02 +09:00 |
|
Dean Herbert
|
6761f869f9
|
Modify flow to avoid weird bindable and value resetting
|
2022-08-16 14:17:35 +09:00 |
|
Dean Herbert
|
c9baadcf88
|
Merge branch 'master' into improve_retry_behaviour
|
2022-08-16 13:06:04 +09:00 |
|
Dean Herbert
|
61a8873266
|
Ensure GameplayClockContainer's FramedClock is always non-null
|
2022-08-15 20:22:36 +09:00 |
|
Dean Herbert
|
1696a905ba
|
Reduce exposed properties in GameplayClockContainer
|
2022-08-15 20:22:36 +09:00 |
|
Dean Herbert
|
704568ae3b
|
Remove remaining usage of GameplayClock
|
2022-08-15 20:22:36 +09:00 |
|
Dean Herbert
|
27569e2ed5
|
Remove FrameStableClock (and redirect usages to FrameStabilityContainer)
|
2022-08-15 19:19:19 +09:00 |
|
Dean Herbert
|
cc982d374c
|
Cache self rather than GameplayClock
|
2022-08-15 18:30:53 +09:00 |
|
Dean Herbert
|
c5f8529d20
|
Mark unused methods as NotImplemented for safety
|
2022-08-15 18:30:53 +09:00 |
|
Dean Herbert
|
f81c7644b4
|
Make GameplayClockContainer also an IGameplayClock and expose to remaining tests
|
2022-08-15 18:30:53 +09:00 |
|
Dean Herbert
|
c8764cb333
|
Move all usage of GameplayClock to IGameplayClock
|
2022-08-15 18:30:53 +09:00 |
|
Dean Herbert
|
6d78218142
|
Update usages of GameplayClockContainer.GameplayClock to access properties directly
|
2022-08-15 18:08:49 +09:00 |
|
Dean Herbert
|
224f3eaa84
|
Make GameplayClockContainer non-abstract and use in MultiSpectatorPlayer
|
2022-08-15 18:08:49 +09:00 |
|
Dean Herbert
|
623e90a7b2
|
Fix div-by-zero in SongProgress when no object duration could be calculated
|
2022-08-15 15:05:35 +09:00 |
|
Ryuki
|
2aa3a1b50d
|
Rename all "KeysPerSecond" usages to "ClicksPerSecond"
|
2022-08-14 20:12:11 +02:00 |
|
Ryuki
|
9dc806506e
|
Make ActionListener and KeysPerSecondCalculator not rely on events to add timestamps
|
2022-08-14 19:31:14 +02:00 |
|
Ryuki
|
d5f10cbb9d
|
Revert 787dee24 and initialize calculator in HUDOverlay
|
2022-08-14 18:53:00 +02:00 |
|
Ryuki
|
e08f71797e
|
Change displayed metric from "KPS" to "clicks/s"
|
2022-08-13 04:27:26 +02:00 |
|
Ryuki
|
9b252b1d81
|
Make KeysPerSecondCalculator dependency in HUDOverlay nullable
|
2022-08-11 11:58:30 +02:00 |
|
Ryuki
|
d29cba80e9
|
Remove useless comment in KeysPerSecondCounter
|
2022-08-11 11:01:16 +02:00 |
|
Ryuki
|
787dee249d
|
Move KeysPerSecondCalculator instantiation from HUDOverlay to Player
This prevents messing with *future* Skin (de)serialization
|
2022-08-11 10:37:16 +02:00 |
|
Ryuki
|
3c6461b9e4
|
Remove KPS acronym usage
|
2022-08-11 10:01:39 +02:00 |
|