1
0
mirror of https://github.com/ppy/osu.git synced 2024-10-01 15:17:31 +08:00
Commit Graph

9470 Commits

Author SHA1 Message Date
Terochi
672e1cd45b Variant 2: edit changes history, cannot reset index (similar to stable) 2022-11-21 09:41:29 +01:00
Terochi
8f942f130b Variant 1: edit changes history, empty text resets index 2022-11-21 09:36:31 +01:00
Andrei Zavatski
14a4de36f4 Expose thickness property 2022-11-21 10:20:35 +03:00
Dean Herbert
9a330c3cdb Apply nullability and clean up conditionals 2022-11-21 15:02:45 +09:00
Dean Herbert
a07b033d22
Merge branch 'master' into triangles-v2 2022-11-21 14:55:01 +09:00
Dean Herbert
dfa92b3de9
Merge pull request #21326 from bdach/fix-phantom-beatmap-sets
Fix phantom beatmap sets appearing on carousel after delete/update
2022-11-21 13:25:14 +09:00
Dean Herbert
d0ff5be7e6 Fix TestSceneTabletSettings falling off the bottom of the screen 2022-11-21 12:15:43 +09:00
Bartłomiej Dach
1269afd0c5
Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu
Hide scroll speed control from effects section on rulesets which don't support it
2022-11-20 16:17:55 +01:00
Salman Ahmed
793d5b117e Fix timing screen test scene not creating editor beatmap properly 2022-11-20 15:20:35 +03:00
Bartłomiej Dach
b3667821eb
Add failing test case 2022-11-20 10:07:32 +01:00
Andrei Zavatski
6f449a583e Handle empty values as a separate case 2022-11-19 23:27:48 +03:00
Terochi
eff6c7be64 Removed unnecessary methods, changed tests, and moved LimitedCapacityQueue.cs to a more generic namespace. 2022-11-19 16:53:35 +01:00
Bartłomiej Dach
c05c1625f2
Merge branch 'master' into editor-test-play-dont-retain-test-time 2022-11-19 12:09:04 +01:00
Dean Herbert
130f776427
Merge pull request #21267 from peppy/catch-file-enumeration-errors
Catch and gracefully handle file/directory enumeration failures during stable import
2022-11-19 15:38:40 +09:00
Salman Ahmed
ca67689a36 Fix intermittent present beatmap test failures 2022-11-19 07:44:43 +03:00
Bartłomiej Dach
d587f29351
Update tests to reflect desired behaviour 2022-11-18 21:03:30 +01:00
Salman Ahmed
8943819ee7 Add test coverage 2022-11-18 17:49:03 +03:00
Dean Herbert
b86b45b6d2 Fix excess string interpolation 2022-11-18 21:13:21 +09:00
Dawid Sośnia
9ad484a0f4
Merge branch 'ppy:master' into gameplay-leaderboard-fix 2022-11-18 12:11:22 +01:00
Dan Balasescu
9d33a6568e
Merge pull request #21292 from peppy/fix-binding-two-keys-single-binding
Fix being able to bind two non-modifier keys to the same binding
2022-11-18 16:19:38 +09:00
Dean Herbert
7c08cff297 Make new test more resilient to false passes 2022-11-18 16:10:32 +09:00
Dean Herbert
0a520c979e Update test to split out per-type tests 2022-11-18 16:03:40 +09:00
Salman Ahmed
e2aca8dc90 Suppress nullable warning for now 2022-11-18 09:46:50 +03:00
Dean Herbert
3faa7f5f74
Merge branch 'master' into gameplay-leaderboard-fix 2022-11-18 15:44:30 +09:00
Dean Herbert
cb8275ee75 Add failing test coverage to TestSceneKeyBindingPanel for multiple non-modifiers being bound 2022-11-18 15:34:41 +09:00
Dean Herbert
45f5849301 Add more test coverage to TestSceneKeyBindingPanel 2022-11-18 15:33:14 +09:00
Dan Balasescu
57b8495c7a Merge branch 'master' into long-standard 2022-11-18 14:24:04 +09:00
Salman Ahmed
82829867db Fix beatmap options test failure due to no beatmap being selected 2022-11-18 07:07:56 +03:00
Dean Herbert
1ff1738988
Merge pull request #21244 from nanashi-1/beatmapoptions-disabled
Disable certain beatmap option buttons when there are no beatmaps selected
2022-11-18 12:55:07 +09:00
Dawid Sośnia
0dbf491872
Merge branch 'master' into gameplay-leaderboard-fix 2022-11-17 22:06:51 +01:00
Piggey
53769479c7 oh oops 2022-11-17 21:42:15 +01:00
Piggey
eb8f6626ab revert changes from GameplayLeaderboard tests 2022-11-17 21:38:09 +01:00
Piggey
5e4ade3bee add tests 2022-11-17 13:28:04 +01:00
Dragon
a25c94d567 Replacing structure to use LimitedCapacityQueue.cs 2022-11-17 13:07:06 +01:00
Dragon
a9747d367c Cleaning up 2022-11-17 13:07:06 +01:00
Terochi
19dc31c7ae Changed tests. 2022-11-17 13:07:06 +01:00
Terochi
5253f5309e Added more tests for new features 2022-11-17 13:07:06 +01:00
Terochi
3d4962e181 Added functioning tests. 2022-11-17 13:07:06 +01:00
Terochi
a79af6671e Added SetUp for new tests. 2022-11-17 13:07:06 +01:00
Salman Ahmed
039ab83a46 Disable beatmap options button when none selected 2022-11-17 04:00:23 +03:00
Salman Ahmed
0e46614c57 Revert beatmap option button state changes 2022-11-17 03:57:01 +03:00
Andrei Zavatski
13cf3fc40c Make SpawnRatio public 2022-11-16 15:17:50 +03:00
Andrei Zavatski
bda32d71bf Change test scene name 2022-11-16 14:53:55 +03:00
Andrei Zavatski
d94c624ee4 Merge branch 'master' into triangles-v2 2022-11-16 14:53:32 +03:00
nanashi-1
46c7451ede remove redundant code 2022-11-16 09:57:23 +08:00
nanashi-1
9101ad0cbd fixed naming 2022-11-16 09:42:40 +08:00
nanashi-1
7aec5ca1e8 visual tests 2022-11-15 20:57:42 +08:00
Andrei Zavatski
333165e052 Add test scene for Triangles 2022-11-15 10:54:37 +03:00
Dean Herbert
308ed1abd1 Fix number of judgements shown potentially exceeding upper limit 2022-11-15 12:31:25 +09:00
Andrei Zavatski
81c9ea98e2 Implement TrianglesV2 component 2022-11-13 15:31:48 +03:00
maromalo
1911120afe
Merge branch 'master' into long-standard 2022-11-12 09:52:11 -03:00
Dean Herbert
dde09d409b Merge branch 'master' into chat-silences 2022-11-12 21:00:56 +09:00
Dean Herbert
8154eaafd8
Merge pull request #20991 from smoogipoo/websocket-chat-2
Receive chat messages via notification websocket
2022-11-12 18:18:39 +09:00
Bartłomiej Dach
b0314c67aa
Fix failing gameplay bindings test 2022-11-12 14:16:46 +09:00
Dean Herbert
19876ca0fb
Merge branch 'master' into websocket-chat-2 2022-11-11 23:53:42 +09:00
Dean Herbert
106f1cf90b Merge branch 'master' into combo-colour-brightness-limit 2022-11-11 18:24:39 +09:00
Dan Balasescu
db25e9e9c8 Merge branch 'master' into combo-colour-brightness-limit 2022-11-11 15:31:28 +09:00
Dan Balasescu
6ac19615fa Fix test failure 2022-11-11 14:55:41 +09:00
Bartłomiej Dach
63270c8619
Merge branch 'master' into improve-ui-control-sound-sync 2022-11-11 05:50:28 +01:00
Dean Herbert
3547c04002
Merge branch 'master' into skinnable-things-cleanup 2022-11-10 12:09:32 +09:00
Dan Balasescu
040d7ee247
Merge pull request #21183 from peppy/skinnable-nullability
Apply nullability considerations to all skin related classes
2022-11-10 11:50:41 +09:00
Joseph Madamba
2b81f3048c
Merge branch 'master' into close-side-overlays-when-main-overlay 2022-11-09 12:48:57 -08:00
Salman Ahmed
3909e5730e
Rename test steps
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2022-11-09 21:33:28 +03:00
C0D3 M4513R
a57c824092
Merge branch 'master' into beatmap-info 2022-11-09 14:47:08 +00:00
Dean Herbert
e19ba65f91 Remove LookupName from base ISkinComponentLookup 2022-11-09 17:46:43 +09:00
Dean Herbert
1aa0e40f2f Add "Component" prefix to lookup naming 2022-11-09 17:46:43 +09:00
Dean Herbert
e75c3b3f94 Rename SkinnableTarget to GlobalSkinLookup 2022-11-09 17:46:43 +09:00
Dean Herbert
c908969d9b Rename ISkinComponent to ISkinLookup 2022-11-09 17:46:43 +09:00
Dean Herbert
ab458320c4 Fix some lingering inspections 2022-11-09 17:46:24 +09:00
Dawid Sośnia
9549e55ef8
Merge branch 'ppy:master' into gameplay-leaderboard-fix 2022-11-08 20:04:13 +01:00
Piggey
9da57c66a2 add visual tests 2022-11-08 20:03:09 +01:00
Dean Herbert
b166e477c2
Merge branch 'master' into editor-background 2022-11-08 17:18:34 +09:00
Dean Herbert
4c15794694 Add test coverage of overlay interplay 2022-11-08 14:58:57 +09:00
maromalo
b7ef9b176d Make score type consistent 2022-11-06 19:59:27 -03:00
C0D3 M4513R
0c17571c58
Merge branch 'master' into beatmap-info 2022-11-06 18:53:14 +00:00
Dean Herbert
ee68f33e3c
Merge pull request #21109 from frenzibyte/fix-beatmap-duplicating-again
Fix beatmap cards still potentially showing twice in listing
2022-11-06 18:46:31 +09:00
Dean Herbert
e02c477008
Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks
Remove nullable disable in the checks.
2022-11-06 18:39:03 +09:00
Bartłomiej Dach
84179fb087
Merge branch 'master' into combo-colour-brightness-limit 2022-11-05 16:48:56 +01:00
andy840119
e862ba5e04 Fix the wrong AsNonNull() usage. 2022-11-05 20:13:50 +08:00
andy840119
6062641bf4 Mark mock track as nun-nullable because technically it should not accept the null track. 2022-11-05 16:17:20 +08:00
andy840119
5931e965c5 Mark background prams in the getMockWorkingBeatmap() as nun-nullable because technically it should not accept the null background. 2022-11-05 16:16:26 +08:00
Dan Balasescu
fa18b5f701 Construct notifications client inside ChannelManager 2022-11-04 18:51:00 +09:00
Dean Herbert
eb836269e7 Allow testing settings panel with interactivity by default 2022-11-04 18:50:17 +09:00
Dean Herbert
923d44a769 Update dependencies 2022-11-04 17:00:58 +09:00
Dean Herbert
566738494f
Merge pull request #20952 from OliBomby/bezier-convert
Add conversion algorithm for lazer slider curves to work with stable
2022-11-04 16:49:51 +09:00
Dean Herbert
dd5a3b2bf3 Add one more complex test 2022-11-04 16:49:21 +09:00
Joseph Madamba
e11d44d14f Add url clicking support to profile badges 2022-11-03 18:12:32 -07:00
Salman Ahmed
37b5f48911 Adjust test scene to cover failure 2022-11-04 03:23:33 +03:00
Dean Herbert
1edde8f73c Merge branch 'master' into disabled-button-sfx 2022-11-03 20:27:41 +09:00
Dean Herbert
cdb3494418
Merge pull request #20765 from Feodor0090/comment-report
Implement comments reporting
2022-11-03 20:09:00 +09:00
Dean Herbert
486515ed90
Merge pull request #20758 from frenzibyte/maintain-common-mod-selection
Maintain selection of common mods when switching rulesets
2022-11-03 20:08:32 +09:00
Jamie Taylor
f1c17129eb
Add support for 'disabled' sample variation to HoverClickSounds 2022-11-03 17:47:49 +09:00
C0D3 M4513R
2ec29c0f26
Merge branch 'master' into beatmap-info 2022-11-03 07:09:02 +00:00
Dean Herbert
c48c9ecb6d
Merge pull request #20743 from frenzibyte/improve-beatmap-card-buttons
Improve clickable area of beatmap card icon buttons
2022-11-03 15:47:08 +09:00
Dean Herbert
e6c45b8ab5 Merge branch 'master' into comment-report 2022-11-03 15:35:42 +09:00
Dean Herbert
20dd405c2b
Merge branch 'master' into maintain-common-mod-selection 2022-11-03 15:32:40 +09:00
Dean Herbert
fb0bc597a0 Merge branch 'master' into improve-beatmap-card-buttons 2022-11-03 13:53:29 +09:00
Dean Herbert
5f2f6b84b2 Add failing test coverage of automated skip scenarios 2022-11-03 13:52:27 +09:00
Dean Herbert
aef3c7918c Add total skip count to SkipOverlay 2022-11-03 13:52:24 +09:00
C0D3 M4513R
75b5025e12
Fix Skin Deserialisation Test 2022-11-02 16:37:48 +01:00
Dean Herbert
3ec9686e58 Fix test failures and rename configuration value to match better 2022-11-02 18:15:18 +09:00
Dean Herbert
0e502de8b4 Rename field to match usage 2022-11-02 18:04:42 +09:00
Dean Herbert
c3eb0c6330 Merge branch 'master' into editor-background 2022-11-02 17:43:38 +09:00
Dan Balasescu
063a8bdf9e Remove messages from silenced users 2022-11-02 17:13:14 +09:00
Dan Balasescu
f688ed12d0 Add test for removing chat messages 2022-11-02 17:00:47 +09:00
Dan Balasescu
695104a666 Fix TestSceneChatOverlay messages not being unique 2022-11-02 16:59:03 +09:00
Dean Herbert
2b04e852be
Merge branch 'master' into websocket-chat-2 2022-11-02 14:56:13 +09:00
Dan Balasescu
5b25ef5f2f Construct notifications client via IAPIProvider 2022-11-01 21:34:34 +09:00
Dean Herbert
29bc653d24 Remove incorrect double multiplication and add missing test coverage 2022-11-01 17:17:54 +09:00
Dean Herbert
d807d9d822 Add failing test covering snap calculations with SV applied 2022-11-01 16:22:48 +09:00
Dean Herbert
e8b7914295 Add test coverage of new parameter 2022-11-01 15:13:05 +09:00
Dean Herbert
2a88409dfe Fix time snap of sliders not matching when SV is not 1.0x
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.

Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.

The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
Dean Herbert
17f482bfc3
Merge branch 'master' into websocket-chat-2 2022-10-31 16:11:58 +09:00
Dean Herbert
e38ba5e4c6 Apply nullability to new test scene 2022-10-31 15:46:57 +09:00
Dean Herbert
31ba77e378 Merge branch 'master' into bezier-convert 2022-10-31 15:41:08 +09:00
Dean Herbert
8399261c77 Add failing test showing hold for menu not working when HUD is hidden 2022-10-30 21:38:31 +09:00
Dean Herbert
f5e11343c2 Apply nullability to HUD test scene 2022-10-30 21:25:31 +09:00
andy840119
c8c76f2351 Use AsNonNull() because the type does not accept the null case. 2022-10-30 17:03:54 +08:00
andy840119
500bf90a34 Mark as accept the nullable stream. 2022-10-30 17:03:54 +08:00
andy840119
6ce3841686 Remove nullable disable annotation in the test case. 2022-10-30 17:03:54 +08:00
Bartłomiej Dach
71d87489ab
Merge branch 'master' into safe-area-toggle 2022-10-29 13:19:44 +02:00
Dean Herbert
19e0b9085c Remove redundant parameters 2022-10-29 00:24:33 +09:00
Dan Balasescu
169bcc2654 Use polling connector in tests 2022-10-28 18:08:08 +09:00
Dean Herbert
f9d2c30c3e Add user toggle for application of safe areas 2022-10-28 14:05:45 +09:00
Bartłomiej Dach
f787da892b
Merge branch 'master' into grid-momentary-shortcuts 2022-10-26 21:30:24 +02:00
OliBomby
86d5fcc26d Added tests 2022-10-26 19:30:42 +02:00
cdwcgt
6991195d69
let editor dim different from gameplay dim 2022-10-26 15:22:57 +09:00
Dean Herbert
7249542167
Merge pull request #20912 from LittleEndu/carousel-do-not-select-random
Make beatmap carousel select nearest to selection when selection was filtered
2022-10-26 11:40:56 +09:00
Bartłomiej Dach
48057412f5
Merge branch 'master' into grid-momentary-shortcuts 2022-10-25 22:17:08 +02:00
Bartłomiej Dach
bcdf24b972
Merge branch 'master' into add-editor-object-clone 2022-10-25 21:33:52 +02:00
Bartłomiej Dach
3d31c9bbc5
Merge branch 'master' into beat-snap-divisor-hotkey 2022-10-25 20:32:32 +02:00
Dean Herbert
2b850694fa Merge branch 'allow-distance-grid-snap' into grid-momentary-shortcuts 2022-10-25 14:10:45 +09:00
Dean Herbert
8e4f5381e3 Add top level test coverage of editor shortcuts 2022-10-25 12:03:46 +09:00
Dean Herbert
1b42f5ec6e Add test coverage of BeatDivisorControl key bindings 2022-10-25 11:51:31 +09:00
Dean Herbert
4d4f6e25ba Rename to "clone" instead of "duplicate" 2022-10-25 11:43:23 +09:00
Dean Herbert
da74690ec9 Add test coverage of clone operations 2022-10-25 11:38:58 +09:00
Dan Balasescu
f6f30eec0b
Merge pull request #20810 from peppy/scoring-test-scene
Add test scene as environment to test changes to score algorithms
2022-10-25 11:19:00 +09:00
Endrik Tombak
b95091fbb0 Move test to improve diff readability 2022-10-24 22:55:09 +03:00
Endrik Tombak
9def12c60b Write new tests 2022-10-24 22:50:56 +03:00
Dean Herbert
f08270f6b0 Fix incorrect maxBaseScore accounting due to silly oversight 2022-10-24 15:54:09 +09:00
Dean Herbert
247cf589aa
Merge branch 'master' into directoryselector-hidden-toggle 2022-10-24 15:33:10 +09:00
Salman Ahmed
90a9961a69 Add visual test case for report button
Makes it much easier to test button/popover design changes
2022-10-22 02:50:59 +03:00
ansel
15aeb4a137 Display text in buttons flow instead of toast 2022-10-21 17:25:41 +03:00
Dean Herbert
bace3df4ca Update test assertions in line with change 2022-10-21 22:58:10 +09:00
Dan Balasescu
703a8afb11
Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks
Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself
2022-10-21 12:56:14 +09:00
ansel
81bdf716ef Change test 2022-10-20 19:56:00 +03:00
Dean Herbert
6b26547d03
Merge pull request #20835 from frenzibyte/improve-hide-mouse-on-keyboard
Improve automatic cursor hiding logic and limit to gameplay screen
2022-10-20 11:44:20 +09:00
Salman Ahmed
212f15e2d2 Update existing test cases 2022-10-20 04:06:33 +03:00
Dean Herbert
2f8a4fd2d0
Merge branch 'master' into remove-current-item 2022-10-20 10:02:09 +09:00
Dean Herbert
bea136ce50 Adjust test assert ordering to read better 2022-10-19 23:59:40 +09:00