Salman Alshamrani
e9868c6318
Enable exporting beatmaps in iOS
2024-12-09 07:47:28 -05:00
Bartłomiej Dach
459533aba6
Merge branch 'master' into bookmarks
2024-12-07 22:22:04 +09:00
Thomas Müller
0a00f7a7c2
Implement skinnable mod display
...
Also makes the mod display initialization sequence (start expanded, then
unexpand) controlled by HUDOverlay rather than mod display itself. This
enabled different treatment depending on whether the mod display is
viewed in the skin editor or in the player.
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-12-07 12:06:33 +09:00
Dean Herbert
5849a69a86
Merge pull request #30921 from huoyaoyuan/netcore-analyzer
...
Set up-to-date .NET code quality analyzers
2024-12-06 17:29:09 -08:00
Dean Herbert
8d0e1f9d18
Merge branch 'master' into improve-menu-sample-playback
2024-12-05 21:07:03 +09:00
Huo Yaoyuan
d92ea910cf
Merge branch 'master' into netcore-analyzer
2024-12-05 17:18:56 +08:00
Dean Herbert
791416c8f1
Merge pull request #30937 from frenzibyte/fix-quick-restart-not-saving-score
...
Fix score no longer being saved when quick-restarting after pass
2024-12-04 23:48:18 -08:00
Salman Alshamrani
a7586c52d0
Merge branch 'master' into results-screen-quick-retry-transition
2024-12-04 06:31:14 -05:00
Salman Alshamrani
fa87df6c6a
Move non-current handling to PerformExit
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-12-04 04:55:55 -05:00
Salman Alshamrani
8e0f6fc12d
Re-encode difficulties on resource change
2024-12-04 04:36:00 -05:00
Salman Alshamrani
60d91bada8
Merge branch 'master' into editor-multiple-background-audio-files
2024-12-04 04:31:15 -05:00
Dan Balasescu
ad4df82593
Improve multiplayer listing search by making it fuzzy
2024-12-04 16:26:36 +09:00
Dean Herbert
a4d58648e2
Fix quick retry transition from results screen
2024-12-04 14:31:39 +09:00
Bartłomiej Dach
d60b7f4798
Implement basic bookmark support in editor
2024-12-03 15:14:22 +01:00
Bartłomiej Dach
808934581f
Move bookmarks out of BeatmapInfo
...
Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473 ...
2024-12-03 14:17:14 +01:00
Dan Balasescu
be05f2a1c2
Merge pull request #30929 from timschumi/rate-change-ready
...
Account for rate changing mods when disabling the "Ready" button
2024-12-03 16:30:16 +09:00
Tim Schumacher
e920cfa187
Move rate-changing TODO to a common place in CalculateRateWithMods
2024-12-02 23:49:51 +01:00
Bartłomiej Dach
b505ecc7ba
Do not deselect objects when control-clicking without hitting anything
...
As per feedback in
https://discord.com/channels/90072389919997952/1259818301517725707/1310270647187935284 .
2024-12-02 13:51:43 +01:00
Bartłomiej Dach
6c0ccc5ebe
Merge pull request #30863 from frenzibyte/improve-back-button-display
...
Delay back button appearance when performing a quick restart
2024-12-02 11:49:45 +01:00
Bartłomiej Dach
52b8753a12
Merge pull request #30749 from Sheppsu/multi-spectator-settings-sidebar
...
Add player settings to multi spectator screen
2024-12-02 11:34:57 +01:00
Dean Herbert
5b2558cec2
Merge pull request #28473 from bdach/beatmap-info-purge
...
Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`
2024-12-02 16:19:12 +09:00
Dean Herbert
23522b02d8
Use local instead of field for local only usage
2024-12-01 19:53:57 +09:00
Dean Herbert
6afe083ec9
Fix settings showing up during gameplay
2024-12-01 18:44:26 +09:00
Dean Herbert
ddac71628d
Merge branch 'master' into multi-spectator-settings-sidebar
2024-12-01 18:33:46 +09:00
Salman Alshamrani
53dce83b56
Fix restarting no longer working from results screen
...
Thanks to tests for pointing that out :blobsweat:
2024-12-01 02:13:20 -05:00
Salman Alshamrani
9140893249
Fix score no longer being saved when quick-restarting after pass
2024-11-30 23:36:02 -05:00
Tim Schumacher
164b809c89
Document ready button enable state with some comments
2024-11-30 23:02:22 +01:00
Tim Schumacher
f4e155bfa6
Account for rate changing mods when disabling the "Ready" button
2024-11-30 16:01:32 +01:00
Huo Yaoyuan
fa3c95c296
Merge branch 'master'
2024-11-30 01:07:08 +08:00
Dean Herbert
f56b2b9aef
Merge pull request #30793 from bdach/close-playlists
...
Add ability to close playlists within grace period after creation
2024-11-29 22:37:32 +09:00
Dean Herbert
58efed4ebe
Merge pull request #30915 from bdach/extension-checks
...
Centralise supported file extensions to one helper class
2024-11-29 20:55:28 +09:00
Bartłomiej Dach
5f092811cb
Use helper in one more place
2024-11-29 09:22:29 +01:00
Bartłomiej Dach
5a9127dfc6
Accidentally a word
2024-11-29 08:46:08 +01:00
Bartłomiej Dach
110e4fbb30
Centralise supported file extensions to one helper class
...
As proposed in
https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837 .
2024-11-29 08:42:45 +01:00
Dean Herbert
b697ddc6db
Simplify the dev footer display
2024-11-29 15:32:35 +09:00
Salman Alshamrani
489d7a30ec
Perform a single Save call rather than doing it in each difficulty
2024-11-28 18:37:13 -05:00
Salman Alshamrani
311f0947e4
Abstractify resource change logic and share between background and audio
2024-11-28 17:57:47 -05:00
Salman Alshamrani
932afcde01
Make editor make sense
2024-11-28 17:43:32 -05:00
Jamie Taylor
58cf1c11e4
Improve menu/context-menu sample playback
2024-11-29 06:54:48 +09:00
Bartłomiej Dach
c93c549b05
Fix ready button not disabling on playlist close
2024-11-28 14:17:31 +01:00
Bartłomiej Dach
9926ffd326
Make button a little narrower
2024-11-28 14:06:12 +01:00
Bartłomiej Dach
ac2c4e81c7
Use switch
2024-11-28 14:04:39 +01:00
Bartłomiej Dach
2e6f43a75d
Merge branch 'master' into close-playlists
2024-11-28 14:01:36 +01:00
Huo Yaoyuan
f5a7716509
Apply minor performance rules
2024-11-28 20:41:44 +08:00
Bartłomiej Dach
d0e80ce982
Merge pull request #30895 from peppy/watch-replay-reliability
...
Fix watch replay button sometimes not loading the replay on first click
2024-11-28 13:16:40 +01:00
Dan Balasescu
1575eed5ba
Merge pull request #30893 from peppy/realm-perf-improvements
...
Improve realm update performance
2024-11-28 19:08:22 +09:00
Dan Balasescu
077719903b
Merge pull request #30905 from peppy/fix-multiple-offset-applications
...
Clear previous `LastLocalUserScore` when returning to song select
2024-11-28 18:58:13 +09:00
Dean Herbert
ced8dda1a2
Clear previous LastLocalUserScore when returning to song select
...
This seems like the lowest friction way of fixing
https://github.com/ppy/osu/issues/30885 .
We could also only null this on application, but this feels worse
because
- It would require local handling (potentially complex) in
`BeatmapOffsetControl` if we want to continue displaying the graph and
button after clicking it.
- It would make the session static very specific in usage and
potentially make future usage not possible due to being nulled in only
a very specific scenario.
One might argue that it would be nice to have this non-null until the
next play, but if such a usage comes up I'd propose we rename this
session static and add a new one with that purpose.
2024-11-28 18:01:28 +09:00
Bartłomiej Dach
0d491e3159
Merge branch 'master' into fix-daily-challenge-leaderboard
2024-11-28 09:41:24 +01:00
Dan Balasescu
5d7aafaab3
Merge pull request #30894 from HenintsoaSky/star-fountains-toggle-setting
...
Add a toggle for star fountains during gameplay
2024-11-28 17:35:11 +09:00
Salman Alshamrani
b1d0939142
Add localisation support
2024-11-28 02:37:31 -05:00
Salman Alshamrani
4a1401a33d
Rewrite bindable flow to make more sense
2024-11-28 02:37:27 -05:00
Dean Herbert
70eee8882a
Remove unnecessary null check
2024-11-28 15:42:37 +09:00
Dean Herbert
32b34c1967
Rename container to make more sense
2024-11-28 15:20:51 +09:00
Dean Herbert
4d9d5adbf4
Rename parameter to be more clear
2024-11-28 15:13:59 +09:00
Salman Alshamrani
f792b6de00
Fix comment
2024-11-27 06:07:10 -05:00
Salman Alshamrani
efb68e4232
Refactor ResourcesSection to support new form of selection
2024-11-27 05:53:22 -05:00
Salman Alshamrani
b70fb4b0fe
Add FormBeatmapFileSelector for intermediate user-choice step
2024-11-27 05:52:43 -05:00
Dean Herbert
0f73941808
Combine new implementation back into the old one and use everywhere
2024-11-27 17:47:42 +09:00
Dean Herbert
782ce24ca6
Move player settings out of right flow
2024-11-27 17:09:15 +09:00
Dean Herbert
9c707ed341
Rename class and fix padding considerations
2024-11-27 16:47:54 +09:00
Dean Herbert
5ce55e9cb4
Merge branch 'master' into multi-spectator-settings-sidebar
2024-11-27 16:35:05 +09:00
Dean Herbert
5260a401d4
Use RealmLive in SaveFailedScoreButton
...
This also optimises the manager classes to better support `Live` usage
where the managed object is already in a good state (ie. doesn't require
re-fetching).
2024-11-27 15:25:42 +09:00
Salman Alshamrani
dfbccc2144
Knock some sense into the playlists results screen implementation
...
As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint,
the existing playlists results screen classes needed some restructuring.
2024-11-27 01:20:43 -05:00
Dean Herbert
aa3d3a6344
Remove unnecessary local subscription in BeatmapCarousel
...
Not sure why I left this around during the refactor. This is 100%
handled by the `DetachedBeatmapStore`.
Removing this subscription reduces overheads by a huge amount for users
with large beatmap databases. My hypothesis is that subscriptions are
more expensive based on **the number of results matching**. This one
matches almost every beatmap so removing it is a large win.
2024-11-27 14:24:57 +09:00
HenintsoaSky
a477bb7bfe
Renaming of 'StarFountainEnabled'
2024-11-27 07:38:33 +03:00
Dean Herbert
573aaf6637
Merge pull request #27128 from frenzibyte/user-statistics-provider
...
Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset
2024-11-27 13:13:47 +09:00
Salman Alshamrani
9083daf363
Fix epic code failure
...
I wasn't feeling well last night.
2024-11-26 20:04:36 -05:00
Salman Alshamrani
3e1b4f4ac5
Rename AllowBackButton to AllowUserExit and rewrite visibility flow structure
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-11-26 16:52:39 -05:00
HenintsoaSky
80a66085a9
rename and remove again
2024-11-27 00:41:02 +03:00
HenintsoaSky
460471e73f
Rename of the setting
2024-11-27 00:27:22 +03:00
HenintsoaSky
df74a177ae
Add option to disable star fountain in gameplay
2024-11-27 00:13:32 +03:00
Joseph Madamba
9173a74552
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-26 12:13:08 -08:00
Bartłomiej Dach
33c2eb1af7
Merge pull request #30881 from peppy/fix-editor-state-leaking
...
Fix hitobjects' samples getting in bad state when changing selection between objects
2024-11-26 13:54:50 +01:00
Bartłomiej Dach
3e373ae85e
Merge pull request #30868 from peppy/ur-perf-fix
...
Improve performance of UR calculations
2024-11-26 13:54:17 +01:00
Dan Balasescu
4c7976bb93
Remove unused using
2024-11-26 21:11:48 +09:00
Dan Balasescu
af0c6fc51b
Add Room.HasEnded helper method
2024-11-26 21:09:28 +09:00
Bartłomiej Dach
cf905d0f5c
Merge branch 'master' into beatmap-info-purge
2024-11-26 10:21:16 +01:00
Dean Herbert
3ecb3b674d
Don't reset state when changing from one selection to another in the editor
...
This was causing state pollution in the new selection. I can't see why
this needs to happen when a selection changes to another.
This fixes https://github.com/ppy/osu/issues/30839 and also the same
issue happening for the new combo toggle.
Tests all seem to pass, and I can't immediately find anything broken,
but YMMV.
2024-11-26 17:33:41 +09:00
Dean Herbert
e3ea38a366
Add setting to allow hold-for-pause to still exist
...
Users have asked for this multiple times since last release.
Not sure on the best default value, but I'm going with the
stable/classic one, at least for the initial release to avoid needing
migrations.
In the future we may reconsider this for new users.
2024-11-26 15:14:19 +09:00
Salman Alshamrani
7201bac60d
Remove DailyChallengePlayer
2024-11-26 01:10:19 -05:00
Salman Alshamrani
c1416f9920
Bring back user-based endpoint for viewing result screen from playlists lounge
2024-11-26 01:10:12 -05:00
Salman Alshamrani
d150aeef2b
Use score-based endpoint everywhere
2024-11-26 01:01:59 -05:00
Salman Alshamrani
dfa21574fd
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-25 23:52:56 -05:00
Dean Herbert
bbe8f2ec44
Only update unstable rate counter when an applicable hitobject is reached
2024-11-25 21:13:18 +09:00
Dean Herbert
5668258182
Add incremental processing
2024-11-25 21:13:17 +09:00
Dean Herbert
33d725e889
Address unstable rate calculations as a list for marginal gains
2024-11-25 19:44:11 +09:00
Dean Herbert
605fe71f46
Make empty hitwindows readonly static and slightly improve comparison performance
2024-11-25 19:17:32 +09:00
Bartłomiej Dach
1410e8837a
Merge branch 'master' into better-room-status
2024-11-25 09:48:40 +01:00
Dean Herbert
82bdd8fbfc
Merge pull request #30861 from frenzibyte/fix-multiplayer-missing-hold-delay
...
Fix pause shortcut on multiplayer no longer requiring hold
2024-11-25 16:22:56 +09:00
Dean Herbert
876c2e468a
Merge pull request #30858 from frenzibyte/fix-match-settings-overlay-typo
2024-11-25 15:58:17 +09:00
Salman Alshamrani
1468385559
Reset new file states after syncing
2024-11-24 22:38:48 -05:00
tsrk.
cfaf972813
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-24 18:24:43 +01:00
Dean Herbert
c34827a4ed
Merge pull request #30862 from frenzibyte/dont-scare-the-player
...
Don't play fail animation if restarting on fail
2024-11-24 23:11:19 +09:00
tsrk.
8611ed31c2
refactor(MenuTip): add localisation support
...
Signed-off-by: tsrk. <tsrk@tsrk.me>
2024-11-24 14:22:56 +01:00
Dean Herbert
888f02e3a6
Merge pull request #30855 from SupDos/tips-remove-fps
...
Remove FPS shortcut tip
2024-11-24 19:57:08 +09:00
Salman Alshamrani
ae9119eef0
Hide back button when quick-restarting unless load time takes long
2024-11-24 05:40:06 -05:00
Salman Alshamrani
2420793466
Allow controlling back button visibility state from screens
2024-11-24 05:39:43 -05:00
Salman Alshamrani
6d0d7f3e75
Don't play fail animation if restarting on failure
2024-11-24 04:45:48 -05:00
Salman Alshamrani
f3155bfc7d
Fix pause shortcut on multiplayer not delayed
2024-11-24 04:24:31 -05:00
Salman Alshamrani
3480da22d2
Remove no-op SaveState call
2024-11-24 01:13:39 -05:00
Salman Alshamrani
95a6226413
Only enable button if there are different filenames
2024-11-24 01:11:36 -05:00
Salman Alshamrani
a872f74974
Make sync button only affect changed resource type
2024-11-24 01:02:34 -05:00
Salman Alshamrani
c8b13b726d
Add localisation support
2024-11-24 00:45:17 -05:00
Salman Alshamrani
e348b3a7aa
Only enable button if there are multiple difficulties
2024-11-24 00:34:03 -05:00
Salman Alshamrani
8e20dc7e9d
Add option to update all difficulties with new background/audio file
2024-11-24 00:32:50 -05:00
Salman Alshamrani
871c365fd8
Preserve existing beatmap background/audio files if used elsewhere
2024-11-24 00:32:27 -05:00
Salman Alshamrani
956da0383f
Merge branch 'master' into multiplayer-remove-expired-item-removal
2024-11-23 22:19:21 -05:00
Salman Alshamrani
8f5d513d46
Fix room auto start duration setting applied to the wrong component
2024-11-23 22:16:29 -05:00
Salman Alshamrani
6b78553559
Merge branch 'master' into tips-remove-fps
2024-11-23 20:57:14 -05:00
SupDos
2f096f71d3
Remove FPS shortcut tip
2024-11-24 02:34:30 +01:00
Salman Alshamrani
608bda135a
Merge branch 'master' into fix-song-ticker-contrast
2024-11-23 20:14:33 -05:00
Salman Alshamrani
2f45ebeec8
Remove using directive
2024-11-23 20:13:57 -05:00
Salman Alshamrani
eed02c2ab1
Fix daily challenge results screen beginning score fetch from user highest
2024-11-23 15:45:29 -05:00
Sheppsu
3713bb48b7
expand and contract settings from hover
2024-11-23 01:09:58 -05:00
Dean Herbert
ce41c000a1
Merge pull request #30812 from smoogipoo/playlist-populate-on-enter
...
Fix joining playlists room sometimes not selecting the first item
2024-11-22 23:57:45 +09:00
Dan Balasescu
5ebaab7e9a
Add localisation
2024-11-22 21:21:04 +09:00
Dan Balasescu
82a63228de
Improve handling of multiplayer room status
2024-11-22 21:21:04 +09:00
Dean Herbert
086a34f5c0
Merge branch 'master' into beatmap-info-purge
2024-11-22 18:47:32 +09:00
Dean Herbert
04ed954387
Fix song ticker having very bad contrast against bright backgrounds
...
Closes #30814 .
2024-11-22 18:17:55 +09:00
Bartłomiej Dach
cfc38df889
Add close button to playlists footer
2024-11-22 09:57:56 +01:00
Bartłomiej Dach
69c2c988a1
Add extra check to ensure closed rooms can't be closed harder
2024-11-22 09:54:56 +01:00
Dan Balasescu
e59ac9e7c8
No longer remove expired playlist items from Room model
2024-11-22 17:19:26 +09:00
Bartłomiej Dach
3b2f43012e
Merge branch 'master' into close-playlists
2024-11-22 09:02:41 +01:00
Bartłomiej Dach
479ff7eb41
Merge pull request #30799 from peppy/fix-player-loader-focus-fux
...
Fix beatmap load not continuing when when settings slider is focused
2024-11-22 08:57:10 +01:00
Bartłomiej Dach
512d2c6e3b
Merge branch 'master' into multiplayer-nrt
2024-11-22 08:09:42 +01:00
Dean Herbert
6a0ac4c29e
Merge pull request #29640 from smoogipoo/mania-imperfect-ss
...
Make mania award SS even if there are GREAT judgements
2024-11-22 14:42:32 +09:00
Dan Balasescu
f738fb2a89
Populate rooms as soon as they're joined
2024-11-21 23:48:04 +09:00
Dan Balasescu
84ac3097c2
Populate parameter description
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-11-21 22:47:46 +09:00
Dan Balasescu
cc59434ea4
Fix crash due to being too forgiving of nulls
...
This one is super duper annoying to test, because we already have e.g.
`TestScenePlaylistsScreen`. The only way to test it would be to use an
`OsuGameTestScene`.
Maybe this is okay?
2024-11-21 20:52:34 +09:00
Dan Balasescu
dc45816566
Fix inspection
2024-11-21 20:41:14 +09:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists
2024-11-21 20:32:09 +09:00
Dean Herbert
ae98f63b51
Fix beatmap load not continuing when when settings slider is focused
...
Regressed with recent sliderbar focus changes.
Closes #30716 .
2024-11-21 02:28:35 +09:00
Bartłomiej Dach
a679f0736e
Add ability to close playlists within grace period after creation
2024-11-20 12:36:12 +01:00
Fivoka
7726ca02b0
Changed multiplier from 2 to 3.5
2024-11-20 12:29:29 +01:00
Dean Herbert
6fba6de4dc
Merge branch 'master' into multiplayer-remove-cmc-and-composite
2024-11-20 17:24:55 +09:00
Dean Herbert
03de518484
Fix missing updateRoomPlaylist call
2024-11-20 16:56:22 +09:00
Dean Herbert
b070a50ac9
Merge pull request #30718 from frenzibyte/initial-key-counter-state
...
Fix key counter not updating activation state on initial load
2024-11-20 15:39:44 +09:00
Bartłomiej Dach
273095fd82
Merge pull request #30757 from peppy/fix-scroll-absolute-pos
...
Fix right click scroll at song select not quite matching scrollbar position
2024-11-19 10:40:00 +01:00
Dean Herbert
a2af4cbb50
Fix right click scroll at song select not quite matching scrollbar position
...
Closes https://github.com/ppy/osu/issues/30744 .
2024-11-18 23:54:56 +09:00
Bartłomiej Dach
259e9ecf65
Deactivate new combo toggle on deselecting objects
...
Closes https://github.com/ppy/osu/issues/30713 .
Was a point of discussion doing review:
https://github.com/ppy/osu/pull/30214#discussion_r1798833139
Given it got pointed out immediately for something so minor, I'm
inclined to believe it's a rather undesirable change.
2024-11-18 15:13:32 +01:00
Sheppsu
7d4062d2ad
remove redundant Scale attribute
2024-11-18 04:04:28 -05:00
Sheppsu
29e7adcd3b
add player settings to multi spectator screen
2024-11-18 03:57:50 -05:00
Salman Alshamrani
4a628287e2
Decouple game-wide ruleset bindable and refactor LocalUserStatisticsProvider
...
This also throws away the logic of updating
`API.LocalUser.Value.Statistics`. Components should rely on
`LocalUserStatisticsProvider` instead for proper behaviour and ability
to update on statistics updates.
2024-11-17 18:13:37 -05:00
Salman Alshamrani
b014bfea3e
Fix key counter not updating activation state on initial load
2024-11-17 09:56:19 -05:00
Joseph Madamba
465cc716d3
Add missing source query filter in song select
2024-11-15 22:53:23 -08:00
Dean Herbert
0a1f589c80
Fix black layer not fading fast enough when exiting quickly from quick restart
2024-11-16 11:52:02 +09:00
Bartłomiej Dach
21d407680b
Merge pull request #30623 from peppy/fix-flash-transition-player
...
Fix occasional flash when quick exiting / retrying from player
2024-11-15 08:42:43 +01:00
Dan Balasescu
1a656d0ec3
Remove CachedModelDependencyContainer usages from online play
2024-11-15 15:59:28 +09:00
Dan Balasescu
bfbae9458a
Remove OnlinePlayComposite
2024-11-15 15:59:28 +09:00
