1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-14 16:37:26 +08:00
Commit Graph

43962 Commits

Author SHA1 Message Date
Dean Herbert
885d832e98
Fix deserialise failing with some old skins 2024-08-23 20:44:45 +09:00
Dean Herbert
1e39af8ac5
Add a bit of logging around medal awarding
Might help with https://github.com/ppy/osu/issues/29119.
2024-08-23 19:49:24 +09:00
Dean Herbert
2a479a84dc
Remove conditional inhibiting seek when beatmap change is not allowed
In testing I can't find a reason for this to exist. Blaming back shows
that it existed before we had `AllowTrackControl` and was likely being
used as a stop-gap measure to achieve the same thing. It's existed since
over 6 years ago.

Let's give removing it a try to fix some usability concerns?

Closes https://github.com/ppy/osu/issues/29563.
2024-08-23 18:21:31 +09:00
Dean Herbert
60271fb0f7
Merge pull request #29564 from peppy/skinnable-components-what-2
Remove requirement of `base` calls to ensure user skin container layouts are retrieved
2024-08-23 17:52:46 +09:00
Dean Herbert
48cfd77ee8
Component -> Lookup 2024-08-23 14:48:50 +09:00
OliBomby
2de5ecceb8 Merge remote-tracking branch 'upstream/master' into scroll-speed-std 2024-08-22 20:17:14 +02:00
OliBomby
ad8e7f1897 Fix scroll speed visualisation missing on start kiai effect points
They were being drawn far offscreen because the width of the kiai multiplied with the X coordinate of the scroll speed vis.
2024-08-22 20:17:09 +02:00
OliBomby
998b5fdc12 Add property EditorShowScrollSpeed to Ruleset 2024-08-22 19:53:34 +02:00
OliBomby
adbdb39e9f move public member to top of file 2024-08-22 19:18:38 +02:00
OliBomby
0db068e423 allow repeating on seek actions 2024-08-22 19:15:53 +02:00
Bartłomiej Dach
bd6943ebc2
Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu
Allow copying beatmap link in song select carousel context menu
2024-08-22 14:03:39 +02:00
Dean Herbert
46d55d5e61
Remove remaining early base lookup calls which were missed 2024-08-22 20:13:28 +09:00
Bartłomiej Dach
b3e961f6c5
Merge pull request #29562 from peppy/remove-migration-leftover-message
Remove "leftover files" notification when migration partly fails
2024-08-22 12:32:44 +02:00
Dean Herbert
58552e9768
Add missing user ruleset to link copying for beatmap panels 2024-08-22 19:18:41 +09:00
Dean Herbert
1435fe24ae
Remove requirement of base calls to ensure user skin container layouts are retrieved 2024-08-22 19:14:30 +09:00
Bartłomiej Dach
a32a817305
Merge pull request #29512 from peppy/toolbar-pp-change-weird
Fix toolbar PP change showing `+0` instead of `0`
2024-08-22 12:08:12 +02:00
Dean Herbert
b57b8168a6
Rename Target lookup to Component 2024-08-22 19:00:28 +09:00
Dean Herbert
9a21174582
Move GlobalSkinnableContainers to global scope 2024-08-22 18:46:07 +09:00
Dean Herbert
36b4013fa6
Rename GameplaySkinComponentLookup -> SkinComponentLookup 2024-08-22 18:46:03 +09:00
Dean Herbert
f37cab0c6e
Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup 2024-08-22 18:39:36 +09:00
Bartłomiej Dach
1859e173f2
Fix EVEN MORE code quality inspections! 2024-08-22 11:16:24 +02:00
Bartłomiej Dach
9997271a6a
Fix more code quality inspections 2024-08-22 10:49:24 +02:00
Dean Herbert
41756520b1
Rename SkinComponentsContainer to SkinnableContainer 2024-08-22 17:42:50 +09:00
Bartłomiej Dach
9020739f36
Remove unused using directives 2024-08-22 10:05:45 +02:00
Dean Herbert
67f0ea5d7d
Fix flooring causing delta to not work as expected 2024-08-22 16:22:00 +09:00
Dean Herbert
b3be04aff1
Remove "leftover files" notification when migration partly fails
People were deleting files they shouldn't, causing osu! to lose track of
where the real user files are.

For now let's just keep things simple and not let the users know that
some files got left behind. Usually the files which are left behind are
minimal and it should be fine to leave this up to the user.

Closes https://github.com/ppy/osu/issues/29505.
2024-08-22 16:09:11 +09:00
Bartłomiej Dach
df94c22a29
Merge pull request #29545 from peppy/timeline-redesign-in-circles
Further timeline usability tweaks
2024-08-22 08:39:34 +02:00
Dean Herbert
7e483bbee3
Merge pull request #29541 from frenzibyte/fix-mod-customisation-dragging-outside
Keep mod customisation panel open when dragging outside
2024-08-22 15:28:32 +09:00
Bartłomiej Dach
d33f4837fa
Merge pull request #29532 from bdach/redesign-timing-table-tracking
Redesign timing table tracking
2024-08-22 08:21:39 +02:00
Dean Herbert
066c34e950
Merge pull request #29553 from bdach/local-cache-updates
Add support for retrieving submit/rank date from local metadata cache in version 2
2024-08-22 14:55:43 +09:00
Dean Herbert
9df12e3d87
Move seek button to left to differentiate mutating operations 2024-08-22 14:15:36 +09:00
Dean Herbert
54e5f1c9f0
Merge pull request #29556 from frenzibyte/kiai-star-bursts
Add star fountains/bursts when entering kiai mode in gameplay
2024-08-22 14:14:25 +09:00
Dean Herbert
f068b7a521
Move copy-to-url method to OsuGame to centralise toast popup support 2024-08-22 14:03:41 +09:00
Dean Herbert
7f5f3a4589
Fix mod icons potentially showing incorrectly at daily challenge intro
Prefer using the beatmap's rulesets over the current user selection.

Closes https://github.com/ppy/osu/issues/29559.
2024-08-22 13:57:19 +09:00
Salman Ahmed
922814fab3 Fix flag reset on connection dropouts 2024-08-22 06:00:37 +09:00
Salman Ahmed
1efa6b7221 Merge if branches 2024-08-22 05:40:43 +09:00
Salman Ahmed
fc02b4b942 Alter NRT usage 2024-08-22 05:39:57 +09:00
Dean Herbert
ac5a3a0959
Remove one unused parameter 2024-08-22 02:17:11 +09:00
Dean Herbert
87123d99bf
Move URL implementation to extension methods and share with other usages 2024-08-22 02:08:01 +09:00
Dean Herbert
18a3ab2ffd
Use "link" instead of "URL" 2024-08-22 01:45:43 +09:00
Dean Herbert
a943000579
Merge pull request #29435 from OliBomby/improve-snaps
Fix timeline snapping ignoring nearby timing points
2024-08-22 01:36:30 +09:00
Dean Herbert
fb5fb78fd3
Move zero marker below control points to avoid common overlap scenario 2024-08-22 01:09:22 +09:00
Dean Herbert
843b10ef34
Add back incorrectly removed control point display toggle 2024-08-22 01:05:47 +09:00
Dean Herbert
2876cb73bd
Merge pull request #28991 from Layendan/master
Add collection and favourite buttons to results screen
2024-08-21 23:59:26 +09:00
Bartłomiej Dach
5f88435d96
Add support for retrieving submit/rank date from local metadata cache in version 2
Closes https://github.com/ppy/osu/issues/22416.
2024-08-21 15:42:22 +02:00
OliBomby
423feadd64 Revert "add arrow indicator"
This reverts commit 1ce9e97fd4.
2024-08-21 14:12:58 +02:00
Bartłomiej Dach
28d0a24555
Fix the fix
The more proper way to do this would be to address the underlying issue,
which is https://github.com/ppy/osu/issues/29546, but let's do this
locally for now.
2024-08-21 12:27:56 +02:00
OliBomby
eefd7cf083 add back protection against perfect curve segments with > 3 points 2024-08-21 12:03:15 +02:00
Salman Ahmed
c92af71029 Add in-gameplay version of kiai star fountains/burst 2024-08-21 17:34:38 +09:00
jkh675
3d5b57454e Fix null reference 2024-08-21 16:21:49 +08:00
Dean Herbert
fef56cc29e
Remove expanding behaviour of timeline completely 2024-08-21 16:57:52 +09:00
Dean Herbert
7e6490133d
Adjust visuals of tick display (and fine tune some other timeline elements) 2024-08-21 16:46:14 +09:00
Dean Herbert
1a48a6f654
Reduce size of hit objects on timeline 2024-08-21 16:46:13 +09:00
Dean Herbert
3065f808a7
Simplify timing point display on timeline 2024-08-21 16:46:13 +09:00
Dean Herbert
a0002943a1
Adjust centre marker visuals a bit 2024-08-21 16:46:12 +09:00
Bartłomiej Dach
c4f08b42ab
Use colours to distinguish buttons better 2024-08-21 09:05:33 +02:00
OliBomby
8d72ec8bd6 move timing point binary search back inline 2024-08-21 01:50:52 +02:00
OliBomby
1ce9e97fd4 add arrow indicator 2024-08-20 23:38:38 +02:00
OliBomby
ae6d855f8d Merge remote-tracking branch 'upstream/master' into doubleclick 2024-08-20 23:19:27 +02:00
Salman Ahmed
637c9aeef0 Add DailyChallengeIntroPlayed session static 2024-08-21 03:37:04 +09:00
Salman Ahmed
b7599dd1f8 Keep mod customisation panel open when dragging a drawable 2024-08-21 03:23:23 +09:00
Salman Ahmed
0d358a1dae Fix resume overlay appearing behind HUD/skip overlays 2024-08-21 02:53:11 +09:00
jkh675
8e273709f1 Implement copy url in beatmap and beatmap set carousel 2024-08-20 22:48:11 +08:00
Dan Balasescu
5bb94000d3
Merge pull request #29534 from bdach/fix-divisor-crash
Fix crash on attempting to edit particular beatmaps
2024-08-20 22:06:32 +09:00
Dan Balasescu
44213a34ae
Merge pull request #29508 from peppy/hold-for-menu-sometimes
Change "hold for menu" button to only show for touch by default
2024-08-20 21:45:50 +09:00
Bartłomiej Dach
c2dd2ad978
Clamp beat divisor to sane range when decoding
In my view this is a nice change, but do note that on its own it does
nothing to fix https://github.com/ppy/osu/issues/29492, because of
`BeatmapInfo` reference management foibles when opening the editor. See
also: https://github.com/ppy/osu/issues/20883#issuecomment-1288149271,
https://github.com/ppy/osu/pull/28473.
2024-08-20 13:52:29 +02:00
Bartłomiej Dach
bb964e32fa
Fix crash on attempting to edit particular beatmaps
Closes https://github.com/ppy/osu/issues/29492.

I'm not immediately sure why this happened, but some old locally
modified beatmaps in my local realm database have a `BeatDivisor` of 0
stored, which is then passed to
`BindableBeatDivisor.SetArbitraryDivisor()`, which then blows up.

To stop this from happening, just refuse to use values outside of a sane
range.
2024-08-20 13:51:58 +02:00
Bartłomiej Dach
c9f1ef5361
Fix incorrect bank set / sample addition logic
Closes https://github.com/ppy/osu/issues/29361.

Typical case of a few early-returns gone wrong leading to `NodeSamples`
not being checked correctly.
2024-08-20 12:37:01 +02:00
Dean Herbert
a633fcdb49
Merge branch 'master' into redesign-timing-table-tracking 2024-08-20 19:16:03 +09:00
Bartłomiej Dach
f0ddb6daa4
Merge pull request #29445 from OliBomby/transparent-break
Make break periods in bottom timeline transparent
2024-08-20 11:46:02 +02:00
Bartłomiej Dach
a33294ac42
Redesign timing table tracking
- On entering the screen, the timing point active at the current instant
  of the map is selected. This is the *only* time where the selected
  point is changed automatically for the user.

- The ongoing automatic tracking of the relevant point after the initial
  selection is *gone*. Even knowing the fact that it was supposed to
  track the supposedly relevant "last selected type" of control point,
  I always found the tracking to be fairly arbitrary in how it works.
  Removing this behaviour also incidentally fixes
  https://github.com/ppy/osu/issues/23147.

  In its stead, to indicate which timing groups are having an effect,
  they receive an indicator line on the left (coloured using the
  relevant control points' representing colours), as well as a slight
  highlight effect.

- If there is no control point selected, the table will autoscroll to
  the latest timing group, unless the user manually scrolled the table
  before.

- If the selected control point changes, the table will autoscroll to
  the newly selected point, *regardless* of whether the user manually
  scrolled the table before.

- A new button is added which permits the user to select the latest
  timing group. As per the point above, this will autoscroll the user
  to that group at the same time.
2024-08-20 11:14:42 +02:00
Dean Herbert
bccc797bcb
Move break display to background of summary timeline 2024-08-20 17:45:44 +09:00
Bartłomiej Dach
373ff47a94
Remove dead row attribute classes
These aren't shown on the control point table since difficulty and
sample control points were moved into objects.
2024-08-20 09:53:40 +02:00
Layendan
59ba48bc81 Fix crash if favourite button api request fails 2024-08-19 07:58:20 -07:00
Bartłomiej Dach
7693d4c039
Merge branch 'master' into master 2024-08-19 14:30:20 +02:00
Dean Herbert
610ebc5481
Fix toolbar PP change showing +0 instead of 0 2024-08-19 20:50:11 +09:00
Dean Herbert
6985e2e657
Increase default visibility on touch platforms 2024-08-19 20:32:05 +09:00
Dean Herbert
005b1038a3
Change "hold for menu" button to only show for touch by default 2024-08-19 20:23:25 +09:00
Bartłomiej Dach
24a0a3c47f
Merge pull request #29476 from EVAST9919/buffered-editor-grid
Improve draw performance of editor grids
2024-08-19 12:44:08 +02:00
Dan Balasescu
03188e40ee
Merge pull request #29504 from peppy/skin-editor-fix-sidebar-reload
Fix skin editor components sidebar not reloading when changing skins
2024-08-19 18:13:52 +09:00
Dan Balasescu
c18f7a239c
Merge pull request #29474 from peppy/fix-legacy-combo-counter-animation-dead
Fix legacy combo counter bounce animation not always playing
2024-08-19 18:09:57 +09:00
Dean Herbert
1bd2f4c6a2
Fix skin editor components sidebar not reloading when changing skins
Closes https://github.com/ppy/osu/issues/29098.
2024-08-19 15:45:18 +09:00
Dean Herbert
4a3f4c3a55
Don't duck music when effect volume is set to zero
Addresses https://github.com/ppy/osu/discussions/28984.
2024-08-19 14:46:50 +09:00
Dean Herbert
e75ae4a37b
More hardening of TestMultiplayerClient to attempt to fix test failures 2024-08-19 04:04:24 +09:00
Joseph Madamba
6dd08e9a96 Fix beatmap carousel panels not blocking hover of other panels in song select 2024-08-17 11:45:54 -07:00
Andrei Zavatski
3cd5820b5b Make PositionSnapGrid a BufferedContainer 2024-08-17 10:34:39 +03:00
Dean Herbert
04a2d67ca4
Fix legacy combo counter bounce animation not always playing
As mentioned [in
discord](https://discord.com/channels/188630481301012481/1097318920991559880/1274231995261649006).
2024-08-17 15:13:44 +09:00
Andrei Zavatski
f74263db81 Remove extra box in OnlinePlayBackgroundScreen 2024-08-17 01:01:51 +03:00
Dean Herbert
d1d195cf18
Fix incorrect skin lookup shortcutting causing sprites to no longer work 2024-08-17 02:33:52 +09:00
OliBomby
621c4d65a3 Hide scroll speed in effect row attribute 2024-08-16 14:43:33 +02:00
OliBomby
b253d8ecbf Hide scroll speed in bottom timeline 2024-08-16 14:43:09 +02:00
OliBomby
a2e26ba9ff Fix perfect curve anchors losing type between reloads 2024-08-16 14:24:55 +02:00
OliBomby
4cc38cea63 fix last anchor converting to implicit segment 2024-08-16 14:24:03 +02:00
OliBomby
5624c1d304 Make break periods in bottom timeline transparent 2024-08-16 13:22:09 +02:00
OliBomby
e5fab9cfbe Remove select action to end placement 2024-08-16 11:55:07 +02:00
Joseph Madamba
e2bf02cf94 Fix preview play button having incorrect click area 2024-08-15 22:49:12 -07:00
Joseph Madamba
fda17a5a72 Expose BeatmapCardNormal height const 2024-08-15 22:49:12 -07:00
OliBomby
3565a10ea2 fix confusing return statement at the end 2024-08-16 01:45:28 +02:00
OliBomby
3a84409546 Use TimingPointAfter for seeking check 2024-08-16 01:36:51 +02:00
OliBomby
2e11172e8e Take into account next timing point when snapping time 2024-08-16 01:01:24 +02:00
OliBomby
ac064e814f Add BinarySearchUtils 2024-08-16 00:15:40 +02:00
Joseph Madamba
c3600467bf Make collection button test less broken 2024-08-15 11:49:15 -07:00
Dan Balasescu
52c1858bbe
Merge pull request #29428 from peppy/update-editor-menu-items-difficulty-change
Ensure the "Change Difficulty" menu uses up-to-date difficulty names
2024-08-16 00:44:59 +09:00
Dean Herbert
5710f0f302
Merge pull request #26254 from frenzibyte/mania-combo-counter
Add argon/classic osu!mania combo counter
2024-08-15 17:56:28 +09:00
Dean Herbert
b5f615882f
Ensure the "Change Difficulty" menu uses up-to-date difficulty names
Closes https://github.com/ppy/osu/issues/29391.
2024-08-15 17:25:30 +09:00
Dean Herbert
4b279ecaa8
Fix mistake 2024-08-15 16:44:15 +09:00
Dean Herbert
26da2c0637
Update MultiplayerClient test output with new knowledge 2024-08-15 16:16:48 +09:00
Dean Herbert
9dc496d6a7
Merge pull request #29415 from Joehuu/difficulty-name-content
Implement song select v2 difficulty name content component
2024-08-15 15:20:52 +09:00
Salman Ahmed
3a4546d62d Remove x symbol from argon mania combo counter 2024-08-15 15:08:35 +09:00
Dean Herbert
054366b25d
Use zero baseline for legacy sprite text display 2024-08-15 13:07:42 +09:00
Dan Balasescu
8bfb5cedc4
Merge pull request #29406 from peppy/fix-skin-change-crash
Fix crash on changing skins when classic mod is enabled and game is rewound
2024-08-15 01:04:32 +09:00
Dean Herbert
28ab65243d
Remove daily challenge tooltip from main menu
Now that we have a nice intro screen for the daily challenge, it's
generally thought that we want to "spoil" the beatmap until the intro is
shown.

Also I was never a huge fan of having a tooltip on a main menu button..
just feels a bit odd.
2024-08-14 20:45:27 +09:00
Dean Herbert
58d9a4adba
Merge pull request #29414 from smoogipoo/fix-daily-challenge-2
Add localisation for daily challenge day/week units
2024-08-14 18:45:12 +09:00
Joseph Madamba
11bd0c9a61 Inline single-frame layout issue comment instead 2024-08-14 00:41:43 -07:00
Joseph Madamba
c24f1444f9 Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent 2024-08-13 23:26:18 -07:00
Joseph Madamba
2b41f71fd0 Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers 2024-08-13 23:26:17 -07:00
Joseph Madamba
625c6fc7eb Implement song select v2 difficulty name content component 2024-08-13 23:26:17 -07:00
Dean Herbert
e465049050
Merge branch 'master' into mania-combo-counter 2024-08-14 15:12:00 +09:00
Dan Balasescu
f882ad4a53
Add localisation for daily challenge day/week units 2024-08-14 15:10:55 +09:00
Dean Herbert
78ef436ea0
Update test debug output to test second scenario 2024-08-14 12:23:47 +09:00
Dean Herbert
2221c4891f
Remove legacy non-pooled pathway to DrawableJudgement 2024-08-13 21:03:00 +09:00
Dean Herbert
bb0c9e2497
Add log output when judgements aren't being pooled 2024-08-13 20:57:23 +09:00
Dean Herbert
d74ac57092
Never call prepareDrawables from unsafe context
I can't mentally figure out *what* is causing the issue here, but in the
case where `prepareDrawables` is called from
`JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario),
things go very wrong.

I think a smell test is enough for anyone to agree that the flow was
very bad. Removing this call doesn't seem to cause any issues.

`runAnimation` should always be called in `PrepareForUse` (both pooled
and non-pooled scenarios) so things should still always be in a correct
state.

Closes #29398.
2024-08-13 20:57:20 +09:00
Salman Ahmed
c9b2a5bb9c Fix user profile overlay colour resetting when changing rulesets 2024-08-13 13:03:31 +03:00
Dan Balasescu
513a666847
Merge pull request #29401 from CloneWith/patch/wiki-locale
Automatically use in-game language for wiki pages
2024-08-13 17:18:29 +09:00
Dan Balasescu
3f02869bcc
Enable NRT while we're here 2024-08-13 16:08:06 +09:00
Dan Balasescu
4b4f0ecf7d
Merge pull request #29342 from cl8n/remove-mania-action-special
Remove "Special" `ManiaAction`s for center columns
2024-08-13 15:36:36 +09:00
Dan Balasescu
cd76f474d8
Merge pull request #29388 from cl8n/fix-mania-replay
Fix error on parsing osu!mania replays with 18 or more keys
2024-08-13 15:29:53 +09:00
CloneWith
ca91726190
Reload wiki page on language change 2024-08-13 13:34:11 +08:00
CloneWith
64468bce6d
Merge github.com:ppy/osu into patch/wiki-locale 2024-08-13 11:51:14 +08:00
CloneWith
7cbb4ab6f1
Get in-game locale for wiki pages 2024-08-13 11:50:33 +08:00
Dean Herbert
16f6e26c2e
Merge pull request #29372 from ArijanJ/song-progress-optional-time
Add option to hide song progress time/text
2024-08-13 00:57:15 +09:00
Dean Herbert
b567ab2a39
Fix context menus sometimes not being clickable at song select
Closes https://github.com/ppy/osu/issues/21602.
2024-08-12 20:31:20 +09:00
Bartłomiej Dach
92bd123ebc
Merge pull request #29363 from peppy/fix-daily-challenge-notification-spam
Fix daily challenge notification spam
2024-08-12 12:18:38 +02:00
Bartłomiej Dach
96bd374b18
Change notification interval to 30 minutes 2024-08-12 11:24:59 +02:00
Bartłomiej Dach
54a1d79136
Clean up some naming weirdness 2024-08-12 11:23:36 +02:00
Bartłomiej Dach
041c70e4eb
Fix tests 2024-08-12 11:19:02 +02:00
Bartłomiej Dach
306e84c7ac
Move disposal method to more expected location 2024-08-12 10:46:58 +02:00
clayton
9620c58751
Fix mouseX legacy replay parsing for high key counts in mania 2024-08-11 09:45:43 -07:00
ArijanJ
fed5b9d747
Fix one more inspectcode warning 2024-08-10 09:45:30 +02:00
ArijanJ
d01e76d9db
Fix double blank line 2024-08-09 23:08:22 +02:00
ArijanJ
2dee8bef7e
Add option to hide song progress time/text 2024-08-09 22:50:37 +02:00
Dean Herbert
df43263e38
Merge branch 'master' into daily-challenge-intro-sfx 2024-08-10 02:22:48 +09:00
Dean Herbert
c29b40ae65
Update resources 2024-08-10 02:08:02 +09:00
Dean Herbert
81777f22b4
Update framework 2024-08-10 00:11:39 +09:00
Jamie Taylor
c6fa348d82
Add sound design for daily challenge intro animation 2024-08-09 23:05:33 +09:00
Dean Herbert
3896a081a5
Update framework 2024-08-09 22:50:56 +09:00
Dean Herbert
bb7cea2417
Merge pull request #29346 from peppy/move-mute-button
Move mute button to master volume circle
2024-08-09 21:16:47 +09:00
Dan Balasescu
179a3ad8dd
Hack around the border looking ugly
This is an o!f issue because borders are applied into the individual
sprites of the container via masking, rather than being isolated to the
container itself. In this case, it'll be applied to the "flash" sprite,
which is using additive blending, causing further issues.
2024-08-09 19:55:57 +09:00
Dean Herbert
fa9a835eb5
Make icon smaller 2024-08-09 19:29:23 +09:00
Dan Balasescu
104942ccf6
Merge pull request #29362 from peppy/dont-truncate-floating-point-positioning
Fix hit object coordinates being truncated to `int` values
2024-08-09 19:10:24 +09:00
Dan Balasescu
dc3e6c1e6b
Merge pull request #29366 from peppy/editor-inspector-during-placement
Show object inspector values during placement
2024-08-09 19:03:10 +09:00
Dean Herbert
3e634a14a4
Add temporary debug code for multiplayer test failures 2024-08-09 18:43:37 +09:00
Dean Herbert
8fdd94090b
Show object inspector values during placement 2024-08-09 18:02:37 +09:00
Dean Herbert
f6ada68e47
Fix migration failure due to change in class name 2024-08-09 17:27:39 +09:00
Dean Herbert
e146c8e230
Ensure only one daily challenge notification is fired per room 2024-08-09 17:11:11 +09:00
Dean Herbert
52b2d73e04
Only show daily challenge notification if it started within the last 30 minutes 2024-08-09 17:10:18 +09:00
Dean Herbert
d072c6a743
Fix hit object coordinates being truncated to int values
Closes https://github.com/ppy/osu/issues/29340.
2024-08-09 16:34:39 +09:00
Dean Herbert
161734af95
Simplify argon mania combo counter implementation by sharing with base counter 2024-08-09 15:46:57 +09:00
Dean Herbert
7666e8b932
Remove SupportsClosestAnchor for the time being
This may have had a good reason to be added, but I can't find that
reason, so let's keep things simple for the time being.
2024-08-09 15:30:21 +09:00
Dean Herbert
80c814008f
Update in line with new changes 2024-08-09 14:55:01 +09:00
Dean Herbert
e645651ef4
Merge branch 'master' into mania-combo-counter 2024-08-09 00:19:17 +09:00
Dean Herbert
0cb3b6a1f8
Add back TrySetDailyChallengeBeatmap call for safety 2024-08-08 22:10:26 +09:00
Dean Herbert
8eb0ef1e33
Merge branch 'master' into daily-challenge-intro-audio-auto-download 2024-08-08 22:09:21 +09:00
Dean Herbert
d84d0310e0
Move mute button to master volume circle 2024-08-08 22:06:13 +09:00
Dan Balasescu
45c1dfde5e
Merge pull request #29349 from peppy/fix-daily-challenge-async-test-woo
Fix potential test failure in daily challenge tests
2024-08-08 19:05:39 +09:00
Dean Herbert
dcafee7cb7
Merge pull request #26249 from frenzibyte/ruleset-specific-combo-counter
Move combo counter to ruleset-specific HUD components container
2024-08-08 17:41:58 +09:00
Dean Herbert
03d543ec99
Fix potential test failure in daily challenge tests
See https://github.com/ppy/osu/actions/runs/10296877688/job/28500580680.
2024-08-08 16:53:22 +09:00
Dean Herbert
88c5997cb3
Add back removed xmldoc 2024-08-08 16:36:54 +09:00
Dean Herbert
60d383448f
Avoid making non-ruleset transformers in Ruleset.CreateSkinTransformer
This didn't make any sense, so let's do it a better way.
2024-08-08 16:29:54 +09:00
Dean Herbert
3f3145e109
Start playing music during intro if download finishes early 2024-08-08 15:10:18 +09:00
Dean Herbert
5d66eda982
Add support for automatically downloading daily challenge during the intro display 2024-08-08 15:10:18 +09:00
Dean Herbert
e95d61d4c2
Remove accidental double handling of beatmap availability in DailyChallenge 2024-08-08 15:10:18 +09:00
Dean Herbert
f91a3e9a35
Start playing daily challenge track as part of intro sequence 2024-08-08 15:10:17 +09:00
Dean Herbert
5891780427
Show initial text a bit longer 2024-08-08 14:15:40 +09:00
Dean Herbert
7058fedf42
Merge branch 'master' into daily-challenge-intro-screen-part-2 2024-08-08 14:12:16 +09:00
Dean Herbert
1ee5522a25
Merge branch 'master' into daily-challenge-intro-screen-part-2 2024-08-08 14:08:14 +09:00
Dean Herbert
25dddb694a
And then completely change the animation to a new style 2024-08-08 14:02:43 +09:00
Dean Herbert
f72f5ee7e3
More improvements maybe 2024-08-08 13:29:10 +09:00
Dean Herbert
9bafdeeeff
Improve animation 2024-08-08 13:17:25 +09:00
clayton
8e63c17536
Apply CodeFactor lint 2024-08-07 15:02:53 -07:00
clayton
93e193d719
Add realm migration to remap key bindings 2024-08-07 14:36:04 -07:00
Dean Herbert
3c572abaa7
Merge branch 'master' into ruleset-specific-combo-counter 2024-08-08 03:21:52 +09:00
Dean Herbert
8773c2f7eb
Merge pull request #29281 from kstefanowicz/multiplayer-chat-focus-hint
Add "enter" hint to in-gameplay chatbox placeholder text
2024-08-08 01:29:42 +09:00
Dan Balasescu
089ff559d3
Fix inspection 2024-08-08 00:42:31 +09:00
Dan Balasescu
a06cb9a0de
Merge pull request #29322 from peppy/daily-challenge-import-improvement
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu
2024-08-08 00:42:03 +09:00
Dan Balasescu
10f704cc41
Fix xmldoc 2024-08-07 23:50:09 +09:00
Dean Herbert
cfd7f96e76
Add missing exit line causing completely incorrect behaviour 2024-08-07 23:29:24 +09:00
Bartłomiej Dach
f83d43c38b
Get rid of weird method 2024-08-07 14:07:20 +02:00
Bartłomiej Dach
e6d5389608
Merge branch 'master' into hover-open-mod-customise 2024-08-07 14:05:19 +02:00
Bartłomiej Dach
518c1aa5a0
Remove weird Expanded / ExpandedState duality 2024-08-07 14:01:30 +02:00
kstefanowicz
775f76f472 Have placeholder text change while focused 2024-08-07 07:47:35 -04:00
Bartłomiej Dach
437812eebe
Merge pull request #29279 from normalid-awa/bugfix/editor/delete-operation-wont-close-the-menu
Close context menus when deselecting items in editor
2024-08-07 13:25:13 +02:00
Dean Herbert
e52d80a41b
Add more difficulty information and further tweaks to visuals 2024-08-07 19:08:04 +09:00
Dean Herbert
083fe32d20
Improve feel of animation 2024-08-07 19:07:45 +09:00
Salman Ahmed
a0615a8f18
Frenzi's WIP animation 2024-08-07 19:07:45 +09:00
Dean Herbert
cfccd74441
Add daily challenge intro sequence 2024-08-07 19:07:44 +09:00
Dean Herbert
6870311c1e
Remove requirement of specifying animateOnnter in BackgroundScreen ctor 2024-08-07 19:07:44 +09:00
Dean Herbert
3c05b975a0
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu 2024-08-07 19:07:43 +09:00
Dean Herbert
43f1fe350d
Fix PresentBeatmap sometimes favouring an already DeletePending beatmap 2024-08-07 19:07:43 +09:00