1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 12:22:55 +08:00
Commit Graph

3468 Commits

Author SHA1 Message Date
Dean Herbert
fa263b91a7 Attempt to fix tests 2019-06-21 00:12:39 +09:00
Dean Herbert
f2200594c9 Remove necessity for MusicController to be always visible 2019-06-20 23:40:25 +09:00
Dean Herbert
52ca5f9c00 Fix mod icons in ModSelect being loaded in a blocking fashion 2019-06-20 23:06:07 +09:00
Dean Herbert
74fabf8db4 Improve ChatOverlay load behaviour 2019-06-20 23:02:02 +09:00
Dean Herbert
4a25a84975 Fix DrawableChannel async flow 2019-06-20 23:01:39 +09:00
Dean Herbert
4ef165fdac Fix ChatLine not being correctly loaded asynchronously 2019-06-20 23:01:02 +09:00
Dean Herbert
21a1fd738b Remove the necessity for NotificationOverlay to always be present
Now it will only become present when there is a pending notification.
2019-06-20 19:06:21 +09:00
Dean Herbert
9a663715cd Make get methods of ProgressNotification return correct values immediately
Previously they were only updated after the resultant schedule ran. This would not bode well when the overlay containing them is not present.
2019-06-20 19:05:33 +09:00
Dean Herbert
6bc2cf85d1 Move NotificationSection strings to constructor 2019-06-20 17:41:12 +09:00
Dean Herbert
97d65783db Remove osu!-side DebugUtils 2019-06-20 12:48:45 +09:00
Dean Herbert
7482ecb8e7
Fix beatmap set cover goes out of its container (#5073)
Fix beatmap set cover goes out of its container
2019-06-20 11:21:22 +09:00
Andrei Zavatski
0da8a483c5 Fix scores header is visible even if no scores are loaded 2019-06-19 23:14:53 +03:00
iiSaLMaN
ee2268caba
Enable masking for the beatmap set cover 2019-06-19 21:20:00 +03:00
KingLuigi4932
5f5441c692 Add ShowPlaceholderOnNull in updateable flag + do not show placeholders in some overlays 2019-06-19 20:17:02 +03:00
iiSaLMaN
865af00ab6
Merge branch 'master' into header-improvements 2019-06-19 20:00:28 +03:00
Dean Herbert
08cf8dd299 Adjust for readability 2019-06-20 01:39:54 +09:00
Dean Herbert
2773cfba42
Merge branch 'master' into andy840119/_20190614_hidden_nod_label_when_empty 2019-06-20 01:35:24 +09:00
KingLuigi4932
9f25d3cd72 More changes and improvements 2019-06-19 17:55:36 +03:00
iiSaLMaN
3e285e5dde
Separate beatmap info container from details (avoid overlapping) 2019-06-19 17:47:47 +03:00
iiSaLMaN
15229f3a23
Make header expandable 2019-06-19 17:45:39 +03:00
iiSaLMaN
5fb4f2fadf
Add TOP_PADDING 2019-06-19 17:38:43 +03:00
KingLuigi4932
a6c268ef5c Move the horizontal margin into the sprite text itself 2019-06-19 15:05:53 +03:00
KingLuigi4932
475b40cc02 Remove empty line 2019-06-19 14:47:29 +03:00
KingLuigi4932
4600336581 Use TextFlowContainer + small changes 2019-06-19 14:43:18 +03:00
Andrei Zavatski
17749e84f9 Merge remote-tracking branch 'refs/remotes/ppy/master' into user-online-fix 2019-06-19 12:17:31 +03:00
Andrei Zavatski
1c44fa84fb Fix colour issues 2019-06-19 12:15:32 +03:00
Andrei Zavatski
c8604b2c17 Merge remote-tracking branch 'refs/remotes/ppy/master' into useroverlay-tabs 2019-06-19 12:08:34 +03:00
KingLuigi4932
6e28294182 Fix another test 2019-06-19 04:27:31 +03:00
KingLuigi4932
3876442143 More simplifies + fix test 2019-06-19 03:37:08 +03:00
KingLuigi4932
a0609f28d7 Revert some changes + simplify BeatmapNotAvailable 2019-06-19 01:43:28 +03:00
iiSaLMaN
5278c5f365
Merge branch 'master' into not-available-to-download 2019-06-19 01:14:32 +03:00
Andrei Zavatski
2fb1052a1e Add missing space 2019-06-18 21:04:36 +03:00
Dean Herbert
d65c20bbdc
Merge branch 'master' into generic-download-model-manager 2019-06-19 01:29:06 +09:00
Andrei Zavatski
03d560ed41 Initial implementation 2019-06-18 19:13:21 +03:00
Andrei Zavatski
3c3757f12e Make ProfileTabControl based on OverlayTabControl 2019-06-18 16:23:57 +03:00
Andrei Zavatski
a7306248d1 Implement OverlayTabControl class
An abstraction for OverlayHeaderTabControl
2019-06-18 16:20:35 +03:00
Dean Herbert
6823ba1ab0 Unbind from previous bindable when rebinding a SettingsItem 2019-06-18 14:24:44 +09:00
Andrei Zavatski
413c2158e2 Simplify bindables usage 2019-06-18 01:11:05 +03:00
Andrei Zavatski
c95e3da3ec Implement a BindableRulesetSelector 2019-06-18 00:23:00 +03:00
Andrei Zavatski
cecbcd21b2 Merge remote-tracking branch 'upstream/master' into toolbar-rulesets-refactor 2019-06-17 23:12:55 +03:00
KingLuigi4932
d6a39b8a2a Fix CI issues + slight change 2019-06-17 22:33:27 +03:00
KingLuigi4932
fec0db8fe1 Merge UpdateableAvatar.cs and Avatar.cs + Rename Avatar to DrawableAvatar 2019-06-17 21:55:07 +03:00
KingLuigi4932
d665f1fe4b Seperate drawable and updateable flag from Country + Use UpdateableFlag 2019-06-17 20:57:57 +03:00
KingLuigi4932
794ba17a2f Seperate UpdateableRank from DrawableRank and use it 2019-06-17 20:04:09 +03:00
andy840119
4e85481fd4 Merge branch 'master' of https://github.com/ppy/osu into andy840119/_20190614_hidden_nod_label_when_empty 2019-06-16 13:27:15 +09:00
andy840119
84b4e877f8 using FadeTo instead of show/hide
headerLabel.FadeTo() is still remain because effect can be visible when expand== true
2019-06-16 13:27:01 +09:00
Dean Herbert
4882283084
Merge branch 'master' into generic-download-model-manager 2019-06-15 15:35:08 +09:00
andy840119
1a73178260 using FadeTo() instead of FadeIn()/FadeOut() 2019-06-15 13:28:03 +08:00
Dean Herbert
587edcb716
Merge branch 'master' into fix-beatmapoverlay-graphs 2019-06-15 13:42:13 +09:00
Dean Herbert
1b75fbed9a Merge remote-tracking branch 'upstream/master' into update-scrollcontainer 2019-06-14 23:25:17 +09:00
Dean Herbert
bc574520bf Update ScrollContainer usages in line with framework changes 2019-06-14 15:55:32 +09:00
Dean Herbert
15b9b53d35 Fix IconButtons not being scaled correctly 2019-06-14 13:40:32 +09:00
為什麼
9114c8dee7 remve unnecessary effect. 2019-06-14 11:44:03 +08:00
為什麼
0db9816321 expanded -> expand 2019-06-14 11:23:41 +08:00
為什麼
c30e467717 oops 2019-06-14 11:12:30 +08:00
andy840119
3a14794c43 use show/hide instead because FillFlowContainer's spacing 2019-06-14 01:43:20 +09:00
andy840119
4f0aff3d9c hide label when mod is empty 2019-06-14 01:12:56 +09:00
KingLuigi4932
155f7c7e03 Use OsuTextFlowContainer for multi-lines 2019-06-13 17:32:27 +03:00
smoogipoo
39f9deea96 Add success rate test scene 2019-06-13 18:44:00 +09:00
smoogipoo
6b615d763a Fix potential nullref 2019-06-13 18:43:51 +09:00
smoogipoo
f2b5f274cf Add details test scene + fix metrics not getting updated correctly 2019-06-13 18:31:39 +09:00
smoogipoo
7af2d650cd Fix potential nullref 2019-06-13 18:31:12 +09:00
smoogipoo
dd7335079f Fix beatmap set overlay not showing ratings 2019-06-13 17:01:57 +09:00
smoogipoo
0a79b444d9 Move metrics to beatmap set 2019-06-13 16:52:49 +09:00
EVAST9919
e5a6d920cd Implement an abstract RulesetSelector class 2019-06-12 23:23:01 +03:00
EVAST9919
8d8615773c Fix selection is being possible even in disabled state 2019-06-12 20:54:19 +03:00
EVAST9919
3150b5cfb4 Naming adjustments 2019-06-12 20:51:21 +03:00
KingLuigi4932
1a50544c94 Add tests for undownloadable / parts-removed beatmapsets 2019-06-12 20:42:52 +03:00
EVAST9919
065b4cd055 Merge remote-tracking branch 'refs/remotes/ppy/master' into toolbar-rulesets-refactor 2019-06-12 20:35:51 +03:00
naoey
7ba676ad31
Rename Info to Model 2019-06-12 21:56:36 +05:30
KingLuigi4932
744f32ab35 Fix little bug 2019-06-12 19:11:05 +03:00
KingLuigi4932
c5c6f6b9e0 Allow for not refetching in ShowBeatmapSet (will be used for tests) 2019-06-12 18:36:47 +03:00
KingLuigi4932
a069a3029e Make DownloadButton accessible by DirectPanel 2019-06-12 18:07:57 +03:00
KingLuigi4932
efd9766fb3 Make Header accessible by BeatmapSetOverlay 2019-06-12 17:37:34 +03:00
naoey
951a5abccc
Merge remote-tracking branch 'upstream/master' into generic-download-model-manager 2019-06-12 17:41:16 +05:30
Dean Herbert
021d0273f9
Split out user activity from user status (#4619)
Split out user activity from user status

Co-authored-by: Dean Herbert <pe@ppy.sh>
2019-06-12 20:14:03 +09:00
Dean Herbert
b2b3df3885 Merge remote-tracking branch 'upstream/master' into settings-footer-show-changelog-current-build 2019-06-12 18:28:43 +09:00
Dean Herbert
f358fce9ab Move activity (writable) bindable to APIAccess so it correctly transfers between users 2019-06-12 18:04:57 +09:00
smoogipoo
243cd517ad Merge remote-tracking branch 'origin/master' into backgrounded-beatmap-status-lookups
# Conflicts:
#	osu.Game.Tests/Visual/SongSelect/TestScenePlaySongSelect.cs
2019-06-12 17:24:16 +09:00
smoogipoo
28f8b04765 Merge remote-tracking branch 'origin/master' into backgrounded-beatmap-status-lookups 2019-06-12 16:47:56 +09:00
Dean Herbert
a9c229b1ec Merge remote-tracking branch 'upstream/master' into user-status-wiring 2019-06-12 16:00:35 +09:00
Dean Herbert
94e65a3244 Fix settings checkboxes not being searchable 2019-06-12 15:16:59 +09:00
Dean Herbert
c591a6f1fa Rename request type to be less verbose 2019-06-12 13:30:23 +09:00
Dean Herbert
b29b1bf254
Merge branch 'master' into mod-grow-improvement 2019-06-12 13:18:02 +09:00
naoey
ba6546038c
Make ModelInfo and abstract class constructor protected
- Implementing classes would be better off exposing it if necessary under a different name
2019-06-12 00:55:43 +05:30
naoey
7495bc5d3a
Post merge and inverted condition fix 2019-06-12 00:42:05 +05:30
naoey
27ac06e9de
Merge branch 'generic-download-model-manager' into generic-download-tracking-composite 2019-06-12 00:07:44 +05:30
naoey
fe76fa9d75
Merge remote-tracking branch 'upstream/master' into generic-download-model-manager 2019-06-12 00:03:43 +05:30
naoey
ab27d82cd5
Make beatmap download buttons inherit BeatmapDownloadTrackingComposite
- Move DownloadTrackingComposite into the online namespace
2019-06-11 23:01:01 +05:30
naoey
06a558c4b7
Remove unecessary third generic and change usages to match 2019-06-11 21:11:30 +05:30
Dean Herbert
606be3d7ce
Merge branch 'master' into backgrounded-beatmap-status-lookups 2019-06-12 00:22:47 +09:00
Dean Herbert
a690a67a6c
Merge branch 'master' into fullscreen-overlay-surface 2019-06-12 00:07:30 +09:00
naoey
341d137f5c
Make BeatmapManager inherit from new base class 2019-06-11 19:36:08 +05:30
Dean Herbert
00ee45fe46 Merge remote-tracking branch 'origin/update-visibility-container' into update-framework 2019-06-11 19:36:13 +09:00
iiSaLMaN
1c6a81e2aa
Merge branch 'master' into not-available-to-download 2019-06-11 12:32:46 +03:00
KingLuigi4932
130ff56886 Move logic into BeatmapNotAvailable 2019-06-11 12:29:42 +03:00
smoogipoo
a9758ba813 Merge remote-tracking branch 'origin/master' into fix-checkbox-overlap 2019-06-11 18:26:42 +09:00
Arphox
07e17518e9 Fix all "Maintainability" CodeFactor issues 2019-06-11 10:28:16 +02:00
Dean Herbert
8de62b608e Allow FullscreenOverlay to surface to front on subsequent Show requests 2019-06-11 15:22:27 +09:00
Dean Herbert
609a82bc94 Update VisibilityContainer usage in line with framework 2019-06-11 15:13:58 +09:00
Lucas A
141775d98c Merge remote-tracking branch 'upstream/master' into user-status-wiring 2019-06-10 21:41:00 +02:00
iiSaLMaN
94a7794ff7
Fix issue 2019-06-10 21:54:33 +03:00
iiSaLMaN
ae284d1127
Merge branch 'master' into not-available-to-download 2019-06-10 21:39:32 +03:00
KingLuigi4932
75716af25e Forgot to return 2019-06-10 21:14:12 +03:00
KingLuigi4932
70fdd4ba5b Disable download button + Fix AppVeyor Errors 2019-06-10 21:13:37 +03:00
KingLuigi4932
3202110b80 Add a container for Beatmap Availability 2019-06-10 20:17:44 +03:00
Lucas A
2e911d0e96 Merge remote-tracking branch 'upstream/master' into settings-footer-show-changelog-current-build 2019-06-10 19:13:54 +02:00
KingLuigi4932
adbf4d374e Redirecting ShowBeatmapSet to FetchAndShowBeatmapSet 2019-06-10 14:15:49 +03:00
Dean Herbert
fc0fc8f164
Merge branch 'master' into backgrounded-beatmap-status-lookups 2019-06-10 19:37:35 +09:00
EVAST9919
27163c9996 Fix crashes in some cases
When we want to switch ruleset from outside of the selector, but it's
blocked (multiplayer is a good example)
2019-06-10 09:18:48 +03:00
smoogipoo
f090e292c9 Move ArchiveModelManager import process to async flow 2019-06-10 13:42:22 +09:00
EVAST9919
ec8c09dd39 Fix unability to mannualy switch ruleset 2019-06-10 04:36:34 +03:00
EVAST9919
9b8540d818 Add a testcase 2019-06-10 03:35:00 +03:00
EVAST9919
d86e3d0c4c Merge remote-tracking branch 'refs/remotes/ppy/master' into toolbar-rulesets-refactor 2019-06-09 18:06:24 +03:00
iiSaLMaN
3979dab573
Merge branch 'master' into rename-f-to-d 2019-06-09 16:04:26 +03:00
Shane Woolcock
807d434be0 Access WindowModes via IBindableList 2019-06-09 17:52:02 +09:30
Dean Herbert
d500f3605e Fix checkboxes with long labels overlapping nub 2019-06-09 16:48:03 +09:00
Dean Herbert
126d168527 Merge remote-tracking branch 'upstream/master' into mod-grow-improvement 2019-06-09 16:29:01 +09:00
Ganendra Afrasya
49193a2703 Rename the setting label 2019-06-09 13:12:41 +07:00
Ganendra Afrasya
afc3a08953 Use existing setting instead
Now it read IncreaseFirstObjectVisibility bindable instead
2019-06-09 13:11:40 +07:00
iiSaLMaN
dfbc652803
Use ScoreRank.D instead of F 2019-06-08 19:32:26 +03:00
EVAST9919
62eadf21c9 Remove useless line 2019-06-08 18:38:52 +03:00
EVAST9919
06dfa42a5a Refactor 2019-06-08 18:27:40 +03:00
EVAST9919
d1d3cfa991 Remove ruleset selector from the user overlay 2019-06-08 11:55:52 +03:00
EVAST9919
ea492772cf Merge remote-tracking branch 'refs/remotes/ppy/master' into user_profile_modes 2019-06-08 11:31:28 +03:00
Lucas A
e8c73f3127 Make APIChangelogEntry.Major a non-nullable property 2019-06-08 09:45:34 +02:00
Lucas A
342e39776a Move ChangelogEntries populating logic from constructor to BDL load() to use OsuColour palette +apply review suggestions. 2019-06-07 20:59:56 +02:00
Ganendra Afrasya
f326264a85 Adding increase first object grow mod visibility setting 2019-06-08 00:42:57 +07:00
Lucas A
e5b64bfa39 Highlight major changes in changelog overlay 2019-06-07 18:51:43 +02:00
Dan Balasescu
6a06ea2aee
Merge branch 'master' into ruleset_fix 2019-06-07 20:36:29 +09:00
Dan Balasescu
b6896b31c9
Merge branch 'master' into fix-paginated-layout 2019-06-07 20:19:14 +09:00
Dean Herbert
8f30c9b0a3 Fix file layout of ModSelectOverlay 2019-06-07 15:58:24 +09:00
Dean Herbert
7ffc08b187
Merge branch 'master' into master 2019-06-07 15:34:14 +09:00
Dean Herbert
b914bb1e2e Remove key hints for now
A proper design for this will come in the future.
2019-06-07 15:32:48 +09:00
Dean Herbert
0ce5c7468f Use switch and consume/block input 2019-06-07 15:31:23 +09:00
Dean Herbert
2531250f89 Fix paginated layouts only showing one column even if enough space is available for more 2019-06-07 14:58:04 +09:00
EVAST9919
210437042f Remove useless update calls in ToolbarRulesetSelector 2019-06-07 02:39:36 +03:00
EVAST9919
923f9fb6cd Naming adjustments 2019-06-07 01:43:26 +03:00
EVAST9919
2a303748e3 Merge remote-tracking branch 'refs/remotes/ppy/master' into user_profile_modes 2019-06-07 01:23:10 +03:00
smoogipoo
90966b113b Merge remote-tracking branch 'origin/master' into ftb-prepass 2019-06-06 20:32:38 +09:00
smoogipoo
4d035afcc6 Add setting to bypass front-to-back 2019-06-06 16:49:42 +09:00
Welsar55
c04c6693c2 Change close action from PopOut to Hide and switched to TriangleButton.Click() 2019-06-05 13:01:21 -05:00
Lucas A
a2bc5b538e Merge remote-tracking branch 'upstream/master' into user-status-wiring 2019-06-05 16:59:38 +02:00
EVAST9919
e20a899265 remove excessive null check 2019-06-04 21:46:43 +03:00
EVAST9919
05aeb66973 Fix possible crash due to null user or playmode 2019-06-04 20:20:07 +03:00
EVAST9919
e9403bf2f7 Move GamemodeControl to UserProfileOverlay 2019-06-04 19:33:55 +03:00
EVAST9919
8260b61db5 Fix CI issues 2019-06-04 19:02:09 +03:00
EVAST9919
0c48aec265 Split SetDefaultGamemode into two functions 2019-06-04 18:37:31 +03:00
EVAST9919
d0d846469a Move GamemodeTabItem to a distinct class 2019-06-04 18:14:03 +03:00
EVAST9919
367fdcf519 Make GamemodeControl depend on rulesets 2019-06-04 18:07:52 +03:00