13710 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	cbb2a0dd70	Use both score ID types to deduplicate score on solo results screen	2023-10-26 15:09:59 +02:00
Bartłomiej Dach	ca4b09f8ef	Merge branch 'master' into score-encoding-cleanup	2023-10-26 09:04:05 +02:00
Dean Herbert	6934e045df	Fix editor not prompting before saving beatmap for export	2023-10-25 14:39:46 +09:00
Dean Herbert	34505b3933	Merge pull request #25185 from bdach/minimum-sample-volume	2023-10-24 22:04:43 +09:00
Bartłomiej Dach	19be0055d5	Merge pull request #24921 from Pasi4K5/diff-name-search ... Add ability to search for difficulty names using square brackets	2023-10-24 12:07:02 +02:00
Dean Herbert	c9161a7bfc	Remove incorrect copy paste fail	2023-10-24 17:32:01 +09:00
Bartłomiej Dach	abfe2ce0fe	Fix comment	2023-10-24 10:05:20 +02:00
Dean Herbert	fcb366af4d	Add diff= support for more advanced usages	2023-10-24 16:09:05 +09:00
Dean Herbert	6865d8894d	Simplify implementation and remove unsupported test coverage	2023-10-24 16:01:32 +09:00
Bartłomiej Dach	05d7516479	Merge pull request #25182 from peppy/song-select-scroll-improvemets ... Improve mouse interactions at song select	2023-10-24 08:26:20 +02:00
Dean Herbert	1274829193	Block scroll and click operations on the left side of song select	2023-10-24 14:51:40 +09:00
Pasi4K5	c5339f440e	Apply code review suggestions	2023-10-23 23:30:54 +02:00
Bartłomiej Dach	12282fff5c	Disallow setting sample volume lower than 5% in editor	2023-10-20 15:50:21 +02:00
Dean Herbert	0ae0b0c353	Fix carousel "reset position" marging not scaling with UI scale correctly	2023-10-20 20:04:26 +09:00
Dean Herbert	137a1d948d	Allow interacting with the carousel anywhere in empty space at song select	2023-10-20 20:04:11 +09:00
Susko3	5bbbca3e44	Also support D for those with muscle memory from stable	2023-10-20 12:22:00 +02:00
Susko3	4a3a4ee17f	Change beatmap listing key to B to match Ctrl-B shortcut	2023-10-20 11:47:00 +02:00
Dean Herbert	52c2eb93de	Merge branch 'master' into taiko-beat-snap-grid	2023-10-19 23:53:01 +09:00
Dean Herbert	e081fa48a2	Fix various other inspections	2023-10-17 17:48:51 +09:00
Dean Herbert	5341a335a6	Bypass Parent nullability checks for now	2023-10-17 17:48:45 +09:00
Dean Herbert	2a89a25790	Add beat snap grid to osu!taiko editor ... Addresses https://github.com/ppy/osu/discussions/25150.	2023-10-17 16:59:56 +09:00
Dean Herbert	1b9acdf55c	Abstract out common implementation of BeatSnapGrid	2023-10-17 16:42:52 +09:00
Bartłomiej Dach	fb2293821a	Allow watching replay from multi/playlist results screens	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	c4af8591a5	Preserve OnlineID when importing scores ... Previously, for lazer scores, the ID returned from `osu-web` was discarded and replaced with -1, due to the fact that the appropriate structures for unification with stable, as well as unification across solo and multiplayer, were not in place yet. Now we're at the point where scores from all the aforementioned sources receive a `solo_scores` DB row, and as such, we can start treating `solo_scores`-scheme IDs as canonical "online IDs" for a score.	2023-10-16 11:20:02 +02:00
Bartłomiej Dach	9cd33d9bb2	Merge pull request #25139 from peppy/collection-ordering-fix ... Fix collections not being sorted alphabetically in context menus	2023-10-16 10:53:43 +02:00
Dean Herbert	7139592e43	Fix collections not being sorted correctly in context menus	2023-10-16 16:03:12 +09:00
Dean Herbert	48832c64ac	Fix health bar animating when it shouldn't be ... It wasn't correctly checking the current underlying health, which could be zero in usages of `AccumulatingHealthProcessor`, for instance. Closes #25046.	2023-10-16 13:12:04 +09:00
Jamie Taylor	d97b618d02	Use new generic-error sample in appropriate places	2023-10-13 21:06:50 +09:00
Bartłomiej Dach	5f51b8a7c9	Merge pull request #25097 from peppy/results-screen-progress-fast ... Show results immediately if user hits "back" key after finishing gameplay	2023-10-13 11:54:34 +02:00
Bartłomiej Dach	79cec7707d	Privatise setter	2023-10-13 09:56:46 +02:00
Bartłomiej Dach	6c8490bc7e	Revert changes to LoungeSubScreen.Join() ... - `virtual` modifier was used in mocking. - The spacing change revert is just mostly to keep it out of the final diff.	2023-10-12 20:39:40 +02:00
Dean Herbert	fa47309eef	Fix exit key during storyboard outro not progressing to results	2023-10-12 19:31:54 +09:00
Dean Herbert	d174a6ce61	Remove dead code which was only there for the exit-specific scenario	2023-10-12 19:27:35 +09:00
Dean Herbert	32eda99c3a	Add missing xmldoc returns	2023-10-12 19:06:34 +09:00
Dean Herbert	56e27f1c27	Merge branch 'master' into multiplayer-invites	2023-10-12 18:17:15 +09:00
Dean Herbert	94d7a65e40	Schedule Join operations rather than using OnLoadComplete for added safety	2023-10-12 17:42:02 +09:00
Dean Herbert	242a41371c	Fix HotkeyOverlay fade out occurring when exit is blocked	2023-10-12 15:42:54 +09:00
Dean Herbert	7c0d496730	Show results immediately if user hits "back" key after finishing gameplay ... I've gone ahead and matched the osu!stable behaviour for this, as it seems like it's what people are used to and they will settle for no less. Closes https://github.com/ppy/osu/issues/18089.	2023-10-12 15:42:23 +09:00
Dean Herbert	b9dbc8139b	Merge branch 'master' into fix-argon-health-bar-flash	2023-10-11 00:20:08 +09:00
Bartłomiej Dach	d701e88a08	Merge pull request #25076 from peppy/fix-argon-health-bar-perf ... Ensure health displays don't pile up transforms when off-screen	2023-10-10 16:33:32 +02:00
Dean Herbert	b9dadc52b7	Adjust comment to match current behaviour ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-10-10 22:54:19 +09:00
Dean Herbert	e2e28ef0ca	Remove comment regarding inlined delegate	2023-10-10 22:12:20 +09:00
Dean Herbert	682aa06acf	Remove JudgementResult from Miss/Flash as it is not used	2023-10-10 22:10:44 +09:00
Dean Herbert	f0bd975393	Change GameplayClockContainer.Reset to directly call GameplayClock.Stop ... The reasoning is explained in the inline comment, but basically this was getting blocked by `isPaused` being in an initial `true` state (as it is on construction), while the source clock was still `IsRunning`. There's no real guarantee of sync between the source and the `isPaused` bindable right now. Maybe there should be in the future, but to restore sanity, let's ensure that a call to `Reset` can at least stop the track as we expect.	2023-10-10 18:16:14 +09:00
Dean Herbert	100c0cf533	Fix MultiplayerPlayer never calling Reset on GameplayClockContainer ... This call is responsible for ensuring the clock is in a stopped state.	2023-10-10 17:58:37 +09:00
Dean Herbert	eee7dc02da	Reduce severity of clock running check to avoid production crashes	2023-10-10 17:58:11 +09:00
Dean Herbert	4674f63655	Fix Scheduler.AddOnce not working in one location	2023-10-10 16:17:34 +09:00
Dean Herbert	7e68b64526	Avoid running finishInitialAnimation when already finished	2023-10-10 15:59:48 +09:00
Dean Herbert	1eb6c93916	Also debounce updatePathVertices to reduce overhead	2023-10-10 15:50:42 +09:00
Dean Herbert	6c346874d3	Add TODO mentioning that ArgonHealthDisplay is doing lerp wrong	2023-10-10 15:24:54 +09:00
Dean Herbert	57f588fa86	Ensure health displays don't pile up transforms when off-screen	2023-10-10 15:24:54 +09:00
Dean Herbert	6ee958743e	Adjust glow animation specifics slightly	2023-10-10 15:10:42 +09:00
Dean Herbert	aeb579eb54	Syncrhonise initial colour of glowBar for sanity	2023-10-10 15:10:27 +09:00
Dean Herbert	8e26b3c405	Fix argon health bar not completing flash animation correctly	2023-10-10 15:09:33 +09:00
Bartłomiej Dach	ca217094d6	Merge pull request #25063 from peppy/move-download-button ... Move playlist item download button to left	2023-10-09 10:01:15 +02:00
Dean Herbert	142c61ab9b	Move playlist item download button to left	2023-10-09 12:21:56 +09:00
Dean Herbert	e5207167c8	Rename FailAnimation to FailAnimationContainer	2023-10-08 00:39:30 +09:00
Dean Herbert	7c7771afca	Merge pull request #24986 from peppy/health-animates-in-intro ... Add initial animation for health bars	2023-10-07 10:31:34 +09:00
Bartłomiej Dach	cfcdbe1c30	Merge pull request #25028 from peppy/bindable-fixes ... Fix some incorrect bindable-related code	2023-10-06 22:31:30 +02:00
Bartłomiej Dach	a099cc0f36	Merge pull request #25030 from peppy/adjustable-health-bar ... Adjust argon health bar to fit with existing layout	2023-10-06 21:51:18 +02:00
Bartłomiej Dach	b7d0bf3756	Only flush the Current transform specifically	2023-10-06 21:39:29 +02:00
Bartłomiej Dach	ce0d4bd0df	Fix health display potentially desyncing from actual if health was changed during initial animation	2023-10-06 21:35:08 +02:00
Dean Herbert	58448d3dd9	Fix health animation affecting failing tint	2023-10-07 01:06:31 +09:00
Dean Herbert	1a60e6d76e	Merge branch 'master' into health-animates-in-intro	2023-10-07 00:32:19 +09:00
Dean Herbert	8e5b2e78e5	Fix variable clash	2023-10-06 21:01:23 +09:00
Dean Herbert	d87ab9c82d	Adjust transition time based on miss/hit	2023-10-06 19:34:38 +09:00
Dean Herbert	3f2a00d90d	Add argon health display to default skin layout	2023-10-06 19:34:27 +09:00
Dean Herbert	f40e910c51	Remove left line from health display	2023-10-06 19:34:27 +09:00
Dean Herbert	db5178e453	Change ArgonHealthDisplay to be relative sized for now	2023-10-06 18:56:39 +09:00
Dean Herbert	936a21a661	Fix redundant bindable initialisation in SongSelect	2023-10-06 16:51:56 +09:00
Dean Herbert	1d7b8ea21a	Fix incorrect implementation of IHasCurrentValue in FooterButtonFreeMods	2023-10-06 16:51:40 +09:00
Dean Herbert	f2e56bbb65	Fix publicly-settable bindables	2023-10-06 16:51:24 +09:00
Dean Herbert	1005b7ac85	Fix incorrect test assumption in TestSceneEditorClock ... I don't know what this test was trying to do, but it was wrong. Any offset which is applied should be invisible to the clock's final `CurrentTime` (and to the user).	2023-10-06 16:43:28 +09:00
Dean Herbert	354193c53a	Merge branch 'master' into clock-fix-attempt-2	2023-10-06 16:43:27 +09:00
Dean Herbert	61fd4186af	Ensure regenerateDisplay is eventually performed if originally called before load	2023-10-05 22:55:23 +09:00
Dean Herbert	76cc2f9f22	Fix WaveformComparisonDisplay potentially crashing on invalid track length ... As seen at https://github.com/ppy/osu/runs/17415814918#r0s2.	2023-10-05 14:58:55 +09:00
Bartłomiej Dach	bd71403309	Merge branch 'master' into health-animates-in-intro	2023-10-04 13:53:42 +02:00
Dean Herbert	5a17a86d1d	Merge branch 'master' into clock-fix-attempt-2	2023-10-04 16:57:49 +09:00
Marvin Schürz	6d97f89399	Rename OnlinePlayScreen.LoungeSubScreen to Lounge	2023-10-04 08:37:22 +02:00
Bartłomiej Dach	844a3b6c1b	Merge pull request #24980 from frenzibyte/gameplay-hud-redesign/health-display ... Implement redesigned health bar display for "Argon" skin	2023-10-03 11:26:21 +02:00
Dean Herbert	4f3c433946	Move vertex related constants local to method	2023-10-03 17:41:52 +09:00
Dean Herbert	32b2ac4974	Rename and refactor glow/miss bars to hopefully make more sense	2023-10-03 17:41:11 +09:00
Dean Herbert	4f9daa1c14	Tidy up ArgonHealthDisplay code quality	2023-10-03 17:32:35 +09:00
Dean Herbert	8178cf3a8d	Tidy up background colour gradient logic ... This changes things visually a touch, but I think it feels better. And reads better.	2023-10-03 17:17:11 +09:00
Marvin Schürz	a171fa7649	Join multiplayer match when clicking the invite notification	2023-10-03 01:31:30 +02:00
Dean Herbert	82ba545358	Add initial animation for health bars	2023-10-02 17:01:58 +09:00
Dean Herbert	3a45bcad15	Improve flash and glow further	2023-10-02 02:11:07 +09:00
Dean Herbert	c4f47974bc	Improve glow further	2023-10-02 02:11:07 +09:00
Dean Herbert	88d608e1fa	Tidy up common animation code	2023-10-02 02:11:07 +09:00
Dean Herbert	df51e61234	Improve animation	2023-10-02 00:42:51 +09:00
Dean Herbert	22aa7ffd06	Use additive colour	2023-10-01 22:09:59 +09:00
Salman Ahmed	eef099e69d	Do not display "miss" bar if health is already zero	2023-10-01 15:25:34 +03:00
Salman Ahmed	7825bea959	Use interpolation for health bar opacity instead of transforms	2023-10-01 15:25:23 +03:00
Salman Ahmed	30d9004ef9	Fix small mistake	2023-10-01 13:41:11 +03:00
Salman Ahmed	446c9c2efe	Apply adjustments on the "miss" bar display	2023-10-01 13:39:36 +03:00
Salman Ahmed	9e2b8254d9	Add argon-specific health display test scene	2023-10-01 13:26:47 +03:00
Salman Ahmed	a331fb993a	Adjust health bar outer stroke colour	2023-10-01 01:21:37 +03:00
Salman Ahmed	319208ca3d	Adjust health bar glow intensity	2023-10-01 01:18:05 +03:00
Salman Ahmed	776536e816	Add "Argon" health display implementation	2023-10-01 00:56:16 +03:00
Salman Ahmed	33b0cb15a8	Add handling for miss judgements in HealthDisplay	2023-10-01 00:21:25 +03:00