59798 Commits

This Branch

This Branch

All Branches

• Merge pull request #23362 from bdach/fix-saving-online-beatmap-not-resetting-id

  Reset online ID on locally modifying beatmap

  Dean Herbert · 2023-05-02 12:41:23 +09:00
  5da78098ad
• Merge pull request #23361 from OliBomby/distance-snap

  Enable 'Use current' distance snap when exactly on a hit object

  Dean Herbert · 2023-05-02 12:21:57 +09:00
  0b048979f4
• Fix beatmap leaderboard test failure

  Because the online info reset (which includes online ID reset) was
  happening after encoding,
  `TestSceneBeatmapLeaderboard.TestLocalScoresDisplayOnBeatmapEdit()`
  started failing, as the hash no longer matched expectations after the
  first save of the map.

  Bartłomiej Dach · 2023-05-01 19:44:15 +02:00
  436ebdcfcb
• Enable current distance snap when exactly on a hit object
  OliBomby · 2023-05-01 19:22:52 +02:00
  cf5211aec9
• Remove no longer needed API call mocking

  The online ID will be reset unconditionally after any local change is
  made to any beatmap. That behaviour no longer depends on online lookups
  succeeding or failing.
  
  This may change at a later date when beatmap submission is integrated
  into lazer - the idea is that online IDs would get re-populated on local
  beatmaps once they are submitted to web.

  Bartłomiej Dach · 2023-05-01 19:08:41 +02:00
  1fb4c814f4
• Always reset online info when saving local beatmap
  Bartłomiej Dach · 2023-05-01 18:17:45 +02:00
  f470b2c9cc
• Add failing test case covering online ID reset on save

  This test scene passes at e58e1151f3 and
  fails at current master, due to an inadvertent regression caused by
  e72f103c17.
  
  As it turns out, the online lookup flow that was causing UI thread
  freezes when saving beatmaps in the editor, was also responsible for
  resetting the online ID of locally-modified beatmaps if online lookup
  failed.

  Bartłomiej Dach · 2023-05-01 18:17:35 +02:00
  8ab3a87b13
• Merge pull request #23342 from peppy/cursor-ripples

  Implement cursor ripples

  Bartłomiej Dach · 2023-05-01 10:34:04 +02:00
  5c066c40b1
• Merge branch 'master' into cursor-ripples
  Bartłomiej Dach · 2023-05-01 09:37:50 +02:00
  d98aa60efc
• Add custom cursor-ripple to cover skinnability in test
  Bartłomiej Dach · 2023-05-01 09:33:37 +02:00
  ff29189e89
• Adjust ripple size with cursor scale (including CS)
  Dean Herbert · 2023-05-01 14:43:49 +09:00
  0a70734331
• Adjust metrics of default ripple to match stable default better
  Dean Herbert · 2023-05-01 13:29:50 +09:00
  5cbfefbcb4
• Fix incorrect starting scale for ripples
  Dean Herbert · 2023-05-01 13:09:00 +09:00
  b8ae508639
• Change default scaling and add note about legacy cursor-ripple scale
  Dean Herbert · 2023-04-30 14:48:03 +09:00
  72b472a756
• Fix positioning and rewinding support for ripples
  Dean Herbert · 2023-04-30 14:48:03 +09:00
  6a62949fcd
• Add pooling support for ripples
  Dean Herbert · 2023-04-30 14:48:03 +09:00
  c994adfc22
• Implement ripples (legacy and default)
  Dean Herbert · 2023-04-30 14:48:03 +09:00
  a4ae9e409b
• Add basic structural requirements for cursor ripples
  Dean Herbert · 2023-04-30 14:48:03 +09:00
  b39a9d816e
• Merge pull request #23332 from peppy/fix-exclusive-fullscreen-detection

  Fix exclusive fullscreen notice showing false positives for new renderers

  Bartłomiej Dach · 2023-04-29 15:30:04 +02:00
  6a04708a7e
• Merge branch 'master' into fix-exclusive-fullscreen-detection
  Bartłomiej Dach · 2023-04-29 14:39:34 +02:00
  646d4965b9
• Merge pull request #23329 from rltn/clickable-country-name-in-profile

  Clickable country name in profile

  Dean Herbert · 2023-04-29 14:19:13 +09:00
  119687cf6e
• Merge pull request #23333 from Cootz/add-events-for-loading-screen

  Fix editor potentially leaving a dangling beatmap if exiting during load too fast

  Dean Herbert · 2023-04-29 11:57:24 +09:00
  8df5410946
• Merge branch 'master' into add-events-for-loading-screen
  Dean Herbert · 2023-04-29 11:05:45 +09:00
  602a276884
• Add xmldoc to new test mentioning failure rate and general purpose
  Dean Herbert · 2023-04-29 11:05:10 +09:00
  2643100644
• Extract beatmap retrieval method for more legibility
  Dean Herbert · 2023-04-29 11:01:29 +09:00
  32f8c674f4
• Improve legibility and code quality of new test
  Dean Herbert · 2023-04-29 10:51:56 +09:00
  a6f0186112
• Rename test scene to explicitly mention navigation testing
  Dean Herbert · 2023-04-29 10:51:56 +09:00
  428b5fad3c
• Fix testing
  Cootz · 2023-04-29 10:29:33 +09:00
  d9b3c97179
• Add test
  Cootz · 2023-04-29 10:29:33 +09:00
  c5357d30ab
• Fix the issue
  Cootz · 2023-04-29 10:29:33 +09:00
  607a04ae73
• use of Child instead of Children
  _ltn · 2023-04-28 19:24:07 +03:00
  2d6c0d2900
• Change condition for exclusive fullscreen notice to only show when using the correct renderer

  This avoids the notice showing when running on windows, but using the
  newer renderers (where the underlying logic hasn't been tested properly
  and can result in false-positives).
  
  Supersedes https://github.com/ppy/osu-framework/pull/5759 as a more
  correct implementation.

  Dean Herbert · 2023-04-28 22:36:30 +09:00
  6929be49b7
• add OsuHoverContainer
  _ltn · 2023-04-28 05:48:54 +03:00
  4b0ee392f6
• remove UpdateableCountryText
  _ltn · 2023-04-28 05:47:05 +03:00
  17730f05bc
• Merge pull request #23325 from sw1tchbl4d3r/taiko_aspect_limit

  Fix extreme aspect ratios in taiko

  Dean Herbert · 2023-04-28 09:39:53 +09:00
  6308bef0c8
• clearing the code
  _ltn · 2023-04-28 02:06:13 +03:00
  4d144cd5b5
• moving UpdateableCountryText
  _ltn · 2023-04-28 01:47:14 +03:00
  092377fdaa
• replace country text object
  _ltn · 2023-04-28 01:16:50 +03:00
  e9843f2066
• UpdateableCountryText rewrite
  _ltn · 2023-04-28 01:14:42 +03:00
  b13201fb79
• Create UpdateableCountryText.cs
  _ltn · 2023-04-27 23:44:18 +03:00
  f5c652325a
• Merge pull request #23307 from peppy/fix-storyboard-loop-end-time

  Fix some storyboard loops not playing for as long as expected

  Bartłomiej Dach · 2023-04-26 22:42:45 +02:00
  1959c2daeb
• Merge branch 'master' into fix-storyboard-loop-end-time
  Bartłomiej Dach · 2023-04-26 21:53:26 +02:00
  07efa7d660
• Limit taiko playfield aspect ratio to 5:4 - 16:9
  sw1tchbl4d3 · 2023-04-26 18:05:47 +02:00
  76df5fd3e2
• Merge pull request #23275 from Terochi/catch-lag-spike-fix

  Fix huge lag spike on new combo in osu!catch

  Dean Herbert · 2023-04-26 16:29:43 +09:00
  58ace1d613
• Merge pull request #18626 from ggliv/decouple-mod-fails

  Allow ModFailCondition to arbitrarily trigger failures

  Dean Herbert · 2023-04-26 16:19:42 +09:00
  61b62b35f5
• Fix naming and update in line with nullability
  Dean Herbert · 2023-04-26 15:27:58 +09:00
  cb7b246e33
• Merge branch 'master' into decouple-mod-fails
  Dean Herbert · 2023-04-26 15:26:20 +09:00
  210c5e7c53
• Merge pull request #23260 from Haspamelodica/master

  Fix some videos with uppercase file extensions not displaying correctly in-game

  Dean Herbert · 2023-04-26 14:29:25 +09:00
  6a3b587374
• Actually use new end time property when setting lifetimes
  Dean Herbert · 2023-04-26 13:28:51 +09:00
  1efc78c0f8
• Merge pull request #23309 from peppy/key-counters-fix

  Fix key counters counting during break time

  Bartłomiej Dach · 2023-04-25 21:15:12 +02:00
  5ec8ecb11b