7711 Commits

Author	SHA1	Message	Date
Dan Balasescu	c48a0dc993	Move UserLookupCache to online play test dependencies	2022-02-15 20:56:46 +09:00
Dean Herbert	a8f09a8676	Merge branch 'master' into remove-playlistitem-ruleset-mods	2022-02-15 17:40:39 +09:00
Dan Balasescu	03106e846c	Fix test failures due to async mod icon loads	2022-02-15 17:15:00 +09:00
Dean Herbert	d79845fb1d	Revert NUnit3TestAdaptor (again) ... Console output is still broken. See https://github.com/ppy/osu/runs/5196023462?check_suite_focus=true.	2022-02-15 17:06:34 +09:00
Dean Herbert	b1cf014dc2	Add test coverage of EF to Realm migration process	2022-02-15 17:00:17 +09:00
Dean Herbert	f03de16ee5	Add a test EF database ... Created on d8a23aad4 (just before skins were migrated to realm). This contains: - 2 beatmap sets (intro and disco prince) - 1 score (set on disco prince using autopilot/DT) - 1 skin (haxwell) - 322 named files (from skin) - 5 named files (from beatmaps) - 270 total file infos	2022-02-15 16:56:00 +09:00
Dan Balasescu	5b765581d8	Fix free mod selection not showing allowed mods	2022-02-15 16:28:15 +09:00
Dan Balasescu	efeba30b9f	Remove ruleset and mod bindables from PlaylistItem	2022-02-15 16:28:15 +09:00
Dean Herbert	60153bb69d	Update nuget packages to highest usable versions ... EF packages are intentionally pinned to 5.0.14 as higher versions no longer support `netstandard2.1`, which we require for xamarin projects.	2022-02-15 15:19:23 +09:00
Bartłomiej Dach	1685e214d3	Adjust test coverage to cover desired copy naming scheme	2022-02-14 19:59:54 +01:00
Dean Herbert	db74a226c0	Fix test regression due to mouse overlapping settings overlay	2022-02-15 02:54:45 +09:00
Dean Herbert	02f58a82fc	Use WaitSafely() in tests where it was not already being used	2022-02-15 02:35:08 +09:00
Dean Herbert	5b30921cbf	Merge branch 'master' into net6	2022-02-14 22:06:35 +09:00
Dean Herbert	b9d9fc56af	Move files to UI namespace	2022-02-14 17:51:39 +09:00
Dean Herbert	80ba06b0e3	Merge branch 'master' into expandable-controls	2022-02-14 16:57:45 +09:00
Bartłomiej Dach	13abc392bd	Add failing test coverage for not copying online properties	2022-02-13 18:54:52 +01:00
Bartłomiej Dach	90c48de9f8	Add failing test coverage for save of copied beatmap keeping old beatmap file	2022-02-13 14:01:23 +01:00
Bartłomiej Dach	1292722a00	Add failing test coverage for correct combo colour copy	2022-02-13 14:01:22 +01:00
Bartłomiej Dach	fd1c8c3614	Add failing test coverage for correct beatmap difficulty copy	2022-02-13 14:01:21 +01:00
Bartłomiej Dach	eb939547a9	Add test coverage for difficulty copy flow	2022-02-13 14:01:21 +01:00
Bartłomiej Dach	0d1171b7fa	Adjust existing test coverage to pass	2022-02-13 14:01:20 +01:00
Dean Herbert	6005daeba8	Fix fire-and-forget async calls to use WaitSafely	2022-02-11 16:02:42 +09:00
Dean Herbert	f012f64fd1	Add test coverage checking carousel panel visual state after ruleset filter change	2022-02-11 15:21:01 +09:00
Dean Herbert	eda213e4de	Merge pull request #16827 from smoogipoo/spectator-state-rework ... Add user state to SpectatorState, allowing multiplayer to continue to results	2022-02-11 01:48:47 +09:00
Dean Herbert	19cb8cb03a	Update tests	2022-02-10 19:35:28 +09:00
Dean Herbert	176bb4a4e2	Update desktop projects to target .NET 6	2022-02-10 17:42:09 +09:00
Dan Balasescu	ffc4c64f7e	Unify namings across the board	2022-02-09 12:10:07 +09:00
Dan Balasescu	4966c4e974	Remove redundant parameter	2022-02-09 11:51:47 +09:00
Dan Balasescu	886d1d2df6	Refactorings	2022-02-08 21:29:43 +09:00
Dan Balasescu	4c76027178	Rename completed state to passed	2022-02-08 20:29:49 +09:00
Dan Balasescu	0d99017178	Add state tests	2022-02-08 20:27:08 +09:00
Dan Balasescu	45b3f472ab	Merge branch 'master' into spectator-state-rework	2022-02-08 19:51:50 +09:00
Dan Balasescu	9c2d57d707	Add failing test	2022-02-08 19:36:16 +09:00
Henry Lin	b31c1513f6	Fix test failure ... The cursor was clicking too far to the right.	2022-02-05 22:41:04 +08:00
Dean Herbert	ee0ff5c33f	Merge pull request #16774 from smoogipoo/fix-broken-test-scene ... Fix test scene broken without being logged in	2022-02-04 23:55:51 +09:00
Dan Balasescu	09728a29ed	Merge branch 'fix-broken-test-scene' into spectator-state-rework	2022-02-04 22:42:10 +09:00
Dean Herbert	98f61415c2	Merge branch 'master' into mvp-safe-area-support	2022-02-04 20:05:35 +09:00
Dean Herbert	002cc7261b	Merge pull request #16773 from smoogipoo/fix-spectator-restart-crash ... Fix crash when gameplay is started while inside multiplayer spectator screen	2022-02-04 19:23:08 +09:00
Dan Balasescu	fa3d1115fa	Remove online api requirement	2022-02-04 19:17:50 +09:00
Dan Balasescu	dd63b1a350	Fix broken spectator playback test scene	2022-02-04 19:12:02 +09:00
Dean Herbert	6457cf8d9b	Fix weird formatting in TestSceneSafeArea	2022-02-04 18:45:40 +09:00
Dan Balasescu	d5269ba05b	Merge branch 'fix-spectator-restart-crash' into spectator-state-rework	2022-02-04 17:59:18 +09:00
Dan Balasescu	b41655d5b9	Fix crash when gameplay starts while in multi-spectator screen	2022-02-04 17:47:41 +09:00
Dean Herbert	1444df4d50	Add test scene for playing with safe areas	2022-02-04 16:39:10 +09:00
Dan Balasescu	63064d682b	Merge pull request #16743 from hlysine/extended-statistics-without-replay ... Allow statistic items in results screen to display without needing to watch a replay	2022-02-04 15:07:52 +09:00
Salman Ahmed	bbef12e72c	Refactor ExpandingControlContainer to no longer rely on controls	2022-02-04 05:45:12 +03:00
Bartłomiej Dach	b7d7e6612e	Merge branch 'master' into new-difficulty-creation-v3	2022-02-03 16:36:18 +01:00
Dan Balasescu	d4ebff6ea1	Add failing test	2022-02-03 23:18:22 +09:00
Dan Balasescu	483977d5c8	Merge branch 'master' into spectator-state-rework	2022-02-03 19:59:07 +09:00
Dean Herbert	b2efce2656	Merge branch 'master' into expandable-controls	2022-02-03 19:23:34 +09:00
Dean Herbert	df9d99f5aa	Merge branch 'master' into extended-statistics-without-replay	2022-02-03 18:59:48 +09:00
Henry Lin	a27d0572ed	Add test cases for manual testing	2022-02-03 17:00:40 +08:00
Dean Herbert	41aa4b8cca	Fix TestSelectingFilteredRuleset failing under visual tests due to using local database	2022-02-03 16:04:05 +09:00
Dean Herbert	6355ac6663	Wait for DialogOverlay load in more tests ... Apparently the previous fix was not enough as this can still be seen failing (https://github.com/ppy/osu/runs/5046718623?check_suite_focus=true). This change is copying from what other tests use seemingly reliably, such as `TestScenePerformFromScreen`)	2022-02-03 15:10:08 +09:00
Bartłomiej Dach	afc48d86df	Add failing test coverage for save after safeties addition	2022-02-02 21:57:10 +01:00
Bartłomiej Dach	87e2e83288	Add test coverage for difficulty name clash cases	2022-02-02 21:55:34 +01:00
Bartłomiej Dach	0d51c015ad	Add basic test coverage for new difficulty creation	2022-02-02 21:55:34 +01:00
Dan Balasescu	fcbba3d948	Rename PlayingUserStates -> WatchingUserStates	2022-02-02 23:11:29 +09:00
Dan Balasescu	589f5e7a31	Update test which has now been resolved	2022-02-02 23:09:38 +09:00
Dan Balasescu	6d3bc005ea	Merge branch 'master' into spectator-state-rework	2022-02-02 18:57:04 +09:00
Dan Balasescu	b5fb3b7dae	Fix crash when selecting swap mod as freemod	2022-02-02 18:42:22 +09:00
Dean Herbert	6d962e7925	Merge pull request #16726 from dekrain/leaderboard-score-tooltip ... Add basic tooltip for leaderboard scores	2022-02-02 13:56:45 +09:00
Dean Herbert	35b7653290	Revert mod flow changes and add visual test coverage showing an overflow case	2022-02-02 09:13:19 +09:00
Bartłomiej Dach	3674ed15ce	Remove unused game host parameter ... No longer used since eeccf836ec.	2022-02-01 21:53:21 +01:00
Bartłomiej Dach	b978010b48	Remove unused allowMissing parameter in audio file check test ... No longer used since 7f95400f46.	2022-02-01 21:53:21 +01:00
Bartłomiej Dach	7cdf63c654	Remove unused FindProvider() methods ... No longer needed since 39f99bf785.	2022-02-01 21:53:21 +01:00
Bartłomiej Dach	75101b1105	Remove unused ruleset ctor params from test beatmap model managers ... No longer used since 00e3af3366.	2022-02-01 21:49:41 +01:00
Dan Balasescu	41007169f7	Give SpectatorState a user state	2022-02-01 21:51:05 +09:00
Dean Herbert	15479ae046	Add test coverage of no header doing nothing	2022-02-01 16:55:28 +09:00
Dean Herbert	3ca2c90684	Add test scores in BeatmapLeaderboard test scene with more mods	2022-02-01 16:35:25 +09:00
Dan Balasescu	781cb9f18d	Move HasPassed/HasFailed into GameplayState	2022-02-01 14:46:24 +09:00
Dan Balasescu	502e6af008	Remove PlayingUsers list from SpectatorClient	2022-02-01 14:42:30 +09:00
Dan Balasescu	0641264a11	Merge branch 'master' into spectator-consistency-frames	2022-02-01 14:35:30 +09:00
Dan Balasescu	4fb565e15f	Reset ScoreProcessor from statistics replay frames	2022-01-31 21:32:56 +09:00
Dan Balasescu	0458d408bb	Add replay statistics frames to FramedReplayInputHandler	2022-01-31 18:53:47 +09:00
Dan Balasescu	4727aeda01	Give last bundled replay frame the frame header	2022-01-31 18:53:47 +09:00
Dan Balasescu	f3d4756c7f	Merge pull request #16713 from frenzibyte/fix-spectator-gcc-state-2 ... Fix multiplayer spectator occasionally rewinding time unexpectedly	2022-01-31 18:33:08 +09:00
Dan Balasescu	62603e78fd	Merge pull request #16714 from frenzibyte/rewrite-hardware-correction-clock ... Rewrite `HardwareCorrectionOffsetClock` to handle seeking on different gameplay rates	2022-01-31 17:32:22 +09:00
Dean Herbert	575d9671bf	Merge pull request #16717 from peppy/fix-dialog-overlay-missing-test-failures ... Fix test failures if `DialogOverlay` is not loaded in time	2022-01-31 17:06:24 +09:00
Dean Herbert	25cbe5a0de	Remove acronym shortening of GameplayClockContainer	2022-01-31 15:23:31 +09:00
Dean Herbert	9001c3a396	Fix test failures if DialogOverlay is not loaded in time ... As seen at https://github.com/ppy/osu/runs/4999391205?check_suite_focus=true, where `DialogOverlay` hasn't loaded in single file yet.	2022-01-31 15:17:07 +09:00
Dean Herbert	c8c0ae5658	Merge branch 'master' into flush-frames-end-play	2022-01-31 15:12:41 +09:00
Dean Herbert	57f793aff0	Rename dictionary and make private for added safety	2022-01-31 15:12:08 +09:00
Dan Balasescu	e9f3e7f5cb	Merge pull request #16703 from peppy/leaderboard-component-fixes ... Rewrite `Leaderboard` component to bring up to current code standards	2022-01-31 14:33:04 +09:00
Salman Ahmed	2b999f9780	Add failing test case	2022-01-31 01:40:07 +03:00
Dean Herbert	f8939af5e6	Track loading via state as well	2022-01-31 01:12:03 +09:00
Dean Herbert	6a21d58325	Avoid test failures on non-triangle intro tests	2022-01-30 18:59:18 +09:00
Dean Herbert	1dbcb5ab63	Add test coverage of intro fail scenario	2022-01-30 18:51:16 +09:00
Dean Herbert	04dbb5d3c6	Disallow setting "NoScores" externally as it is handled internally	2022-01-30 16:18:19 +09:00
Dean Herbert	acc1199add	Consolidate flows of Set operations, either result or error	2022-01-30 16:16:00 +09:00
Dean Herbert	c401629dd8	Also refactor placeholder logic to make more sense	2022-01-30 10:50:32 +09:00
Salman Ahmed	4f4f60248f	Add failing test case	2022-01-30 01:46:10 +03:00
Dean Herbert	06660ff960	Fix null beatmap in test scene	2022-01-30 03:02:56 +09:00
Dean Herbert	d21464ea61	Fix assertions to work in both directions	2022-01-30 02:54:51 +09:00
Dean Herbert	51acf79935	Change test exposure to property instead of method	2022-01-30 02:29:51 +09:00
Dean Herbert	9861c50b33	Remove pointless tests that no longer show anything valid	2022-01-30 00:03:22 +09:00
Dean Herbert	a915b9cd30	Fix occasional failures in TestSceneDeleteLocalScore	2022-01-29 23:58:57 +09:00
Dean Herbert	661fec7c8a	Make score setter private	2022-01-29 23:58:57 +09:00
Dean Herbert	aee93934d5	Rename methods to make more sense (and always run through AddOnce)	2022-01-29 23:58:57 +09:00
Dean Herbert	4c97ed676f	Fix score presentation tests not correctly entering song select before running	2022-01-29 14:46:24 +09:00
Bartłomiej Dach	1253e1ecc1	Replace LINQ Count() invocation with count property access	2022-01-28 20:25:12 +01:00
Dan Balasescu	3037a3a769	Purge final spectator frames before ending play	2022-01-28 22:26:05 +09:00
Dan Balasescu	bda3cdc9a7	Add tests	2022-01-28 19:29:30 +09:00
Dan Balasescu	f021a274d2	Merge pull request #16681 from peppy/fix-delete-local-scores ... Fix delete local scores via "Clear all scores" button crashing the game	2022-01-28 17:01:31 +09:00
Dan Balasescu	b94984bd2d	Merge pull request #16678 from peppy/hold-for-menu-always-fade ... Ensure hold for menu button fades out if the cursor is never moved	2022-01-28 15:55:41 +09:00
Dean Herbert	2453bf5ed0	Add test coverage of the same thing but via "clear all scores" button	2022-01-28 15:54:53 +09:00
Dean Herbert	778eebc94d	Add test coverage of local score import and deletion	2022-01-28 15:50:36 +09:00
Dan Balasescu	32f9299fe0	Remove unused using	2022-01-28 15:26:29 +09:00
Dean Herbert	28c8e07e3f	Ensure hold for menu button fades out if the cursor is never moved ... Closes https://github.com/ppy/osu/discussions/16669.	2022-01-28 14:48:35 +09:00
Dean Herbert	f32d56e213	Bring HoldForMenuButton tests up-to-date in code quality	2022-01-28 14:48:17 +09:00
Bartłomiej Dach	7dc3940dee	Add test coverage for preserving legacy beatmap info defaults	2022-01-27 21:49:26 +01:00
Bartłomiej Dach	04d6ca59a3	Merge branch 'master' into song-select-scroll-position-during-delete	2022-01-27 20:46:19 +01:00
Dean Herbert	e872877185	Merge pull request #16648 from peppy/fix-song-select-tests ... Fix song select tests not waiting for beatmap imports to arrive	2022-01-27 23:00:58 +09:00
Dean Herbert	fae4f8bd8e	Move nulling of previous songSelect to SetUpSteps instead	2022-01-27 21:59:44 +09:00
Dean Herbert	7af23328a4	Merge branch 'master' into ruleset-ordering-fix	2022-01-27 21:46:03 +09:00
Dean Herbert	831fa44433	Fix song select tests not waiting for beatmap imports to arrive ... After the change to realm, notification fires could take a frame or two. We aren't accounting for this. Fixes test failures like https://github.com/ppy/osu/runs/4963255990?check_suite_focus=true	2022-01-27 19:35:42 +09:00
Dean Herbert	a5d422e82c	Merge branch 'master' into ruleset-id-fixes	2022-01-27 17:07:18 +09:00
Dean Herbert	29a4ec949f	Merge pull request #16637 from bdach/editor-changes-not-resetting ... Fix changes to beatmap info made in editor persisting after exit without save	2022-01-27 17:02:42 +09:00
Dean Herbert	f2cecad83b	Add failing test coverage showing carousel deletions don't keep scroll position	2022-01-27 16:52:02 +09:00
Dean Herbert	5637fd64d6	Perform ordering using IComparable instead	2022-01-27 15:59:20 +09:00
Dean Herbert	5288eedd31	Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID	2022-01-27 15:38:03 +09:00
Dean Herbert	714177cce1	Remove pointless constructor in RulesetInfo	2022-01-27 15:37:27 +09:00
Dean Herbert	f30d63107a	Add SortID to RulesetInfo to allow stable ordering of rulesets for display	2022-01-27 15:35:16 +09:00
Bartłomiej Dach	e0616476e2	Fix test gameplay tests failing due to beatmap refetch on suspend	2022-01-26 21:15:49 +01:00
Bartłomiej Dach	4382adad82	Add test coverage for editor changes not resetting after exit without save	2022-01-26 21:15:49 +01:00
Dean Herbert	0c2ed2f9a7	Add failing test coverage of incorrect filter ruleset matching	2022-01-27 01:25:57 +09:00
Derrick Timmermans	6ec9c5c21a	Use default custom ruleset ID	2022-01-26 16:23:00 +01:00
Derrick Timmermans	e712fab299	Add test for custom ruleset conversion filtering	2022-01-26 16:14:07 +01:00
Dan Balasescu	cf9ee43b17	Merge pull request #16608 from peppy/playlist-overlay-optimisations ... Optimise `PlaylistOverlay` and reduce startup overhead of `MusicController`	2022-01-26 20:28:33 +09:00
Dan Balasescu	94d3e2c90c	Merge branch 'master' into fix-out-of-order-events-on-block-fail	2022-01-26 19:08:55 +09:00
Dean Herbert	abe2cccaae	Fix completely invalid method of testing realm migration	2022-01-26 19:03:26 +09:00
Dan Balasescu	cdca1285ab	Merge branch 'master' into playlist-overlay-optimisations	2022-01-26 19:01:33 +09:00
Dan Balasescu	4a51bab9ac	Merge pull request #16622 from peppy/fix-results-score-switch-crash ... Fix crash at results screen when viewing another score panel after playing	2022-01-26 16:59:39 +09:00
Salman Ahmed	a34b8fc4d0	Merge branch 'master' into expandable-controls	2022-01-26 10:36:22 +03:00
Salman Ahmed	eb83b7fe0a	Update existing implementation with changes	2022-01-26 10:18:17 +03:00
Dean Herbert	68ee80c5de	Merge pull request #16623 from frenzibyte/refactor-editor-save-test ... Refactor editor saving test scene for scalability	2022-01-26 15:40:39 +09:00
Dan Balasescu	701f00a4b1	Merge pull request #16609 from peppy/fix-realm-related-failures ... Fix some realm-related test failures	2022-01-26 15:31:18 +09:00
Dean Herbert	91e0d1021f	Merge branch 'master' into fix-out-of-order-events-on-block-fail	2022-01-26 15:21:10 +09:00
Dean Herbert	d0a2818847	Fix incorrect testing	2022-01-26 15:14:43 +09:00
Dean Herbert	9532454e2a	Remove ILive remnants	2022-01-26 15:12:07 +09:00
Dean Herbert	ba46827ac0	Merge branch 'master' into playlist-overlay-optimisations	2022-01-26 15:11:14 +09:00
Dean Herbert	3491b77c8c	Fix ScoreInfo.RealmUser not getting deep cloned correctly ... I'm still not at all happy with the play-to-results flow (with multiple clones), but this will have to do for now.	2022-01-26 14:27:48 +09:00
Salman Ahmed	064468faad	Refactor editor saving test scene for scalability	2022-01-26 07:57:46 +03:00
Dean Herbert	cd71ec0edd	Remove ILive<> interface (and use abstract Live<> instead)	2022-01-26 13:38:56 +09:00
Dean Herbert	dda513dd08	Change PlaylistOverlay to use ILive	2022-01-26 12:19:59 +09:00
Dean Herbert	bdf215c576	Merge branch 'master' into improve-timeline-zoom	2022-01-26 03:40:53 +09:00
Dean Herbert	5085eb6801	Ensure gameplay starts by dismissing any notifications in TestSceneChangeAndUseGameplayBindings	2022-01-26 03:39:01 +09:00
Salman Ahmed	ad18bc4983	Update timeline selection test scene with zoom changes	2022-01-25 18:57:39 +03:00
Dean Herbert	5b82eaf112	Merge branch 'master' into fix-beat-divisor-not-saving	2022-01-25 23:29:37 +09:00
Salman Ahmed	6c69df815a	Update editor test scenes to set working beatmap properly	2022-01-25 15:56:27 +03:00