541 Commits

Author	SHA1	Message	Date
Dean Herbert	7509a9ff8f	Update BeatmapModelManager.Save to work for editor scenarios	2022-01-12 17:49:11 +09:00
Dean Herbert	8c3dc4333d	Fix incorrect realm access after new beatmap import	2022-01-12 17:49:11 +09:00
Dean Herbert	e74a5022c9	Fix multiple tests via null checks and changing ToLive to Detach ... flow	2022-01-12 17:00:17 +09:00
Dean Herbert	8461eaab46	BeatmapSetInfo detach support	2022-01-12 17:00:16 +09:00
Dean Herbert	fe8a5e867d	Remove updated/removed flow method mapping	2022-01-12 17:00:16 +09:00
Dean Herbert	1f9318265e	Update ToLive usages in line with recent changes	2022-01-12 17:00:16 +09:00
Dean Herbert	db05727ec4	Remove unused includeProtected parameter	2022-01-12 17:00:16 +09:00
Dean Herbert	b91f309879	Inline query methods from BeatmapModelManager to BeatmapManager where possible	2022-01-12 17:00:16 +09:00
Dean Herbert	1d536fd0bc	Start introducing ILive	2022-01-12 17:00:16 +09:00
Dean Herbert	8696f82627	Fix intro screen ... Fix things	2022-01-12 17:00:16 +09:00
Dean Herbert	c4a9211179	Apply NRT to BeatmapManager and move Hide/Restore methods across	2022-01-12 17:00:16 +09:00
Dean Herbert	00e3af3366	Update model manager and many related classes to get things compiling again	2022-01-12 17:00:00 +09:00
Dean Herbert	b8cd3cdbbc	Various updates to ruleset and primary key usages to move closer to realm support	2022-01-12 16:57:13 +09:00
Dean Herbert	116f35c52a	Remove EF FileStore	2022-01-12 16:39:36 +09:00
Dean Herbert	89d6ffa7f3	Use RealmContextFactory instead of EF	2022-01-12 16:39:36 +09:00
Dean Herbert	6a671b0a52	Remove unnecessary assigns of BeatmapSetInfo.Metadata	2022-01-12 16:39:36 +09:00
Dean Herbert	fda529de26	Update usages of APIUser to RealmUser	2022-01-12 16:39:36 +09:00
Dean Herbert	00177a3ae1	Update usages to new naming	2022-01-06 22:54:43 +09:00
Dean Herbert	73b40e6833	Replace usage of .Result with .WaitSafelyForResult	2022-01-04 11:51:41 +09:00
Dean Herbert	a7e4e7be3a	Remove the ability to specify a filename in ReplaceFile	2021-11-29 18:11:51 +09:00
Dan Balasescu	f712aeee01	Merge pull request #15795 from peppy/realm-integration/separate-download-flow ... Split out download logic from main manager classes	2021-11-25 20:59:23 +09:00
Dean Herbert	716543b5b3	Move beatmap download logic out of BeatmapManager	2021-11-25 17:29:41 +09:00
Dean Herbert	cc1b91e4bd	Split out legacy model export logic into LegacyModelExporter classes	2021-11-25 16:41:12 +09:00
Dean Herbert	6cab7b877d	Move stable import handling into its own class	2021-11-25 15:36:58 +09:00
Dan Balasescu	5ff62a8e04	Merge pull request #15779 from peppy/remaining-misc-fixes ... Apply some various code quality fixes that don't fit elsewhere	2021-11-24 16:59:49 +09:00
Dean Herbert	9c61ec217b	Remove unnecessary mainTrackMixer parameter from BeatmapManager	2021-11-24 16:27:17 +09:00
Dean Herbert	49c2cb9125	Initialise BeatmapSet.Beatmaps list to line up with realm expectations	2021-11-24 13:25:55 +09:00
Dean Herbert	7c2e79f911	Update all simple cases of switching to IWorkingBeatmap	2021-11-17 20:56:57 +09:00
Dean Herbert	3b485b5f37	Rewrite PreviewTrackManager to avoid constructing TrackBass locally ... This paves the way for the framework code quality change (https://github.com/ppy/osu-framework/pull/4873) which stops exposing the constructor. Most of the restructuring here is required to give `PreviewTrackManager` an adjustable target to apply the global mute.	2021-11-09 17:38:12 +09:00
Dean Herbert	78aef9ce86	Merge branch 'master' into remove-stupid-weak-reference-bindable-events	2021-11-08 13:35:49 +09:00
Dean Herbert	f0809801c5	Update remaining actions to events	2021-11-07 11:34:37 +09:00
Dean Herbert	89cc2523ef	Fix incorrectly specified events	2021-11-06 22:31:49 +09:00
Dean Herbert	2881ce0f5a	Merge branch 'master' into remove-stupid-weak-reference-bindable-events	2021-11-06 14:08:39 +09:00
Dean Herbert	9a7c75508e	Merge branch 'master' into user-class-cleanup	2021-11-05 19:56:18 +09:00
Dean Herbert	54f72d68ca	Revert weird event flow in model manager/importers	2021-11-05 19:12:49 +09:00
Dean Herbert	6c385ccd29	Move second generic to abstract model downloader rather than interface type	2021-11-05 17:37:05 +09:00
Dean Herbert	1fe9bca819	Change ModelDownloader's requirement to an IModelImporter rather than IModelManager	2021-11-05 16:47:18 +09:00
Dean Herbert	b90f44493c	Remove importer inheritance from IModelManager ... Now only exists in legacy implementations, to reduce inheritance complexity of interfaces which are going to be used going forwards.	2021-11-05 16:45:38 +09:00
Dean Herbert	86540d1fb6	Update existing usages of Author as string to access Username directly	2021-11-04 18:57:54 +09:00
Dean Herbert	b9983add15	Rename User to APIUser and move to correct namespace	2021-11-04 18:21:31 +09:00
Dean Herbert	67d9590a79	Fix new inspections	2021-11-04 14:02:09 +09:00
Dean Herbert	ca438a102d	Fix beatmap paths including invalid slash/backslash characters	2021-11-03 16:46:05 +09:00
Dean Herbert	392559ae3e	Fix beatmap download notifications not showing beatmap name correctly	2021-11-03 03:23:41 +09:00
Dean Herbert	b3219bb592	Update usages of OnlineID	2021-10-18 16:16:36 +09:00
Dean Herbert	e9c3d09e0e	Remove redundant specs	2021-10-15 16:27:16 +09:00
Dean Herbert	a90f40e831	Update one missed instance of PresentImport	2021-10-15 16:00:09 +09:00
Dean Herbert	6b35ccae95	Fix some cases where interface specifications can be used but weren't	2021-10-11 15:06:24 +09:00
Dean Herbert	8ffaa491e7	Fix BeatmapModelManager not receiving WorkingBeatmapCache	2021-10-06 12:55:04 +09:00
smoogipoo	4871db2f86	Merge branch 'master' into importer-returns-live	2021-10-04 19:42:36 +09:00
Dean Herbert	63f0b0c932	Rename out of place interface name	2021-10-04 16:35:55 +09:00
Dean Herbert	916342c837	Merge branch 'master' into importer-returns-live	2021-10-04 16:24:26 +09:00
Dean Herbert	ec61c3c5ee	Rename all remaining cases	2021-10-03 00:55:29 +09:00
Dan Balasescu	6a172d54d5	Merge branch 'master' into model-downloader-split	2021-10-01 22:34:39 +09:00
Dean Herbert	428c7830d9	Pass online lookup queue in as a whole, rather than function	2021-10-01 01:45:21 +09:00
Dean Herbert	a2e61883e3	Initial push to use ILive in import process	2021-09-30 22:55:25 +09:00
Dean Herbert	3e3b9bc963	Split out IModelDownloader and also split apart ScoreManager	2021-09-30 18:25:20 +09:00
Dean Herbert	fd13142a15	Add missing interface to BeatmapManager	2021-09-30 18:21:24 +09:00
Dean Herbert	7a72747d88	Add back optional online lookups	2021-09-30 17:18:39 +09:00
Dean Herbert	90225f2082	Hook up all required interfaces to new BeatmapManager	2021-09-30 17:18:39 +09:00
Dean Herbert	d21139b03e	Split out database portion from BeatmapManager	2021-09-30 15:43:49 +09:00
Dean Herbert	e7e0473323	Split out WorkingBeatmapCache from BeatmapManager	2021-09-30 15:40:41 +09:00
Dean Herbert	6ffd9fdcfa	Split out BeatmapOnlineLookupQueue from BeatmapManager	2021-09-30 14:46:01 +09:00
Bartłomiej Dach	1be8cb452f	Make new beatmaps' samples match playback rate by default	2021-09-12 16:57:21 +02:00
Dean Herbert	d17f7b5c8b	Side WidescreenStoryboard to on by default for new beatmaps	2021-08-23 17:40:41 +09:00
Dean Herbert	77149044a5	Allow intro screen to retrieve beatmap even if rulesets is not loaded	2021-08-20 19:43:48 +09:00
Bartłomiej Dach	6108451449	Retrieve separated skin instance from working beatmap for editing	2021-08-15 21:18:09 +02:00
Dean Herbert	0be75cc4ed	Fix incorrect base call causing import optimisation to not work	2021-07-03 22:35:46 +09:00
Dan Balasescu	697b07acb1	Merge branch 'master' into fix-beatmap-import-fk-failure	2021-06-29 11:36:31 +09:00
Dan Balasescu	92fcf90768	Merge branch 'master' into import-early-checksum-abort	2021-06-28 19:29:08 +09:00
Dean Herbert	90b87cbb9e	Add back unidirectional online id check	2021-06-28 10:11:27 +09:00
Dean Herbert	9a96cd4a1d	Revert "Remove comparison of online beatmap IDs during dedupe checks" ... This reverts commit 15af28d2a0.	2021-06-28 09:54:18 +09:00
Dean Herbert	15af28d2a0	Remove comparison of online beatmap IDs during dedupe checks	2021-06-27 14:48:57 +09:00
Dean Herbert	46f8100f43	Remove overly verbose logging during beatmap imports	2021-06-27 14:29:02 +09:00
Dean Herbert	dcba7bf779	Fix import flow potentially hitting foreign key constraint	2021-06-23 17:34:56 +09:00
Dean Herbert	17fa2426d4	Merge branch 'master' into legacy-skin-resource-improvements	2021-05-31 19:36:09 +09:00
Dean Herbert	b16d10bd95	Provide game-wide resources via IStorageResourceProvider	2021-05-31 18:57:47 +09:00
Dean Herbert	675fe37446	Change check order around to ensure re-fetches which return no results don't nullref	2021-05-31 18:35:18 +09:00
Dean Herbert	06bd696cc2	Remove previous consumption logic in GetWorkingBeatmap ... This should not be required since the introduction of `workingCache`, which does the same thing in a more global way.	2021-05-31 14:11:58 +09:00
Bartłomiej Dach	ab077c6656	Merge branch 'master' into non-nullable-beatmapset-files	2021-05-31 00:10:03 +02:00
Bartłomiej Dach	78213e09d4	Merge branch 'master' into editor-exit-stability	2021-05-30 23:03:50 +02:00
Dean Herbert	8652ac05db	Merge branch 'editor-exit-stability' into non-nullable-beatmapset-files	2021-05-28 18:58:35 +09:00
Dean Herbert	ee5eb9576f	Fix completely wrong conditional logic	2021-05-28 18:38:50 +09:00
Dean Herbert	581a86b91a	Revert "Revert "Fix editor tests failing due to empty files being specified"" ... This reverts commit 1af684c4b2.	2021-05-28 14:33:06 +09:00
Dean Herbert	41733af0ed	Revert "Revert "Make BeatmapSetInfo.Files non-nullable"" ... This reverts commit 9c4f39e968.	2021-05-28 14:33:05 +09:00
Dean Herbert	b349ff8693	Revert "Add temporary accounting for tests with null files" ... This reverts commit e52c0a34f8.	2021-05-28 14:33:04 +09:00
Dean Herbert	e52c0a34f8	Add temporary accounting for tests with null files	2021-05-28 14:31:26 +09:00
Dean Herbert	9c4f39e968	Revert "Make BeatmapSetInfo.Files non-nullable" ... This reverts commit c24712642c.	2021-05-28 14:15:28 +09:00
Dean Herbert	1af684c4b2	Revert "Fix editor tests failing due to empty files being specified" ... This reverts commit fdbd421040.	2021-05-28 14:15:28 +09:00
Salman Ahmed	4f6de6fdc6	Implement GetSkin() for other working beatmaps	2021-05-21 20:21:29 +03:00
Dean Herbert	c24712642c	Make BeatmapSetInfo.Files non-nullable	2021-05-20 17:39:52 +09:00
Dean Herbert	fdbd421040	Fix editor tests failing due to empty files being specified	2021-05-20 17:09:55 +09:00
Dean Herbert	7980bdd384	Revert incorrectly changed requery code	2021-05-20 15:41:58 +09:00
Dean Herbert	a639132825	Avoid doing any re-fetch on beatmap from test scenes	2021-05-19 17:58:28 +09:00
Naxess	400f8b3938	Add GetStream to IWorkingBeatmap ... This is necessary to obtain the filesize of the audio and background files.	2021-04-17 17:47:13 +02:00
Bartłomiej Dach	a16c0641b2	Revert EF Core to version 2.2 ... This reverts commit f3faad74d5, reversing changes made to 712e7bc7bf. Several issues arose after migrating to 5.0, including, but possibly not limited to, performance regressions in song select, as well as failures when attempting to save beatmaps after metadata changes in the editor.	2021-03-21 11:05:15 +01:00
Dean Herbert	eda891223c	Start the editor with empty artist/creator/difficulty name fields	2021-03-17 16:47:12 +09:00
Roman Kapustin	0a1e325fc7	Extract requerying of navigational properties from DbContext	2021-03-14 19:34:53 +03:00
Roman Kapustin	47b80d2474	Workaround InvalidOperation exceptions	2021-03-11 20:51:54 +03:00
Dean Herbert	b1cd01ceb8	Apply ConfigureAwait changes to game side	2021-03-08 14:36:35 +09:00
Dean Herbert	103dd4a6ce	Remove WorkingBeatmap's finalizer	2021-03-02 16:14:43 +09:00
Dean Herbert	a080a9bdbc	Merge pull request #11603 from Game4all/handle-stable-imports-custom-songs-folder ... Handle beatmap import from a stable installation with a custom Songs directory	2021-02-12 21:42:36 +09:00
Dean Herbert	5f23bd7259	Revert most of the changes to ArchiveModeManager by using better code	2021-02-12 12:48:32 +09:00
Lucas A	383c40b992	Address remaining reviews suggestions.	2021-01-26 20:35:42 +01:00
Lucas A	9f9206726a	Fix typos.	2021-01-26 18:11:54 +01:00
Lucas A	51d4da565c	Fix ArchiveModelManagers lookup paths.	2021-01-24 22:25:49 +01:00
smoogipoo	24e991a5ef	Actually return beat length and not BPM	2021-01-15 14:35:09 +09:00
smoogipoo	c6e9a6cd5a	Make most common BPM more accurate	2021-01-15 14:28:49 +09:00
Dean Herbert	a97a2b2a66	Add nullability to BeatmapManager's GameHost reference	2020-12-22 12:03:25 +09:00
Dean Herbert	10c2745682	Add region specifications around implicit interface implementations	2020-12-22 12:01:09 +09:00
Dean Herbert	a5bcf1dc20	Expose resources to skin via interface (and share common pieces with beatmap)	2020-12-21 15:18:52 +09:00
Dean Herbert	0ffbe12fcc	Expose resources to beatmaps in a saner way	2020-12-21 14:22:34 +09:00
Dean Herbert	7c804be4d3	Rename textureStore to make its purpose more clear	2020-12-21 14:06:33 +09:00
smoogipoo	dfbc0965e4	Merge branch 'master' into peppy/skinnable-health-display	2020-10-16 23:17:17 +09:00
Dean Herbert	e89c5c3b3c	Add dynamic compile exceptions to fix skin test scenes	2020-10-16 17:08:46 +09:00
Dean Herbert	88ffcb9234	Update EndsWith usages	2020-10-16 12:58:34 +09:00
Dean Herbert	50eca202f4	User IEnumerable for HandledExtensions	2020-10-02 16:17:10 +09:00
Dean Herbert	50ba320a51	Expand available file operations in ArchiveModelManager	2020-09-25 13:16:30 +09:00
Dean Herbert	5b93752065	Merge pull request #10103 from smoogipoo/disable-online-lookups-tests ... Disable online beatmap lookups in tests	2020-09-09 21:21:04 +09:00
smoogipoo	aeae009512	Disable online beatmap lookups in tests	2020-09-09 20:12:40 +09:00
Dean Herbert	2cd07b2d3c	Fix editor crash on saving more than once ... I'm fixing this in the simplest way possible as this kind of issue is specific to EF core, which may cease to exist quite soon. Turns out the re-retrieval of the beatmap set causes concurrency confusion and wasn't actually needed in my final iteration of the new beatmap logic.	2020-09-09 12:48:12 +09:00
smoogipoo	9ab6d584d3	Merge branch 'master' into editor-new-beatmap	2020-09-07 14:30:41 +09:00
Dan Balasescu	e17ccdfe9f	Merge branch 'master' into combo-colors	2020-09-07 13:55:41 +09:00
Dean Herbert	fba253f131	Take user argument in CreateNew method parameters	2020-09-04 13:17:43 +09:00
Dean Herbert	d32b77f045	Add missing extension to filename ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2020-09-03 21:33:25 +09:00
Dean Herbert	1c1c583d3b	Fix regression in file update logic (filename set too early)	2020-09-03 19:31:40 +09:00
Dean Herbert	d849f7f2b5	Use the local user's username when saving a new beatmap	2020-09-03 13:20:23 +09:00
Dean Herbert	e337e6b3b0	Use a more correct filename when saving	2020-09-03 13:20:23 +09:00
Dean Herbert	e032844570	Start with a fresh beatmap when entering editor from main menu	2020-09-03 13:20:23 +09:00
Craftplacer	c2ade44656	Change types back	2020-09-01 17:58:06 +02:00
Craftplacer	1484e78654	Update xmldoc	2020-08-31 17:24:00 +02:00
Craftplacer	e428144f73	Use IBeatmapSkin	2020-08-30 11:34:50 +02:00
Craftplacer	e6646b9877	Resolve review comments	2020-08-23 15:08:02 +02:00
Craftplacer	c4a7fac760	Add required parameters and other various changes	2020-08-15 22:03:24 +02:00
smoogipoo	91e28b849d	Fix incorrect BeatmapManager construction	2020-08-13 00:29:23 +09:00
smoogipoo	338c01fa43	Remove track store reference counting, use single instance stores	2020-08-11 13:16:06 +09:00
Craftplacer	78692dc684	Initial commit	2020-08-10 05:21:10 +02:00
smoogipoo	e87f50f74f	Rename method	2020-08-07 22:31:41 +09:00
smoogipoo	f53672193e	Fix track stores being kept alive	2020-08-06 17:48:07 +09:00
smoogipoo	86ae61c6b7	Re-implement store transferral in BeatmapManager	2020-08-06 16:24:14 +09:00
smoogipoo	6e42b8219c	Move track to MusicController, compiles	2020-08-06 16:24:14 +09:00
Dean Herbert	632f333ce2	Add ability to return protected beatmaps in GetAllUsable call	2020-07-10 17:20:27 +09:00
smoogipoo	6afd6efdeb	Return default beatmap if local beatmap can't be retrieved	2020-06-22 20:33:08 +09:00
smoogipoo	88aed1d504	Merge branch 'master' into update-inspectcode-version	2020-06-09 20:12:39 +09:00
Dan Balasescu	1476412eaa	Merge branch 'master' into startup-safety	2020-06-09 13:55:33 +09:00
Dean Herbert	63003757c4	Remove WorkingBeatmap cache when deleting or updating a beatmap	2020-06-08 14:48:26 +09:00
smoogipoo	443977aa8d	Remove PreUpdate, update hash in Save()	2020-06-08 14:40:17 +09:00
smoogipoo	dfed27bd46	Add back stream seeking for sanity	2020-06-08 14:24:21 +09:00
Dean Herbert	b41384dde8	Merge branch 'master' into multiplayer-beatmap-checksum	2020-06-07 18:05:33 +09:00
smoogipoo	0107e9ba16	Change lookups to use SingleOrDefault()	2020-06-05 19:18:00 +09:00
Dean Herbert	c155ab8339	Check filenames and timestamps before reusing an already imported model	2020-06-03 18:03:10 +09:00