39686 Commits

Author	SHA1	Message	Date
Joseph Madamba	2fbd67cf26	Merge branch 'master' into beatmap_wedge_clean_ii	2023-09-04 11:24:20 -07:00
Joseph Madamba	f616648730	Remove icon blending	2023-09-04 09:40:35 -07:00
Bartłomiej Dach	a200d043be	Merge pull request #24698 from Wleter/skin-editor-closest-anchor ... Fix closest anchor for rotated/flipped selections in skin editor	2023-09-04 10:29:05 +02:00
Joseph Madamba	6c0bd13308	Add xmldoc to newly exposed methods	2023-09-04 00:53:14 -07:00
Joseph Madamba	5abf271b56	Implement beatmap options popover	2023-09-04 00:53:09 -07:00
Hồ Nguyên Minh	d5a89c4c45	Fix formatting	2023-09-04 13:32:42 +07:00
Hồ Nguyên Minh	b17a55d6a8	Add length check for slider velocity	2023-09-04 10:43:05 +07:00
Magnus-Cosmos	40dbf098d2	Use existing localisation for "view profile"	2023-09-02 22:51:08 -04:00
Magnus-Cosmos	d674856e29	Use existing localisations in BeatmapInfoWedge	2023-09-02 22:49:29 -04:00
Bartłomiej Dach	76954f6e91	Merge branch 'master' into skin-editor-selection-negative-scaling	2023-09-01 21:30:24 +02:00
Wleter	fc4069f794	let SelectionBox perform flip with scale handles	2023-09-01 13:01:51 +02:00
Wleter	47160f7744	make getClosestAnchor work with rotated drawable	2023-08-31 20:24:26 +02:00
Dean Herbert	038e618af0	Merge branch 'master' into switch-to-new-score-download-endpoint	2023-08-31 00:15:57 +09:00
Wleter	f277909470	maintain rotated selection's centre position	2023-08-30 09:16:16 +02:00
Dean Herbert	96a5443813	Merge branch 'master' into carousel-difficulty-split	2023-08-30 14:24:30 +09:00
Dean Herbert	cbd4b91feb	Merge pull request #24678 from Nabile-Rahmani/bot-scores ... Fix and use score user's IsBot property in results screen animation	2023-08-30 14:00:35 +09:00
Nabile Rahmani	270e2a6600	Update osu.Game/Rulesets/Mods/ModExtensions.cs ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-29 23:59:08 +02:00
Nabile Rahmani	b658b0e346	Fix and use score user's IsBot property in results screen animation ... While a mod-created replay did flag itself as performed by a bot, the extension method converting it into a Score did not copy all the generated properties. As noted, it might be preferable for ModCreatedUser to inherit APIUser and forward it as-is to the Score instance. Related to PR #24675	2023-08-29 23:28:50 +02:00
Wleter	ce1bc71567	formatting	2023-08-29 18:41:56 +02:00
Wleter	586ce6e8d3	fix multiple selected	2023-08-29 17:47:42 +02:00
Wleter	14ee0ee395	Merge branch 'ppy:master' into skin-editor-selection-negative-scaling	2023-08-29 17:30:55 +02:00
Wleter	d56ab0fe9a	change names	2023-08-29 17:25:52 +02:00
Wleter	3c575516ab	add correct scaling for 90 degrees rotation	2023-08-29 17:06:23 +02:00
Bartłomiej Dach	d07530b241	Mark "Score V2" mod as not user-playable ... The mod generally will only be present on scores imported from stable. As such, it's probably ok to mark it as such. The primary reason for this change is to address #24436 (Score V2 being visible on beatmap overlay leaderboard mod selector). There is one possibly-unintended consequence of this change, namely that the results screen uses `UserPlayable` to determine as to whether animations should be played back, with the intention of turning off the animation playback for autoplay scores specifically. Therefore, turning off this flag will mean that the results screen animations will not play out for Score V2 scores - but I tend to consider this as either largely unimportant, or something that should be fixed in some other way (possibly by checking against the autoplay mod directly). Other usages of `UserPlayable` are either innocuous, or straight-up good safeties going forward in the context of Score V2 (guards against selection in mod select overlays, against score submission with the mod).	2023-08-29 11:52:11 +02:00
Wleter	07e126241d	working negative scaling	2023-08-28 16:41:55 +02:00
Bartłomiej Dach	99d5ff9efb	Switch download requests to new API endpoint ... This API endpoint is intended for usage with the entire `solo_scores` machinery and ID schema, rather than the legacy `*_scores_high` ID schema. It also supports automagically falling back to downloading legacy replays if a stable-imported score is requested for download (internally this happens via `legacy_score_id` in the `data` json). This change will allow replays to be downloaded, but it will still not yield 100% correct behaviour, as there is further work to be done in that respect. The download tracker is expecting score hashes to arrive from web to verify the integrity of the incoming download, but the API does not expose such a facility right now; we will have to decide as to whether we want to add one web-side, or whether we want to disable the checking client-side.	2023-08-28 13:50:52 +02:00
Bartłomiej Dach	97d1c6e9fc	Merge branch 'master' into carousel-difficulty-split	2023-08-28 11:07:43 +02:00
Bartłomiej Dach	b9795eb3d4	Fix changes to beatmap sets being undone on switching sort mode	2023-08-28 11:02:22 +02:00
Bartłomiej Dach	80ec18d117	Fix incorrect selection restore code in split case ... The fallback to "any of the added sets" needs to be applied after they've all been added, rather than with every added one. Otherwise, in flows that expect a particular difficulty to be selected in the end (such as exiting from editor) would end up switching away from the edited beatmap.	2023-08-28 10:06:26 +02:00
Bartłomiej Dach	0af6cc1394	Fix online ID not being propagated in split difficulty mode ... Would result in failures to re-download the beatmap in update flows, for instance.	2023-08-28 10:05:59 +02:00
Dean Herbert	10b1450138	Rename remove method to better explain return type being IEnumerable	2023-08-25 18:10:54 +09:00
Dean Herbert	bf0f4fddad	Localise non-overridden samples	2023-08-25 01:08:22 +09:00
Dean Herbert	35cdd6d866	Use string.Empty	2023-08-25 01:07:07 +09:00
Dean Herbert	89eeff515b	Reduce complexity of selection restore	2023-08-25 00:52:54 +09:00
Dean Herbert	9e94f38091	Fix typo in local variable	2023-08-24 18:33:15 +09:00
Dean Herbert	081fb308e1	Merge branch 'master' into new-overlay-sfx	2023-08-24 18:29:00 +09:00
Jamie Taylor	f4415a5bab	Add more detail to comment	2023-08-24 18:20:36 +09:00
Jamie Taylor	7ef5a71e91	Move PopIn/PopOut sample playback from WaveOverlayContainer to WaveContainer (so Multiplayer/Lounge plays the samples)	2023-08-24 18:13:23 +09:00
Jamie Taylor	2e27a476bb	Re-enable sample playback for PasswordEntryPopover and remove sampleJoin playback instead	2023-08-24 18:04:47 +09:00
Dean Herbert	a8e4237e34	Enable sentry "global mode" as per recommendation ... Sentry documentation suggests this should be on for a client-facing app. We haven't run into issues without it until now, but might as well set it correctly?	2023-08-24 03:23:18 +09:00
Dean Herbert	72d2715222	Show mod settings as "on" or "off" rather than "True" or "False"	2023-08-23 20:21:43 +09:00
Dean Herbert	d6aded3ac3	Update framework	2023-08-23 20:11:55 +09:00
Dean Herbert	91c2cadb47	Add missing colon in mod settings tooltip	2023-08-23 19:13:32 +09:00
Dean Herbert	018be4c20f	Fix selection not being retained when switching between split mode	2023-08-22 18:49:02 +09:00
Dean Herbert	ecbf0f138e	Fix incorrect handling when new beatmaps arrive	2023-08-22 18:48:07 +09:00
Dean Herbert	2b1c6ae612	Ensure ID is maintained in temporary BeatmapSetInfos	2023-08-22 18:48:07 +09:00
Dean Herbert	290d18ad69	Split out difficulties in beatmap carousel in a bit of a hacky way ... Seems like the simplest path forward for now, without a full rewrite.	2023-08-22 18:47:41 +09:00
Bartłomiej Dach	8cd9f0822a	Merge branch 'master' into judge-fix	2023-08-22 09:44:58 +02:00
Bartłomiej Dach	5be5335784	Reword comment to be better	2023-08-22 09:37:54 +02:00
Bartłomiej Dach	142abe1fd0	Make highlight messages important in order to trigger window flash	2023-08-22 09:01:32 +02:00
Bartłomiej Dach	aa29e00578	Remove FlashTaskbar and use IsImportant directly instead	2023-08-22 08:58:48 +02:00
Bartłomiej Dach	be1a712f33	Make OsuGame dependency nullable	2023-08-22 08:54:41 +02:00
Bartłomiej Dach	71b5be2568	Merge branch 'master' into ux/notifications/flash-on-message	2023-08-22 08:20:08 +02:00
Dean Herbert	f09b818418	Update resources	2023-08-22 13:17:12 +09:00
Dan Balasescu	e8337c592a	Update framework and apply changes to support masking SSBO	2023-08-22 12:50:13 +09:00
Dean Herbert	2937dcef1a	Merge pull request #24610 from bdach/remove-global-action-container-hack ... Remove global action container input queue workaround	2023-08-22 12:44:26 +09:00
tsrk	96c58c86ea	refactor: make flashing available in Notifications ... This will be used in `NotificationOverlay` when a `Notification` is posted.	2023-08-21 23:36:54 +02:00
Wleter	9f4f81c150	accumulating negative scaling	2023-08-21 19:36:11 +02:00
Bartłomiej Dach	5454d1caa1	Remove global action container input queue workaround ... As described in #24248, the workaround employed by `GlobalActionContainer`, wherein it tried to handle actions with priority before its children by being placed in front of the children and not _actually containing_ said children, is blocking the resolution of some rather major input handling issues that allow key releases to be received by deparented drawables. To resolve, migrate `GlobalActionContainer` to use `Prioritised`, which can be done without regressing certain mouse button flows after ppy/osu-framework#5966.	2023-08-21 17:54:08 +02:00
Bartłomiej Dach	273dcf9150	Also update the reference to added flag in schema change breakdown	2023-08-21 17:44:35 +02:00
Bartłomiej Dach	99c862f894	Merge branch 'master' into fix-score-import-fail-fail-fail	2023-08-21 17:28:10 +02:00
Bartłomiej Dach	8533cba0bf	Fix mismatching schema version in comment	2023-08-21 17:27:05 +02:00
Bartłomiej Dach	aa5680a8aa	Merge pull request #24527 from Pasi4K5/fix-slider-reversing ... Fix sliders being reversed incorrectly in the editor	2023-08-21 17:12:00 +02:00
Bartłomiej Dach	6cd48e9db5	Merge pull request #24604 from peppy/fix-star-fountain-directions ... Fix star fountain directions not matching stable	2023-08-21 17:00:51 +02:00
tsrk	bdac052631	refactor(MessageNotifier): apply changes required by framework	2023-08-21 15:29:41 +02:00
OliBomby	e283aa2843	Update inline comments	2023-08-21 13:09:31 +02:00
OliBomby	5bc11ed358	Revert "Ensure invariant of monotone time" ... This reverts commit 5d1ccc2601.	2023-08-21 13:02:23 +02:00
OliBomby	c7b1c75379	Revert "Fix typo" ... This reverts commit 90f2acaf0a.	2023-08-21 13:00:01 +02:00
Dean Herbert	b3e7416972	Rename new flag and update xmldoc to match	2023-08-21 19:36:22 +09:00
Dean Herbert	662073c472	Fix some incorrect comments / test step descriptions ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2023-08-21 19:35:04 +09:00
Dean Herbert	db893f3dc7	Merge branch 'master' into fix-score-import-fail-fail-fail	2023-08-21 19:34:12 +09:00
Dean Herbert	5f040a991b	Fix potential crash when loading menu items due to cross-thread ops	2023-08-21 19:05:20 +09:00
Dean Herbert	e7d61e0002	Fix star fountain directions not matching stable	2023-08-21 17:59:24 +09:00
Dean Herbert	4915b2563c	Merge pull request #24366 from Joehuu/supporter-playlist-duration ... Always show supporter-only playlist durations	2023-08-21 17:46:26 +09:00
Bartłomiej Dach	1d657a8844	Merge branch 'master' into fix-slider-reversing	2023-08-21 09:29:46 +02:00
Bartłomiej Dach	90bef267c8	Merge pull request #24581 from OliBomby/fix-segment-ends ... Fix `SliderPath.GetSegmentEnds`	2023-08-21 09:29:13 +02:00
Bartłomiej Dach	dd1ac461db	Reformat xmldoc	2023-08-21 08:29:51 +02:00
Bartłomiej Dach	c27f06c0a7	Merge branch 'master' into formats-nrt	2023-08-21 08:17:34 +02:00
Bartłomiej Dach	de9a4448fc	Merge branch 'master' into fix-export-slider	2023-08-21 07:28:16 +02:00
Bartłomiej Dach	a942b6ff74	Replace inline comment with actual explanation of what's happening	2023-08-21 07:27:02 +02:00
Wleter	d2798c7a1c	don't allow negative scaling	2023-08-20 17:55:19 +02:00
OliBomby	56b1062c2f	expand xmldoc	2023-08-19 19:39:29 +02:00
Dean Herbert	8120c3f87a	Merge branch 'master' into precise-rotation-2	2023-08-19 23:25:42 +09:00
Bartłomiej Dach	0a55830c16	Add braces for clarification ... I like no-braces for single-line ifs as much as anyone, but with inline comments involved it gets rather dicey.	2023-08-19 14:34:20 +02:00
tsrk	548e6dc23b	feat(MessageNotifier): flash window on PM or mention	2023-08-19 03:04:09 +02:00
Pasi4K5	44a85139e4	Update Reverse() based on the changes in #24581	2023-08-19 02:40:18 +02:00
Pasi4K5	47d787b359	Merge remote-tracking branch 'OliBomby/fix-segment-ends' into fix-slider-reversing	2023-08-19 02:38:34 +02:00
Pasi4K5	0e691d5935	Revert changes in SliderPath	2023-08-19 00:16:05 +02:00
OliBomby	ff07fbae15	fix GetSegmentEnds	2023-08-18 12:20:40 +02:00
Dean Herbert	cbee7c7146	Merge branch 'master' into import-stable-date-added	2023-08-18 18:01:06 +09:00
Dean Herbert	5e0b89a1a8	Rename GetPath to GetFullPath to better match expectations	2023-08-18 17:56:43 +09:00
Dean Herbert	864f1bdb3e	Move population of import time to the Populate method ... Feels like a better place to be doing this. I think we want to keep any kind of potentially expensive work in the `Populate` method.	2023-08-18 17:56:11 +09:00
Dean Herbert	eb2460d180	Remove dead metadata transfer code	2023-08-18 17:40:00 +09:00
Dean Herbert	9023059bc0	Convert to switch statement	2023-08-18 17:27:09 +09:00
Dean Herbert	75750957c7	Add note about why pop in samples are disabled for PasswordEntryPopover	2023-08-18 17:11:30 +09:00
Dean Herbert	fc2fac577f	Inverse and xmldoc ShearedToggleButton sample allowance bool	2023-08-18 17:05:25 +09:00
Pasi4K5	3481c41a22	Fix segmentEnds being calculated incorrectly	2023-08-18 04:34:10 +02:00
OliBomby	360f9750e1	Allow selecting empty control point groups	2023-08-17 16:30:18 +02:00
Dean Herbert	c811546868	Update resources	2023-08-17 21:09:50 +09:00
Jamie Taylor	d10d7b6ea4	Change some component samples to go better with overlay pop-in samples	2023-08-17 18:36:37 +09:00