29194 Commits

Author	SHA1	Message	Date
Dean Herbert	b9983add15	Rename User to APIUser and move to correct namespace	2021-11-04 18:21:31 +09:00
Dean Herbert	df3c3a32ce	Fix unintentionally broken background update logic	2021-11-04 18:07:39 +09:00
Dean Herbert	25b0bccfd5	Remove unused team class	2021-11-04 17:39:42 +09:00
Dean Herbert	b80c02b757	Fix crash on gameplay startup if beatmap has no background	2021-11-04 17:24:40 +09:00
Dean Herbert	eb17d897a3	Finally, remove the To* methods as they have no usages	2021-11-04 17:09:53 +09:00
Dean Herbert	08d94f864f	Update ScoresContainer to not use ToBeatmapInfo	2021-11-04 17:09:53 +09:00
Dean Herbert	7bab487621	Remove usage of ToBeatmapInfo in APIScoreInfo.CreateScoreInfo	2021-11-04 17:09:53 +09:00
Dean Herbert	d2831b1152	Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2	2021-11-04 17:09:50 +09:00
Dean Herbert	5a078da4d9	Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues	2021-11-04 16:50:14 +09:00
Dean Herbert	c820d445ad	Merge pull request #15461 from peppy/fix-more-computationally-expensive ... Fix a few more "maybe null" inspections	2021-11-04 16:49:38 +09:00
Dean Herbert	8f459e6ce8	Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues	2021-11-04 16:44:17 +09:00
Dean Herbert	317506d4d7	Fix a few more "maybe null" inspections	2021-11-04 16:11:23 +09:00
Dean Herbert	09701d0af1	Use explicit primitive type specification	2021-11-04 16:02:37 +09:00
Dean Herbert	0f4f1349db	Merge branch 'master' into editor-context-menu-on-select	2021-11-04 15:59:06 +09:00
Dean Herbert	a5a7181915	Fix unintentionally broken background update logic	2021-11-04 15:35:32 +09:00
Dean Herbert	4b1b92cde6	Stop BeatmapInfo from implementing IBeatmapOnlineInfo and remove all usages	2021-11-04 15:23:04 +09:00
Dean Herbert	9c926e5514	Remove BeatmapSetInfo.OnlineInfo and all usages	2021-11-04 15:23:04 +09:00
Dean Herbert	66f4516eee	Allow creating sample API models without specifying a ruleset	2021-11-04 15:23:04 +09:00
Dean Herbert	e3a9fbecfe	Add method to create sample APIBeatmap (with BeatmapSet populated)	2021-11-04 15:23:04 +09:00
Dean Herbert	0d0eab90bc	Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/remove-online-info	2021-11-04 15:23:02 +09:00
Dean Herbert	84d36cbae7	Add fallback for cases where BeatmapSet may be null ... Seems to only happen in tests, but better safe than sorry.	2021-11-04 15:22:33 +09:00
Dean Herbert	e43d91ad5d	Fix another case of incorrect null checking in editor verification processing	2021-11-04 15:18:10 +09:00
Dean Herbert	d1e6d1cb98	Update some other missed incorrect null/empty usages	2021-11-04 14:50:43 +09:00
Dean Herbert	a49366ff84	Remove nullability from IBeatmapInfo.Metadata	2021-11-04 14:28:39 +09:00
Dean Herbert	1e73b09e57	Fix another couple of cases of incorrect string null/empty checking	2021-11-04 14:22:28 +09:00
Dean Herbert	41854f2e16	Fix incorrect check on AudioFile presence	2021-11-04 14:02:09 +09:00
Dean Herbert	67d9590a79	Fix new inspections	2021-11-04 14:02:09 +09:00
Dean Herbert	0df339d0b8	Fix incorrect invocation of download method in SoloSpectator	2021-11-04 13:50:04 +09:00
Dean Herbert	0ab50f1cc9	Add inline comment explaining why we are manually populating beatmap.BeatmapSet	2021-11-04 13:45:59 +09:00
Dean Herbert	9f9c960fe3	Revert PlaylistItem.APIBeatmap to be private	2021-11-04 13:36:32 +09:00
Dean Herbert	05f1fd4bc9	Remove unnecessary properties and parameters	2021-11-04 13:33:54 +09:00
Dean Herbert	3453160a8b	Change PlaylistItem.Beatmap to be an IBeatmapInfo	2021-11-04 13:16:56 +09:00
Dean Herbert	772b6c6dcd	Enable nullable support on BeatmapMetadata	2021-11-04 12:11:42 +09:00
Dean Herbert	6fdeb66dc1	Use APIBeatmap instead of BeatmapInfo in playlist display classes where feasible	2021-11-04 11:55:50 +09:00
Dean Herbert	1d8e253112	Expose PlaylistItem.APIBeatmap for now	2021-11-04 11:53:26 +09:00
Dan Balasescu	dd948e5ada	Merge pull request #15447 from peppy/fix-invalid-characters-zip-export ... Fix beatmaps being exported with malformed filenames inside `.osz` zip files	2021-11-04 09:03:51 +09:00
Bartłomiej Dach	098fa181b4	Fix text flow wrapping incorrectly in multiplayer usages	2021-11-03 18:36:43 +01:00
Dean Herbert	8d40d55d93	Update framework	2021-11-03 17:09:49 +09:00
Dean Herbert	d85224d7ad	Merge branch 'master' into localisable-text-flow	2021-11-03 17:09:46 +09:00
Dean Herbert	ca438a102d	Fix beatmap paths including invalid slash/backslash characters	2021-11-03 16:46:05 +09:00
Dean Herbert	900549a771	Merge pull request #15398 from bdach/beatmap-card-basics ... Add basic elements of new beatmap cards	2021-11-03 15:35:29 +09:00
Bartłomiej Dach	cf7545e36c	Merge branch 'master' into beatmap-card-basics	2021-11-03 00:11:03 +01:00
Bartłomiej Dach	1813681fac	Move private method below protected	2021-11-03 00:10:50 +01:00
Bartłomiej Dach	75e89f17ad	Rewrite BeatmapCardContentBackground	2021-11-03 00:07:03 +01:00
Bartłomiej Dach	494d582830	Fix PlaylistItem attempting to read from OsuColour dependency too early	2021-11-02 23:19:45 +01:00
Bartłomiej Dach	195a141625	Fix score tracker not tracking non-online scores correctly	2021-11-02 22:51:25 +01:00
Bartłomiej Dach	e4e8390a8a	Update ScreenEntry colour usage to update correctly on language change	2021-11-02 21:42:03 +01:00
Bartłomiej Dach	d218e7d935	Remove manual romanisation handling in PlaylistItem	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	ed00cd9fc5	Remove simple localisable .ToString() calls	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	11de924704	Use LocalisableStrings where possible to leverage localisable text flow	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	ad98ab0a26	Fix drawable room playlist item assuming single sprite text	2021-11-02 21:42:02 +01:00
Bartłomiej Dach	b95c95527e	Accept LocalisableStrings in LinkFlowContainer	2021-11-02 21:42:01 +01:00
Bartłomiej Dach	98367fc482	Update usages of GetLocalised{-> Bindable}String	2021-11-02 21:42:01 +01:00
Dean Herbert	47914c49ba	Fix missed null consideration	2021-11-03 04:54:36 +09:00
Dean Herbert	fe9b8f3274	Merge pull request #15432 from peppy/fix-beatmap-availability-potentially-wrong ... Fix multiplayer potentially getting incorrect beatmap availability state after changing beatmaps	2021-11-03 04:54:22 +09:00
Dean Herbert	5ea901da2e	Merge pull request #15429 from peppy/fix-beatmap-download-notifications ... Fix beatmap download notifications not showing beatmap name correctly	2021-11-03 04:36:59 +09:00
Dean Herbert	a97e5fbd89	Merge pull request #15431 from peppy/fix-unauth-api-requests ... Fix unauthenticated API requests no longer working	2021-11-03 04:35:48 +09:00
Dean Herbert	85037dfb70	Fix multiplayer potentially getting incorrect beatmap availability state after changing beatmaps	2021-11-03 04:32:21 +09:00
Dean Herbert	cb5c6e1924	Merge pull request #15427 from peppy/fix-multiplayer-panel-star-rating-display ... Fix multiplayer panels not correctly showing star rating	2021-11-03 04:21:01 +09:00
Dean Herbert	f67f42dc5b	Merge pull request #15430 from bdach/fix-multi-submission ... Fix multiplayer score submission not working	2021-11-03 04:10:23 +09:00
Dean Herbert	51e92e1b2d	Check for null/empty instead	2021-11-03 04:09:31 +09:00
Dean Herbert	8d0b32981f	Fix unauthenticated API requests no longer working	2021-11-03 03:30:15 +09:00
Dean Herbert	392559ae3e	Fix beatmap download notifications not showing beatmap name correctly	2021-11-03 03:23:41 +09:00
Bartłomiej Dach	c028275d6c	Fix multiplayer score submission not working	2021-11-02 19:16:44 +01:00
Dean Herbert	6efd3d3115	Don't perform background difficulty calculation for multiplayer panels ... There are cases these are shown in a long list. They shouldn't be running calculations.	2021-11-03 03:12:52 +09:00
Dean Herbert	08b0ffad50	Fix incorrect check for local beatmap in BeatmapDifficultyCache ... This was correct in the WIP branch I have, but pulled out alone (where usages of `ToBeatmapInfo` still exist) it was not enough.	2021-11-03 03:12:52 +09:00
Dean Herbert	c85a4dca28	Fix crash when attempting to view global leaderboards	2021-11-03 02:47:33 +09:00
Dean Herbert	73b09f3b3d	Merge pull request #15409 from smoogipoo/fix-pp-counter-rate-adjust ... Fix PP counter showing incorrect values with rate adjustment mods	2021-11-03 00:06:13 +09:00
smoogipoo	81aaef719f	Add xmldoc to CalculateTimed()	2021-11-02 17:55:00 +09:00
smoogipoo	168a7a588b	Add xmldoc to ctor also	2021-11-02 17:19:14 +09:00
smoogipoo	efba7a9c4d	Missed hyphen	2021-11-02 17:18:02 +09:00
smoogipoo	0cdd2898fe	Expose non-adjusted time from CalculateTimed()	2021-11-02 17:17:14 +09:00
Dean Herbert	135df0e190	Avoid adding null users to RecentParticipants	2021-11-02 17:13:37 +09:00
Dean Herbert	1bfa1365a0	Rename "null user" tests to better explain purpose	2021-11-02 17:13:37 +09:00
Dean Herbert	b0bd39fc49	Fix multiplayer room participants display not updating as new users join/leave ... Can add tests on request, but not sure the code around this area is here to stay permanently. Should be pretty low risk. - Closes https://github.com/ppy/osu/issues/14788.	2021-11-02 17:13:37 +09:00
smoogipoo	eaeee80a26	Fix PP counter showing incorrect values with rate adjustment mods	2021-11-02 16:55:20 +09:00
Dan Balasescu	6f941a8916	Merge pull request #15405 from peppy/legacy-decoder-default-section ... Default legacy decoder to `General` section, rather than none	2021-11-02 15:42:25 +09:00
smoogipoo	1e9211c00b	Use explicit type	2021-11-02 15:41:25 +09:00
Dean Herbert	5d784b2ef8	Perform a consistency check by decoding the newly written skin.ini during ComputeHash ... As this has regressed twice now, let's play it safe and bail rather than stack overflowing. Note that as all the underlying issues that could trigger this have been fixed, no additional tests have been added. To test, comment out `SkinManager.cs` line 228-229 to cause a failure. The new logic will kick in and show a log output message, but all tests will still (correctly) pass.	2021-11-02 14:11:25 +09:00
Dean Herbert	2e66ab453d	Always write automated changes to skin metadata at the end of the file ... Apart from being cleaner (and allowing removal at the point of export, if that is ever requires), this also gives us a better guarantee that the metadata is going to take effect. By writing the `[General]` section ourselves, we avoid any issues that may be present from a user constructing the file (incorrectly) themselves, such as multiple `Title:` entries or a malformed `[General]` marker. The main goal is to ensure that the name is updated to what we expect it to be.	2021-11-02 14:11:25 +09:00
Dean Herbert	15c770e155	Remove no longer used Section.None	2021-11-02 14:01:41 +09:00
Dean Herbert	ab28948744	Default legacy decoder to General section, rather than none ... This is mainly to reach parity with how stable handles such cases for skins specifically. It was brought to our attention after finding a skin with a malformed `\[General]` tag which did not break further parsing of the file on stable, but did on lazer. Note that stable defaults to an "unknown" section for beatmaps, but functionally I can't think of a regression case from changing this to a "general" default.	2021-11-02 13:59:13 +09:00
Bartłomiej Dach	90fb536a25	Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.11' into update-dependencies	2021-11-01 20:53:43 +01:00
Bartłomiej Dach	d05d0f2b88	Merge branch 'dependabot/nuget/Sentry-3.10.0' into update-dependencies	2021-11-01 20:53:19 +01:00
Bartłomiej Dach	bfcd7948fe	Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.11' into update-dependencies	2021-11-01 20:52:56 +01:00
Bartłomiej Dach	e4672981d8	Merge branch 'dependabot/nuget/SharpCompress-0.30.0' into update-dependencies	2021-11-01 20:52:44 +01:00
Bartłomiej Dach	f671ee28c5	Use buffered container to eliminate gaps near foreground border	2021-11-01 20:17:27 +01:00
Bartłomiej Dach	a59f2d7b83	Implement basic hover card state	2021-11-01 19:41:11 +01:00
Bartłomiej Dach	5962f16b1c	Implement basic card appearance	2021-11-01 19:41:11 +01:00
dependabot[bot]	3b7379b777	Bump Microsoft.AspNetCore.SignalR.Client from 5.0.10 to 5.0.11 ... Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Client dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-11-01 17:02:20 +00:00
dependabot[bot]	e0a940be1d	Bump Sentry from 3.9.4 to 3.10.0 ... Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.9.4 to 3.10.0. - [Release notes](https://github.com/getsentry/sentry-dotnet/releases) - [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.9.4...3.10.0) --- updated-dependencies: - dependency-name: Sentry dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2021-11-01 17:02:14 +00:00
dependabot[bot]	f215439b4f	Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-11-01 17:02:10 +00:00
dependabot[bot]	f8f4b9d3d3	Bump SharpCompress from 0.29.0 to 0.30.0 ... Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.29.0 to 0.30.0. - [Release notes](https://github.com/adamhathcock/sharpcompress/releases) - [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.29...0.30) --- updated-dependencies: - dependency-name: SharpCompress dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2021-11-01 17:02:04 +00:00
dependabot[bot]	f893556b80	Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson ... Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11. - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2021-11-01 17:02:00 +00:00
Dean Herbert	3a5aed1182	Ensure APIScoreInfo.Mods is non-null	2021-11-01 22:59:12 +09:00
Dean Herbert	caa9d8997b	Merge branch 'master' into score-refactor/less-create-score-info	2021-11-01 22:59:11 +09:00
Bartłomiej Dach	793c384ecd	Remove unnecessary null-conditional access	2021-11-01 12:02:37 +01:00
Bartłomiej Dach	5dcff7d8b7	Merge branch 'master' into score-refactor/less-create-score-info	2021-11-01 11:41:20 +01:00
Dan Balasescu	95b1f5830d	Merge branch 'master' into beatmap-refactor/beatmap-overlays	2021-11-01 19:32:07 +09:00
Dan Balasescu	8c38698506	Merge pull request #15363 from peppy/beatmap-refactor/get-and-present ... Update `GetScoreRequest` and `PresentBeatmap` to accept interface types	2021-11-01 19:28:28 +09:00
Dan Balasescu	65d2b54ef6	Merge pull request #15387 from bdach/fix-score-download-tracker ... Fix incorrect state transition in score download tracker	2021-11-01 18:36:35 +09:00
Dean Herbert	b21e0e7efb	Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays	2021-11-01 18:07:51 +09:00
Dean Herbert	602fe372c2	Merge branch 'score-refactor/isolated-serialisation' into beatmap-refactor/get-and-present	2021-11-01 18:06:53 +09:00
Dean Herbert	5dcc940864	Merge branch 'master' into fix-score-download-tracker	2021-11-01 17:50:34 +09:00
Bartłomiej Dach	f5feed138d	Merge branch 'master' into score-refactor/isolated-serialisation	2021-11-01 09:43:51 +01:00
Bartłomiej Dach	cd4681496a	Fix incorrect state transition in score download tracker	2021-11-01 09:35:02 +01:00
Dean Herbert	63c9512ab1	Update dashboard components to use APIBeatmapSet	2021-11-01 16:04:01 +09:00
Dean Herbert	722e0d50bb	Fix BeatmapInfo not being correctly populated in CreateScoreInfo call	2021-11-01 15:54:39 +09:00
Dan Balasescu	c51349de57	Merge pull request #15358 from peppy/online-id-potentially-zero ... Add a note about `OnlineID` potentially being zero in non-autoincrement cases	2021-11-01 15:54:08 +09:00
Dean Herbert	b98faf6159	Merge branch 'master' into score-refactor/isolated-serialisation	2021-11-01 15:49:25 +09:00
Dan Balasescu	9e633a1b17	Merge pull request #15321 from peppy/beatmap-refactor/download-tracker ... Replace `DownloadTrackingComposite` with instantiable `DownloadTracker` components	2021-11-01 15:48:12 +09:00
smoogipoo	94dce3f92a	Remove whitespace	2021-11-01 15:43:19 +09:00
Dan Balasescu	cd9ee7723a	Merge pull request #15384 from peppy/fix-tourney-map-pool-creator-shows-twice ... Fix beatmap creator showing twice in tournament map pool panels	2021-11-01 15:24:54 +09:00
Dean Herbert	227963047a	Fix hash validity check function returning incorrect results after soft deleting a beatmap ... The soft-deleted one would potentially match before the newly imported copy, resulting in a false-positive hash mismatch.	2021-11-01 15:15:45 +09:00
Dean Herbert	123b10f647	Fix playlist item download button being clickable when it shouldn't	2021-11-01 15:10:32 +09:00
Dean Herbert	21e0074d3b	Add missing AddInternal call for BeatmapSetHeaderContent's download tracker	2021-11-01 14:43:32 +09:00
Dean Herbert	10a9266956	Fix beatmap creator showing twice in tournament map pool panels	2021-11-01 14:33:24 +09:00
Dean Herbert	6b250955d7	Add missing verbatim string markers	2021-11-01 14:24:38 +09:00
Dean Herbert	5bfb16efe2	Ignore case when searching for existing skin.ini	2021-11-01 14:24:38 +09:00
Dean Herbert	708b57348d	Change loose api ordering requirement to throw instead	2021-11-01 13:22:16 +09:00
Dean Herbert	269a8df0ec	Fix HasReplay not being corrrectly implemented by APIScoreInfo	2021-11-01 13:20:37 +09:00
Dean Herbert	19feae4a8e	Merge branch 'master' into beatmap-refactor/download-tracker	2021-11-01 13:15:36 +09:00
Dean Herbert	02e69626e3	Reduce fail animation tint slightly	2021-11-01 13:06:26 +09:00
Bartłomiej Dach	914e5c0f9d	Fix star rating not updating for some mods on details tab in song select ... `AdvancedStats` was locally assuming that the only changes in mods that are relevant to it are if the mods are `IApplicableToDifficulty`. This is not true, as other mods (such as `IApplicableToRate` mods, or more recently, Flashlight) can also affect star difficulty, which is shown on one of the bars in `AdvancedStats`.	2021-10-31 18:58:17 +01:00
Dean Herbert	b63a90966b	Remove misplaced access modifier in interface specification ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-31 23:49:26 +09:00
Bartłomiej Dach	9e05e7af74	Merge branch 'master' into add-hw-accel-setting	2021-10-30 15:19:01 +02:00
Bartłomiej Dach	e9ba1ea198	Mark IScoreInfo implementation with region	2021-10-30 15:08:45 +02:00
Bartłomiej Dach	8053b2c320	Merge branch 'master' into score-refactor/isolated-serialisation	2021-10-30 15:07:34 +02:00
Bartłomiej Dach	b0c4fa662d	Merge branch 'master' into long-online-id-score-info	2021-10-30 14:35:30 +02:00
Bartłomiej Dach	6e4f7af8d3	Mark IHasOnlineID implementation with region	2021-10-30 14:15:20 +02:00
Bartłomiej Dach	5a8dff0e4e	Merge branch 'master' into beatmap-refactor/difficulty-icons	2021-10-30 14:06:15 +02:00
Dean Herbert	e9473db77c	Reorder to have video settings next to renderer ... Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>	2021-10-30 20:37:55 +09:00
Opelkuh	4d988340eb	Add hardware acceleration toggle	2021-10-30 01:02:53 +02:00
Dean Herbert	5311fe2d02	Merge branch 'master' into beatmap-refactor/beatmap-overlays	2021-10-29 22:37:29 +09:00
Dean Herbert	f8aa4c2851	Merge pull request #15352 from bdach/text-flow-parts ... Update text flow usages to use `ITextPart`	2021-10-29 22:32:46 +09:00
Dean Herbert	1fd05ab78a	Update framework	2021-10-29 18:56:13 +09:00
Dean Herbert	a16c8f1ebc	Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet	2021-10-29 18:50:55 +09:00
Dean Herbert	b8ee7e05f4	Expose more pieces of APIBeatmap for testing purposes	2021-10-29 18:35:27 +09:00
Dean Herbert	993a28b37e	Merge branch 'beatmap-refactor/difficulty-icons' into beatmap-refactor/beatmap-overlays	2021-10-29 18:35:26 +09:00
Dean Herbert	07e3ced315	Fix test scene and remove "impossible" nullable coalesce	2021-10-29 18:22:23 +09:00
Dean Herbert	7db8bdfb7c	Fix fallback logic not considering case where ruleset is not available ... Occurs only in tests.	2021-10-29 18:16:54 +09:00
Dean Herbert	8ad33d43d0	Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays	2021-10-29 18:01:17 +09:00
Dean Herbert	3be9c487f8	Merge branch 'beatmap-refactor/download-tracker' into beatmap-refactor/beatmap-overlays	2021-10-29 18:01:12 +09:00
Dean Herbert	90503f72ca	Update PresentBeatmap to support interface types	2021-10-29 17:43:39 +09:00
Dean Herbert	b5834044e0	Update GetScoreRequest to support requests with interface types	2021-10-29 17:43:39 +09:00
Dean Herbert	be0564f732	Update DifficultyIcon classes to use IBeatmapInfo	2021-10-29 17:05:06 +09:00
Dean Herbert	aff216840f	Add a note about OnlineID potentially being zero in non-autoincrement cases	2021-10-29 16:54:03 +09:00
Dean Herbert	7583435901	Refactor BeatmapDifficultyCache to work with IBeatmapInfo	2021-10-29 16:45:10 +09:00
Dean Herbert	31403daa20	Change DrawableProfileScore to use APIScoreInfo	2021-10-29 15:14:52 +09:00
Dean Herbert	17a83f701a	Store mods as APIMods for the time being	2021-10-29 15:13:49 +09:00