75 Commits

• Fix most open compound words in identifiers being closed
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  7de43e3aba
• Add helper method for editor check tests
  Dean Herbert · 2021-11-24 14:22:41 +09:00
  c7bc03e6f7
• Update tests which set Files lists directly
  Dean Herbert · 2021-11-24 14:00:14 +09:00
  c2f8d9f677
• Refactor to avoid duplicate code
  Naxesss · 2021-11-10 06:18:40 +01:00
  72ee2b1556
• Add background stream closed test
  Naxesss · 2021-11-10 05:04:30 +01:00
  5dc6a9ed21
• Update some other missed incorrect null/empty usages
  Dean Herbert · 2021-11-04 14:50:43 +09:00
  d1e6d1cb98
• Fix new inspections
  Dean Herbert · 2021-11-04 14:02:09 +09:00
  67d9590a79
• Merge branch 'master' into no-more-difficulty-control-points-info
  smoogipoo · 2021-10-14 12:02:10 +09:00
  aa380a11c1
• Merge branch 'master' into file-sanity-checks
  Bartłomiej Dach · 2021-10-14 00:17:29 +02:00
  c7db286b94
• Add proper stream disposal to tests
  Dean Herbert · 2021-10-12 11:04:41 +09:00
  7f95400f46
• Undo disposal of Stream for use in mocking

  Because the Stream object is accessed when the mocked object calls `GetStream`, we cannot close it here.
  
  The resource should be released upon teardown anyway.

  Naxesss · 2021-10-12 00:35:58 +02:00
  bb9cbd3e66
• Dispose of Streams when used
  Naxesss · 2021-10-12 00:13:38 +02:00
  47b4d03145
• Remove redundant Bass.Init call in test setup
  Naxesss · 2021-10-11 23:58:06 +02:00
  01d77fb741
• Merge branch 'master' into no-more-difficulty-control-points-info
  smoogipoo · 2021-10-08 18:41:17 +09:00
  bc37cb6f43
• Copy BaseDifficulty to Beatmap<T> and move all write operations across
  Dean Herbert · 2021-10-06 15:10:45 +09:00
  b339c149d8
• Update tests to use more correct control point definitions
  Dean Herbert · 2021-09-06 22:04:51 +09:00
  1952ebece9
• Update outdated tests
  Dean Herbert · 2021-09-03 17:11:12 +09:00
  b2a14b13dc
• Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time

  This allows fetching the correct `DifficultyControlPoint` from the
  hitobject. Nothing more.

  Dean Herbert · 2021-09-03 17:11:12 +09:00
  d4e5a612ea
• Move approach rate to EffectControlPoint
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  a3d9ab1e2e
• Fix test regressions
  Dean Herbert · 2021-08-30 17:25:36 +09:00
  9fae2c350d
• Add zero-length objects check and tests
  Naxess · 2021-07-13 10:50:11 +02:00
  6da2a3d51f
• Add audio in video check and tests
  Naxess · 2021-07-13 04:17:41 +02:00
  c8f58cbf6c
• Add too short audio files check and tests
  Naxess · 2021-07-13 03:46:45 +02:00
  a4a1919842
• Add zero byte check and tests
  Naxess · 2021-07-13 03:45:21 +02:00
  0a8fd01b99
• Add nested hitobject tests for few hitsounds check
  Naxess · 2021-06-27 15:58:00 +02:00
  b58644106c
• Use local variables for common sample lists
  Naxess · 2021-06-27 15:57:41 +02:00
  1dbac76da5
• Add concurrent hitobjects test for few hitsounds check

  See https://github.com/ppy/osu/pull/13669#discussion_r659314980

  Naxess · 2021-06-27 15:26:52 +02:00
  1d5bff1660
• Move MockNestedHitObject to own class
  Naxess · 2021-06-27 15:16:40 +02:00
  c2ceb83bbb
• Fix comments in few hitsounds check tests
  Naxess · 2021-06-26 23:43:08 +02:00
  5642d321b7
• Add hitsounded with break test
  Naxess · 2021-06-26 19:57:12 +02:00
  82b64f5589
• Add few hitsounds check tests
  Naxess · 2021-06-26 19:21:15 +02:00
  a5abc664f3
• Add muted object check tests
  Naxess · 2021-06-26 19:21:01 +02:00
  7b9569a117
• Fix test not being marked as headless
  smoogipoo · 2021-05-19 13:36:39 +09:00
  e8bc2cac5b
• Simplify
  smoogipoo · 2021-05-18 19:15:46 +09:00
  ab6a79f84c
• Remove Component inheritance
  smoogipoo · 2021-05-18 18:59:45 +09:00
  97f4f7bbd1
• Rename to HitObjectUsageEventBuffer
  smoogipoo · 2021-05-18 18:57:02 +09:00
  633f841a0f
• Add test
  smoogipoo · 2021-05-18 18:49:05 +09:00
  a31a6947bb
• Fix case of hitObjects variables
  Dean Herbert · 2021-05-14 16:22:19 +09:00
  9069db0743
• Use TestWorkingBeatmap instead of null in tests

  Fixes the warning that #12801 will give.

  Naxess · 2021-05-14 05:32:52 +02:00
  9860e482af
• Remove accidental whitespace
  Naxess · 2021-05-13 12:56:36 +02:00
  94538b3842
• Move IBeatmap arg into context
  Naxess · 2021-05-13 11:24:22 +02:00
  19800f5f7f
• Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks

  This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
  
  See next commit for example.

  Naxess · 2021-05-12 02:29:18 +02:00
  c13b93e6f1
• Rename unsnap check templates
  Naxess · 2021-04-27 13:56:05 +02:00
  200352b750
• Sort objects by time in concurrent check test
  Naxess · 2021-04-27 00:36:26 +02:00
  0f0870c8b8
• Rename CheckUnsnaps -> CheckUnsnappedObjects

  Will potentially have `CheckUnsnappedKiai` or similar later, so this is worth specifying.
  
  Also consistent with `CheckConcurrentObjects`, which will likely have a `CheckConcurrentLines` later.

  Naxess · 2021-04-26 20:32:44 +02:00
  ce258febf6
• Add concurrent object check tests
  Naxess · 2021-04-26 20:22:24 +02:00
  b8cdcf56c0
• Fix duplicate code in unsnap test
  Naxess · 2021-04-26 17:44:46 +02:00
  71f880aa94
• Add unsnap check tests
  Naxess · 2021-04-26 04:48:56 +02:00
  9178aa1d7d
• Fix usage of _ in Moq lambdas
  Naxess · 2021-04-20 13:29:14 +02:00
  c0318a4d3e
• Add file hash to file presence test

  Necessary because we now find the storage path of the file rather than just the file itself.

  Naxess · 2021-04-20 13:28:32 +02:00
  6a1e4ff99f