293 Commits

• Merge pull request #28809 from bdach/mania-timeline-zooms-composer

  Match mania editor playfield time range with timeline zoom

  Dan Balasescu · 2024-07-11 15:41:26 +09:00
  00cab0ec0a
• Match mania editor playfield time range with timeline zoom
  Bartłomiej Dach · 2024-07-10 17:36:39 +02:00
  92dc125d39
• Enable NRT on ManiaHitObjectComposer
  Bartłomiej Dach · 2024-07-10 15:12:03 +02:00
  fa749d317e
• Remove setup screen controls that do nothing useful

  Before I go with a hammer to redesign these, I want to remove stuff that
  does nothing first.
  
  Hard-breaks API to allow rulesets to specify an enumerable of custom
  sections rather than two specific weird ones.
  
  For specific rulesets:
  
  - osu!:
    - Stack leniency slider merged into difficulty section.
  - osu!taiko:
    - Approach rate and circle size sliders removed.
    - Colours section removed.
  - osu!catch:
    - No functional changes.
  - osu!mania:
    - Special style toggle merged into difficulty section.
    - Colours section removed.

  Bartłomiej Dach · 2024-07-10 14:53:16 +02:00
  c8a64c5950
• Allow modifying hold note start/end time via mania composer playfield
  Bartłomiej Dach · 2024-06-12 15:30:27 +02:00
  feadf7a56e
• Fix failing tests due to missing DI pieces
  Dean Herbert · 2024-06-12 11:23:56 +08:00
  2a8bd8d968
• Attempt full editor reload on key count change
  Bartłomiej Dach · 2024-06-11 11:31:49 +02:00
  da53a11d3c
• Split mania difficulty section implementation off completely from base

  - "Circle size" / key count needs completely different handling.
  - Approach rate does not exist in mania.

  Bartłomiej Dach · 2024-06-11 11:30:20 +02:00
  10af642342
• Implement flip operations in mania editor
  Bartłomiej Dach · 2024-06-07 09:01:41 +02:00
  629e7652c0
• Remove redundant cast
  Bartłomiej Dach · 2024-05-14 18:41:15 +02:00
  3d190f7e88
• Refactor abstract check to reduce duplication
  Bartłomiej Dach · 2024-03-26 11:13:03 +01:00
  1866b4b6b1
• Make check ruleset specific
  Arthur Araujo · 2024-03-22 14:48:22 -03:00
  6fa663c8ca
• Remove warning for 10K+
  Arthur Araujo · 2024-03-20 16:51:27 -03:00
  2d6a3b8e2b
• Add mania keycount check
  Arthur Araujo · 2024-03-20 15:52:16 -03:00
  c605e463a4
• Reduce allocations in ManiaSelectionBlueprint
  Andrei Zavatski · 2024-02-20 20:47:41 +03:00
  b92cff9a8e
• fix near-zero length sliders n stuff being placeable
  OliBomby · 2023-12-19 21:20:21 +01:00
  ec578e1d9f
• Rename variable
  Bartłomiej Dach · 2023-11-20 22:04:08 +09:00
  a8fc73695f
• Compile regexes
  Bartłomiej Dach · 2023-11-20 22:03:25 +09:00
  364a3f75e1
• Rename and document SelectFromTimestamp
  Bartłomiej Dach · 2023-11-20 21:57:14 +09:00
  b6215b2809
• Updated comments, renamed method
  ratinfx · 2023-11-12 15:09:15 +01:00
  fab6fc9adb
• Do Split and Parse before checking HitObjects
  ratinfx · 2023-11-12 14:58:46 +01:00
  4e7c40f1d7
• Refactor HitObject selection in Composer
  ratinfx · 2023-11-11 14:02:42 +01:00
  4e1e19728c
• HitObject Selection logic and separation for gamemodes

  + moved time_regex into EditorTimestampParser

  ratinfx · 2023-11-07 01:36:58 +01:00
  aa87e0a44d
• Merge branch 'master' into taiko-beat-snap-grid
  Dean Herbert · 2023-10-19 23:53:01 +09:00
  52c2eb93de
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Remove unused using directive
  Bartłomiej Dach · 2023-10-17 10:30:01 +02:00
  2192c9f2c2
• Remove unused field
  Bartłomiej Dach · 2023-10-17 10:27:16 +02:00
  22c1a963e7
• Combine selection and input handling logic for beat snap grids across all rulesets
  Dean Herbert · 2023-10-17 17:09:42 +09:00
  4381169a3f
• Abstract out common implementation of BeatSnapGrid
  Dean Herbert · 2023-10-17 16:42:52 +09:00
  1b9acdf55c
• Cache IScrollingInfo at a HitObjectComposer level automatically
  Dean Herbert · 2023-10-17 16:42:22 +09:00
  d26d4b8b79
• Use a DrawablePool for mania's beat snap grid

  I'm not sure what the cause of the issue is, but I'm also not sure why
  it wasn't using `DrawablePool` (was it not around back then?).
  
  Either way, switching to a proper pool fixes things just fine.
  
  Resolves https://github.com/ppy/osu/issues/25009.

  Dean Herbert · 2023-10-10 13:36:31 +09:00
  1a60d6ade5
• Fix publicly-settable bindables
  Dean Herbert · 2023-10-06 16:51:24 +09:00
  f2e56bbb65
• Implement new interface-based speed change visualisation support on mania/taiko
  Dean Herbert · 2023-09-20 15:28:13 +09:00
  cb0226f843
• Remvoe null default for mods which can't be null
  Dean Herbert · 2023-09-20 15:27:50 +09:00
  41a8239e49
• Move toggle implementation to work on all scrolling rulesets automatically
  Dean Herbert · 2023-09-01 19:53:10 +09:00
  37c2b330a2
• Allow toggling SVs in the editor
  Dan Balasescu · 2023-08-18 18:55:24 +09:00
  a2fd7707a1
• Disable SVs from being visualised in mania editor
  Dan Balasescu · 2023-08-15 18:51:24 +09:00
  ec9e7f14a8
• Fix mania key count slider still using circle size precision
  Bartłomiej Dach · 2023-07-22 16:10:58 +02:00
  157aec5144
• Fix "key count" setting showing as "circle size" in osu!mania editor

  Closes https://github.com/ppy/osu/issues/12904.

  Dean Herbert · 2023-07-21 18:52:29 +09:00
  fd2bdc10c7
• Fix remaining obvious CI inspections
  Bartłomiej Dach · 2023-06-24 16:07:01 +02:00
  e3a89a6273
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Fix incorrect colouring of beat snap grids (mania and catch)
  Dean Herbert · 2023-06-07 12:25:34 +09:00
  6d446d3e97
• Move blueprint validity conditions to allow more correct external usage of EndPlacement

  Until now, these were haphazardly enforce inline in blueprint
  implementations. The only thing stopping complete breakage is that
  `EndPlacement` wasn't called (too much) from outside the blueprint,
  leaving them responsible for their own placement.
  
  By moving this conditional out of the provided paramters to
  `EndPlacement`, it allows more flexible usage of that method externally.
  Coming in a future PR.

  Dean Herbert · 2023-05-12 16:02:22 +09:00
  f443cfb93e
• Match generally used casing

  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

  Bartłomiej Dach · 2023-05-09 07:03:13 +02:00
  0a47ffcbdd
• Fix incorrect special style description text

  Closes https://github.com/ppy/osu/issues/23428.

  Dean Herbert · 2023-05-08 13:00:45 +09:00
  85d0c56cd2
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Avoid casting by accepting all Playfields but throwing on a bad choice
  Dean Herbert · 2022-10-11 16:54:41 +09:00
  f41b79688f
• Anchor drag box on time (catch, mania)

  Not done for taiko because I cannot figure out how it should work with the overlapping scroll algorithm.

  ekrctb · 2022-10-11 14:23:17 +09:00
  6ab29a62d0
• Add a few more overlooked beatmap save states on setup screen modifications
  Dean Herbert · 2022-08-16 16:31:56 +09:00
  ee153a345c