160 Commits

• Fix editing juice stream path sometimes changing its duration

  I'm not *super* sure why this works, but it appears to, and my educated
  guess as to why is that it counteracts the effects of a change in the SV
  of the juice stream by artificially increasing or decreasing the
  velocity when running the appropriate path conversions and expected
  distance calculations. The actual SV change takes effect on the next
  default application, which is triggered by the `Update()` call at the
  end of the method.

  Bartłomiej Dach · 2024-07-22 15:14:45 +02:00
  f3617eadad
• Fix EditablePath.UpdateHitObjectFromPath() not automatically updating object

  This is important because the editable path conversions heavily depend
  on the value of `JuiceStream.Velocity` being correct. The value is only
  guaranteed to be correct after an `ApplyDefaults()` call, which is
  triggered by updating the object via `EditorBeatmap`.

  Bartłomiej Dach · 2024-07-22 14:50:25 +02:00
  56af009e77
• Unify juice stream piece UX with osu! control point pieces

  - Use same hover state
  - Use shift-right click for quick delete rather than shift-left click

  Bartłomiej Dach · 2024-07-22 13:30:15 +02:00
  6b3c1f4e47
• Fix catch juice stream vertex remove operation not undoing
  Bartłomiej Dach · 2024-07-22 13:21:49 +02:00
  47964f33d7
• Fix catch juice stream vertex add operation not undoing
  Bartłomiej Dach · 2024-07-22 12:18:53 +02:00
  64381d4087
• Update HasFlag usages
  Dean Herbert · 2024-07-03 00:19:04 +09:00
  5350945340
• Adjust calls to GetContainingInputManager()
  Bartłomiej Dach · 2024-06-18 07:41:19 +02:00
  659505f711
• Merge pull request #27723 from 64ArthurAraujo/editor-fix-reverse-selection

  Fix reverse selection not updating new combo location

  Bartłomiej Dach · 2024-03-28 11:25:17 +01:00
  21201e616d
• Simplify implementation
  Bartłomiej Dach · 2024-03-28 10:12:27 +01:00
  2f786ffc32
• Fix combo not reversing properly depending on the order of selection
  Arthur Araujo · 2024-03-26 12:10:40 -03:00
  01a72d5afa
• Refactor abstract check to reduce duplication
  Bartłomiej Dach · 2024-03-26 11:13:03 +01:00
  1866b4b6b1
• Use order of new combo flags instead of StartTime
  Arthur Araujo · 2024-03-26 04:59:47 -03:00
  10683de578
• Handle new combo on HandleReverse
  Arthur Araujo · 2024-03-25 04:19:14 -03:00
  78037fa477
• Make check ruleset specific
  Arthur Araujo · 2024-03-22 14:48:22 -03:00
  6fa663c8ca
• fix near-zero length sliders n stuff being placeable
  OliBomby · 2023-12-19 21:20:21 +01:00
  ec578e1d9f
• Generalize Bezier curves to BSplines of Nth degree
  Thomas Müller-Höhne · 2023-11-11 13:32:53 +01:00
  926636cc03
• Fix catch distance snap grid not moving

  Regressed in https://github.com/ppy/osu/pull/25154.
  Specifically, in 013b5fa916
  and 74b86349d5.
  
  A simple case of too-much-code-deleted-itis.

  Bartłomiej Dach · 2023-10-26 15:42:50 +02:00
  359ae31204
• Tidy up CatchHitObjectComposer
  Dean Herbert · 2023-10-19 23:57:36 +09:00
  74b86349d5
• Move beat snap grid implementation details to ScrollingHitObjectComposer
  Dean Herbert · 2023-10-19 23:54:34 +09:00
  013b5fa916
• Merge branch 'master' into taiko-beat-snap-grid
  Dean Herbert · 2023-10-19 23:53:01 +09:00
  52c2eb93de
• Inherit ScrollingHitObjectComposer in catch
  Bartłomiej Dach · 2023-10-19 11:58:25 +02:00
  0c4e74c82d
• Remove DistancedHitObjectComposer inheritance from catch composer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  31849192c3
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Combine selection and input handling logic for beat snap grids across all rulesets
  Dean Herbert · 2023-10-17 17:09:42 +09:00
  4381169a3f
• Abstract out common implementation of BeatSnapGrid
  Dean Herbert · 2023-10-17 16:42:52 +09:00
  1b9acdf55c
• Move comment a bit to fix formatting

  Would otherwise trigger IDE0055, but that isn't resolveable without
  an inspection cycle with resharper, so just move in a more sane place.

  Bartłomiej Dach · 2023-09-20 12:22:05 +02:00
  f2791d4f3e
• Remvoe null default for mods which can't be null
  Dean Herbert · 2023-09-20 15:27:50 +09:00
  41a8239e49
• Merge branch 'master' into mania-edit-disable-sv
  Dean Herbert · 2023-09-20 14:23:07 +09:00
  c5397bdbb3
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28
• Move toggle implementation to work on all scrolling rulesets automatically
  Dean Herbert · 2023-09-01 19:53:10 +09:00
  37c2b330a2
• Remove no-longer-necessary ReceivePositionalInputAt overide in CatchPlacementBlueprint
  Dean Herbert · 2023-07-12 17:39:54 +09:00
  d12845d7b1
• Fix incorrect colouring of beat snap grids (mania and catch)
  Dean Herbert · 2023-06-07 12:25:34 +09:00
  6d446d3e97
• Add beat snap grid for osu!catch editor

  As discussed in https://github.com/ppy/osu/discussions/23462.

  Dean Herbert · 2023-06-06 17:52:29 +09:00
  c1f23ef211
• Fix incorrect catch grid specification
  Dean Herbert · 2023-05-26 10:41:29 +09:00
  3c69956b55
• Split out grid snapping modes into "relative" and "global" types
  Dean Herbert · 2023-05-25 21:41:19 +09:00
  804671ca74
• Move blueprint validity conditions to allow more correct external usage of EndPlacement

  Until now, these were haphazardly enforce inline in blueprint
  implementations. The only thing stopping complete breakage is that
  `EndPlacement` wasn't called (too much) from outside the blueprint,
  leaving them responsible for their own placement.
  
  By moving this conditional out of the provided paramters to
  `EndPlacement`, it allows more flexible usage of that method externally.
  Coming in a future PR.

  Dean Herbert · 2023-05-12 16:02:22 +09:00
  f443cfb93e
• remove redundant zero check in sv calculation
  OliBomby · 2023-05-02 12:29:11 +02:00
  d2d81bb82c
• fix 0 velocity juicestream
  OliBomby · 2023-04-30 16:43:26 +02:00
  79f3cfec91
• remove all regular usage of DifficultyControlPoint
  OliBomby · 2023-04-26 17:55:38 +02:00
  c44f71a737
• Move right-side editor toolbox to base HitObjectComposer

  Move right-side editor toolbox to base `HitObjectComposer`

  Dean Herbert · 2023-04-04 19:00:56 +09:00
  f9ebdadfe8
• Remove redundant canBeNull: true
  ekrctb · 2023-01-15 23:11:59 +09:00
  d664a66a37
• Remove #nullable disable from Catch.Edit namespace
  ekrctb · 2023-01-15 17:29:32 +09:00
  a75fc5108a
• Code Quality
  Dylan Nantz · 2023-01-13 10:16:52 -05:00
  6028abff39
• Merge branch 'master' of https://github.com/ppy/osu into 18469
  Dylan Nantz · 2023-01-13 09:54:29 -05:00
  5dd0aaccef
• Use PlacementState to check juice stream placement
  Dylan Nantz · 2023-01-13 09:37:23 -05:00
  e38075c4ef
• Use MaxBy in all locations that can and update inspection level to match dotnet-build
  Dean Herbert · 2022-12-19 16:47:10 +09:00
  4a7d7c6ed9
• Show distance snap for first juice stream object. Fixes #18469
  Dylan Nantz · 2022-12-05 15:12:50 -05:00
  4ab7ef9af9
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove nullable disable annotation in the cache ruleset.
  andy840119 · 2022-11-05 16:49:55 +08:00
  4d4d7cf863
• Add osu!catch read-distance-spacing implementation
  Dean Herbert · 2022-10-26 13:45:06 +09:00
  f8a4af5e0e