2791 Commits

Author	SHA1	Message	Date
OliBomby	ab6bf6e1dc	Merge remote-tracking branch 'upstream/master' into carousel	2023-01-16 00:27:56 +01:00
OliBomby	1c0a650575	Fix typo	2023-01-16 00:17:26 +01:00
OliBomby	87ee9ab813	Added custom menu items in DrawableCarouselBeatmap	2023-01-16 00:13:12 +01:00
mk56-spn	9a29c9ae26	remove hacky method to check if carousel is null	2023-01-15 15:32:53 +01:00
Dean Herbert	c5775aa452	Merge branch 'master' into song_select_nullability	2023-01-15 22:44:13 +09:00
Dean Herbert	4cf4a66858	Make MusicController a required dependency of SongSelect	2023-01-15 22:43:30 +09:00
Dean Herbert	f7af5a8115	Revert some formatting changes	2023-01-15 22:39:00 +09:00
Dean Herbert	4906f37109	Merge pull request #22181 from frenzibyte/attempt-fix-song-select-test-failure ... Fix intermittent failure in beatmap carousel tests	2023-01-15 02:35:36 +09:00
ansel	515ada6815	Remove CanBeNull where it's no longer requered	2023-01-13 23:11:50 +03:00
ansel	a41a031909	Localise some notifications	2023-01-13 23:11:25 +03:00
Salman Ahmed	112cf403ec	Fix intermittent failure in certain beatmap carousel tests	2023-01-13 19:41:44 +03:00
mk56-spn	a6b6fb864e	Make carousel non nullable and ensure pre load usages of methods that reference it are protected against failure	2023-01-13 13:10:29 +01:00
mk56-spn	403ca05e5e	Enable nullability for song select	2023-01-13 00:52:14 +01:00
Bartłomiej Dach	aab84d50eb	Remove boxing overhead in CarouselItem comparator	2023-01-10 18:35:06 +01:00
Dean Herbert	b7e845201f	Fix whitespace around Debug.Assert	2023-01-10 18:03:17 +09:00
Dean Herbert	d53dafa29f	Revert Debug.Assert	2023-01-10 17:52:28 +09:00
Dean Herbert	93038ce496	Use OfType instead of forceful nullability	2023-01-10 17:52:21 +09:00
mk56-spn	6abbc7dc28	Further fix nullability	2023-01-09 20:59:28 +01:00
mk56-spn	69260ca3c3	remove unnecessary usages of nullable forgiveness, add asserts for debugging	2023-01-09 18:36:55 +01:00
mk56-spn	47fb467012	Remove nullable disabling in carousel	2023-01-08 19:02:48 +01:00
Dean Herbert	464f251c0c	Merge branch 'master' into beatmap-set-link-genre-language	2023-01-06 17:09:06 +08:00
Salman Ahmed	8f37e69dc4	Schedule difficulty calculation to avoid performing with incomplete state updates	2023-01-05 12:52:08 +03:00
Salman Ahmed	39221a52da	Fix advanced statistics display using decoupled ruleset bindable for difficulty calculation	2023-01-05 12:52:08 +03:00
Dean Herbert	beb3b96aca	Harden request equality checks	2023-01-04 01:44:00 +08:00
Dean Herbert	8f7ae0395a	Fix song select leaderboard potentially showing wrong scores on quick beatmap changes ... Closes #22002.	2023-01-03 00:55:09 +08:00
mk56-spn	680646d3a6	Make offsetting of bottom bar more readable	2022-12-29 12:02:08 +01:00
Joseph Madamba	494886ef92	Rename Text to Metadata	2022-12-23 11:11:15 -08:00
Joseph Madamba	1d39e8d0ce	Refactor MetadataSection to use generics and inheritance	2022-12-21 10:18:47 -08:00
mk56-spn	626f4b0dfd	fix test failures, improve button logic	2022-12-19 16:35:20 +01:00
MK56	878e2f24c4	Merge branch 'master' into footer_V2_implementation	2022-12-19 13:19:23 +01:00
mk56-spn	407b0a0ad3	Address issues from Joehuu review	2022-12-19 11:30:23 +01:00
ansel	b66409bd37	Perform rewind with right click only if cursor didn't leave the button	2022-12-05 23:38:45 +03:00
mk56-spn	7373d79ba6	Use OsuColour instead of hex for button accent colour	2022-12-02 19:16:25 +01:00
mk56-spn	c5bad816db	Add button colouring whilst corresponding overlay is present	2022-12-02 18:44:21 +01:00
mk56-spn	ea882f6874	Add disabled button dimming.	2022-12-01 22:31:14 +01:00
mk56-spn	55a21a75a4	Add hover lightening	2022-12-01 22:07:28 +01:00
mk56-spn	d7cea51551	Add functionality of Random button	2022-12-01 16:29:52 +01:00
mk56-spn	1530495e7c	Add button "accent" colour, bottom bar, icon, text	2022-12-01 15:34:09 +01:00
mk56-spn	774eb178a1	Add basic button design and footer button addition flow	2022-12-01 13:13:37 +01:00
mk56-spn	18b4317e99	Create Basic V2 footer and test	2022-12-01 11:57:50 +01:00
mk56-spn	0aba119056	Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation ... # Conflicts: # osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs # osu.Game/Screens/Select/DifficultyRangeFilterControl.cs	2022-11-27 10:40:29 +01:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
mk56-spn	92ed2ed4ef	Refactor star "DifficultyRangeFilterControl" into generic range slider class	2022-11-26 12:19:08 +01:00
Dean Herbert	de163b2bb5	Change song select to only allow volume adjusting if alt is held while scrolling	2022-11-22 19:48:55 +09:00
Dean Herbert	4a79141824	Merge pull request #21338 from RATCM/fix-leaderboard-filter ... Match leaderboard filter behaviour to web	2022-11-21 14:01:55 +09:00
RATCM	f5fbb7c8de	Changed comments	2022-11-20 19:27:40 +01:00
RATCM	d20a357c0e	Fixed ordering bug	2022-11-20 19:24:51 +01:00
RATCM	9040dfbd4e	Match leaderboard filter behaviour to web	2022-11-20 17:39:46 +01:00
Bartłomiej Dach	7b274083d3	Fix phantom beatmap sets appearing on carousel after delete/update ... Regressed in c40c70509e. As it turns out, `item.Item.Filtered.Value` is not the only condition that should be checked to determine if a carousel item should be hidden or not - `item.Item.State.Value != CarouselItemState.Collapsed` should also be true. This was even available as the `item.Item.Visible` convenience property, which is used in this commit. Failing to check `item.Item.State.Value` led to setting non-zero alpha on collapsed carousel items, leading to phantom beatmap sets appearing, as the alpha was set in the entire carousel's `Update()` method, thus firing every frame.	2022-11-20 10:08:34 +01:00
nanashi-1	4773979e52	add condition	2022-11-17 16:15:34 +08:00
Salman Ahmed	87b4fee10f	Remove leftover constant	2022-11-17 04:05:21 +03:00
Salman Ahmed	55beaf5d93	Revert buttons order change	2022-11-17 04:05:15 +03:00
Salman Ahmed	039ab83a46	Disable beatmap options button when none selected	2022-11-17 04:00:23 +03:00
Salman Ahmed	0e46614c57	Revert beatmap option button state changes	2022-11-17 03:57:01 +03:00
nanashi-1	5d8d8ffce5	fix naming	2022-11-16 10:09:51 +08:00
nanashi-1	55edd6c907	add space	2022-11-16 09:58:49 +08:00
nanashi-1	1fb8357e93	change disabledAlpha from readonly to const	2022-11-16 09:58:32 +08:00
nanashi-1	9101ad0cbd	fixed naming	2022-11-16 09:42:40 +08:00
nanashi-1	5973bb1956	AddButton now returns the button	2022-11-15 20:57:31 +08:00
nanashi-1	1186ed3e32	add disable	2022-11-15 20:56:18 +08:00
nanashi-1	e8d170e772	disable certain options when no beatmap is selected	2022-11-15 20:55:55 +08:00
Dean Herbert	1aa0e40f2f	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
Dean Herbert	e75c3b3f94	Rename SkinnableTarget to GlobalSkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	391840404d	Play exiting transition in both directions	2022-11-07 11:59:43 +09:00
Dean Herbert	c40c70509e	Improve song select transition to gameplay	2022-11-04 15:24:37 +09:00
Dean Herbert	20dd405c2b	Merge branch 'master' into maintain-common-mod-selection	2022-11-03 15:32:40 +09:00
Dean Herbert	d9d083752a	Clamp backwards index to total current items to fix edge case of item removal	2022-10-26 11:03:11 +09:00
Dean Herbert	cf3bf41b49	Harden and simplify logic to avoid weird issues	2022-10-25 18:57:15 +09:00
Dean Herbert	22ea9a8ab4	Add early return of carousel group has no items	2022-10-25 13:34:22 +09:00
Dean Herbert	2456a18bc1	Rewrite implementation to avoid duplicated LINQ returns	2022-10-25 12:48:17 +09:00
Endrik Tombak	5a118cfdc3	Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection ... Conflicts: osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs	2022-10-24 21:40:48 +03:00
Salman Ahmed	01c65d3cc1	Remove seemingly unnecessary/leftover code	2022-10-14 02:16:36 +03:00
Salman Ahmed	964ed01abb	Add confirmation dialog for updating locally modified beatmaps	2022-10-13 02:40:15 +03:00
Dean Herbert	a44ba579c5	Fix beatmap update button not respecting user "prefer no video" setting ... Closes #20701.	2022-10-11 14:27:40 +09:00
Dean Herbert	d9f678d942	Change song select random key binding to not handle key repeat	2022-10-03 18:16:54 +09:00
Dean Herbert	5fc836d1f0	Apply NRT to BeatmapLeaderboard / MatchLeaderboard	2022-09-26 16:17:28 +09:00
Dean Herbert	32d56fe3a9	Use request cancellation and IsDisposed guard instead of more Schedule	2022-09-26 16:02:33 +09:00
Dean Herbert	0fa5e1b28e	Fix intermittent leaderboard crash due to request finishing after drawable is disposed	2022-09-23 20:18:44 +09:00
Dean Herbert	5b73f24864	Fix outdated scores being held by BeatmapLeaderboard after external beatmap switch	2022-09-21 15:21:32 +09:00
Dean Herbert	68c040175a	Ensure Leaderboard.Scores is updated immediately via request flow	2022-09-20 17:02:57 +09:00
Dean Herbert	46db3ad96d	Move implementation to individual classes	2022-09-20 00:06:02 +09:00
Dean Herbert	4c4fdfd153	Provide scores directly to Player instance rather than relying on DI	2022-09-16 18:15:17 +09:00
Dean Herbert	0227eddda1	Merge branch 'master' into gameplay-leaderboards	2022-09-16 15:44:58 +09:00
Dean Herbert	b4e6a20846	Fix song select status prefix matching no longer working ... Regressed in #19275 due to weird logic. Closes #20289.	2022-09-14 12:59:05 +09:00
Dean Herbert	94693a4667	Fix oversight when making interface implementation explicit	2022-09-13 19:55:57 +09:00
Dean Herbert	6d167070f8	Add back DI leaderboard retrieval via bindable pathway	2022-09-13 18:45:11 +09:00
Dan Balasescu	3cfacb5e39	Merge pull request #20257 from peppy/update-button-show-login ... Show login overlay when attempting to update a beatmap while logged out	2022-09-12 17:51:45 +09:00
Dan Balasescu	31225066a1	Merge pull request #19308 from frenzibyte/top-rank-badge-order ... Fix best rank badge not handling legacy scores properly	2022-09-12 16:20:21 +09:00
Dean Herbert	94f8197e22	Show login overlay when attempting to update a beatmap while logged out	2022-09-12 16:15:14 +09:00
Salman Ahmed	95062c2cc8	Remove center origin specification to avoid single-frame layout issues	2022-09-09 19:42:58 +03:00
Salman Ahmed	dd10a06e3d	Merge branch 'master' into top-rank-badge-order	2022-09-09 19:38:44 +03:00
Dean Herbert	602ffebd54	Apply NRT and fix code style	2022-09-09 23:29:04 +09:00
Dean Herbert	d961b96897	Merge branch 'master' into search-filter	2022-09-09 23:25:54 +09:00
Dean Herbert	d463bd2f3f	Merge pull request #20130 from Exanc/master ... Display 0 stars instead of infinity for the minimum star slider	2022-09-08 17:51:32 +09:00
Dean Herbert	d523a2ac33	Rename default value field and make private	2022-09-08 15:53:08 +09:00
Dean Herbert	9ead5e59d3	Fix incorrectly displaying minimum value in placeholder messaging	2022-09-08 15:51:15 +09:00
Dean Herbert	f3bda4e040	Fix weird edge case of nullability in CarouselRoot ... A bit unfortunately, but it's what we get for having ctor level bindings..	2022-09-07 14:27:25 +09:00
Dean Herbert	e18b524f8e	Fix missing null checks on selectedBeatmap fields in BeatmapCarousel	2022-09-07 14:12:35 +09:00
Dean Herbert	241d33d415	Apply NRT to BeatmapCarousel	2022-09-07 14:07:53 +09:00
Exanc	4ea7ca4c07	Slight tweak to the StarsSlider ... - MinimumStarsSlider now shows "0" when at it's minimum - Modified and NoResultsPlaceholder the tooltip to stay consistent with the changes	2022-09-05 00:09:20 +02:00
Dean Herbert	1524623624	Fix back-to-front filter logic ... Was copied across from a place which was checking for `match` and applied verbatim to a place that was `filter`. Which are polar opposites.	2022-09-01 19:59:27 +09:00
Dean Herbert	82b9e1f0eb	Merge pull request #20011 from smoogipoo/scoring-refactor ... Refactor scoring to remove async methods / simplify	2022-08-29 19:55:27 +09:00
Dan Balasescu	423f6f90f2	Remove async calls from ScoreManager	2022-08-29 15:34:08 +09:00
Salman Ahmed	a3e595a9aa	Update comment to include inserted indices	2022-08-26 14:51:19 +03:00
Salman Ahmed	81c0a641b4	Fix selection fallback path not updated to check inserted indices	2022-08-26 14:51:08 +03:00
Salman Ahmed	f38194fb40	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-26 14:35:19 +03:00
Dean Herbert	217fa00a72	Bring logic up-to-date	2022-08-26 19:32:49 +09:00
Dean Herbert	a146db0e35	Merge branch 'master' into carousel-perform-selection	2022-08-26 19:29:00 +09:00
Andrew Hong	55f1b43329	Removed check	2022-08-22 13:41:36 -04:00
Andrew Hong	bcab7aea26	Merge branch 'master' into add-date-created-sort	2022-08-22 04:02:46 -04:00
Andrew Hong	c2036d3893	Moved filter exclusion	2022-08-22 03:39:46 -04:00
Andrew Hong	09ef13908c	Adjust to reviews	2022-08-22 03:20:27 -04:00
Dan Balasescu	0815b01b75	Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation ... Fix selecting preset containing Difficulty Adjust automatically opening customisation panel	2022-08-22 15:44:00 +09:00
Andrew Hong	c6a739f5a8	Add date submitted sorting	2022-08-21 23:09:33 -04:00
Dean Herbert	37799e3b31	Allow preparing preview point without looping	2022-08-17 13:20:24 +09:00
Dean Herbert	9d2c2b71cf	Change conditional to check for insertions in addition to modifications ... It is possible that the import process itself marks the previous beatmaps as deleted due to an overlap in metadata or otherwise.	2022-08-16 16:21:36 +09:00
Bartłomiej Dach	5ff2e41a55	Add preset column to mod select test scene	2022-08-15 18:38:37 +02:00
Dean Herbert	cbe5cb5d03	Merge branch 'master' into carousel-maintain-selection-over-update	2022-08-08 18:01:26 +09:00
Bartłomiej Dach	839409d7ac	Add preset column to solo mod select overlay	2022-08-07 16:20:31 +02:00
Bartłomiej Dach	a0d093be5c	Extract common implementation of delete dialog	2022-08-06 21:04:12 +02:00
Dean Herbert	c0e5f11c90	Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability ... Fix newly imported beatmaps not using correct comparer for sorting	2022-08-02 02:20:51 +09:00
Salman Ahmed	fc7fc3d673	Fix newly imported beatmaps not using correct comparer for sorting	2022-08-01 19:13:57 +03:00
Salman Ahmed	faefda9143	Fix song select not updating selected beatmap card on editor resume	2022-07-30 19:47:42 +03:00
Dean Herbert	ad482b8afc	Tidy up naming of collection dropdowns	2022-07-28 13:57:21 +09:00
Dean Herbert	67c7f324ee	Simplify CollectionFilterDropdown filter flow weirdness	2022-07-28 13:57:21 +09:00
Dean Herbert	438067a18b	Convert realm data propagation to more correctly use Live<T> ... wip	2022-07-27 19:35:09 +09:00
Dean Herbert	41393616d8	Replace BeatmapCollection with RealmBeatmapCollection	2022-07-27 19:35:09 +09:00
Dean Herbert	9c543fef48	Remove CollectionManager	2022-07-27 18:45:33 +09:00
Dean Herbert	e6a3659581	Guard against NewModifiedIndices being empty	2022-07-27 14:23:47 +09:00
Dean Herbert	24d75612e2	Always attempt to follow selection, even if difficulty name / metadata change	2022-07-27 14:18:53 +09:00
Dean Herbert	8105d4854a	Fix beatmap carousel not maintaining selection if currently selected beatmap is updated	2022-07-27 13:33:48 +09:00
Dan Balasescu	8f7dff5c2c	Merge pull request #19378 from peppy/beatmap-update-test ... Add separate beatmap update flow to handle edge cases better	2022-07-26 18:49:20 +09:00
Salman Ahmed	a4f6f2b9eb	Make item ID comparer static	2022-07-26 09:55:37 +03:00
Dean Herbert	8370ca9765	Add ImportAsUpdate method to IModelImporter to avoid otehr changes	2022-07-26 15:49:04 +09:00
Salman Ahmed	693ac8750c	Remove remaining uses of "child" terminology in non-drawable components	2022-07-26 09:43:47 +03:00
Salman Ahmed	d7ef4170be	Maintain sort stability by using carousel item ID as fallback	2022-07-26 09:40:41 +03:00
Dean Herbert	b7f6413bce	Fix old version of beatmap potentially not being deleted during update flow ... This can happen if the online IDs are not present in the `.osu` files. Previously this was only working due to the early logic in the import process (that relies on matching all online IDs perfectly).	2022-07-25 19:51:19 +09:00
solstice23	aaad2e474c	Refactor the multiple regex checks in criteria parsing	2022-07-23 21:43:27 +08:00
solstice23	63210d5662	Merge branch 'master' into search-filter	2022-07-23 18:13:53 +08:00
solstice23	3f2c341369	Simplify length parsing	2022-07-23 18:13:19 +08:00
Salman Ahmed	3aecd288e2	Enable NRT on TopLocalRank	2022-07-23 09:27:03 +03:00
Salman Ahmed	1d0306810a	Fix TopLocalRank not handling legacy scores properly	2022-07-23 09:24:38 +03:00
Salman Ahmed	727fe76b60	Fix TopLocalRank hacking around presence to hide on null rank ... Fixed this here because that blocks `Schedule` from running, and I don't want to add another override to the `IsPresent` flag.	2022-07-23 09:22:22 +03:00
solstice23	7c222505e9	Simplify length parsing	2022-07-22 14:24:17 +08:00
Salman Ahmed	3b913bb9ad	Fix sorting mode not filling up to usable area in filter control	2022-07-22 09:15:48 +03:00
solstice23	b36e23c0da	Simplify the regex expression	2022-07-22 03:30:31 +08:00
solstice23	ae0902ca86	Fix lax in search criteria parsing	2022-07-22 02:55:11 +08:00
solstice23	0dcb3644f5	Merge branch 'master' into search-filter	2022-07-22 01:32:25 +08:00
solstice23	6baaef432f	Add colon parsing support in search length criteria	2022-07-21 18:49:13 +08:00
solstice23	a5a8fac66f	Add multiple units support in search length criteria	2022-07-21 18:24:31 +08:00