708 Commits

• Don't snap non-head slider nodes to distance grid during placement either

  1cd69220ef only disabled snapping the
  aforementioned nodes to distance grid for already-placed sliders.
  `SliderPlacementBlueprint` has its own logic for placement, so the fix
  needs to be mirrored there too.

  Bartłomiej Dach · 2023-05-26 19:51:20 +02:00
  e35201cb99
• Fix slider path placement snapping non-head nodes to distanced snapping grid

  As discussed at https://github.com/ppy/osu/discussions/23531.

  Dean Herbert · 2023-05-25 21:41:43 +09:00
  1cd69220ef
• Split out grid snapping modes into "relative" and "global" types
  Dean Herbert · 2023-05-25 21:41:19 +09:00
  804671ca74
• Make EditorClock non-nullable in PlacementBlueprint
  Dean Herbert · 2023-05-17 21:40:52 +09:00
  b58ab28765
• Move blueprint validity conditions to allow more correct external usage of EndPlacement

  Until now, these were haphazardly enforce inline in blueprint
  implementations. The only thing stopping complete breakage is that
  `EndPlacement` wasn't called (too much) from outside the blueprint,
  leaving them responsible for their own placement.
  
  By moving this conditional out of the provided paramters to
  `EndPlacement`, it allows more flexible usage of that method externally.
  Coming in a future PR.

  Dean Herbert · 2023-05-12 16:02:22 +09:00
  f443cfb93e
• Merge pull request #23308 from OliBomby/sample-control-points

  Remove SampleControlPoint and DifficultyControlPoint from HitObject

  Dean Herbert · 2023-05-03 14:21:51 +09:00
  6b017ac05f
• Add more padding around playfield in editor to avoid overlap with tool areas

  Closes #23130.

  Dean Herbert · 2023-05-02 15:37:02 +09:00
  67f83f246b
• remove all regular usage of DifficultyControlPoint
  OliBomby · 2023-04-26 17:55:38 +02:00
  c44f71a737
• fix usings
  OliBomby · 2023-04-26 17:34:02 +02:00
  9f8d7bccba
• remove all non-test usage of SampleControlPoint
  OliBomby · 2023-04-26 13:55:39 +02:00
  d97daee96b
• Fix spinners being selectable for too long after they fade in the editor

  The actual visual extension is only applied to `HitCircle`s (which does include slider
  start / end), and should not be applied to spinners in the first place.
  
  Addresses https://github.com/ppy/osu/discussions/22949.

  Dean Herbert · 2023-03-28 18:49:59 +09:00
  45e3e3623b
• Inline temporary variable
  Bartłomiej Dach · 2023-02-04 14:36:30 +01:00
  49443f0b55
• Merge branch 'master' into SnapToReverseSlider
  Bartłomiej Dach · 2023-02-04 14:14:37 +01:00
  a1343dacc1
• fix spaces
  Wleter · 2023-02-03 16:13:37 +01:00
  60f6484073
• fix formatting
  Wleter · 2023-02-03 16:13:04 +01:00
  f7f13cb9d9
• prioritize closest snap position
  Wleter · 2023-02-03 16:05:16 +01:00
  20e220df56
• check every snap position in blueprint
  Wleter · 2023-02-02 14:22:30 +01:00
  23e9bdd554
• Move where class specs to next line
  Dean Herbert · 2023-01-26 17:12:41 +09:00
  7344d34d5b
• Merge branch 'master' into stream-tool-2
  Dean Herbert · 2023-01-26 16:08:20 +09:00
  13937cf555
• Refactor how additional points are provided to avoid confusion
  Dean Herbert · 2023-01-23 14:13:46 +09:00
  73f083a316
• change property name
  Wleter · 2023-01-18 22:00:39 +01:00
  f8d8a627b8
• add collection of selection points.
  Wleter · 2023-01-18 21:34:23 +01:00
  ab78dd0436
• Fix formatting issues
  Dean Herbert · 2023-01-18 17:33:14 +09:00
  ecb4727aec
• fix double newlines
  Wleter · 2023-01-17 21:11:21 +01:00
  00f15d19f9
• add ScreenSpaceEndPoint field
  Wleter · 2023-01-10 21:20:09 +01:00
  e5863fbaf1
• add fields for path's end location
  Wleter · 2023-01-10 21:16:34 +01:00
  38bb7ac0c7
• Fix some more inspections
  Dean Herbert · 2022-12-16 20:21:19 +09:00
  192536643c
• Fix variable which didnt get renamed
  OliBomby · 2022-12-07 10:13:40 +01:00
  d458c3a012
• made PathControlPointVisualiser generic
  OliBomby · 2022-12-07 10:13:40 +01:00
  10b5900710
• Fix test failure

  Similar to SliderPlacementBlueprint.

  Dan Balasescu · 2022-12-02 18:32:43 +09:00
  ee62f3c0d3
• Fix being able to place zero-length spinners

  Also always snap a spinner's end time using beat snap (matches stable).

  Dean Herbert · 2022-12-02 17:57:15 +09:00
  45ea183cc3
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix sliders not correctly taking on full available length after changing curve type
  Dean Herbert · 2022-11-17 13:59:07 +09:00
  12606122e3
• Add the ability to toggle off hit marker displays in the editor
  Dean Herbert · 2022-11-08 18:07:06 +09:00
  ada039151b
• Merge pull request #21017 from andy840119/remove-nullable-disable-in-the-checks

  Remove nullable disable in the checks.

  Dean Herbert · 2022-11-06 18:39:03 +09:00
  e02c477008
• Remove nullable disable annotation in the osu ruleset.
  andy840119 · 2022-11-05 16:49:55 +08:00
  b0673636ca
• Update outdated comment
  Bartłomiej Dach · 2022-11-04 19:48:19 +01:00
  23134aea61
• Fix failing tests
  Dean Herbert · 2022-11-04 20:47:49 +09:00
  36c08b69fe
• Fix editor selection behaviour regressions due to new path visualiser optimisation
  Dean Herbert · 2022-11-04 19:36:59 +09:00
  20021551bb
• Merge pull request #20965 from peppy/reduce-slider-blueprint-overhead

  Only draw path visualiser when hovered or single slider is selected

  Dan Balasescu · 2022-10-28 16:01:30 +09:00
  74f3b9b18d
• Don't bother checking for null editorBeatmap
  Dean Herbert · 2022-10-28 14:35:55 +09:00
  300ffbb500
• Ensure updateVisualDefinition is called once on load

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-10-28 14:34:24 +09:00
  10c658e440
• Merge branch 'master' into avoid-unnecessary-path-updates
  Bartłomiej Dach · 2022-10-27 20:07:46 +02:00
  d657005ffa
• Fix one more null edge case
  Dean Herbert · 2022-10-28 01:20:17 +09:00
  7faf5cd1f6
• Remove unused using statements
  Dean Herbert · 2022-10-28 01:17:09 +09:00
  e582d9d5a8
• Fix nullref in tests due to missing EditorBeatmap dependency
  Dean Herbert · 2022-10-27 19:05:50 +09:00
  361153f598
• Reduce size of spinner blueprint to better represent gameplay size
  Dean Herbert · 2022-10-27 16:15:22 +09:00
  39e0362db1
• Avoid unnecessarily refreshing SliderBodyPiece's path
  Dean Herbert · 2022-10-27 16:02:04 +09:00
  0c7672e124
• Block hover if a multi-selection is made to avoid overlapping path visualisers
  Dean Herbert · 2022-10-27 14:52:46 +09:00
  2f172b66cf
• Only draw path visualiser when hovered or single slider is selected
  Dean Herbert · 2022-10-27 14:40:14 +09:00
  097d310d74