60561 Commits

This Branch

This Branch

All Branches

• Change osu!mania scoring ratio to 99% acc (to match previous lazer scoring)
  Dean Herbert · 2023-06-10 02:21:14 +09:00
  c40887eee8
• Be slightly more specific with error message
  Bartłomiej Dach · 2023-06-10 02:19:34 +09:00
  06040828c0
• Inline binary reading to avoid polluting RealmAccess with nested class
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  7fe06185b9
• try-catch more
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  50e3932256
• Catch errors during score parsing
  Dan Balasescu · 2023-06-10 02:19:34 +09:00
  f47bca7e32
• Don't scale stable scores with the classic scoring mode
  Dan Balasescu · 2023-06-10 02:19:34 +09:00
  8c1d6e0aeb
• Parse ScoreInfo.IsLegacyScore from replays
  Dan Balasescu · 2023-06-10 02:19:34 +09:00
  1d5464022c
• Fix test failures due to cross-test state pollution

  `TestSceneEditorTestGameplay` is not isolated from database, and one of
  the tests exiting editor when seeked to 60000 milliseconds
  (`TestClockTimeTransferIsOneDirectional()`) ended up changing
  `EditorTimestamp` to the same value, causing
  `TestSaveChangesBeforeGameplayTest()` to fail due to changing initial
  state.
  
  To fix, perform a direct deletion of imported beatmaps in realm to avert
  this scenario, contrary to the soft-deletion via `BeatmapManager` done
  previously.

  Bartłomiej Dach · 2023-06-10 02:19:34 +09:00
  7032ba9df1
• Fix incorrect realm schema comment

  Co-authored-by: timiimit <32331609+timiimit@users.noreply.github.com>

  Dean Herbert · 2023-06-10 02:19:34 +09:00
  b90b76c039
• Add test coverage of editor timestamp remembering
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  19734193fe
• Bump schema version
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  90c30dee62
• Rename variable and ensure timestamp is updated even when not saving
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  38fda7ac7d
• Use LastEditTime in Editor
  timiimit · 2023-06-10 02:19:34 +09:00
  aa0e4e16f7
• Add BeatmapInfo.LastEditTime property
  timiimit · 2023-06-10 02:19:34 +09:00
  2c327a74b2
• Update framework
  Dean Herbert · 2023-06-10 01:47:30 +09:00
  1765e6d430
• Bump replay version in encoder after Score V2 changes

  One release too late, but this may help in the future if we need to
  discern replays set with Score V2 from older lazer replays.

  Bartłomiej Dach · 2023-06-10 01:46:09 +09:00
  e07cae50a2
• Merge pull request #23741 from peppy/fix-manage-collection-commit-on-focus-loss

  Fix collection name changes not being reflected if enter is not pressed

  Bartłomiej Dach · 2023-06-04 17:19:13 +02:00
  25d0f0f3da
• Merge pull request #23718 from peppy/tidy-results-grid-usage

  Tidy up results screen statistic item flow

  Bartłomiej Dach · 2023-06-04 16:57:51 +02:00
  d0167cb324
• Ensure collection edit textbox commits on focus loss

  As discussed in https://github.com/ppy/osu/discussions/23739

  Dean Herbert · 2023-06-04 12:51:03 +09:00
  eb7586b517
• Add test coverage showing commit failure in manage collections dialog
  Dean Herbert · 2023-06-04 12:50:30 +09:00
  3e308e4c27
• Merge branch 'master' into tidy-results-grid-usage
  Bartłomiej Dach · 2023-06-03 19:45:23 +02:00
  331e90f720
• Merge pull request #23551 from timiimit/update-multiplayer-room-diff-range

  Fix multiplayer room difficulty range not being updated

  Bartłomiej Dach · 2023-06-03 19:41:50 +02:00
  51149343fb
• Simplify column dimensions code

  `dimensions` would always receive exactly one item, so might as well
  inline it.
  
  And yes, at this point the grid container is mostly a glorified
  `FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not
  touching that in this pull pending further decisions with respect to
  direction.

  Bartłomiej Dach · 2023-06-03 19:40:01 +02:00
  602d5db3bb
• Fix code quality inspection
  Bartłomiej Dach · 2023-06-03 16:50:58 +02:00
  474f7c2bc0
• Merge branch 'master' into update-multiplayer-room-diff-range
  Bartłomiej Dach · 2023-06-03 16:50:09 +02:00
  a9d4556647
• Merge pull request #23719 from peppy/disable-tablet-support-on-error

  Automatically disable tablet support on error

  Bartłomiej Dach · 2023-06-03 12:25:06 +02:00
  0b841eda71
• Merge pull request #23733 from peppy/bubble-mod-pool-fix

  Fix "bubbles" mod not adding pool to hierarchy (and constructing too early)

  Bartłomiej Dach · 2023-06-03 08:56:26 +02:00
  24f0b8df1f
• Fix "bubbles" mod not adding pool to hierarchy (and constructing too early)
  Dean Herbert · 2023-06-02 23:01:03 +09:00
  a5fd833214
• Merge pull request #23730 from smoogipoo/reduce-legacy-diffcalc-mod-init

  Fix legacy mod difficulty calculation creating all mods unnecessarily

  Dean Herbert · 2023-06-02 22:22:19 +09:00
  8063d50369
• Fix legacy diffcalc creating all mods unnecessarily
  Dan Balasescu · 2023-06-02 17:37:43 +09:00
  bfe80fe143
• Disable all tablet handlers to guard against a grim future
  Dean Herbert · 2023-06-02 08:48:47 +09:00
  c33ddedca0
• Merge pull request #23720 from peppy/fix-mouse-disappear-screenshot-fail

  Fix mouse cursor potentially disappearing for good if screenshot capture fails

  Bartłomiej Dach · 2023-06-01 23:09:23 +02:00
  2023.605.0 f8289927d2
• Merge pull request #23721 from peppy/fix-mania-hold-not-early-hit

  Fix osu!mania hold notes snapping to judgement area too early on early hits

  Bartłomiej Dach · 2023-06-01 21:57:36 +02:00
  4daf1fcb7d
• Merge pull request #23701 from EVAST9919/editor-timeline-fix

  Fix editor timeline hitobjects popping in and out of existence

  Bartłomiej Dach · 2023-06-01 21:57:14 +02:00
  b4ab3c8921
• Merge branch 'master' into editor-timeline-fix
  Bartłomiej Dach · 2023-06-01 21:18:08 +02:00
  8433813677
• Adjust inline comment
  Bartłomiej Dach · 2023-06-01 21:18:00 +02:00
  c2d89a32a9
• Fix nullability
  Andrei Zavatski · 2023-06-01 21:21:01 +03:00
  03eb7c7830
• Use combined area of children as a mask instead
  Andrei Zavatski · 2023-06-01 15:32:17 +03:00
  949fe32740
• Merge pull request #23691 from smoogipoo/mania-scroll-speed

  Replace mania scroll "time" with scroll "speed"

  Dean Herbert · 2023-06-01 17:23:27 +09:00
  00bf79d51f
• Fix osu!mania hold notes snapping to judgement area too early on early hits

  Closes https://github.com/ppy/osu/issues/23515.

  Dean Herbert · 2023-06-01 16:06:35 +09:00
  98f35f7481
• Use FireAndForget to avoid unobserved exception
  Dean Herbert · 2023-06-01 15:50:37 +09:00
  289f0e9862
• Fix mouse cursor potentially disappearing for good if screenshot capture fails
  Dean Herbert · 2023-06-01 15:50:13 +09:00
  0a7d5a51d4
• Automatically disable tablet support on error

  Closes #23710.

  Dean Herbert · 2023-06-01 15:16:48 +09:00
  9f8a13480b
• Merge pull request #23717 from peppy/fix-accuracy-heatmap

  Fix accuracy heatmap not working since scoring changes

  Dean Herbert · 2023-06-01 14:41:58 +09:00
  bbc5b86077
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Remove unused Dimension specification from StatisticItem
  Dean Herbert · 2023-06-01 14:25:18 +09:00
  dc595b83f1
• Add back required override to make AccuracyHeatmap work
  Dean Herbert · 2023-06-01 13:26:47 +09:00
  e830b96e61
• Add test coverage ensuring positional data is present in hit events
  Dean Herbert · 2023-06-01 13:26:47 +09:00
  310c54fe28
• Merge pull request #23708 from peppy/labelled-slider-visibility

  Adjust background colour used in `LabelledDrawable`s to allow visibility of some elements

  Dean Herbert · 2023-06-01 13:08:17 +09:00
  55a3847036
• Merge pull request #23695 from peppy/realm-startup-error-handling

  Adjust realm startup for added reliability

  Bartłomiej Dach · 2023-05-31 22:46:58 +02:00
  d78df0b084