39283 Commits

This Branch

This Branch

All Branches

• Change interpreted difficulty from bindable to regular value

  There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.

  Naxess · 2021-05-13 09:00:30 +02:00
  b37cb3bdbe
• Keep track of local bound copy
  Naxess · 2021-05-13 07:57:32 +02:00
  4eeeaf6a1a
• Merge branch 'master' into beatmap-verifier-context
  Naxess · 2021-05-13 07:40:33 +02:00
  e7c7786db3
• Merge pull request #12758 from Naxesss/verify-settings-ui

  Add setting UI components to the verify screen

  Dean Herbert · 2021-05-13 14:35:35 +09:00
  5b71d8ca37
• Move DI resolution to inside BDL parameters
  Dean Herbert · 2021-05-13 13:54:06 +09:00
  b81f86bd4d
• Simplify binding flow in InterpretationSection
  Dean Herbert · 2021-05-13 13:51:41 +09:00
  c6648112e5
• Tidy up specification of SettingsSection
  Dean Herbert · 2021-05-13 13:45:10 +09:00
  cdcbaf4291
• Set default for bindable in object initializer

  Fixes the CI failure.

  Naxess · 2021-05-13 06:08:48 +02:00
  47948d7b34
• Also refresh when interpreted difficulty changes
  Naxess · 2021-05-13 06:00:21 +02:00
  fb305130de
• Use local bound copy in InterpretationSection as well

  Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.

  Naxess · 2021-05-13 05:59:49 +02:00
  ee0a6ba93e
• Keep track of local bound copy
  Naxess · 2021-05-13 05:46:47 +02:00
  e80d8f6922
• Use more consistent lambda discards
  Naxess · 2021-05-13 05:38:45 +02:00
  04c1585eb2
• Merge pull request #12754 from peppy/skin-instantiation-info

  Add `SkinInfo.InstantiationInfo` to allow creating different skin types

  Dean Herbert · 2021-05-13 12:34:14 +09:00
  8bf05e142b
• Merge pull request #12777 from smoogipoo/fix-test-failure

  Fix possible multiplayer test failure

  Dean Herbert · 2021-05-13 12:33:59 +09:00
  fb13ed52f7
• Use local bound copy for HiddenIssueTypes
  Naxess · 2021-05-13 05:25:20 +02:00
  e86834b740
• Isolate refreshing to IssueList
  Naxess · 2021-05-13 05:25:02 +02:00
  c8d21f2c3f
• Fix possible test failure
  smoogipoo · 2021-05-13 11:53:50 +09:00
  5b03092968
• Split ShowIssueTypes dict into hidden and configurable lists

  This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
  
  Bindings are a bit less neat, though.

  Naxess · 2021-05-13 04:50:32 +02:00
  fbb76ba598
• Set interpreted difficulty to correct default
  Naxess · 2021-05-13 04:36:20 +02:00
  dd8423c4c4
• Remove unnecessary local variable

  This now exists in `VerifyScreen`, which we can access from here.

  Naxess · 2021-05-13 04:30:40 +02:00
  6806e40ad9
• Move ShowIssueTypes to VerifyScreen
  Naxess · 2021-05-13 04:29:27 +02:00
  56bd897666
• Actually annotate the correct ctor
  Bartłomiej Dach · 2021-05-12 23:53:39 +02:00
  27ca7d0f4f
• Fix missed InstantiationInfo setter usages
  Bartłomiej Dach · 2021-05-12 23:34:25 +02:00
  a6aec6e007
• Merge branch 'master' into skin-instantiation-info
  Bartłomiej Dach · 2021-05-12 23:23:57 +02:00
  d31fa20e92
• Extract invariant instantiation info extension method
  Bartłomiej Dach · 2021-05-12 23:23:51 +02:00
  1b579dd838
• Mark all skin ctors used via reflection in SkinInfo.CreateInstance()
  Bartłomiej Dach · 2021-05-12 23:23:42 +02:00
  4464204e33
• Merge pull request #12753 from peppy/health-bar-hud-overlay-dependency

  Remove downwards dependency from `HUDOverlay` to `HealthDisplay`

  Dan Balasescu · 2021-05-12 19:27:02 +09:00
  4e7c079560
• Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen

  Implement the multiplayer spectator screen

  Dean Herbert · 2021-05-12 17:24:35 +09:00
  c6f0a6aed3
• Reverse direction of binding to allow for better abstract class definitions
  Dean Herbert · 2021-05-12 16:53:58 +09:00
  d2e0e8ad94
• Rename Settings to have a more localised name
  Dean Herbert · 2021-05-12 16:38:04 +09:00
  17e3764576
• Add combo to test streaming client
  smoogipoo · 2021-05-12 14:22:15 +09:00
  e1dacde314
• Use test streaming client in gameplay leaderboard test
  smoogipoo · 2021-05-12 14:19:36 +09:00
  273cd18b8a
• Merge pull request #12748 from smoogipoo/fix-mania-sample-crash

  Fix mania crashing on playing samples after skin change

  Dean Herbert · 2021-05-12 14:10:08 +09:00
  87dfd9672d
• Merge pull request #12761 from smoogipoo/mania-hp-lenience

  Increase mania HP lenience

  Dean Herbert · 2021-05-12 14:09:09 +09:00
  90affa62cc
• Increase mania HP lenience
  smoogipoo · 2021-05-12 13:27:30 +09:00
  05c21fb5b3
• Use container instead of array for field
  smoogipoo · 2021-05-12 13:27:12 +09:00
  672108edcf
• Only update playing user states when users are watched
  smoogipoo · 2021-05-12 13:10:59 +09:00
  f4c96b2675
• Fix ordering + threading issues
  smoogipoo · 2021-05-12 13:06:28 +09:00
  e0e8f5ab80
• Remove watched users on stop watching
  smoogipoo · 2021-05-12 13:05:02 +09:00
  ad11818868
• Combine test spectator streaming client implementations
  smoogipoo · 2021-05-12 13:05:02 +09:00
  21fc0ba43b
• Remove unnecessary usage of ChildrenEnumerable for array assignment
  Dean Herbert · 2021-05-12 13:00:02 +09:00
  3428056113
• Add name identifying container and rename index variable
  Dean Herbert · 2021-05-12 12:59:46 +09:00
  bf44c09a91
• Merge branch 'master' into fix-mania-sample-crash
  Dean Herbert · 2021-05-12 12:56:53 +09:00
  7f015ee1d0
• Improve safety of bindings in HealthDisplay
  Dean Herbert · 2021-05-12 12:53:30 +09:00
  184dbaf202
• Add testable spectator streaming client
  smoogipoo · 2021-05-12 12:16:41 +09:00
  9b09361cc9
• Rename "playableBeatmap" check arg to "beatmap"

  The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.

  Naxess · 2021-05-12 02:34:16 +02:00
  b7bc42e0d3
• Add interpreted difficulty info to BeatmapVerifierContext

  Enables checks to make use of the difficulty level as shown in the settings UI.

  Naxess · 2021-05-12 02:30:21 +02:00
  64d96b06a6
• Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks

  This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
  
  See next commit for example.

  Naxess · 2021-05-12 02:29:18 +02:00
  c13b93e6f1
• Add InterpretationSection and its bindable in IssueList

  We'll eventually connect that bindable so that checks can access it.

  Naxess · 2021-05-12 01:32:18 +02:00
  4aeaec6ecc
• Remove negligible default hidden TODO
  Naxess · 2021-05-12 01:31:16 +02:00
  75adec57eb