65 Commits

• Fix slider blueprint placement when ending placement outside the playfield

  As mentioned in https://github.com/ppy/osu/discussions/24161

  Dean Herbert · 2023-07-11 17:29:53 +09:00
  a0e6748882
• Change PlacementBlueprint.AutomaticBankAssignment to property

  Mostly for consistency.

  Bartłomiej Dach · 2023-05-25 21:32:21 +02:00
  adee624a8f
• Add "auto" bank selection during placement
  Dean Herbert · 2023-05-24 17:11:12 +09:00
  3a05dffa50
• Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes

  Fix timeline blueprint display not showing correct combo number / colour during placement

  Bartłomiej Dach · 2023-05-20 15:02:55 +02:00
  afdddb0195
• Remove a couple of unnecessary volume declarations
  Dean Herbert · 2023-05-18 14:12:57 +09:00
  ee522253cb
• Make EditorClock non-nullable in PlacementBlueprint
  Dean Herbert · 2023-05-17 21:40:52 +09:00
  b58ab28765
• Update combo information on placement blueprint
  Dean Herbert · 2023-05-17 17:26:19 +09:00
  0b25818bd2
• Improve previous hitobject lookup efficient and correctness
  Dean Herbert · 2023-05-17 17:19:29 +09:00
  e43f2c2c43
• Apply NRT to PlacementBlueprint
  Dean Herbert · 2023-05-17 17:19:29 +09:00
  7d7d402d4e
• Make HitSampleInfo.Bank non-nullable
  Dean Herbert · 2023-05-16 18:12:56 +09:00
  83dcd78826
• Allow commiting / undoing placement of blueprints using back / select bindings
  Dean Herbert · 2023-05-12 16:06:20 +09:00
  0c1959ef2f
• Move blueprint validity conditions to allow more correct external usage of EndPlacement

  Until now, these were haphazardly enforce inline in blueprint
  implementations. The only thing stopping complete breakage is that
  `EndPlacement` wasn't called (too much) from outside the blueprint,
  leaving them responsible for their own placement.
  
  By moving this conditional out of the provided paramters to
  `EndPlacement`, it allows more flexible usage of that method externally.
  Coming in a future PR.

  Dean Herbert · 2023-05-12 16:02:22 +09:00
  f443cfb93e
• Make sure the first object you place has bank and volume
  OliBomby · 2023-05-01 00:49:01 +02:00
  2a94757154
• fix null sample
  OliBomby · 2023-04-30 01:08:52 +02:00
  83111223e0
• remove other usages of hitobject SampleControlPoint
  OliBomby · 2023-04-25 16:01:43 +02:00
  ebe1d852f5
• Use equals instead and update other usage
  Joseph Madamba · 2023-02-04 19:58:48 -08:00
  191259c050
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Fix new hitobject placements not taking on the existing sample settings

  Similar to velocity / difficulty points, a user expectation is that
  volume and sample settings will be transferred to newly placed objects
  from the most recent one.
  
  Closes https://github.com/ppy/osu/issues/18742.

  Dean Herbert · 2022-06-18 13:49:59 +09:00
  bd5037fcad
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Copy BaseDifficulty to Beatmap<T> and move all write operations across
  Dean Herbert · 2021-10-06 15:10:45 +09:00
  b339c149d8
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Fix PlacementBlueprint using the wrong beatmap when applying defaults

  Closes #12855.

  Dean Herbert · 2021-05-19 18:34:07 +09:00
  6c4709e7b4
• Allow certain mouse input to pass through PlacementBlueprints to the selection logic
  Dean Herbert · 2021-04-22 15:44:12 +09:00
  9a7bf8109f
• Fix placement blueprints not being correctly removed after a rolled back placement
  Dean Herbert · 2021-04-16 14:11:33 +09:00
  119c9b4294
• Move default sample addition to inside PlacementBlueprint

  This isn't actually required to fix the behaviour but it does feel like
  a better place to put this logic.

  Dean Herbert · 2021-02-11 17:16:18 +09:00
  e9730d4782
• Fix outdated xmldoc
  Dean Herbert · 2020-11-30 18:35:30 +09:00
  3ad2eeaff5
• Rename application method to better describe what it actually does
  Dean Herbert · 2020-11-26 19:16:18 +09:00
  9811c46e35
• Add new combo toggle to main composer interface
  Dean Herbert · 2020-09-25 14:10:30 +09:00
  e009264f10
• Add swell and drumroll blueprints
  Dean Herbert · 2020-05-29 16:45:47 +09:00
  b2fad91589
• Merge pull request #9033 from smoogipoo/applydefaults-cancellation

  Add cancellation token support to CreateNestedHitObjects()

  Dean Herbert · 2020-05-26 12:04:06 +09:00
  0cc6d6d97c
• Remove extra default application
  smoogipoo · 2020-05-25 16:15:55 +09:00
  cd65fc860b
• Remove double resolution of EditorClock
  Dean Herbert · 2020-05-25 15:40:45 +09:00
  b44beb4137
• Merge branch 'master' into editor-clock-cache
  Dean Herbert · 2020-05-25 15:39:42 +09:00
  ed83ef202a
• Merge branch 'master' into editor-clock-cache
  Dean Herbert · 2020-05-23 00:44:04 +09:00
  a3a9810344
• Fix defaults not being applied correctly to blueprints after StartTime is changed
  Dean Herbert · 2020-05-22 22:42:17 +09:00
  83f4ba107f
• Remove now incorrect comment
  Dean Herbert · 2020-05-22 18:30:39 +09:00
  3e0ee310d0
• Cache and resolve editor clock as EditorClock in all cases
  Dean Herbert · 2020-05-22 16:44:06 +09:00
  dd09d7830d
• Remove unused using
  Dean Herbert · 2020-05-21 14:53:36 +09:00
  776b842fdb
• Move responsibility placement blueprint's StartTime set to within
  Dean Herbert · 2020-05-21 14:50:33 +09:00
  a9a1c00cf1
• Pass down snap result and remove local TimeAt usage
  Dean Herbert · 2020-05-20 21:01:29 +09:00
  82d6549161
• Remove local TimeAt usage in mania placement
  Dean Herbert · 2020-05-20 21:01:29 +09:00
  970bd86d2e
• Change snapping to be screen space coordinate based
  Dean Herbert · 2020-05-20 21:00:29 +09:00
  3354d48a38
• Add cancellation token support to CreateNestedHitObjects()
  smoogipoo · 2020-05-15 18:07:41 +09:00
  98125102a7
• Fix placement blueprints handling double clicks
  smoogipoo · 2020-04-13 13:57:15 +09:00
  f38b64d201
• Simplify blueprints by removing visible state
  Dean Herbert · 2020-02-13 10:00:09 +09:00
  b65e839bd2
• Fix blueprint showing even when mouse outside of container
  Dean Herbert · 2020-02-13 09:03:48 +09:00
  0fe41fd50a
• Add commit status to EndPlacement; call BeginPlacement on initial movement
  Dean Herbert · 2020-02-07 18:02:48 +09:00
  e31d69c749
• Make BeginPlacement() set the hitobject start time
  smoogipoo · 2019-10-16 20:04:15 +09:00
  79b2c7b480
• Move placement movement event to BlueprintContainer
  smoogipoo · 2019-10-03 16:14:42 +09:00
  652acac87f