Dan Balasescu
e95983cdb4
Merge branch 'master' into fix-skin-flow
2022-09-16 20:15:51 +09:00
Dan Balasescu
433bb5ae24
Add ServerShuttingDownCountdown
2022-09-16 19:56:52 +09:00
Dean Herbert
85bb6f0beb
Update framework
...
Update framework (again)
Update framework
2022-09-16 19:35:34 +09:00
Dean Herbert
4c4fdfd153
Provide scores directly to Player instance rather than relying on DI
2022-09-16 18:15:17 +09:00
Dean Herbert
38d8d457d9
Add back second completion post attempt for case when notification overlay isn't loaded yet
2022-09-16 17:54:44 +09:00
Dean Herbert
0d24fda4b9
Fire Notification.Closed immediately to ensure off-screen notifications are closed
2022-09-16 16:36:56 +09:00
Dean Herbert
0227eddda1
Merge branch 'master' into gameplay-leaderboards
2022-09-16 15:44:58 +09:00
Dan Balasescu
cbf55732da
Merge pull request #20337 from peppy/catch-unobserved-network-exceptions
...
Catch any unobserved exceptions during beatmap metadata harvesting
2022-09-16 14:37:08 +09:00
Dean Herbert
21ac3fd88b
Catch any unobserved exceptions during beatmap metadata harvesting
...
The process will retry when a connection is successful, so this doesn't
need to be as loud as it was.
Addresses https://github.com/ppy/osu/discussions/20331 .
2022-09-16 14:00:06 +09:00
Dean Herbert
4486fa2546
Merge pull request #20334 from Drison64/fix-scorePanel-timeFormat
...
Make score panel timestamp adjust to 24-hour time setting
2022-09-16 13:40:34 +09:00
Dan Balasescu
d9499abc33
Refactor to avoid passing around bindables
2022-09-16 13:14:25 +09:00
Dan Balasescu
fcba917419
Merge pull request #20320 from peppy/skin-transformers
...
Allow skin transformers to be created for all skins
2022-09-16 12:58:46 +09:00
Dan Balasescu
49d2c84646
Merge pull request #19991 from Feodor0090/mods-effect-displays
...
Move `DifficultyMultiplierDisplay`'s layout and colour logic to a base class
2022-09-16 10:30:30 +09:00
Drison64
4f208416be
Fixed irresponsiveness of score panel timestamp to time format
2022-09-16 13:50:18 +14:00
Dean Herbert
db822696ed
Use latest version of sqlite3 bundle
2022-09-16 01:02:46 +09:00
Dean Herbert
5ce67345ae
Catch against sqlite initialisation failures
2022-09-16 01:02:38 +09:00
Dan Balasescu
f86bbaae30
Merge branch 'master' into mods-effect-displays
2022-09-15 21:17:58 +09:00
Dean Herbert
c7f8f948b9
Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins
2022-09-15 20:18:10 +09:00
HiddenNode
2092008251
Set InvalidationSource to Self
2022-09-15 11:16:00 +01:00
Dan Balasescu
96a89f4fca
Merge pull request #20319 from peppy/remove-ef-migration
...
Remove all entity framework code and migrations
2022-09-15 19:15:23 +09:00
HiddenNode
8286ab0d04
Revert "Fix SongProgress invalidating too often"
...
This reverts commit 2b4b14ca99
2022-09-15 11:11:58 +01:00
Dean Herbert
ea513c539b
Merge pull request #20303 from peppy/hitobject-entry-nesting-stoled
...
Fix editor performance drop over time due to lingering nested object references
2022-09-15 17:15:01 +09:00
Dean Herbert
28b15e232d
Remove all EF models
2022-09-15 16:59:36 +09:00
Dean Herbert
65d1c40dd5
Remove remaining package references and replace with SQLitePCLRaw direct reference
...
This may require further consideration for test and iOS projects.
2022-09-15 16:58:58 +09:00
Dean Herbert
581a4d2d6d
Use APIBeatmap for realm migration requiring ShortName mapping
2022-09-15 16:58:58 +09:00
Dean Herbert
0aa92c78ec
Add local sqlite initialisation to BeatmapUpdaterMetadataLookup for now
2022-09-15 16:58:58 +09:00
Dean Herbert
40a60f7145
Remove all entity framework code and migrations
2022-09-15 16:58:58 +09:00
Dan Balasescu
e56ea58e71
Fix up xmldoc
2022-09-15 16:06:21 +09:00
Dan Balasescu
c847cc521e
Add some inline comments
2022-09-15 16:00:35 +09:00
Dan Balasescu
68e4d22898
Precondition against entryMap intead of parentMap
2022-09-15 15:43:15 +09:00
Dan Balasescu
31bc067dd1
Don't store nulls to parentMap
2022-09-15 15:38:44 +09:00
Salman Ahmed
efebe55d22
Display certain sort criterias based on selected category and query
2022-09-15 04:30:09 +03:00
Salman Ahmed
de7dd29d79
Add "Nominations" and "Updated" sorting criteria in beatmap listing
2022-09-15 03:57:05 +03:00
Dean Herbert
eb18d3661d
Merge pull request #20309 from mk56-spn/dead_class_removal
...
Unused class KeyCounterState.cs Removal
2022-09-15 03:38:39 +09:00
Mk-56spn
d6db82283a
Removes unused class
2022-09-14 18:01:29 +02:00
Dean Herbert
5dc0d32e42
Apply NRT to hitobject lifetime related classes
2022-09-14 15:24:20 +09:00
ekrctb
c59aa57450
Remove createLifetimeEntry from HitObjectEntryManager
2022-09-14 15:19:33 +09:00
ekrctb
47539e2129
Add doc comments to HitObjectEntryManager
2022-09-14 15:19:05 +09:00
ekrctb
bde390828b
Manage entries of nested hit objects in HitObjectEntryManager
...
- Fix nested hit objects are leaked when parent hit object is edited or deleted
2022-09-14 15:19:05 +09:00
ekrctb
a9eba27129
Factor out pooling logic from Playfield
2022-09-14 15:19:05 +09:00
Dan Balasescu
90e5949e9f
Merge pull request #20300 from peppy/stable-sort-local-scores
...
Fix local scores potentially not being stable-sorted for leaderboard display
2022-09-14 15:11:07 +09:00
Dean Herbert
bc07513c3c
Fix local scores potentially not being stable-sorted for leaderboard display
2022-09-14 14:19:53 +09:00
Dean Herbert
fcf54f1bc8
Fix gameplay leaderboard not being sorted correctly in tie situations
2022-09-14 14:18:12 +09:00
Dean Herbert
8a6977213a
Fix displayed scores in gameplay leaderboard not tracking display mode changes
2022-09-14 14:02:35 +09:00
Dan Balasescu
024f7991ad
Merge pull request #20292 from peppy/fix-preix-matching-status
...
Fix song select status prefix matching no longer working
2022-09-14 13:53:03 +09:00
Joseph Madamba
85e3a681b1
Fix notification overlay toast tray background absorbing input from behind
2022-09-13 21:07:30 -07:00
Dean Herbert
b4e6a20846
Fix song select status prefix matching no longer working
...
Regressed in #19275 due to weird logic.
Closes #20289 .
2022-09-14 12:59:05 +09:00
Dan Balasescu
ef6d60ffe9
Merge pull request #20273 from frenzibyte/duplicate-beatmap-listing-cards
...
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-14 10:25:24 +09:00
Salman Ahmed
04dbb6fc1b
Add inline comment
2022-09-14 00:49:02 +03:00
Dan Balasescu
4a49433e2e
Merge branch 'master' into notification-fling-right
2022-09-13 20:01:56 +09:00
Dean Herbert
81b5e4a865
Fix back-to-front condition on leaderboard always show configuration
2022-09-13 19:57:40 +09:00
Dean Herbert
94693a4667
Fix oversight when making interface implementation explicit
2022-09-13 19:55:57 +09:00
Dean Herbert
566a61e770
Merge pull request #20244 from peppy/notification-fling
...
Add ability to "fling" notifications to dismiss them
2022-09-13 19:50:34 +09:00
Dean Herbert
9226f0abbc
Implement equality correctly in Live
2022-09-13 19:16:25 +09:00
Dean Herbert
e15a25ea49
Fix leaderboard positioning logic to actually consider elements on the left side
2022-09-13 18:45:11 +09:00
Dean Herbert
678eec1c67
Move LeaderboardFlow to HUDOverlay to share positioning logic
2022-09-13 18:45:11 +09:00
Dean Herbert
5894d2f0bc
Ensure gameplay leaderboard hides with rest of HUD when it should
2022-09-13 18:45:11 +09:00
Dean Herbert
6d167070f8
Add back DI leaderboard retrieval via bindable pathway
2022-09-13 18:45:11 +09:00
Dean Herbert
70e6b595f1
Refactor SoloGameplayLeaderboard to not read scores via DI
...
Also allows updating scores if they arrive late.
2022-09-13 18:00:21 +09:00
Dean Herbert
d2b80645ab
Change Leaderboard to use IUser instead of APIUser
2022-09-13 18:00:21 +09:00
Dean Herbert
ac58c222b9
Allow DrawableAvatar to accept an IUser for now
2022-09-13 18:00:21 +09:00
Dean Herbert
d251c0b2ac
Move leaderboard implementation to Player itself
2022-09-13 18:00:21 +09:00
Dean Herbert
368faa0084
Make constructor protected in base implementation
2022-09-13 18:00:21 +09:00
Dean Herbert
4c669e2bce
Track local Player.Score's user rather than using APIProvider
2022-09-13 18:00:21 +09:00
Salman Ahmed
3490b16056
Add simplified SoloGameplayLeaderboard implementation
...
Note that this doesn't support waiting until leaderboard finishes fetching scores.
2022-09-13 18:00:21 +09:00
Dean Herbert
27a81dfb9f
Merge pull request #20270 from OliBomby/fix-selectionblueprint-order
...
Fixed HitObjectOrderedSelectionContainer being able to become unsorted and causing crashes
2022-09-13 17:18:58 +09:00
Dan Balasescu
53ac9dbc38
Merge branch 'master' into notification-fling
2022-09-13 17:07:16 +09:00
Dan Balasescu
0e2155303e
Merge branch 'master' into fix-song-progress-invalidations
2022-09-13 16:07:05 +09:00
Dan Balasescu
62971ef1cc
Merge pull request #20281 from peppy/fix-drawable-ruleset-dependencies
...
Fix null considerations in `DrawableRulesetDependencies`
2022-09-13 15:26:29 +09:00
Dean Herbert
f53507828c
Rename event to be more generic (and add comprehensive xmldoc)
2022-09-13 14:59:30 +09:00
Dean Herbert
ac034bffeb
Fix potential crash if multiplayer spectator load is aborted early
2022-09-13 14:21:54 +09:00
Dean Herbert
0fcd9e02f6
Fix skin dropdown not updating correctly when skin is changed externally
2022-09-13 14:01:40 +09:00
Dean Herbert
d368f37c3a
Remove redundant second Current set operation
2022-09-13 13:50:59 +09:00
Dean Herbert
6bf6b7e125
Fix null considerations in DrawableRulesetDependencies
2022-09-13 13:13:38 +09:00
Dean Herbert
9c2b0efbc7
Merge pull request #20262 from smoogipoo/scoreprocessor-computeaccuracy
...
Add `ScoreProcessor.ComputeAccuracy()`
2022-09-13 11:55:02 +09:00
Salman Ahmed
0ca4be5e5b
Fix one more inspection
2022-09-13 03:45:31 +03:00
OliBomby
fd48249eef
fix with new event
2022-09-13 02:20:52 +02:00
Salman Ahmed
69b9bae3b3
Merge branch 'master' into scoreprocessor-computeaccuracy
2022-09-13 03:09:52 +03:00
Salman Ahmed
a20c97d072
Merge branch 'master' into fix-skin-animation-edge-case
2022-09-13 02:26:55 +03:00
Salman Ahmed
5fba21d658
Rename parameter to clarify purpose
2022-09-13 02:21:01 +03:00
OliBomby
718f8c4ee2
revert the fix
2022-09-13 01:09:42 +02:00
Salman Ahmed
07f577a0c6
Fix beatmap listing potentially showing duplicate beatmap cards
2022-09-13 01:39:21 +03:00
OliBomby
8400de4b2e
invoking hitobject updated before invoking removed
2022-09-12 17:50:11 +02:00
ansel
8cbc0502ae
Inline CalculateEffect
2022-09-12 15:51:18 +03:00
Dean Herbert
88107108ee
Add ability to flick notifications to the right to store for later
2022-09-12 20:20:57 +09:00
Dean Herbert
802c5629c0
Merge branch 'master' into notification-fling
2022-09-12 20:09:21 +09:00
Dean Herbert
2b4b14ca99
Fix SongProgress invalidating too often
...
This regressed with https://github.com/ppy/osu/pull/19556 . Rather than
try and figure whether that new container needs to handle size
differently, this is a simple solution.
Height was taken from a runtime check (maxes out at about 14.5).
Closes #20235 .
2022-09-12 20:06:53 +09:00
Dean Herbert
f31deaef7c
Simplify skin bindable flow
...
Now, nothing touches the configuration apart from `OsuGame`, making
everything else flow better and avoid weird cyclic set bugs.
Closes https://github.com/ppy/osu/issues/20234 .
2022-09-12 19:51:50 +09:00
Dan Balasescu
5bd0be14ed
Merge pull request #20259 from peppy/fix-changelog-crash
...
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 19:47:21 +09:00
Dean Herbert
cb6d02ec3a
Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset
...
Remove the nullable disable annotation in the ruleset class
2022-09-12 19:07:23 +09:00
Dean Herbert
d92e000fe6
Fix flinging a notification not correctly running Close
2022-09-12 19:00:03 +09:00
Dean Herbert
4ee3e8f087
Don't play fling animation when activating a notification
2022-09-12 18:57:18 +09:00
Dean Herbert
c064853751
Merge branch 'master' into notification-fling
2022-09-12 18:56:15 +09:00
Dean Herbert
e29f5cb456
Fix new-style legacy skins with animated judgements not adding correct transforms
...
Closes #16173 .
2022-09-12 18:54:06 +09:00
Dan Balasescu
27d4016ccb
Add ScoreProcessor.ComputeAccuracy()
2022-09-12 18:37:55 +09:00
Dan Balasescu
4b37330316
Merge pull request #20248 from acid-chicken/fix/stats/td
...
Fix new hit distribution graph didn't account for size changes
2022-09-12 18:11:18 +09:00
Dan Balasescu
b0980a7bf1
Merge pull request #20215 from peppy/notification-dismiss
...
Allow dismissing notifications without performing action using middle / right click
2022-09-12 18:03:06 +09:00
Dan Balasescu
3cfacb5e39
Merge pull request #20257 from peppy/update-button-show-login
...
Show login overlay when attempting to update a beatmap while logged out
2022-09-12 17:51:45 +09:00
Dean Herbert
58c1ea0321
Fix potential crash when opening changelog overlay if entry has no URL
2022-09-12 17:51:15 +09:00
Dean Herbert
d561fcb126
Don't trigger fling animation when Close is triggered by non-user action
2022-09-12 16:54:25 +09:00
Dean Herbert
5a02e1e713
Use padding instead of FillFlow.Spacing to avoid artifact during animation
2022-09-12 16:46:45 +09:00
Dean Herbert
a506178571
Make bounding box shrink faster to allow for rapid flinging
2022-09-12 16:39:46 +09:00
Dan Balasescu
bcbc867694
Merge branch 'master' into mods-effect-displays
2022-09-12 16:35:28 +09:00
Dean Herbert
931049aec1
Merge branch 'master' into notification-dismiss
2022-09-12 16:27:41 +09:00
Dean Herbert
bd3673baa9
Fix being able to drag after already closing a notification
2022-09-12 16:25:32 +09:00
Acid Chicken (硫酸鶏)
4f298db066
fix(osu.Game): reset Y axis of the bars in hit distribution graph at the first drawing
2022-09-12 16:25:29 +09:00
Acid Chicken (硫酸鶏)
0d0e2e7bcc
fix(osu.Game): bars in hit distribution graph stretching in the opposite direction when DrawHeight is less than DrawWidth
2022-09-12 16:20:33 +09:00
Dan Balasescu
31225066a1
Merge pull request #19308 from frenzibyte/top-rank-badge-order
...
Fix best rank badge not handling legacy scores properly
2022-09-12 16:20:21 +09:00
Dean Herbert
8e6b2796eb
Merge branch 'master' into notification-fling
2022-09-12 16:19:36 +09:00
Dean Herbert
94f8197e22
Show login overlay when attempting to update a beatmap while logged out
2022-09-12 16:15:14 +09:00
Dan Balasescu
6c59be7be9
Merge pull request #20254 from peppy/fix-update-notification
...
Fix update progress notification icon overload
2022-09-12 16:01:19 +09:00
Dean Herbert
96951057df
Avoid using bindables
2022-09-12 15:56:06 +09:00
Dean Herbert
bcd2445d9b
Move helper functions down in file
2022-09-12 15:50:10 +09:00
Dean Herbert
0755289ec3
Apply NRT to HitEventTimingDistributionGraph
2022-09-12 15:48:50 +09:00
Dean Herbert
7a62544923
Merge pull request #19275 from solstice23/search-filter
...
Add multiple-units support in search length criteria
2022-09-12 15:43:44 +09:00
Dean Herbert
2476cf8fb3
Adjust movement to look less sudden when snapping back to Y=0
2022-09-12 15:37:48 +09:00
Dean Herbert
e06a0f7300
Fix dragged state not being exposed correctly
2022-09-12 15:21:01 +09:00
Dean Herbert
92beb6cbe7
Hide notification read light when in a toast state
...
Also adds test coverage of read state and light.
2022-09-12 15:17:45 +09:00
Dean Herbert
9b31aa6d7a
Fix activation not firing with refactors
2022-09-12 15:04:30 +09:00
Dean Herbert
60b0b909a5
Move update icon to background to avoid colour collission with progress spinner
2022-09-12 14:58:46 +09:00
Dean Herbert
eca241e9a7
Move UpdateProgressNotification to base UpdateManager class
2022-09-12 14:52:11 +09:00
Dean Herbert
bbf906ee06
Remove unnecessary virtual spec
2022-09-12 14:20:48 +09:00
Dean Herbert
24138b65a7
Fix storyboard animations not starting their animation playback from the correct point in time
2022-09-12 14:05:16 +09:00
Acid Chicken (硫酸鶏)
ac324c63e2
fix(osu.Game): handle size changes in timing distribution graph
2022-09-12 04:46:32 +09:00
Dean Herbert
9ef23c79ce
Disallow forwarding during a drag operation
2022-09-11 22:05:44 +09:00
Dean Herbert
a56cadcf90
Ensure drag position is reset when transferred to tray
2022-09-11 22:03:29 +09:00
Dean Herbert
b5a2f7003e
Disallow flinging when not in toast state
2022-09-11 21:47:45 +09:00
Dean Herbert
d6f90e3b9f
Add basic fling-to-dismiss support
2022-09-11 21:32:22 +09:00
Dan Balasescu
1eb2c74e57
Fix countdown serialisation
2022-09-11 18:50:51 +09:00
ansel
324a3723a5
Rewrite DMD
2022-09-10 23:23:04 +03:00
ansel
3f93ec8538
Expose counter to inheritors
2022-09-10 23:20:28 +03:00
ansel
667854b034
Make effect display have a built-in counter
2022-09-10 23:18:48 +03:00
Mk-56spn
c00bf61273
Framework change adressed
2022-09-10 21:24:29 +02:00
MK56
8661dc3c93
Merge branch 'ppy:master' into Colour_hit_meter_improved
2022-09-10 21:16:23 +02:00
Mk-56spn
f6aef73f9e
fixed shape bindable not working, test creation, removal of Clear(), adjusted settings names
2022-09-10 20:30:43 +02:00
Dean Herbert
a9094c6b03
Add test coverage of clicking close button to dismiss
2022-09-10 15:18:32 +09:00
Dean Herbert
efe3b1aa7b
Allow dismissing notifications without performing action using middle / right click
2022-09-10 15:10:37 +09:00
ansel
b056cac10a
Remove generic and add default implementation for CalculateEffect
2022-09-10 08:34:29 +03:00
andy840119
3d7367a842
Move the CreateConvertibleReplayFrame() into the base ruleset class for avoid api breaking change in the customized ruleset.
2022-09-10 11:07:23 +08:00
andy840119
1398a7e11e
Property should accept the nullable state.
2022-09-10 10:46:40 +08:00
andy840119
e62999fb16
Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset
...
# Conflicts:
# osu.Game.Rulesets.Catch/CatchRuleset.cs
# osu.Game.Rulesets.Osu/OsuRuleset.cs
# osu.Game.Rulesets.Taiko/TaikoRuleset.cs
# osu.Game/Rulesets/Ruleset.cs
2022-09-10 10:40:12 +08:00
Salman Ahmed
5e4e3dfc2c
Fix markdown container not rendering certain text correctly
2022-09-10 02:55:20 +03:00
Salman Ahmed
95062c2cc8
Remove center origin specification to avoid single-frame layout issues
2022-09-09 19:42:58 +03:00
Salman Ahmed
dd10a06e3d
Merge branch 'master' into top-rank-badge-order
2022-09-09 19:38:44 +03:00
solstice23
823078ed2d
Merge branch 'master' into search-filter
2022-09-09 23:12:37 +08:00
Dean Herbert
602ffebd54
Apply NRT and fix code style
2022-09-09 23:29:04 +09:00
Dean Herbert
d961b96897
Merge branch 'master' into search-filter
2022-09-09 23:25:54 +09:00
Dean Herbert
8f9df9c7b4
Merge pull request #18642 from Joehuu/fix-play-button-touch
...
Fix beatmap card play button not working with touch inputs when not hovered
2022-09-09 19:41:05 +09:00
Dean Herbert
e479a022ef
Merge pull request #19556 from HiddenNode/fix_progress_bar_info
...
Fix progress bar text orientation and scale
2022-09-09 18:46:34 +09:00
Dean Herbert
e9ce968ae3
Merge branch 'master' into fix-play-button-touch
2022-09-09 18:08:18 +09:00
