1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-17 06:02:55 +08:00
Commit Graph

1364 Commits

Author SHA1 Message Date
rushiiMachine
75b9d0fe66
Make flashlight scale with playfield
When the playfield is shrunk with mods such as BarrelRoll, flashlight does not account for this, making it significantly easier to play. This makes it scale along with the playfield.
2023-12-27 23:02:45 -08:00
Bartłomiej Dach
6cb8231054
Add test coverage for failure case 2023-12-22 13:22:26 +01:00
Dean Herbert
7e09164d70
Merge pull request #26036 from smoogipoo/fix-perfect-mod-special-judgements
Fix perfect mod not failing with special judgements
2023-12-22 18:22:28 +09:00
Dan Balasescu
88a5ba8167
Add mania/osu sudden death mod tests 2023-12-22 16:43:09 +09:00
Dan Balasescu
9c35e25036
Add failing tests 2023-12-22 13:58:12 +09:00
Dan Balasescu
6b4b2a57fc
Expose only as one method 2023-12-21 14:58:23 +09:00
Dan Balasescu
4e3b994142
Relocate HitResult numeric score to ScoreProcessor 2023-12-21 14:52:31 +09:00
Dan Balasescu
011bd61e7d
Give sliders in test scene a sample 2023-12-19 16:47:49 +09:00
Dean Herbert
2f28a92f0a
Merge pull request #25776 from smoogipoo/slider-late-hit-lenience
Add slider head circle late hit lenience
2023-12-18 13:05:31 +09:00
Dan Balasescu
04d542105f
Fix assertions 2023-12-17 21:52:21 +09:00
Dan Balasescu
2b33aec124
Require slider head to be judged before ticks 2023-12-17 21:26:48 +09:00
Dan Balasescu
9b02bd712b
Only track if in slider ball after any ticks missed 2023-12-17 20:12:02 +09:00
Dan Balasescu
f77884b62f
Only hit passed-through ticks if none were missed 2023-12-17 19:57:48 +09:00
Dan Balasescu
10610d3387
Rename test scene 2023-12-17 19:33:38 +09:00
Dan Balasescu
4b9aefa6f2
Change osu ruleset to use new HP algorithm by default 2023-12-17 19:33:04 +09:00
Dean Herbert
c0e96927aa
Merge branch 'master' into slider-late-hit-lenience 2023-12-17 13:00:01 +09:00
Dan Balasescu
acb7016156
Remove unused using 2023-12-15 23:53:26 +09:00
Dan Balasescu
9ae3be817f
Add some text to the test scene showing hits/misses 2023-12-15 17:40:36 +09:00
Dan Balasescu
12210017e4
Use the cursor position to test nested object validity 2023-12-15 17:05:14 +09:00
Dan Balasescu
3b8a73bf2c
Refactor test 2023-12-15 16:13:34 +09:00
Dan Balasescu
599fdb0128
Add lenience for late-hit of slider heads 2023-12-15 14:14:58 +09:00
Bartłomiej Dach
555559c5c1
Add testing for GetRateAdjustedDisplayDifficulty() implementations 2023-12-14 20:41:12 +01:00
Dan Balasescu
38e7c03500
Update tests to not miss the head 2023-12-14 12:00:01 +09:00
Dan Balasescu
683ac6f63a
Add some more tests 2023-12-13 20:03:20 +09:00
Dan Balasescu
c131f91736
Add tests 2023-12-13 16:59:33 +09:00
Dean Herbert
73189be6cc
Merge branch 'better-drawing' into dropdown-search 2023-12-13 14:09:33 +09:00
Bartłomiej Dach
856310e954
Remove reference to removed comment from another comment 2023-12-07 08:22:01 +01:00
Dan Balasescu
005fb78994
Fix last tick handling in osu beatmap conversion tests 2023-12-07 16:02:00 +09:00
OliBomby
a8f3a0533a Use 4th order BSpline by default 2023-12-06 16:35:59 +01:00
Dean Herbert
79826dee58
Fix tests which were relying on SliderMultiplier==1 2023-12-06 13:50:10 +09:00
OliBomby
13b7f2fa42 Fix test cases 2023-12-03 22:42:48 +01:00
Dean Herbert
efb6c30252
Merge branch 'master' into scoring-test-mods 2023-11-28 18:38:50 +09:00
Bartłomiej Dach
74966cae6a
Remove unused using directive 2023-11-23 10:31:58 +09:00
Bartłomiej Dach
d4519f74ab
Merge branch 'master' into hp-drain-fix-breaks 2023-11-23 10:31:42 +09:00
Bartłomiej Dach
bf972a04ee
Merge pull request #25409 from Tom94/bspline-sliders
Add free-hand drawing of sliders to the editor
2023-11-21 16:28:14 +09:00
Bartłomiej Dach
d83b2e24e7
Merge pull request #25371 from RatinFX/open-editor-timestamp
Implement opening editor timestamp links
2023-11-21 15:48:36 +09:00
Dean Herbert
1660eb3c15
Add failing test coverage of drag after point placement 2023-11-21 15:38:12 +09:00
Dean Herbert
7bedbe4264
Apply NRT to SliderPlacementBlueprint tests 2023-11-21 15:38:12 +09:00
Dean Herbert
5175464c18
Update test coverage (and add test coverage of curve drawing) 2023-11-21 15:38:12 +09:00
Dean Herbert
3afaafb1d9
Reorder and simplify private helper methods 2023-11-21 15:05:51 +09:00
Bartłomiej Dach
745a04a243
More test cleanup 2023-11-20 22:12:15 +09:00
Bartłomiej Dach
43dbd65708
Show Catmull as a control point type option if selection already contains it 2023-11-20 15:53:25 +09:00
Bartłomiej Dach
5f302662be
Remove test terminally broken by introduction of slider drawing 2023-11-20 15:34:23 +09:00
Bartłomiej Dach
46d4587c97
Add test for slider drawing 2023-11-20 15:34:01 +09:00
Bartłomiej Dach
b6e3e42445
Merge branch 'master' into bspline-sliders 2023-11-20 12:03:29 +09:00
Dan Balasescu
e3137d575b
Fix osu! and base HP processor break time implementation 2023-11-14 01:11:17 +09:00
cs
fa976a5aa0 Fix code style/quality issues 2023-11-13 08:25:27 +01:00
ratinfx
6ddecfd806 Update Test cases 2023-11-11 14:13:06 +01:00
Thomas Müller-Höhne
926636cc03 Generalize Bezier curves to BSplines of Nth degree 2023-11-11 13:32:53 +01:00
Dean Herbert
1c63f1f89d
Merge pull request #25348 from bdach/less-basic-touchscreen-detection
Implement basic touchscreen detection
2023-11-10 18:01:40 +09:00
Bartłomiej Dach
b7938e78a0
Make sure test is in a break
...because apparently it may take a while to update the flag.
2023-11-10 16:30:44 +09:00
Bartłomiej Dach
1818a84034
Rewrite tests to not rely on realtime clock
Definitely faster, hopefully more reliable too.
2023-11-10 15:53:25 +09:00
Dan Balasescu
a8cf105beb
Merge pull request #25342 from peppy/slider-combo-matching-2
Fix osu! (slider) combo not matching expectations when classic mod is disabled
2023-11-10 15:07:05 +09:00
Dean Herbert
fb02c31750
Fix typo in assert step
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-11-10 12:09:48 +09:00
Dean Herbert
e0a5ec5352
Revert incorrect classic mod test assertions 2023-11-10 12:09:16 +09:00
Dean Herbert
1ae3265f92
Update tests in line with new behaviour 2023-11-09 22:03:22 +09:00
Bartłomiej Dach
5180fa669b
Merge pull request #25343 from peppy/spinner-max-sample
Continue to play spinner bonus sounds when MAX display occurs
2023-11-09 13:34:29 +01:00
Bartłomiej Dach
5d5c803cf6
Add failing test case for touch device application during gameplay with incompatible mods active 2023-11-09 17:48:43 +09:00
Bartłomiej Dach
13b599b9b6
Merge branch 'master' into less-basic-touchscreen-detection 2023-11-09 17:36:48 +09:00
Dean Herbert
c00a1d948a
Merge branch 'master' into better-touch-settings 2023-11-07 23:21:59 +09:00
ratinfx
81caa854e6 Separate Test cases by relevant rulesets 2023-11-07 13:02:46 +01:00
Dean Herbert
38c9a98e67
Add failing test coverage 2023-11-07 19:54:21 +09:00
Susko3
05d9418718 Rename setting to TouchDisableGameplayTaps for better visibility when searching 2023-11-07 00:13:46 +01:00
Susko3
c1967a5cbb Make tests fail 2023-11-06 20:43:24 +01:00
Salman Ahmed
073249dafb Allow tinkering with cursor-related settings in resume overlay test scene 2023-11-06 18:35:46 +03:00
Salman Ahmed
e12ee29a94 Update existing test coverage 2023-11-06 18:35:30 +03:00
Bartłomiej Dach
682668ccf0
Remove touch device toasts entirely 2023-11-06 10:54:32 +01:00
Dean Herbert
86cf0a36cf
Add test coverage of spinner with no bonus ticks 2023-11-06 18:16:31 +09:00
Dean Herbert
aa6f14b024
Fix spinner test hitting assertion when spinning too fast 2023-11-06 18:16:04 +09:00
Dean Herbert
e2928cc6b9
Fix incorrect assertion check targets (and flip assertion for miss case) 2023-11-06 17:33:01 +09:00
Dean Herbert
b62811633f
Add test coverage of touching and missing not enabled touch mod 2023-11-06 17:17:19 +09:00
Salman Ahmed
99405a2bbd Tidy up resume overlay test scene 2023-11-05 06:28:51 +03:00
Bartłomiej Dach
f2df02b60f
Automatically activate touch device mod in player 2023-11-02 21:24:58 +01:00
Bartłomiej Dach
29d4d81eaa
Add test scene for basic touchscreen detection scenarios 2023-11-02 21:24:58 +01:00
Bartłomiej Dach
12ef93ac3b
Remove no-longer-valid assertion 2023-10-30 21:31:34 +01:00
Bartłomiej Dach
f2c0bc8218
Add failing test case 2023-10-30 21:28:26 +01:00
Dean Herbert
f706fd2fca
Merge pull request #25307 from bdach/slider-velocity-undo
Fix slider velocity changes not being undone correctly
2023-10-31 01:44:18 +09:00
Bartłomiej Dach
b3369dbb7b
Add failing test for slider velocity 2023-10-30 10:57:48 +01:00
Bartłomiej Dach
e1ff0d12c6
Update tests to NUnit-style assertions 2023-10-30 10:55:26 +01:00
Bartłomiej Dach
0ed5f274f6
Enable NRT in TestSceneSliderVelocityAdjust 2023-10-30 10:48:31 +01:00
Dean Herbert
fbba3787d1
Merge pull request #25190 from frenzibyte/match-skin-element-animation-support
Match capability of animating legacy skin elements with osu!(stable)
2023-10-30 18:25:06 +09:00
Bartłomiej Dach
7a5f3b856f
Add visual test coverage for displaying hitcircles with high combo index 2023-10-27 19:43:49 +02:00
Dan Balasescu
9a0882af69
Merge pull request #25218 from peppy/better-slider-judgement-handling
Fix out-of-order judgements when missing a slider head
2023-10-27 15:50:13 +09:00
Salman Ahmed
e949b1f613 Fix failing tests 2023-10-26 10:36:57 +03:00
Dean Herbert
7dd11fc5bf
Fix null check 2023-10-25 17:55:55 +09:00
Dean Herbert
e79aeea3b0
Add test coverage 2023-10-24 19:10:57 +09:00
Bartłomiej Dach
0e5a521695
Merge pull request #25157 from peppy/spinner-anti-cheese-final
Fix spinner cheese by accounting for spin directionality
2023-10-24 08:13:32 +02:00
Dean Herbert
d08ba764dd
Add extended testing of rewind 2023-10-23 20:29:46 +09:00
Dean Herbert
15c1fcbf96
Set ManualClock rate to 0 to avoid interpolation causing test errors 2023-10-23 20:29:36 +09:00
Dean Herbert
08b7c3d5ad
Remove test which makes less sense with new algorith 2023-10-23 20:01:23 +09:00
Dean Herbert
d0599496bd
Merge pull request #25177 from peppy/spinner-max-display 2023-10-21 11:10:09 +09:00
Dean Herbert
1be49f5b93
Update osu! difficulty calculator tests to factor in fractional changes 2023-10-20 19:04:24 +09:00
Dean Herbert
3fb74cb5f9
Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch
As discussed, it isn't used in stable like this. Was a mistake.
2023-10-20 18:57:14 +09:00
Dean Herbert
2ba6286470
Merge branch 'master' into fix-circle-radius 2023-10-20 18:53:36 +09:00
Dean Herbert
686c45e21b
Merge branch 'master' into legacy-tick-test-coverage 2023-10-20 16:41:32 +09:00
Dean Herbert
0da0855692
Add ability to change spin speed in spinner test 2023-10-20 16:10:54 +09:00
Bartłomiej Dach
dcfd6a0a8a
Remove DistancedHitObjectComposer inheritance from osu! composer 2023-10-19 11:46:30 +02:00
Dean Herbert
78d3c3723d
Ignore instead of retry tests 2023-10-18 20:12:14 +09:00
Dean Herbert
3a5490892c
Centralise and repair circle size calculations game-wide 2023-10-18 19:50:42 +09:00
Dean Herbert
54da6f1048
Merge pull request #25160 from bdach/repeat-arrow-hidden-fade
Adjust slider repeat transforms to closer match stable
2023-10-18 18:03:48 +09:00
Dean Herbert
be321e34e9
Attempt to fix flaky tests with egregious retry rule 2023-10-18 17:46:14 +09:00
Dean Herbert
7479830a8e
Comment flaky tests for now
Same issue as other commented test (clock precision not high enough).

Will probably want a solution to this at some point.
2023-10-18 16:26:34 +09:00
Dan Balasescu
939b55020c
Merge branch 'master' into legacy-tick-test-coverage 2023-10-18 15:21:31 +09:00
Bartłomiej Dach
f116854c9f
Add test step for covering slider appearance with hidden active 2023-10-17 14:15:21 +02:00
Dean Herbert
80ac0c46d9
Fix final test
This looks to have been a WIP test, so I've brought it up to the point
of passing. I haven't given it much more attention than that, though.
2023-10-17 20:24:23 +09:00
Dean Herbert
9011170c3e
Adjust tests in line with new expectations 2023-10-17 20:24:23 +09:00
Dean Herbert
af7180a5b5
Add SpinnerSpinHistory and tests 2023-10-17 20:10:22 +09:00
Dean Herbert
e081fa48a2
Fix various other inspections 2023-10-17 17:48:51 +09:00
Dean Herbert
5341a335a6
Bypass Parent nullability checks for now 2023-10-17 17:48:45 +09:00
Dan Balasescu
3065c9f23d
Fix potential frame misordering in generator 2023-10-16 22:49:41 +09:00
Bartłomiej Dach
b3d60c6d4f
Add inline commentary about workarounds in beatmap conversion test 2023-10-16 13:40:45 +02:00
Bartłomiej Dach
937694cd14
Fix conversion test failures 2023-10-16 13:37:11 +02:00
Dean Herbert
04af46b8c7
Change SpinFramesGenerator to take degrees as input 2023-10-16 18:34:56 +09:00
Dean Herbert
28ee99f132
Add prospective test coverage of spinner input handling 2023-10-16 18:31:01 +09:00
Dean Herbert
cfa4adb24d
Add SpinFramesGenerator class to simplify creating spinner tests 2023-10-16 18:25:40 +09:00
Dean Herbert
159b24acf7
Rename RateAdjustedRotation to TotalRotation 2023-10-16 18:25:03 +09:00
Bartłomiej Dach
d7e891140d
Apply mod multipliers to local score V1/V2 reimplementations 2023-10-09 13:04:12 +02:00
Bartłomiej Dach
419cc8784a
Apply mods to processor-based score algorithms 2023-10-09 12:59:02 +02:00
Dean Herbert
d14d885d19 Add test coverage of very fast slider 2023-10-04 14:58:05 +09:00
Dan Balasescu
854b797ab5
Merge branch 'master' into legacy-tick-not-so-legacy-after-all 2023-10-04 10:52:13 +09:00
Dean Herbert
69ae370e82 Merge branch 'master' into legacy-tick-test-coverage 2023-10-03 19:37:32 +09:00
Dean Herbert
941f26d462 Add extra test coverage to TestSceneOsuModAutoplay to cover fail case
Basically the slider needs to be slightly longer for this test to
correctly fail in headless tests, in conjunction with the new slider
tail leniency.

This is due to headless tests running at a fixed frame interval, and
these timings being *tight*.
2023-10-03 18:52:20 +09:00
Dean Herbert
f0070eecf1 Add rotation support for very old skins 2023-10-02 20:09:39 +09:00
Dean Herbert
3a124a99ce Improve test output for judgement checking 2023-10-02 15:28:32 +09:00
Dean Herbert
393ec119dd Add test coverage of very short sliders 2023-10-02 15:28:32 +09:00
Dean Herbert
589abe2c52 Add note about broken test 2023-10-02 15:28:32 +09:00
Dean Herbert
b683d55023 Add a couple of extra tests 2023-10-02 14:09:52 +09:00
Dean Herbert
07207ffc32 Fix hitsounds playing too early on fast sliders 2023-10-02 14:09:52 +09:00
Dean Herbert
2410036003 Refactor tests to be easier to visually understand 2023-10-02 14:09:52 +09:00
Dean Herbert
22cb168c0f Add test coverage of tracking inside lenience period but not at tick or end 2023-09-29 17:17:04 +09:00
Dean Herbert
135d2497e7 Add gameplay test coverage around last tick of slider
This includes proposed changes as per
https://github.com/ppy/osu/issues/22805#issuecomment-1740377493.
2023-09-29 16:06:48 +09:00
Dean Herbert
55c623ff02 Apply NRT to TestSceneSliderInput 2023-09-29 14:47:55 +09:00
Dean Herbert
81485c548c Move LegacyLastTickOffset specification to generation code and stop passing everywhere 2023-09-29 14:32:29 +09:00
Dan Balasescu
05c9f0f9cc Fix bonus requirement not considering number of normal ticks 2023-09-26 18:11:27 +09:00
Bartłomiej Dach
28da5baea4
Merge branch 'master' into fix-slider-length 2023-09-20 11:10:01 +02:00
Bartłomiej Dach
92cafe23fe
Merge pull request #24810 from peppy/remove-slider-head-movement-allowance
Remove slider head circle movement (and remove setting from "classic" mod)
2023-09-19 12:25:33 +02:00
Dean Herbert
046e96afcd Apply NRT to slider snaking tests 2023-09-19 14:51:03 +09:00
Bartłomiej Dach
0ffb906741
Merge pull request #24831 from peppy/update-deps
Update all dependencies (except for Moq)
2023-09-19 07:50:27 +02:00
Dean Herbert
4504c9fc43 Update tests in line with new slider snaking behaviour 2023-09-19 14:42:07 +09:00
Magnus-Cosmos
bd7dab1d86
Add test for slider path edge case 2023-09-18 12:02:20 -04:00
Dean Herbert
f3b6aa5435
Merge pull request #24821 from bdach/scoring-test-scene-osu
Refactor scoring test scene for ruleset extensibility (and move existing instance to osu! ruleset project)
2023-09-18 19:54:14 +09:00
Dean Herbert
56b5f52e83 Update all dependencies (except for Moq) 2023-09-16 15:37:31 +09:00
Bartłomiej Dach
ebdc501e5b
Add example scenarios and configurable score multiplier 2023-09-15 12:58:29 +02:00
Bartłomiej Dach
0c22ff2a80
Refactor further to allow extensibility to other rulesets 2023-09-15 12:58:29 +02:00
Bartłomiej Dach
45751dd1f2
Minimum viable changes for ruleset-specific scoring test scenes 2023-09-15 12:58:29 +02:00
Bartłomiej Dach
4275af1343
Merge branch 'master' into fix-slider-tick-misssing 2023-09-15 12:09:54 +02:00
Dean Herbert
ec82414090 Allow testing hitting sliders are certain points in tests 2023-09-14 17:49:41 +09:00
Dean Herbert
1ef0c92962 Inverse snaking toggle 2023-09-14 17:49:41 +09:00
Dean Herbert
46126719eb Fix slider tests not correctly passing slider velocity to slideres 2023-09-14 17:49:41 +09:00
Bartłomiej Dach
c68b76d9f4
Add more test cases for input handling with overlapping objects 2023-09-08 17:40:05 +02:00