Dean Herbert
0788a7e9f1
Merge branch 'master' into more-inspections
2019-02-28 14:32:57 +09:00
Dean Herbert
42be7857d1
Use expression body for property get/set where possible
2019-02-28 13:58:19 +09:00
Dean Herbert
26d53d06a9
Fix remaining issues
2019-02-28 13:31:40 +09:00
Dean Herbert
367bc53a06
Revert some more instances of 'e' variable names
2019-02-22 20:15:25 +09:00
smoogipoo
d61dfe888e
Fix venera fonts not being correctly specified
2019-02-22 19:42:09 +09:00
Dean Herbert
3015d40f8f
Merge branch 'master' into osu-fontusage
2019-02-22 18:09:23 +09:00
Dean Herbert
3fe4b8fd1c
Update variable names
...
Also cleans up some weird code
2019-02-22 17:51:39 +09:00
Dean Herbert
452caabd40
Apply suggestions from code review
...
Co-Authored-By: smoogipoo <1329837+smoogipoo@users.noreply.github.com>
2019-02-22 17:06:49 +09:00
smoogipoo
d8c55bc729
Adjust namespaces
2019-02-21 19:05:52 +09:00
smoogipoo
bca347427f
Update with framework bindable changes
2019-02-21 18:56:34 +09:00
smoogipoo
4db5531e4b
Replace copy-constructor/method with extension method
2019-02-20 19:32:30 +09:00
smoogipoo
dbfa95b9e7
Made medium the default font weight
2019-02-20 16:52:36 +09:00
smoogipoo
a2aa3ec5cb
Adjust sprite texts in-line with framework changes
2019-02-20 15:03:20 +09:00
EVAST9919
4d489da032
small visual improvements
2019-02-10 04:16:56 +03:00
EVAST9919
04e57d7d3d
Refactor to make things more flexible
2019-02-09 06:23:58 +03:00
EVAST9919
105053e91b
TestCase fix
2019-02-09 00:56:41 +03:00
EVAST9919
107e0a5239
Warning fixes
2019-02-08 20:43:11 +03:00
EVAST9919
bd1f4f9549
Small design fixes
2019-02-08 20:35:07 +03:00
EVAST9919
13c154a0b3
Fix background colour and a bug with removing scores
2019-02-08 20:07:21 +03:00
EVAST9919
7a3ae0f479
update drawable score inline with the latest design
2019-02-08 19:50:02 +03:00
EVAST9919
f43ee6b6a3
update drawable top score inline with the latest design
2019-02-08 19:06:46 +03:00
EVAST9919
9cca11fb0d
Warning fixes
2019-02-06 01:48:43 +03:00
EVAST9919
c85dc1a236
update another scores design
2019-02-05 19:32:33 +03:00
EVAST9919
f560dde157
Add some flow for info containers
2019-02-05 15:26:45 +03:00
EVAST9919
559960036e
update top score design
2019-02-05 14:48:35 +03:00
Dean Herbert
0b8bd520ab
Shake in all cases
2019-01-31 19:15:04 +09:00
Dean Herbert
b89694a969
Fix "importing" state display
2019-01-31 19:09:04 +09:00
Dean Herbert
c54a515b3e
Change where BindValueChange is immediately run
2019-01-31 18:49:54 +09:00
Dean Herbert
327a34f12a
Merge remote-tracking branch 'upstream/master' into download-tracking-component
...
# Conflicts:
# osu.Game/Beatmaps/Drawables/BeatmapSetDownloader.cs
2019-01-31 18:45:09 +09:00
Dean Herbert
8617aaa2a7
Update licence header (and remove year)
2019-01-24 17:43:03 +09:00
Dean Herbert
7d6d7cf457
Merge remote-tracking branch 'upstream/master' into download-tracking-component
...
# Conflicts:
# osu.Game/Overlays/BeatmapSet/Buttons/DownloadButton.cs
2019-01-23 11:06:29 +09:00
Dean Herbert
09553550a3
Remove remaining supporter check
2019-01-23 00:19:39 +09:00
Dean Herbert
21e79f51b1
Remove necessity of BeatmapSetDownloader
2019-01-18 14:28:06 +09:00
Dean Herbert
8848fa8b1b
Improve UX of download buttons on beatmap set overlay
2019-01-18 12:04:49 +09:00
Dean Herbert
b62630ecd2
Centralise download tracking logic so we can show it in multiple scenarios
2019-01-18 11:28:10 +09:00
Dean Herbert
e3308010c0
Merge pull request #3898 from peppy/leaderboard-modularity
...
Leaderboard modularity
2018-12-22 15:36:12 +09:00
smoogipoo
e657f13c15
Separate out Leaderboard into BeatmapLeaderboard
2018-12-22 14:44:36 +09:00
smoogipoo
f47ac35522
Add click to avatar
2018-12-22 14:23:53 +09:00
Dean Herbert
831cd3ed59
ScoreInfo scoreInfo -> ScoreInfo score
2018-11-30 15:18:52 +09:00
smoogipoo
219929eb47
Score -> ScoreInfo
2018-11-28 18:33:01 +09:00
smoogipoo
5fd6e6ca77
Re-namespacing
2018-11-28 16:12:57 +09:00
smoogipoo
f27bd3ef3e
OpenTK -> osuTK
2018-11-20 17:14:59 +09:00
ekrctb
99fc04c8af
Change signature to new event handler
2018-10-02 12:02:47 +09:00
Dean Herbert
37f3035437
Merge remote-tracking branch 'upstream/master' into update-framework
2018-09-20 18:39:48 +09:00
smoogipoo
7b8094d731
Move text size/padding out of constructor
2018-09-20 12:53:45 +09:00
ekrctb
b790e16217
Use Click instead of now removed TriggerOnClick
2018-09-19 11:42:32 +09:00
Dean Herbert
ccd7c1a17d
Cancel request on disposal for safety
2018-09-06 17:04:33 +09:00
Dean Herbert
923acfbeaf
Fix some web requests being run after disposal of their owner
2018-09-05 10:26:54 +09:00
smoogipoo
ec31028f14
Add tooltip
2018-07-31 14:50:57 +09:00
smoogipoo
70338e087a
Disable beatmap download button if not supporter
2018-07-31 14:41:31 +09:00
Dean Herbert
0f37758314
Update framework
2018-07-21 16:21:53 +09:00
Dean Herbert
825941aff1
Use switch with type matching in place of if-else where possible
2018-07-17 14:35:09 +09:00
naoey
2a0b1f3615
Update direct panel download button for new design
...
- Add a download failed event to BeatmapManager
- Make DownloadButton aware of all 3 possible download states
- Change button appearance based on each state
2018-07-03 20:18:09 +05:30
smoogipoo
b2066c5d73
Rework preview tracks to reduce usage complexities
2018-06-21 18:40:27 +09:00
Dan Balasescu
126678c226
Merge branch 'master' into multiple_previews_different_overlays
2018-06-12 19:26:51 +09:00
Dan Balasescu
7de8e1cfc4
Merge branch 'master' into refactor-api
2018-06-11 18:49:15 +09:00
Roman Kapustin
8702a70524
Resolve merge conflicts in DirectOverlay
2018-06-08 21:03:16 +03:00
Dean Herbert
8cc31aca54
Reorganise API requests and response classes
...
They were previously breaking the two-class-per-file rule.
2018-06-08 11:42:35 +09:00
DrabWeb
0fae49ee21
Don't add a 'with Video' subtitle.
2018-06-07 20:47:27 -03:00
Dean Herbert
2e23da1dfa
Merge branch 'master' into beatmap-set-downloader
2018-06-06 20:32:58 +09:00
DrabWeb
188272e15d
Replace OnAlreadyDownloading with returning a bool from Download.
2018-06-06 03:18:42 -03:00
DrabWeb
df4c855aa2
Manage subtitle inside of DownloadButton.
2018-06-06 03:13:37 -03:00
Dean Herbert
00c8d2ff11
Merge branch 'master' into source-link-colour
2018-06-06 08:27:28 +09:00
DrabWeb
61e1358410
Add OnAlreadyDownloading animations.
2018-06-04 21:07:17 -03:00
DrabWeb
01c5060bcf
Move BeatmapSetDownloader to osu.Game.Beatmaps.Drawables
2018-06-04 20:30:54 -03:00
DrabWeb
9377ffb784
Update BeatmapSetOverlay to use BeatmapSetDownloader.
2018-06-04 20:27:34 -03:00
Joehu
7101533926
Remove 'description' field
2018-06-03 08:02:57 -07:00
Joehu
5c713ac2ab
Use default colour in MetadataSection
2018-06-03 07:51:57 -07:00
Joehu
dc2a004c87
Remove link colours for all unlinked text
2018-06-02 12:04:58 -07:00
Dean Herbert
8bde1fd327
Merge branch 'master' into updateable-beatmap-set-cover
2018-06-01 15:20:59 +09:00
Joehu
729f2ec725
Match authorinfo with web
2018-05-31 14:34:47 -07:00
Joehu
b4d621a2cb
Add link colour to beatmap source
2018-05-31 10:21:22 -07:00
DrabWeb
6781b81336
Cleanup.
2018-05-31 05:48:42 -03:00
DrabWeb
bdfb5752cd
Update existing drawables to use UpdateableBeatmapSetCover.
2018-05-28 19:31:20 -03:00
Roman Kapustin
572c3f5189
Stop preview playback when an overlay is popping out
2018-05-25 23:51:05 +03:00
Roman Kapustin
a24589f583
Cleanup external PlayButton.Playing usage
2018-05-25 22:35:15 +03:00
Dean Herbert
1cb7d50407
Add and use default size (smaller than before)
2018-05-25 18:51:57 +09:00
Roman Kapustin
498244a308
Introduce PreviewTrack class
2018-05-25 00:37:53 +03:00
jorolf
b324337fa1
Add icon next to beatmap title/username to open in browser
2018-05-22 15:29:52 +02:00
Dean Herbert
1be2571d33
Make BeatmapSetOverlay accept nulls everywhere
2018-04-18 16:08:45 +09:00
Dean Herbert
32a74f95a5
Normalize all the line endings
2018-04-13 18:26:38 +09:00
TocoToucan
9acea6eab0
Order beatmap difficulty icons correctly
2018-04-12 19:33:30 +03:00
smoogipoo
b97c4e8b44
Fix all possible cases of crossthread import data races
2018-04-09 12:45:44 +09:00
DrabWeb
eb374c5774
Add beatmap set online status and display it in direct panels and the beatmap set overlay.
2018-03-26 21:04:45 -03:00
Dean Herbert
d340509b1d
Move ArchiveReaders to a more global namespace
...
Also moves delete and action logic to a shared implementation
2018-02-15 14:22:39 +09:00
Aergwyn
56619ae926
use ternary expression
2018-01-18 15:53:53 +01:00
Aergwyn
f86cb30e47
prevent negative width on progress bar
2018-01-17 20:35:28 +01:00
Dean Herbert
37d393bca0
Update licence headers
2018-01-05 20:21:19 +09:00
Aergwyn
ccb69d16d9
move HitResult in Scoring namespace to replace HitCount
2017-12-30 21:23:18 +01:00
Aergwyn
138d78309f
add HitCount enum and replace string usage with enum
2017-12-30 18:07:30 +01:00
Aergwyn
f7fe083018
add tooltip to country flags
2017-12-30 14:59:35 +01:00
Dean Herbert
3c1654e5e4
Fix many instances of non-osu-prefixed text classes being used
...
Results in incorrect default formatting.
2017-12-26 00:44:35 +09:00
Dean Herbert
24b3b10942
Move drawable assignment to load, remove depth overrides
2017-12-07 20:44:55 +09:00
Dean Herbert
8c89354b36
Remove extra whitespace
2017-12-07 20:44:38 +09:00
Santeri
898c49c19d
remove unnecessary assignments
2017-11-28 16:14:32 +02:00
Santeri
e9277d8cb1
last directive error...
2017-11-28 00:27:58 +02:00
Santeri
49949bf698
fix minor param/directive errors
2017-11-28 00:20:44 +02:00
Santeri
86de6f8252
derives from trianglebutton rather than osubutton
2017-11-28 00:09:58 +02:00
Santeri
0a8fa2e6de
Merge branch 'master' into header-button-should-derive
2017-11-27 23:16:42 +02:00
Santeri Nogelainen
96f782e75a
fix object reference issue maybe?
2017-11-27 13:51:56 +02:00
Santeri Nogelainen
bf8d15108e
headerbutton now derives from osubutton
2017-11-27 13:39:01 +02:00
Unknown
f6a33b3ea2
fix osu!direct download reloading all panels
...
This fixes the recreation of all panels when a download completes.
Also fixes NullReference when you download without ever opening the details of one Set.
2017-11-25 14:45:57 +01:00
Dean Herbert
5ea3292dc5
Merge remote-tracking branch 'upstream/master' into load-optimization
2017-11-23 20:21:44 +09:00
Dean Herbert
4986ad73f7
Merge remote-tracking branch 'upstream/master' into load-optimization
2017-11-23 18:44:17 +09:00
Dean Herbert
cf4fc05be3
Fix nullref on disposing BeatmapSetOverlay before load
...
Only affects VisualTests
2017-11-23 17:33:46 +09:00
FreezyLemon
2cc2323791
Style changes (removing newline from before second constructor parameter)
2017-11-23 09:12:23 +01:00
Dean Herbert
6e51664544
Merge branch 'master' into beatmap-overlay-download
2017-11-23 17:11:28 +09:00
FreezyLemon
7d428875b8
Changed LoadWrapper back to DelayedLoadWrapper and fixed the implementation (dependent on framework change, delay now in ctor)
2017-11-22 15:46:04 +01:00
FreezyLemon
bf0184c06d
One more small style fix
2017-11-21 19:34:01 +01:00
FreezyLemon
2203a84300
Small fixes and style corrections
2017-11-21 19:16:44 +01:00
FreezyLemon
870807c265
Switched over to the new LoadWrapper class for all delayed loading.
2017-11-21 16:17:33 +01:00
naoey
97c5956083
Make download buttons disappear instead of closing overlay.
...
- Also unbind event handlers
- Remove unused field
2017-11-16 19:17:22 +05:30
Dean Herbert
62358c0b53
Merge branch 'master' into beatmap_scores
2017-11-16 00:45:17 +09:00
naoey
df53b884ea
Removed unused stuff.
2017-11-15 18:00:19 +05:30
naoey
bbe555dc3c
Pass noVideo flag on...
2017-11-15 17:49:41 +05:30
naoey
5aeeb9aac6
Merge remote-tracking branch 'upstream/master' into beatmap-overlay-download
2017-11-15 17:38:38 +05:30
Dean Herbert
fda810eb8f
Remove scrollability from sub-areas in beatmap overaly
...
The areas that are scrollable inside the beatmap overlay make for a very frustrating experience. Let's disable them for now.
2017-11-15 19:02:56 +09:00
EVAST9919
60a2d84e09
Make the x position depends on the avatar size
2017-11-15 10:43:32 +03:00
EVAST9919
093ebb8b17
Apply suggested changes
2017-11-15 10:21:07 +03:00
Dean Herbert
7dd2720b4b
Merge branch 'master' into beatmap_scores
2017-11-15 13:41:38 +09:00
Dean Herbert
6ef60d0b4e
Merge branch 'master' into beatmap-overlay-scores
2017-11-15 13:18:32 +09:00
EVAST9919
fa6d3f9792
Reduce isLoading calls
2017-11-13 18:49:10 +03:00
EVAST9919
d157e6baf1
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap_scores
2017-11-13 16:02:44 +03:00
Unknown
16e48ed187
Hook up download logic with BeatmapSetOverlay download buttons.
...
- Add noVideo option to DownloadBeatmapSetRequest
- Make Download fire an event with new download instead of returning it
2017-11-12 18:41:10 +05:30
EVAST9919
96e99d996b
Add TestCase
2017-11-12 09:01:13 +03:00
EVAST9919
1792075cf9
Loading animation fix
2017-11-12 07:50:01 +03:00
EVAST9919
7c0b13f9ef
CI fixes and minor visual improvements
2017-11-12 07:31:08 +03:00
EVAST9919
569780d37b
Move Api request outside the scores container itself
2017-11-12 07:05:50 +03:00
EVAST9919
36ac002820
Fix incorrect null check
2017-11-11 18:25:16 +03:00
EVAST9919
74bcc61a67
Fix possible overlapping
2017-11-11 07:51:07 +03:00
EVAST9919
057ada0183
Fix nulls
2017-11-11 07:50:40 +03:00
EVAST9919
944bdc1c25
CI fixes
2017-11-11 07:07:41 +03:00
EVAST9919
5bf756c3c6
Add DrawableTopScore
2017-11-11 06:54:52 +03:00
EVAST9919
3261af5200
Add scores container
2017-11-11 03:46:06 +03:00
EVAST9919
c2f3971188
Extend Beatmap Set Response
2017-11-10 03:01:11 +03:00
EVAST9919
b8b5c67cd2
Apply suggestion concerning the BeatmapSetType enum
2017-11-06 21:46:28 +03:00
EVAST9919
ebaef86432
Fix hard crash when opening beatmap with zero playcount in beatmap overlay
2017-11-06 21:28:01 +03:00
Dean Herbert
7bc0ef44f2
Merge branch 'master' into beatmap-preview-fix
2017-10-30 16:22:47 +09:00
Huo Yaoyuan
06fe874594
CI fixes.
2017-10-15 16:53:30 +08:00
Huo Yaoyuan
9b3676c562
Use format string for double instead of Math.Round.
2017-10-15 16:44:15 +08:00
EVAST9919
bd7bc2c0d2
Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-preview-fix
2017-10-15 00:14:59 +03:00
EVAST9919
e8f85a08b8
Fix audio preview still playing after closing the beatmap overlay
2017-10-14 05:58:06 +03:00
Dean Herbert
cd722e4abb
Fix beatmap author being stored in two different places
2017-10-14 11:39:55 +09:00
Dean Herbert
abf5418080
Apply some renames and refactoring of loading logic
...
Reduced publicly facing properties where possible. Also fixes a potentially bad state issue when the beatmapset was changed while a load was in progress.
2017-10-13 14:06:34 +09:00
Jorolf
f3ca6cc387
remove redundant stuff
2017-10-06 22:02:33 +02:00
Jorolf
de2181b8f5
Merge branch 'master' of git://github.com/ppy/osu into direct-previews
2017-10-06 21:02:48 +02:00
Jorolf
5a8b8dacbb
move stuff thats duplicated in PreviewButton and DirectPanel to PlayButton
2017-10-06 21:02:00 +02:00
EVAST9919
92c3d722b4
Show mapper's profile when clicking on avatar in BeatmapSetOverlay
2017-09-30 05:41:32 +03:00
Jorolf
2457df8e18
remove unused usings and reset the track to the start when playing again
2017-09-29 23:26:16 +02:00
Jorolf
647304c14b
move logic to DirectPanel and reuse stuff for the PreviewButton
2017-09-29 23:08:30 +02:00