15048 Commits

Author	SHA1	Message	Date
Dean Herbert	c90d345ff9	Scroll content forever rather than aggressively fading	2024-07-25 14:31:21 +09:00
Salman Ahmed	dad8e28446	Fix replay download button not added when no score is selected initially	2024-07-25 07:40:17 +03:00
Dean Herbert	aac98ab6b2	Debounce leaderboard refetches to stop excessive operations after returning from gameplay	2024-07-25 12:58:35 +09:00
Dean Herbert	9ec687caab	Avoid reloading the daily challenge leaderboard when already requested	2024-07-25 12:55:45 +09:00
Dean Herbert	4983e5f33e	Merge pull request #29039 from bdach/multiple-selection-sample-popover ... Make sample popover change properties of all samples in multiple selection	2024-07-24 22:49:20 +09:00
Bartłomiej Dach	1ed7e4b075	Make sample popover change properties of all samples in multiple selection ... Closes https://github.com/ppy/osu/issues/28916. The previous behaviour *may* have been intended, but it was honestly quite baffling. This seems like a saner variant.	2024-07-24 12:15:12 +02:00
Dean Herbert	6e4625609d	Merge pull request #29036 from bdach/hardcode-positions-for-leaderboard ... Fill daily challenge top 50 position numbers client-side	2024-07-24 17:49:51 +09:00
Bartłomiej Dach	788b70469d	Exit daily challenge screen when going offline ... This sort of thing is bound to happen when rewriting screens from scratch without invoking abstract eldritch entities sometimes. Damned if you do, damned if you don't...	2024-07-24 09:15:32 +02:00
Bartłomiej Dach	bf4bf4d39e	Fill daily challenge top 50 position numbers client-side ... Only doing this client-side, because doing this server-side is expensive: https://github.com/ppy/osu-web/pull/11354#discussion_r1689224285	2024-07-24 08:57:11 +02:00
Dean Herbert	aded31bd07	Merge pull request #29021 from bdach/editor-breaks-respect-time-preempt ... Respect pre-empt time when auto-generating breaks	2024-07-24 15:21:12 +09:00
Dean Herbert	aed7ba9508	Change order of application to avoid bias to side with more room to drag ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-07-23 20:56:21 +09:00
Bartłomiej Dach	c3062f96ee	Fix autogenerated breaks not invalidating on change to pre-empt time	2024-07-23 13:38:50 +02:00
Bartłomiej Dach	088e8ad0a2	Respect pre-empt time when auto-generating breaks ... Closes https://github.com/ppy/osu/issues/28703.	2024-07-23 13:30:13 +02:00
Dean Herbert	cc4ed0ff3f	Use non-screen-space coordinates and add time-based drag ramping for better control	2024-07-23 18:59:22 +09:00
Bartłomiej Dach	38fc6f70f6	Add tolerance when drag-scrolling editor timeline ... Closes https://github.com/ppy/osu/issues/28983. While the direct cause of this is most likely mouse confine in full-screen, it shouldn't/can't really be disabled just for this, and I also get this on linux in *windowed* mode. In checking other apps, adding some tolerance to this sort of drag-scroll behaviour seems like a sane UX improvement anyways.	2024-07-23 11:10:18 +02:00
Bartłomiej Dach	dd8be62d07	Merge pull request #28849 from frenzibyte/custom-profile-colour ... Add custom hue support to user profile overlay	2024-07-22 09:41:32 +02:00
Salman Ahmed	818b60a3d8	Fix pause overlay hiding input from ruleset input manager ... If a key is pressed while the pause overlay is visible, the ruleset input manager will not see it, therefore if the user resumes while the key is held then releases the key, the ruleset input manager will not receive the key up event.	2024-07-19 18:48:35 +03:00
Salman Ahmed	d7651ef387	Add extensive test cases for correct input handling while paused in osu! & non-osu!	2024-07-19 18:48:35 +03:00
Bartłomiej Dach	27000aa8ed	Merge branch 'master' into editor-blah	2024-07-19 13:42:40 +02:00
Dan Balasescu	ad564f31cb	Merge pull request #28947 from peppy/fix-playlist-item-panel ... Fix various visuals of playlist beatmap panels	2024-07-19 20:12:40 +09:00
Dean Herbert	c2cc85e6f0	Use purple again for kiai time specifically	2024-07-19 19:59:38 +09:00
Dean Herbert	c4de2bbb60	Ignore "too many ticks" in timeline (triggers in normal cases)	2024-07-19 19:57:47 +09:00
Dean Herbert	5ee645ac8f	Increase opacity of control points slightly	2024-07-19 19:50:21 +09:00
Dean Herbert	d9297438ba	Merge pull request #28900 from smoogipoo/fix-more-tests ... Fix more test failures	2024-07-19 19:38:52 +09:00
Dean Herbert	f11f01f9b7	Fix various visuals of playlist beatmap panels ... Supersedes https://github.com/ppy/osu/pull/28907. - Fix border being fat - Fix thumbnail not masking correctly - Fix background layer not being correctly fit to the panel - Dim the main background on hover - Minor tweaks to dimming	2024-07-19 19:26:04 +09:00
Dan Balasescu	5af39aad00	Add beatmap name to log string ... Makes it easy to compare this line versus the one in OsuGame.PresentBeatmap(). At the moment it's just GUID which is... not useful!	2024-07-19 19:02:41 +09:00
Dean Herbert	0f29ed618a	Don't attempt to clear the carousel during realm blocking operation	2024-07-19 17:39:47 +09:00
Dean Herbert	0560214d5b	Fix beatmap carousel performance regression with large databases	2024-07-19 17:39:47 +09:00
Bartłomiej Dach	4dd225fdc8	Fix compose blueprint container not unsubscribing from event ... Closes https://github.com/ppy/osu/issues/28938. This is related to reloading the composer on timing point changes in scrolling rulesets. The lack of unsubscription from this would cause blueprints to be created for disposed composers via the `hitObjectAdded()` flow. The following line looks as if a sync load should be forced on a newly created placement blueprint: da4d37c4ad/osu.Game/Screens/Edit/Compose/Components/ComposeBlueprintContainer.cs (L364) however, it is not the case if the parent (`placementBlueprintContainer`) is disposed, which it would be in this case. Therefore, the blueprint stays `NotLoaded` rather than `Ready`, therefore it never receives its DI dependencies, therefore it dies on an `EditorBeatmap` nullref.	2024-07-19 08:32:36 +02:00
Salman Ahmed	a570949459	Fix selection box initialy visible despite no items selected	2024-07-19 03:00:44 +03:00
Salman Ahmed	d61a72b8fb	Explicitly define Hue rather than implicitly provide it by enum value	2024-07-18 00:26:24 +03:00
Bartłomiej Dach	4c1f902969	Do not allow working beatmap to switch to protected beatmap in song select ... Principal fix to https://github.com/ppy/osu/issues/28880.	2024-07-17 11:46:19 +02:00
Bartłomiej Dach	ad2db3f853	Merge pull request #28882 from peppy/update-framework ... Update framework	2024-07-16 12:28:51 +02:00
Dean Herbert	f1325386f0	Fix summary timeline timing points having x position applied twice	2024-07-16 18:32:54 +09:00
Dean Herbert	4ad7d900c1	Fix incorrect editor screen padding	2024-07-16 18:20:33 +09:00
Dean Herbert	1083e71ce6	Fix potential crash when exiting daily challenge screen ... Without the schedule this will potentially run after disposal of the local drawable hierarchy. Closes https://github.com/ppy/osu/issues/28875.	2024-07-16 03:02:04 +09:00
Dean Herbert	eb3f480a2a	Merge pull request #28683 from frenzibyte/footer-v2-integration ... Replace local footer in existing sheared overlays (e.g. mod select & first-run setup) with `ScreenFooter`	2024-07-12 22:45:06 +09:00
Dean Herbert	e8f7213b3b	Move logo depth to a forward passing	2024-07-12 22:01:20 +09:00
Bartłomiej Dach	217b01d303	Apply tooltip to bookmark pieces too ... Bookmarks don't show on real beatmaps, but they do show in test scenes (namely `TestSceneEditorSummaryTimeline`). Also does some more changes to adjust the markers to the latest updates to other markers.	2024-07-12 11:12:20 +02:00
Dean Herbert	2453e2fd00	Fix nullability issue	2024-07-12 18:11:23 +09:00
Bartłomiej Dach	5e00995948	Merge branch 'master' into tooltips	2024-07-12 11:01:03 +02:00
Bartłomiej Dach	518dc17518	Merge pull request #28788 from bdach/timeline-redesign ... Redesign editor timelines to address most frequent user complaints	2024-07-12 10:58:59 +02:00
Dean Herbert	4be5d056c5	Reduce opacity of centre marker slightly	2024-07-12 17:23:48 +09:00
Dean Herbert	d2cb07b157	Add a bit more padding between node overlays and hitobjects in timeline	2024-07-12 17:22:36 +09:00
Dean Herbert	2454722601	Add tooltips to summary timeline display	2024-07-12 16:39:41 +09:00
Dean Herbert	275e7aa451	Adjust timeline centre marker visuals and bring in front of ticks	2024-07-12 16:37:03 +09:00
Dean Herbert	ca2fc72959	Adjust timeline centre marker visuals and bring in front of ticks	2024-07-12 16:29:40 +09:00
Dean Herbert	f65ab6736d	Adjust breaks in timeline to be centered with waveform / hitobjects	2024-07-12 15:45:58 +09:00
Dean Herbert	2ad2ae0c16	Add slight offset for timeline BPM display to avoid overlaps	2024-07-12 14:34:01 +09:00
Dean Herbert	9a7a0cdb34	Adjust timeline ticks to add a bit more body back	2024-07-12 14:29:18 +09:00
Dean Herbert	685b19a571	Adjust various visuals of summary timeline in a hope for user acceptance ... .. with a somewhat appealing design.	2024-07-12 13:57:42 +09:00
Dean Herbert	fb4f620c90	Add back BPM and adjust sizing of bottom bar a bit more	2024-07-12 12:34:43 +09:00
Salman Ahmed	d4a4a059d4	Fix footer content not accessible by overlay when overriden by a subclass	2024-07-11 15:31:02 +03:00
Bartłomiej Dach	ccc4d288b2	Merge pull request #28821 from peppy/fix-editor-dim ... Fix editor UI transparency being incorrectly opaque when hovering slider control points	2024-07-11 12:05:10 +02:00
Dean Herbert	95464ebf36	Merge branch 'master' into timeline-redesign	2024-07-11 18:38:17 +09:00
Bartłomiej Dach	6801ccbbc5	Fix editor UI remaining transparent when switching away from compose tab ... Could still happen if using the keyboard F-key shortcuts. In that case the composer becomes non-present, so its `Update()` can't really do anything.	2024-07-11 11:23:09 +02:00
Bartłomiej Dach	f1fa34e5d5	Merge pull request #28800 from peppy/file-mounting-v3 ... Add ability to edit beatmap content externally	2024-07-11 10:47:36 +02:00
Dean Herbert	c139478aa2	Merge pull request #28805 from frenzibyte/select-all-on-focus ... Select all text when focusing sample bank/volume textboxes in editor (and number boxes in general)	2024-07-11 17:33:30 +09:00
Dean Herbert	7b0c1e3498	Also apply to timing textboxes	2024-07-11 16:54:27 +09:00
Bartłomiej Dach	cc0d7e9981	Add error logging on failure to begin/end external edit	2024-07-11 09:54:12 +02:00
Bartłomiej Dach	ac467cf73a	Set locally modified state for all externally modified beatmap(sets) that could not be mapped to online	2024-07-11 09:44:33 +02:00
Dean Herbert	fe421edd8f	Fix editor UI transparency being incorrectly opaque when hovering slider control points ... As mentioned at https://github.com/ppy/osu/pull/28787#issuecomment-2221150025.	2024-07-11 16:41:21 +09:00
Dean Herbert	b5bb94e4ec	Merge branch 'master' into file-mounting-v3	2024-07-11 15:54:54 +09:00
Dan Balasescu	00cab0ec0a	Merge pull request #28809 from bdach/mania-timeline-zooms-composer ... Match mania editor playfield time range with timeline zoom	2024-07-11 15:41:26 +09:00
Dean Herbert	bdbdc3592e	Move full export async flow inside screen and add error handling	2024-07-11 14:27:12 +09:00
Dean Herbert	599a765fd1	Add confirmation before saving for external edit	2024-07-11 12:20:33 +09:00
Dean Herbert	cd6b0e875a	Simplify save dialogs	2024-07-11 12:15:17 +09:00
Dean Herbert	b0d6c8ca6d	Abort operation on save failure	2024-07-11 11:42:06 +09:00
Bartłomiej Dach	4901fece26	Merge branch 'master' into fix-dialog-overflow	2024-07-10 18:20:18 +02:00
Bartłomiej Dach	55b4dd9b99	Adjust punctuation	2024-07-10 18:17:10 +02:00
Bartłomiej Dach	92dc125d39	Match mania editor playfield time range with timeline zoom	2024-07-10 17:36:39 +02:00
Dean Herbert	b58ba5f5f1	Just give in to silly code quality inspection	2024-07-10 23:02:19 +09:00
Salman Ahmed	bb9a2b705e	Remove unnecessary math min	2024-07-10 16:29:28 +03:00
Salman Ahmed	7d667ac46b	Fix confirm exit dialog overflowing from too many ongoing operations	2024-07-10 16:06:53 +03:00
Bartłomiej Dach	c8a64c5950	Remove setup screen controls that do nothing useful ... Before I go with a hammer to redesign these, I want to remove stuff that does nothing first. Hard-breaks API to allow rulesets to specify an enumerable of custom sections rather than two specific weird ones. For specific rulesets: - osu!: - Stack leniency slider merged into difficulty section. - osu!taiko: - Approach rate and circle size sliders removed. - Colours section removed. - osu!catch: - No functional changes. - osu!mania: - Special style toggle merged into difficulty section. - Colours section removed.	2024-07-10 14:53:16 +02:00
Salman Ahmed	ce93455aa8	Extend behaviour to sample edit popover	2024-07-10 15:16:10 +03:00
Dean Herbert	b6741ee4ea	Fix back-to-front exit blocking conditionals	2024-07-10 20:00:34 +09:00
Dean Herbert	75344f9c5c	Fix break overlay progress bar becoming a pancake near end of break	2024-07-10 19:28:37 +09:00
Dean Herbert	1381b3c0c5	Merge pull request #28801 from bdach/break-generation-caching ... Improve performance of automatic break regeneration	2024-07-10 19:21:16 +09:00
Bartłomiej Dach	b881c25b17	Pool summary timeline break visualisations to reduce allocations	2024-07-10 11:42:28 +02:00
Bartłomiej Dach	343090e3b1	Do not regenerate breaks unless meaningful change to object start/end times is detected ... Tangentially found when profiling https://github.com/ppy/osu/pull/28792. For reproduction, import https://osu.ppy.sh/beatmapsets/972#osu/9007, move any object on the playfield, and observe a half-second freeze when ending the drag.	2024-07-10 11:42:25 +02:00
Dean Herbert	aa16c72e06	Add test coverage of external editing	2024-07-10 18:34:47 +09:00
Dean Herbert	3beca64cc5	Attempt to stay on correct difficulty	2024-07-10 18:34:46 +09:00
Dean Herbert	27ab54882b	Add loading segments and tidy things up	2024-07-10 18:34:46 +09:00
Dean Herbert	74aa05fa6e	Improve UX and styling of external edit screen	2024-07-10 18:34:45 +09:00
Dean Herbert	118162c631	Add sub screen to limit user interactions	2024-07-10 18:34:45 +09:00
Dean Herbert	d3c66e2404	Add basic flow for mounting beatmaps for external editing	2024-07-10 18:29:51 +09:00
Salman Ahmed	337f05f9a4	Fix loading (but not showing) a sheared overlay hiding displayed footer content ... Identified by tests. See https://github.com/ppy/osu/actions/runs/9869382635/job/27253010485 & https://github.com/ppy/osu/actions/runs/9869382635/job/27253009622. This change also prevents the initial `PopOut` call in overlays from calling `clearActiveOverlayContainer`, since it's not in the update thread and it's never meant to be called at that point anyway (it's supposed to be accompanied by a previous `PopIn` call adding the footer content).	2024-07-10 11:56:35 +03:00
Salman Ahmed	002679ebb0	Ask for VisibilityContainer explicitly	2024-07-10 11:14:22 +03:00
Bartłomiej Dach	95783bd6c2	Merge pull request #28789 from peppy/fix-deletes-reappearing ... Fix deleted beatmap sets potentially reappearing due to pending update requests	2024-07-10 09:14:10 +02:00
Dean Herbert	9a88281ab0	Merge branch 'master' into footer-v2-integration	2024-07-10 15:33:05 +09:00
Dean Herbert	4fe3f39d22	Merge pull request #28682 from frenzibyte/footer-v2-overlay-content ... Add implementation for `ScreenFooter` to house footer content of sheared overlays	2024-07-10 15:08:00 +09:00
Dean Herbert	cd9973b6f9	Merge pull request #28740 from bdach/daily-challenge/better-results ... Improve results displays in daily challenge screen	2024-07-10 14:17:21 +09:00
Dean Herbert	f281019358	Rename method to match provided argument	2024-07-10 14:00:15 +09:00
Joseph Madamba	8c81ba3357	Fix preview track persisting to play after leaving multi/playlists room	2024-07-09 14:36:24 -07:00
Dean Herbert	123d3d2ff8	Add similar special case for insert after removal	2024-07-09 20:44:55 +09:00
Dean Herbert	0e2e44a2f5	Add failing test case showing editor save then delete failure	2024-07-09 20:41:22 +09:00
Salman Ahmed	ed1f3a1eb4	Merge branch 'master' into footer-v2-integration	2024-07-09 13:48:40 +03:00
Salman Ahmed	b17af86491	Merge branch 'master' into footer-v2-overlay-content	2024-07-09 13:41:44 +03:00
Bartłomiej Dach	ca4c0aa7e2	Remove unused using	2024-07-09 10:57:21 +02:00