Dan Balasescu
9036b13637
Merge pull request #13260 from peppy/legacy-skin-resource-improvements
...
Allow `LegacyDefaultSkin` to be constructed without extra resource store parameter
2021-05-31 20:49:21 +09:00
Dean Herbert
f60e9cb085
Remove weird override logic in TestCase methods
2021-05-31 20:00:47 +09:00
Dean Herbert
e78391db7a
Fix usage of DI before it's ready in combo colour tests
2021-05-31 19:58:19 +09:00
Dean Herbert
17fa2426d4
Merge branch 'master' into legacy-skin-resource-improvements
2021-05-31 19:36:09 +09:00
Dean Herbert
ebfc24a499
Rename conflicting resources
2021-05-31 19:14:49 +09:00
Dean Herbert
b16d10bd95
Provide game-wide resources via IStorageResourceProvider
2021-05-31 18:57:47 +09:00
Bartłomiej Dach
ab077c6656
Merge branch 'master' into non-nullable-beatmapset-files
2021-05-31 00:10:03 +02:00
Dean Herbert
581a86b91a
Revert "Revert "Fix editor tests failing due to empty files being specified""
...
This reverts commit 1af684c4b2
2021-05-28 14:33:06 +09:00
Dean Herbert
1af684c4b2
Revert "Fix editor tests failing due to empty files being specified"
...
This reverts commit fdbd421040
2021-05-28 14:15:28 +09:00
Salman Ahmed
3585e2900e
Replace unnecessary empty skin implementation with null
2021-05-24 12:28:52 +03:00
Salman Ahmed
4f6de6fdc6
Implement GetSkin() for other working beatmaps
2021-05-21 20:21:29 +03:00
Salman Ahmed
04e75d8f2b
Return empty skin for GetSkin() in TestWorkingBeatmap
2021-05-21 20:21:13 +03:00
Dean Herbert
fdbd421040
Fix editor tests failing due to empty files being specified
2021-05-20 17:09:55 +09:00
Bartłomiej Dach
b51d038088
Ignore possible path-related nulls
...
They're all in test code anyway, so any issue there will cause a test to
fail.
2021-05-15 00:09:34 +02:00
Salman Ahmed
4cdfdcaddf
Expand the combo colours used for testing
...
To avoid potential false positive.
2021-05-05 09:22:01 +03:00
Salman Ahmed
fda6d8685c
Let LegacyBeatmapSkinColourTest inherit from TestPlayer instead
2021-05-05 09:21:09 +03:00
Naxess
400f8b3938
Add GetStream to IWorkingBeatmap
...
This is necessary to obtain the filesize of the audio and background files.
2021-04-17 17:47:13 +02:00
Dean Herbert
b5954a55ad
Remove empty <returns> xmldoc
2021-04-12 17:46:14 +09:00
Bartłomiej Dach
82e5a5bf6f
Mark legacy beatmap skin colour test as abstract
2021-01-19 23:10:15 +01:00
Dean Herbert
1364de1166
Merge branch 'master' into beatmap-colour-setting
2021-01-18 16:07:46 +09:00
Mysfit
a3535f4b79
Further simplified beatmap colouring tests.
2021-01-16 02:09:35 -05:00
Mysfit
112967c1e8
Created base class for testing beatmap colours.
2021-01-15 23:46:46 -05:00
Salman Ahmed
f827c62081
Add empty online info to test beatmap
...
This is for `BeatmapSetOverlay` to not eat a null reference trying to access `Beatmap.OnlineInfo`.
2021-01-13 12:27:15 +03:00
Dean Herbert
10c2745682
Add region specifications around implicit interface implementations
2020-12-22 12:01:09 +09:00
Dean Herbert
a5bcf1dc20
Expose resources to skin via interface (and share common pieces with beatmap)
2020-12-21 15:18:52 +09:00
smoogipoo
598572195c
Add playlist length to match settings overlay
2020-12-01 19:57:25 +09:00
Bartłomiej Dach
8b74298567
Add base method for testing conversion in other direction
2020-11-15 14:48:23 +01:00
Bartłomiej Dach
9899687bfe
Rename existing method to allow for new one
2020-11-15 14:17:41 +01:00
smoogipoo
832d52a056
Fix hitobject sample tests
2020-11-13 18:19:07 +09:00
Dean Herbert
7bef695072
Merge branch 'master' into fix-test-beatmap-virtual-clock
2020-10-29 17:51:15 +09:00
smoogipoo
573336cb47
Ensure stable sorting order in beatmap conversion tests
2020-10-09 20:12:17 +09:00
Dean Herbert
a8cbd400d3
Ensure virtual track time is long enough for test beatmaps
2020-10-05 13:23:37 +09:00
Dean Herbert
da02ee8828
Add ability to create a TestBeatmap with no HitObjects
2020-09-14 15:26:57 +09:00
Dean Herbert
c6e72dabd3
Add test coverage
2020-09-09 20:04:25 +09:00
Dean Herbert
d2c2e8bbe8
Revert some more usage of MusicController back to WorkingBeatmap
2020-08-21 15:17:21 +09:00
smoogipoo
e87f50f74f
Rename method
2020-08-07 22:31:41 +09:00
smoogipoo
6e42b8219c
Move track to MusicController, compiles
2020-08-06 16:24:14 +09:00
Bartłomiej Dach
c7d2ce12eb
Add failing test cases
2020-06-22 20:08:32 +02:00
Bartłomiej Dach
07cbc3e683
Privatise and seal whatever possible
2020-06-21 23:05:10 +02:00
Bartłomiej Dach
4bba0c7359
Move abstract sample test to main game project
2020-06-21 22:28:19 +02:00
smoogipoo
3c85561cdc
Add tests
2020-06-02 14:31:43 +09:00
Dean Herbert
9638064741
Tidy up ruleset assignment code
2020-05-20 10:06:23 +09:00
Dean Herbert
db4e3047dd
Add test for final sample output
2020-05-19 23:28:13 +09:00
Dean Herbert
d0a8c0fa71
Add kiai support to osu!taiko skinned playfields
2020-04-30 16:43:00 +09:00
smoogipoo
0a34fddcc3
Fix TestBeatmap not setting appropriate ruleset ID
2020-04-22 19:38:27 +09:00
smoogipoo
b29957798f
Fix no audiomanager in test scene working beatmap
2020-04-14 21:05:42 +09:00
Dean Herbert
800e395bc8
Merge branch 'master' into replay-recording
2020-03-25 20:20:59 +09:00
Dean Herbert
546772192c
Add helper method to convert to legacy mods enums
2020-03-24 13:07:51 +09:00
voidedWarranties
76c832518f
Render video as a part of the storyboard
2020-03-07 21:32:03 -08:00
Dean Herbert
09273d1da9
Fix test scene not correctly building a playable beatmap
2020-02-05 18:35:31 +09:00
Huo Yaoyuan
5375af7820
Remove other Equals(object) calls.
2019-12-03 20:23:27 +08:00
Dean Herbert
8d1b11d4bd
Add storyboard lead-in tests
2019-11-21 18:50:54 +09:00
Huo Yaoyuan
ccc8aa6fa4
Apply brace style.
2019-11-11 20:13:13 +08:00
Dean Herbert
a06cb54732
Merge branch 'master' into beatmap-parsing-fallback-v2
2019-09-20 15:28:08 +09:00
Bartłomiej Dach
a407e267a2
Fix PF/SD legacy mod conversion
...
Upon investigating an user report in #6091 that indicated that viewing
replays using the Perfect mod would also display the Sudden Death mod
icon despite Perfect being the more restrictive of the two, it turned
out that the logic of importing legacy scores was missing that corner
case. A similar case of Double Time/Nightcore mutual exclusion was
handled, but PF/SD was missed.
Add analogous handling of PF/SD legacy mods for all four rulesets,
and additionally cover a tiny fraction of all cases with unit tests.
The most problematic cases (NC+HD and PF+SD) are covered in all four
basic rulesets.
2019-09-15 22:55:25 +02:00
Bartłomiej Dach
11eda44d34
Migrate decoding to line-buffered reader
...
Migrate all usages of StreamReader in the context of decoding beatmaps,
storyboards or skins to the new LineBufferedReader.
2019-09-15 01:28:07 +02:00
Andrei Zavatski
6e5cb8a318
implement video parsing
2019-08-30 23:19:34 +03:00
smoogipoo
ed4dda1936
Support beatmap conversion tests with mods
2019-08-01 12:49:01 +09:00
smoogipoo
0108700793
Make beatmap conversion test use WorkingBeatmap
2019-08-01 12:44:10 +09:00
Dean Herbert
f33a5bc54c
Centralise and update WorkingBeatmap creation in test cases
2019-05-31 14:40:53 +09:00
smoogipoo
d7c09e7dbd
Merge remote-tracking branch 'origin/master' into fix-new-inspections
...
# Conflicts:
# osu.Game.Rulesets.Catch/Judgements/CatchDropletJudgement.cs
# osu.Game.Rulesets.Catch/Judgements/CatchJudgement.cs
# osu.Game.Rulesets.Mania/Scoring/ManiaScoreProcessor.cs
# osu.Game.Rulesets.Osu/Replays/OsuAutoGenerator.cs
# osu.Game.Rulesets.Osu/UI/Cursor/CursorTrail.cs
# osu.Game.Tests/Visual/SongSelect/TestCaseBeatmapScoresContainer.cs
# osu.Game/Graphics/OsuFont.cs
# osu.Game/Online/API/Requests/Responses/APILegacyScoreInfo.cs
# osu.Game/Overlays/Profile/Header/BadgeContainer.cs
# osu.Game/Overlays/Profile/ProfileHeader.cs
# osu.Game/Screens/Select/PlaySongSelect.cs
# osu.Game/Skinning/LegacySkinDecoder.cs
2019-05-07 13:20:17 +09:00
smoogipoo
32e71a6314
Fix incorrect seeking behaviour of TrackVirtualManual
2019-04-26 16:15:42 +09:00
Dean Herbert
612db31c38
Apply newline additions
2019-04-01 12:16:32 +09:00
Dean Herbert
83076e32c7
Fix TestWorkingBeatmap not running for times below zero
2019-03-26 16:35:34 +09:00
smoogipoo
e73cef5f94
Prefill some more properties of TestWorkingBeatmap
2019-03-05 17:14:24 +09:00
Dean Herbert
26d53d06a9
Fix remaining issues
2019-02-28 13:31:40 +09:00
smoogipoo
7e41fbc29b
Remove LegacyDifficultyCalculator
2019-02-21 13:12:37 +09:00
Dan Balasescu
f6d70e687b
Use correct local variable
...
Co-Authored-By: peppy <pe@ppy.sh>
2019-02-20 12:27:25 +09:00
Dean Herbert
b4bb87fee3
Make TrackVirtualTracking more accurate on seeks/stops
2019-02-20 12:08:30 +09:00
Dean Herbert
f2ad2931c7
Merge remote-tracking branch 'upstream/master' into test-working-beatmap-clock
2019-02-20 11:37:33 +09:00
Dean Herbert
0fce23a36b
Fix test regression
2019-02-19 12:38:45 +09:00
Dean Herbert
62fe5ad481
Nest class
2019-02-19 12:35:52 +09:00
Dean Herbert
f8033a3b35
Give TestWorkingBeatmap a reference clock
2019-02-19 12:27:30 +09:00
smoogipoo
a8faa942a6
Implement new difficulty calculator structure
2019-02-18 14:49:43 +09:00
smoogipoo
280081d589
Fix beatmap ruleset not being set
2019-02-15 14:42:42 +09:00
smoogipoo
f50a0be29d
Add osu! difficulty calculator test
2019-02-14 16:22:14 +09:00
Dean Herbert
8617aaa2a7
Update licence header (and remove year)
2019-01-24 17:43:03 +09:00
Dan Balasescu
290812cf65
Merge branch 'master' into more-mania-conversion-fixes
2018-07-06 13:29:16 +09:00
smoogipoo
c0c94e24b9
Use VirtualBeatmapTrack in testcases
2018-06-28 11:45:48 +09:00
smoogipoo
47ae962099
Output only one mapping failure per mapping
2018-06-15 18:36:22 +09:00
smoogipoo
e945186978
Expose the beatmap converter
2018-06-15 17:59:52 +09:00
smoogipoo
a4d2364083
Add one more newline
2018-06-14 21:29:08 +09:00
smoogipoo
b99b520656
Allow convertmapping to be extended
2018-06-14 21:25:33 +09:00
smoogipoo
024d2abfe0
Always generate mappings/convert values as soon as objects are converted
...
# Conflicts:
# osu.Game.Rulesets.Catch.Tests/CatchBeatmapConversionTest.cs
2018-06-14 21:25:23 +09:00
smoogipoo
8d0e7abdd6
Some rulesets don't have a beatmap processor
2018-06-14 21:23:11 +09:00
smoogipoo
5e66b02108
Process beatmap before generating mappings
2018-06-14 21:22:56 +09:00
smoogipoo
8d8b7e6fa2
Fix conversion tests for ruleset-specific beatmaps not working
...
TRuleset was a mistake. This resulted in cases that checked whether the beatmap was for the current ruleset (TaikoBeatmapConverter and ManiaBeatmapConverter) failing due to TestXRuleset != XRuleset...
2018-05-16 13:09:48 +09:00
smoogipoo
6867886f4c
Give conversion-tested beatmaps a ruleset
2018-05-07 14:04:37 +09:00
smoogipoo
794418432f
Fix incorrect method name
2018-05-07 11:22:25 +09:00
smoogipoo
db3e48c194
Rename GetBeatmap() to GetPlayableBeatmap()
2018-05-07 10:40:30 +09:00
smoogipoo
9128e64c9a
Rename OriginalBeatmap back to Beatmap
2018-05-07 10:29:38 +09:00
smoogipoo
03a5df84c6
Initial rework of beatmap conversion process
2018-04-19 22:04:12 +09:00
smoogipoo
66b3b295e7
Use IBeatmap wherever possible
2018-04-19 20:44:38 +09:00
smoogipoo
b5a55a0dce
Make an interface for beatmaps
2018-04-19 18:58:40 +09:00
Dean Herbert
32a74f95a5
Normalize all the line endings
2018-04-13 18:26:38 +09:00
smoogipoo
e32eec9259
No more caching
2018-03-13 15:22:46 +09:00
smoogipoo
706c26c32b
Remove extra whitespace
2018-03-13 09:27:33 +09:00
smoogipoo
13c20438ef
Fix build issues
2018-03-12 19:41:51 +09:00
smoogipoo
b91524dbba
Give TestWorkingBeatmap's track a valid length
2018-03-12 19:41:15 +09:00
smoogipoo
7406cb290f
Split out test beatmap from TestCasePlayer into instantiable class
2018-03-12 19:41:09 +09:00
