Dean Herbert
|
d6e78e7d95
|
Merge pull request #17068 from peppy/fix-hit-distribution-rounding
Fix hit distribution graph midpoint rounding not looking great around zero
|
2022-03-04 22:16:30 +09:00 |
|
Jamie Taylor
|
1e246bf560
|
Reduce 'cursor-tap' sample playback volume on MouseUp
|
2022-03-04 20:14:14 +09:00 |
|
Dean Herbert
|
6673e456c5
|
Merge pull request #17090 from miniriley2012/wiki-locale-fix
Fix wiki links containing locale not loading when opened from chat.
|
2022-03-04 19:36:14 +09:00 |
|
Salman Ahmed
|
70219f511c
|
Merge branch 'master' into fix-apply-offset-from-non-zero
|
2022-03-04 12:14:01 +03:00 |
|
Dean Herbert
|
1c40fcb79e
|
Reorder math to be easier to pass
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
|
2022-03-04 17:54:04 +09:00 |
|
Salman Ahmed
|
3fdc7ed9d2
|
Remove brackets surrounding one-line statements
|
2022-03-04 10:14:19 +03:00 |
|
Salman Ahmed
|
5d337e41cf
|
Merge branch 'master' into fix-profile-badge-cancellation
|
2022-03-04 10:07:09 +03:00 |
|
Salman Ahmed
|
129c290ca0
|
Dispose cancellation token source on disposal
|
2022-03-04 10:01:07 +03:00 |
|
Salman Ahmed
|
76c293b9e9
|
Fix cancellation token source recreated on every medal
|
2022-03-04 10:00:56 +03:00 |
|
Riley Quinn
|
8491bab77c
|
Replace string locale with Language
|
2022-03-04 00:57:13 -06:00 |
|
Dean Herbert
|
5a164e4520
|
Hide adjustment when no adjustment is applied
|
2022-03-04 15:19:55 +09:00 |
|
Dean Herbert
|
e9e92b991e
|
Fix calibrating offset from previous non-zero offset not applying adjustment correctly
|
2022-03-04 15:09:44 +09:00 |
|
Dean Herbert
|
8c7b1e0aa8
|
Only construct the adjustment portion of bars when required
|
2022-03-04 15:01:54 +09:00 |
|
Dean Herbert
|
2785218b79
|
Only apply animation if the bar is going to be larger than the minimum height
|
2022-03-04 14:59:53 +09:00 |
|
Riley Quinn
|
81a49057ec
|
Fix wiki links containing locale not loading when opened from chat.
|
2022-03-03 23:38:51 -06:00 |
|
Dean Herbert
|
540d7d0e2c
|
Add the ability to set and show an offset value on timing distribution graph
|
2022-03-04 14:36:15 +09:00 |
|
Salman Ahmed
|
95044bbbac
|
Merge branch 'master' into fix-storyboard-sample-rate
|
2022-03-04 08:17:40 +03:00 |
|
Dean Herbert
|
d3e04fe594
|
Colour centre bin in distribution graph differently
|
2022-03-04 14:09:27 +09:00 |
|
Dean Herbert
|
c063a73742
|
Fix autosize weirdness by specifying a constant size for the x axis
|
2022-03-04 14:05:42 +09:00 |
|
Dean Herbert
|
010fa7ed01
|
Allow an offset to be shown on the timing distribution graph
|
2022-03-04 14:05:42 +09:00 |
|
Dean Herbert
|
e09dd7d8fe
|
Fix calibrating offset from previous non-zero offset not applying adjustment correctly
|
2022-03-04 13:25:14 +09:00 |
|
Salman Ahmed
|
06b46d2b5e
|
Merge branch 'master' into fix-test-null-ref-key-bind-lookup
|
2022-03-04 07:12:49 +03:00 |
|
Dean Herbert
|
c1c9482077
|
Add note about how global audio offset is currently applied
|
2022-03-04 12:44:02 +09:00 |
|
Dean Herbert
|
5dca0e3377
|
Revert back to private set
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
|
2022-03-04 12:44:02 +09:00 |
|
Dean Herbert
|
cc4f89eef4
|
Add tooltip text for offset adjustment slider
|
2022-03-04 12:44:02 +09:00 |
|
Dean Herbert
|
657f2ebb9d
|
Restructure OsuSliderBar to allow for custom tooltips
|
2022-03-04 12:44:02 +09:00 |
|
Dean Herbert
|
8115a4bb8f
|
Fix potential crash in tests when attempting to lookup key bindings in cases the lookup is not available
|
2022-03-04 12:44:02 +09:00 |
|
Dean Herbert
|
835cb09537
|
Merge branch 'master' into fix-hit-distribution-rounding
|
2022-03-04 12:43:57 +09:00 |
|
Dean Herbert
|
8b504bb5ac
|
Ensure rounding is still applied in non-midpoint cases
|
2022-03-04 12:42:07 +09:00 |
|
Dean Herbert
|
ac914878b8
|
Move default function specifications to OsuConfigManager
This ensures that running tests in release configuration will not fail
due to the same issue being fixed in this PR.
|
2022-03-04 12:31:58 +09:00 |
|
Dean Herbert
|
33862fc0db
|
Centralise implementation of slider bars which display millisecond time values
|
2022-03-04 12:25:19 +09:00 |
|
Dean Herbert
|
7854a0a913
|
Use double instead of float for UIHoldActivationDelay configuration value
All times use double, so let's also use double here.
|
2022-03-04 12:22:56 +09:00 |
|
Dean Herbert
|
abba49fd8f
|
Update all usages of OsuSlider.TooltipText overrides to instead implement GetTooltipText
|
2022-03-04 12:16:05 +09:00 |
|
Dean Herbert
|
c38126ba9d
|
Make mods argument optional for storyboard construction
|
2022-03-04 12:05:02 +09:00 |
|
Dean Herbert
|
b0688cc6dd
|
Merge branch 'master' into fix-storyboard-sample-rate
|
2022-03-04 12:04:49 +09:00 |
|
Dean Herbert
|
3a37e6e8b1
|
Fix profile badges potentially showing on incorrect profile when switching users
Closes https://github.com/ppy/osu/issues/17081.
|
2022-03-04 12:01:00 +09:00 |
|
Dean Herbert
|
eeb7d359ec
|
Merge pull request #17069 from hlysine/fix-IUpdatableByPlayfield
Change `IUpdatableByPlayfield.Update` to be called by the main playfield only
|
2022-03-04 11:58:00 +09:00 |
|
Dean Herbert
|
1d7d6a1b65
|
Merge pull request #17042 from peppy/ruleset-leaderboard-unavailable
Improve leaderboard messaging when using a custom ruleset (and add localisation support)
|
2022-03-04 11:56:04 +09:00 |
|
Dean Herbert
|
18b207400d
|
Update framework
|
2022-03-04 11:34:25 +09:00 |
|
Bartłomiej Dach
|
36263b4dbf
|
Replace remaining manual online ID check with extension method
|
2022-03-03 23:09:56 +01:00 |
|
Bartłomiej Dach
|
e1610b5d32
|
Merge branch 'master' into ruleset-leaderboard-unavailable
|
2022-03-03 22:52:20 +01:00 |
|
Bartłomiej Dach
|
2354737abe
|
Merge branch 'master' into scaling-container-better-custom-override
|
2022-03-03 22:32:23 +01:00 |
|
Bartłomiej Dach
|
9dbb0bd85c
|
Merge branch 'master' into player-loader-settings-scroll
|
2022-03-03 21:17:53 +01:00 |
|
Bartłomiej Dach
|
15f65c7897
|
Rename lambda param to avoid name shadowing
|
2022-03-03 20:28:19 +01:00 |
|
Bartłomiej Dach
|
2e24e7ef56
|
Use property expression rather than block
|
2022-03-03 20:28:00 +01:00 |
|
Bartłomiej Dach
|
edd361d256
|
Trim unused using directives
|
2022-03-03 20:21:48 +01:00 |
|
Bartłomiej Dach
|
0fbc018a42
|
Remove redundant string interpolation prefixes
|
2022-03-03 20:21:09 +01:00 |
|
Dean Herbert
|
5cfa8b8821
|
Revert back to private set
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
|
2022-03-03 21:31:56 +09:00 |
|
Dean Herbert
|
cecc746f9e
|
Update existing usages to use SubscribeToPropertyChanged
|
2022-03-03 17:42:50 +09:00 |
|
Dean Herbert
|
35f532fefa
|
Add ability to watch properties via a RealmAccess helper method
|
2022-03-03 17:42:40 +09:00 |
|
Dean Herbert
|
3848964faa
|
Add tooltip text for offset adjustment slider
|
2022-03-03 17:07:46 +09:00 |
|
Dean Herbert
|
7ee30024e8
|
Restructure OsuSliderBar to allow for custom tooltips
|
2022-03-03 17:07:26 +09:00 |
|
Dean Herbert
|
f09a4e9c5b
|
Fix potential crash in tests when attempting to lookup key bindings in cases the lookup is not available
|
2022-03-03 16:29:37 +09:00 |
|
Dean Herbert
|
9c43500ad3
|
Add ability for player loading screen settings to scroll
As we add more items here this is going to become necessary. Until the design no doubt gets changed.
|
2022-03-03 16:23:31 +09:00 |
|
Dean Herbert
|
a06d806fb9
|
Fix hit distribution graph midpoint rounding not looking great around zero
Not sure this will be accepted and it's likely only ever going to show
in tests, but seems to be a better approach to midpoint rounding for
this case?
|
2022-03-03 15:43:02 +09:00 |
|
Henry Lin
|
464be6e64c
|
Only call IUpdatableByPlayfield.Update if the playfield isn't nested
|
2022-03-03 14:37:39 +08:00 |
|
Dean Herbert
|
ab0ee26540
|
Remove padding from distribution graph bars to fix some bars becoming invisible at low sizes
|
2022-03-03 15:13:42 +09:00 |
|
Dean Herbert
|
cb0d643f70
|
Add parameter xmldoc to explain what a null rect does
|
2022-03-03 14:38:20 +09:00 |
|
Dean Herbert
|
29bf7d0bde
|
Fix shocking grammar and typos in block comment
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
2022-03-03 14:35:52 +09:00 |
|
Dean Herbert
|
a38eb426ef
|
Merge pull request #17026 from peppy/beatmap-offset-control
Add basic beatmap offset adjustment
|
2022-03-03 14:23:19 +09:00 |
|
Dean Herbert
|
42e07b7308
|
Convert to extension method to avoid recursive calls
|
2022-03-03 14:15:37 +09:00 |
|
Dean Herbert
|
fab9323707
|
Replace all legacy ruleset checks with a helper property call
|
2022-03-03 14:08:48 +09:00 |
|
Salman Ahmed
|
2f485a29d5
|
Merge branch 'master' into mod-overlay/columns
|
2022-03-03 00:11:33 +03:00 |
|
Salman Ahmed
|
3630ab2db2
|
Remove unnecessary nullability of storyboard mods list
|
2022-03-03 00:09:12 +03:00 |
|
Bartłomiej Dach
|
7e90b4456d
|
Merge branch 'master' into skin-editor-ui
|
2022-03-02 21:01:03 +01:00 |
|
Bartłomiej Dach
|
f627a8af30
|
Merge branch 'master' into legacy-score-encoder-no-beatmap-required
|
2022-03-02 20:27:38 +01:00 |
|
Salman Ahmed
|
cbb8dc2891
|
Fix storyboard samples rate not adjusted from actual gameplay mods
|
2022-03-02 20:56:18 +03:00 |
|
Salman Ahmed
|
e14a35b469
|
Add failing test case
|
2022-03-02 20:32:41 +03:00 |
|
Dean Herbert
|
b5684aaa76
|
Scale -> Rect to read better
|
2022-03-02 20:33:28 +09:00 |
|
Dean Herbert
|
8d7cdbd883
|
Add note about nested masking case
|
2022-03-02 20:25:34 +09:00 |
|
Dean Herbert
|
29ed419d53
|
Change how custom scales are applied to ScalingContainer to allow for better transitions
|
2022-03-02 20:13:01 +09:00 |
|
Dean Herbert
|
ff7db4f405
|
Replace jank buttons with menu in skin editor
|
2022-03-02 20:08:17 +09:00 |
|
Dean Herbert
|
1916011ebf
|
Tween corner radius when scaling container becomes non-fullscreen
|
2022-03-02 20:08:12 +09:00 |
|
Dean Herbert
|
f15b8781bb
|
Move editor mode selector out of EditorMenuBar to allow for better reuse
|
2022-03-02 20:05:01 +09:00 |
|
Dean Herbert
|
c06703d662
|
Add ability to select which display the game runs on
|
2022-03-02 18:29:07 +09:00 |
|
Dean Herbert
|
dc6fa13337
|
Merge branch 'master' into mod-overlay/columns
|
2022-03-02 15:04:37 +09:00 |
|
Dean Herbert
|
763f881d4a
|
Use more correct mod check to encompass more than just autoplay
|
2022-03-02 14:42:10 +09:00 |
|
Dean Herbert
|
e184b26cdd
|
Remove Precision call for database write shortcutting
Shouldn't be required.
|
2022-03-02 14:39:29 +09:00 |
|
Dean Herbert
|
8bd66f1ed7
|
Fix incorrect precision specification for button disable check
|
2022-03-02 14:36:49 +09:00 |
|
Dean Herbert
|
3cbcb702f6
|
Fix calibration button disabled state not checking in corrrect direction
|
2022-03-02 14:36:15 +09:00 |
|
Dean Herbert
|
c07f754565
|
Enable nullable on BeatmapOffsetControl
|
2022-03-02 14:34:24 +09:00 |
|
Dean Herbert
|
d4a2645510
|
Add localisation support for leaderboard error text
|
2022-03-02 14:14:44 +09:00 |
|
Dean Herbert
|
c342030b2c
|
Add specific placeholder message for custom rulesets rather than showing network error
|
2022-03-02 14:10:59 +09:00 |
|
Dean Herbert
|
09a74cdfc6
|
Merge pull request #17023 from peppy/realm-async-write
Add `RealmAccess.WriteAsync` method and more statistics of realm reads/writes
|
2022-03-02 12:31:16 +09:00 |
|
Salman Ahmed
|
97c54de3bf
|
Fix performance statistic not handling rulesets with unimplemented calculator
|
2022-03-01 20:43:20 +03:00 |
|
Dean Herbert
|
222f50d211
|
Fix calibration being back-to-front
|
2022-03-01 20:41:54 +09:00 |
|
Dean Herbert
|
6c09237956
|
Reorder fields in BeatmapOffsetControl and MasterGameplayClockContainer
|
2022-03-01 20:16:55 +09:00 |
|
Dean Herbert
|
7d11cfb301
|
Add detach mapping for BeatmapUserSettings
|
2022-03-01 20:12:59 +09:00 |
|
Dean Herbert
|
9792f0653a
|
Don't show calibration controls for autoplay
|
2022-03-01 20:12:59 +09:00 |
|
Dean Herbert
|
4aee57c9c1
|
Add localisation of all beatmap offset strings
|
2022-03-01 20:12:59 +09:00 |
|
Dean Herbert
|
4d9efe771b
|
Don't display calibration options when the previous play was too short to be useful
|
2022-03-01 20:12:59 +09:00 |
|
Dean Herbert
|
bc2a15db96
|
Handle cases of beatmaps not existing in realm for tests
|
2022-03-01 20:12:59 +09:00 |
|
Dean Herbert
|
99c1ba19aa
|
Allow BeatmapOffsetControl to react to external changes to offset
|
2022-03-01 20:12:59 +09:00 |
|
Dean Herbert
|
bb8caabb8b
|
Subscribe to changes in offset
|
2022-03-01 20:12:59 +09:00 |
|
Dean Herbert
|
071ba5c1df
|
Make writes asynchronously to avoid synchronous overhead
|
2022-03-01 20:12:59 +09:00 |
|
Dean Herbert
|
047e801da9
|
Store and retrieve offset from realm
|
2022-03-01 20:12:59 +09:00 |
|
Dean Herbert
|
acf8db13ac
|
Store user settings to realm
|
2022-03-01 18:44:15 +09:00 |
|
Dean Herbert
|
2901d2a650
|
Hook offset adjustment control up to last play via PlayerLoader
|
2022-03-01 18:44:15 +09:00 |
|
Dean Herbert
|
7215f3f66b
|
Fix CalculateAverageHitError throwing if there are zero HitEvents
|
2022-03-01 18:44:15 +09:00 |
|
Dean Herbert
|
350b0b488c
|
TODO: Get score from previous play session for further analysis
|
2022-03-01 18:44:15 +09:00 |
|