h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-21 18:47:20 +08:00
Code Issues Releases Wiki Activity

Make writes asynchronously to avoid synchronous overhead

Browse Source
This commit is contained in:
Dean Herbert 2022-03-01 18:28:53 +09:00
parent 047e801da9
commit 071ba5c1df
1 changed files with 23 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
osu.Game/Screens/Play/PlayerSettings/BeatmapOffsetControl.cs
View File

@ -1,8 +1,10 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System.Threading.Tasks;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Extensions;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
using osu.Game.Beatmaps;
@ -78,9 +80,11 @@ namespace osu.Game.Screens.Play.PlayerSettings
ReferenceScore.BindValueChanged(scoreChanged, true);
Current.BindValueChanged(currentChanged);
Current.Value = realm.Run(r => r.Find<BeatmapInfo>(beatmap.Value.BeatmapInfo.ID).UserSettings?.Offset) ?? 0;
Current.Value = realm.Run(r => r.Find<BeatmapInfo>(beatmap.Value.BeatmapInfo.ID).UserSettings.Offset);
}
private Task realmWrite;
private void currentChanged(ValueChangedEvent<double> offset)
{
if (useAverageButton != null)
@ -88,12 +92,25 @@ namespace osu.Game.Screens.Play.PlayerSettings
useAverageButton.Enabled.Value = offset.NewValue != lastPlayAverage;
}
realm.Write(r =>
{
var settings = r.Find<BeatmapInfo>(beatmap.Value.BeatmapInfo.ID).UserSettings;
Scheduler.AddOnce(updateOffset);
settings.Offset = offset.NewValue;
});
void updateOffset()
{
// ensure the previous write has completed.
if (realmWrite?.IsCompleted == false)
{
Scheduler.AddOnce(updateOffset);
return;
}
realmWrite?.WaitSafely();
realmWrite = realm.WriteAsync(r =>
{
var settings = r.Find<BeatmapInfo>(beatmap.Value.BeatmapInfo.ID).UserSettings;
settings.Offset = offset.NewValue;
});
}
}
private void scoreChanged(ValueChangedEvent<ScoreInfo> score)