1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 13:47:38 +08:00
Commit Graph

564 Commits

Author SHA1 Message Date
Tree
b694b0c90c
Merge branch 'master' into adjust-beatmap-overlay 2020-02-11 21:07:26 +01:00
recapitalverb
2be7d1a873 Remove redundant type specification 2020-02-11 18:19:08 +07:00
recapitalverb
44568ac9e6 Avoid covariant array conversion 2020-02-11 17:36:10 +07:00
recapitalverb
28a39fd8fa Use explicit typing 2020-02-11 17:12:32 +07:00
recapitalverb
17791259ed Fix InfoColumn minWidth implementation 2020-02-11 16:21:31 +07:00
TheWildTree
e072042d4e Match osu-web font size 2020-02-10 21:11:49 +01:00
Bartłomiej Dach
35d5237ddd Adjust font sizes 2020-02-10 20:40:39 +01:00
Bartłomiej Dach
811553cd60 Remove unnecessary coercions
Comparisons to null of nullable numbers are always false.
2020-02-10 20:37:34 +01:00
Bartłomiej Dach
e2950d7027 Extract method to avoid nested ternaries 2020-02-10 20:27:46 +01:00
Maximilian Junges
ed8cb1d6bf add missing eof newline 2020-02-09 23:46:06 +01:00
Maximilian Junges
3e06324f61 fix formatting issue 2020-02-09 23:39:34 +01:00
Maximilian Junges
867c733809 make score date hoverable 2020-02-09 23:19:32 +01:00
Maximilian Junges
b45f1ef99a make timestamps hoverable 2020-02-09 22:27:37 +01:00
TheWildTree
2770fb71b2 Use SortedStatistics where needed 2020-02-07 21:12:21 +01:00
TheWildTree
7395f01919 Use osu-web font sizes 2020-02-07 20:28:02 +01:00
TheWildTree
c09af0052b Revert accuracy display and column sorting changes 2020-02-06 20:21:47 +01:00
TheWildTree
c93d2c7f00 Adjust loading container corner radius 2020-02-05 18:26:01 +01:00
TheWildTree
63df6b8da6 Change accuracy formatting method 2020-02-05 17:42:14 +01:00
TheWildTree
fa3934ddb4 Match osu-web button description 2020-02-05 17:16:20 +01:00
TheWildTree
e1e1c1a11a Match osu-web display accuracy
Decided to change this only locally instead of modifying FormatAccuracy which would affect everywhere else in the game as well.
2020-02-05 16:34:39 +01:00
TheWildTree
76037e4ffd Recolour ranked status pill 2020-02-05 16:31:14 +01:00
TheWildTree
f4ee281dd6 Add optional decimal place 2020-02-05 16:15:55 +01:00
Tree
447f31ccfc
Remove using directive 2020-02-04 23:25:21 +01:00
Tree
c2a80119ca
Remove using directives 2020-02-04 23:23:57 +01:00
Tree
23d1d3fdf1
Convert field to local variable 2020-02-04 23:09:10 +01:00
Tree
b606408667
Remove space 2020-02-04 23:02:28 +01:00
TheWildTree
c1b8445b00 Add spacing to match osu-web
Note: due to osu-web using flex to even out the spacing and me not being able to implement the same behaviour here, I added a static margin to separate the title from the diffname above. This looks better than the previous state in most cases, the only scenario where this differs somehow visibly from web is on mapsets with large numbers of difficulties.
2020-02-04 21:53:23 +01:00
TheWildTree
86c0b50983 Adjust font once again for readibility 2020-02-04 21:45:45 +01:00
TheWildTree
d7af96a2e5 Adjust corner radius 2020-02-04 21:42:01 +01:00
TheWildTree
82914b5d6e Adjust ScoreTable spacing 2020-02-04 21:41:33 +01:00
TheWildTree
9795897045 Enforce correct column order in ScoreTable 2020-02-04 21:28:31 +01:00
TheWildTree
d23e4a1fa1 Change scoreboard text size 2020-02-04 21:27:51 +01:00
TheWildTree
5458085849 Adjust TopScoreUserSection font and spacing 2020-02-04 21:11:35 +01:00
TheWildTree
3ef6027d57 Show placeholder instead of success rate when beatmap unranked 2020-02-04 21:02:02 +01:00
TheWildTree
48beb9fd6d Recolour PreviewButton 2020-02-04 21:01:02 +01:00
TheWildTree
88e79dfa78 Hide ratings if beatmap has no leaderboard 2020-02-04 21:00:27 +01:00
TheWildTree
85fb4b4a18 Recolour DetailBox 2020-02-04 21:00:00 +01:00
TheWildTree
268bb73ac6 Adjust header padding 2020-02-04 20:14:50 +01:00
TheWildTree
2cc1255035 Adjust online status pill font and padding 2020-02-04 20:09:52 +01:00
TheWildTree
d0eb4e4471 Add necessary variable 2020-02-04 20:08:54 +01:00
TheWildTree
86283cc422 Recolour SuccessRate background 2020-02-04 19:55:19 +01:00
TheWildTree
a366a92d4c Use alpha instead of colour opacity 2020-02-04 19:54:51 +01:00
TheWildTree
b6301f6537 Adjust PreviewButton alpha and animation 2020-02-04 19:52:32 +01:00
TheWildTree
5b881568db Adjust header gradient colours 2020-02-04 19:15:02 +01:00
TheWildTree
5eb1619e24 Adjust title / artist font weight 2020-02-04 18:02:49 +01:00
Bartłomiej Dach
4ea9efd92e Enforce column ordering 2020-02-04 17:59:32 +01:00
TheWildTree
9bc45d21f1 Recolour LeaderboardScopeSelector 2020-02-04 17:11:28 +01:00
recapitalverb
833bb28dcf Adjust separator position between top and bottom content 2020-02-04 22:38:25 +07:00
recapitalverb
0cba1a357f Adjust padding on DrawableTopScore 2020-02-04 21:56:22 +07:00
recapitalverb
bd815cd81b Use minWidth on more columns to further match web 2020-02-04 21:55:48 +07:00
recapitalverb
1c16ab1813 Use better colours 2020-02-04 21:55:20 +07:00
recapitalverb
f112760b00 Revert column separator height to 2 2020-02-04 21:55:04 +07:00
recapitalverb
5030b66092 Adjust width of statistics columns 2020-02-04 19:59:11 +07:00
recapitalverb
a8faee91d8 Use minWidth on pp column 2020-02-04 19:54:57 +07:00
recapitalverb
556a4e64cb Use minimum width on statistics columns 2020-02-04 19:46:14 +07:00
recapitalverb
8f9917238e Add optional minimum width to InfoColumn 2020-02-04 19:45:08 +07:00
recapitalverb
4f312ae6bc Adjust InfoColumn spacing 2020-02-04 19:43:14 +07:00
recapitalverb
c12fc67887 Change InfoColumn title font weight 2020-02-04 19:42:37 +07:00
recapitalverb
3571c2b617 Rearrange children in TopScoreStatisticsSection 2020-02-04 19:41:44 +07:00
Andrei Zavatski
f30cdab025 Update Scores section 2020-02-04 14:35:04 +03:00
Andrei Zavatski
0e54e0e092 Recolour DrawableTopScore 2020-02-04 14:17:22 +03:00
Andrei Zavatski
873eda3bb5 Recolour info section 2020-02-04 14:00:18 +03:00
recapitalverb
79bb476f4c
Merge branch 'master' into display-accuracy 2020-02-04 11:39:47 +07:00
smoogipoo
bc9b499de0 Make selector only privately-settable 2020-02-04 12:55:09 +09:00
Andrei Zavatski
4abd9cb89a Move Enabled/Disabled state logic to the OverlayRulesetTabItem 2020-02-03 21:45:10 +03:00
recapitalverb
9898a926b2 Use ScoreInfo.DisplayAccuracy everywhere 2020-02-03 22:11:36 +07:00
Andrei Zavatski
2abcc6ad69 Simplify counter addition in BeatmapRulesetTabItem 2020-02-03 15:25:07 +03:00
Andrei Zavatski
fa453bc3e1 Refactor beatmap header 2020-02-03 14:35:07 +03:00
Andrei Zavatski
032c2c2afe Refactor BeatmapRulesetSelector 2020-02-03 14:16:26 +03:00
unknown
b916366536 fix formatting 2020-01-31 08:17:39 +08:00
unknown
2274d70dac apply suggestions 2020-01-31 06:41:50 +08:00
unknown
c5995acfff linkify metadata 2020-01-30 12:30:25 +08:00
smoogipoo
76af8bea5d Fix percentage-formatted displays containing a space 2020-01-29 19:51:24 +09:00
Revel
a86fb2113e fix tooltip capitalization 2020-01-14 14:26:54 -05:00
Dean Herbert
c2a40c574d Split out if statement for readability 2019-12-09 02:13:47 +09:00
Andrei Zavatski
929be3e9e7 Highlight own score in BeatmapSetOverlay 2019-12-08 12:34:07 +03:00
Dean Herbert
f0d49d0cdf Decouple APILegacyScoreInfo from ScoreInfo 2019-12-03 15:31:11 +09:00
Huo Yaoyuan
c0fe91a84c Merge branch 'master' into sharpen 2019-11-26 18:21:50 +08:00
Andrei Zavatski
96533631fc Simplify if/else statement 2019-11-24 01:29:11 +03:00
Andrei Zavatski
29b05e2939 Fix getScores can be fired twice on user change 2019-11-24 00:01:49 +03:00
Andrei Zavatski
2e161f7e99 Hook up the rest of the logic 2019-11-22 22:25:58 +03:00
Andrei Zavatski
aede1b183a Make ScopeSelector always visible 2019-11-22 22:04:58 +03:00
Andrei Zavatski
d6c9387beb Implement NotSupporterPlaceholder 2019-11-22 21:55:21 +03:00
Dean Herbert
b026197859 Add spacing 2019-11-22 18:23:48 +09:00
Dean Herbert
dad2e5c678 Improve legibility of NoScroesPlaceholder 2019-11-22 18:10:44 +09:00
Dean Herbert
16bdf4e6bd Update english to be more readable 2019-11-22 18:07:56 +09:00
Dean Herbert
0cc1698b6d Rename incorrectly named container 2019-11-22 18:05:12 +09:00
Andrei Zavatski
da425c93fa Fix beatmap switch doesn't trigger scores update 2019-11-22 05:08:50 +03:00
Andrei Zavatski
dee9ffc694 Merge master with conflicts resolved 2019-11-22 04:59:46 +03:00
Dean Herbert
e170cd2892 Move private methods below 2019-11-22 10:29:16 +09:00
Andrei Zavatski
0f1a3d97c8 Naming adjustments 2019-11-21 20:34:19 +03:00
Andrei Zavatski
c7c8527f5f Remove OnHighlightedChanged function 2019-11-21 20:22:15 +03:00
Andrei Zavatski
e22a71c6b8 Add visual difference between hovered and selected states 2019-11-21 19:42:07 +03:00
Andrei Zavatski
23fc7b1987 Implement updateHighlighted method 2019-11-21 19:02:24 +03:00
Andrei Zavatski
984ec11a78 Make Ruleset a bindable 2019-11-21 18:56:48 +03:00
Andrei Zavatski
737c2bd1c8 Remove pointless const 2019-11-21 18:50:29 +03:00
Andrei Zavatski
f2862e95e0 CI fix 2019-11-15 12:15:51 +03:00
Andrei Zavatski
e51fd00d58 CI fix 2019-11-15 12:09:31 +03:00
Andrei Zavatski
18f77008db Update dependency 2019-11-15 12:04:01 +03:00
Andrei Zavatski
2592a0489b Use existing ModNoMod 2019-11-15 11:57:40 +03:00
Andrei Zavatski
1218d41b50 Make Ruleset a property 2019-11-15 11:52:49 +03:00
Andrei Zavatski
2d3fadc1a8 Don't update mod filter visibility on every beatmap change 2019-11-14 00:38:37 +03:00
Andrei Zavatski
633c497602 Hide content if beatmap has no leaderboard 2019-11-13 17:36:08 +03:00
Andrei Zavatski
d1853ea55b Fix incorrect formatting for switch/case 2019-11-13 17:29:50 +03:00
Andrei Zavatski
8005ee73af Trim whitespace 2019-11-13 17:23:46 +03:00
Andrei Zavatski
3f6140db6d Improve loading animation 2019-11-13 17:18:58 +03:00
Andrei Zavatski
4e90daf212 Implement NoScoresPlaceholder 2019-11-13 16:39:33 +03:00
Andrei Zavatski
2dbee5da79 Update dependency 2019-11-13 16:06:37 +03:00
Andrei Zavatski
6715b25ddd Apply suggestions 2019-11-13 16:04:15 +03:00
Dean Herbert
0292cea2c4
Merge branch 'master' into beatmap-mod-selector 2019-11-13 15:39:08 +09:00
Dean Herbert
367d12aef9
Merge branch 'master' into beatmap-overlay-mod-selector-new 2019-11-13 15:39:06 +09:00
Dean Herbert
ce60f8262c
Merge branch 'master' into sharpen 2019-11-13 15:38:59 +09:00
Dean Herbert
c751328665 Disable button when not logged in 2019-11-13 12:13:33 +09:00
Andrei Zavatski
5f609b48da Use local bindable for api.LocalUser 2019-11-13 00:29:28 +03:00
Andrei Zavatski
99ec84ed38 Update dependency 2019-11-13 00:26:19 +03:00
Andrei Zavatski
27f721eec2 Use = instead of += for OnSelectionChanged Action 2019-11-13 00:24:13 +03:00
Andrei Zavatski
3903e59f2f Add null check for notification overlay 2019-11-13 00:01:13 +03:00
Andrei Zavatski
dfd5c88075 Typo fix 2019-11-13 00:00:08 +03:00
Dean Herbert
da819261e0 Shrink and darken loading layer to better suit button 2019-11-12 21:38:16 +09:00
Dean Herbert
5110ae82a1 Tidy up implementation 2019-11-12 21:38:08 +09:00
Huo Yaoyuan
ca52d09e81 Enforce expression body for typical simple ones. 2019-11-12 19:56:37 +08:00
Huo Yaoyuan
bbeab6fa76 Use auto property. 2019-11-12 19:53:25 +08:00
Dean Herbert
58df6930b2 Get error message from server 2019-11-12 19:34:20 +09:00
Dean Herbert
f04d7f733f Merge remote-tracking branch 'upstream/master' into favourite-beatmap 2019-11-12 19:19:29 +09:00
Andrei Zavatski
a69a4643c9 Simplify LINQ expressions 2019-11-12 08:45:21 +03:00
Andrei Zavatski
0578f91a76 Small logic adjustments 2019-11-11 19:06:46 +03:00
Andrei Zavatski
c5b64e26a3 Layout adjustment 2019-11-11 18:51:29 +03:00
Andrei Zavatski
5f5d130d1a Update mod filter visibility on user change 2019-11-11 18:40:57 +03:00
Andrei Zavatski
31191dadf1 Handle mods change 2019-11-11 18:31:42 +03:00
Andrei Zavatski
2cfd54ca0d Handle scope changing 2019-11-11 18:27:48 +03:00
Andrei Zavatski
00b9229737 Add mod filter to beatmap overlay 2019-11-11 18:21:07 +03:00
Andrei Zavatski
32b2f5e330 Use Bindable for ScoresContainer 2019-11-11 18:10:25 +03:00
Andrei Zavatski
3655f88180 Merge dependency 2019-11-11 17:56:57 +03:00
Andrei Zavatski
93954c8da0 Use BindableList for selected mods 2019-11-10 23:58:07 +03:00
Andrei Zavatski
e3d8e29cdd Merge remote-tracking branch 'refs/remotes/ppy/master' into beatmap-mod-selector 2019-11-10 23:38:41 +03:00
Dean Herbert
ce19b2ed36 Avoid using CreateChildDependencies with a *child* bindable
Don't do this.
2019-10-31 17:16:26 +09:00
Dean Herbert
3e3ff81229 Reorder methods 2019-10-31 17:13:00 +09:00
Dean Herbert
4f04abf282 Fix tabs to match design (should not show pinhair line) 2019-10-31 16:54:28 +09:00
Dean Herbert
5d47a2e557
Merge branch 'master' into add-beatmap-ruleset-selector 2019-10-31 16:42:32 +09:00
Dean Herbert
bf45fa6309 Use lambda function expression 2019-10-31 16:24:03 +09:00
Dean Herbert
f8187fa301 Don't rely on masking for bar display 2019-10-31 16:23:10 +09:00
Andrei Zavatski
2dac3a6efe Handle hitting the maximum allowed number of favourited beatmaps 2019-10-16 13:58:29 +03:00
iiSaLMaN
60133ba0c3 Propagate BeatmapSetInfo to tab items with bindable 2019-10-15 23:33:50 +03:00
Andrei Zavatski
a7dc9bb582 Add tooltip and remove pink layer 2019-10-07 15:41:05 +03:00
Andrei Zavatski
2d707b2b65 Implement PostBeatmapFavouriteRequest 2019-10-07 15:36:23 +03:00
iiSaLMaN
ba1a854701 Use IEnumerable.Where<>() rather than List.FindAll()
Saves a whole list allocation
2019-10-05 10:30:32 +03:00
iiSaLMaN
6985249d90 Simplify properties 2019-10-04 21:18:03 +03:00
iiSaLMaN
0c4f248259 Fix CI issues 2019-10-04 18:02:13 +03:00
iiSaLMaN
555c82e9c9 Filter beatmap difficulties by current ruleset 2019-10-04 17:56:42 +03:00
iiSaLMaN
7d5f5d2fd9 Add ruleset selector to the beatmap overlay header 2019-10-04 17:55:33 +03:00