13223 Commits

Author	SHA1	Message	Date
Salman Ahmed	c8b7cf8672	Merge branch 'master' into add-bindable-for-break-times	2019-07-30 06:23:47 +03:00
Dean Herbert	cec26a270e	Fix using right mouse button to drag at song select seeking incorrectly with many beatmaps loaded ... Closes #5195	2019-07-30 07:04:16 +09:00
Dean Herbert	ece5a9622e	Fix scores without an online ID not always presenting correctly	2019-07-30 06:32:05 +09:00
Dean Herbert	b4bcdb1c70	Update framework	2019-07-29 19:44:58 +09:00
Dean Herbert	31c8c0f75a	Fix legacy scores with no online ID being imported with a non-n… (#5508) ... Fix legacy scores with no online ID being imported with a non-null ID	2019-07-29 19:21:00 +09:00
Dean Herbert	766cf9295d	Merge remote-tracking branch 'upstream/master' into add-legacy-hit-animations	2019-07-29 19:03:36 +09:00
Dean Herbert	2d03c849bf	Improve testability of intro sequence (#5275) ... Improve testability of intro sequence	2019-07-29 18:56:38 +09:00
Dan Balasescu	ef229c0f80	Merge branch 'master' into legacy-cursor-middle	2019-07-29 18:52:11 +09:00
Dean Herbert	894d573fbc	Cache DrawableHitObject for skinnables to access (#5463) ... Cache DrawableHitObject for skinnables to access	2019-07-29 18:49:37 +09:00
Dean Herbert	a4f30daf13	Merge pull request #5462 from peppy/skin-metric-parity ... Bring playfield ratio in line with stable	2019-07-29 18:49:21 +09:00
Dean Herbert	d99408e979	Fix SkinChanged events triggering after disposal (#5461) ... Fix SkinChanged events triggering after disposal Co-authored-by: Dan Balasescu <1329837+smoogipoo@users.noreply.github.com>	2019-07-29 18:48:53 +09:00
Dean Herbert	79d7416474	Merge branch 'master' into remove-type-specification	2019-07-29 18:47:09 +09:00
Dean Herbert	ac01e9fbeb	Fix legacy scores with no online ID being imported with a non-null ID	2019-07-29 18:36:07 +09:00
Dan Balasescu	98813222af	Adjust comment	2019-07-29 18:35:22 +09:00
Dan Balasescu	7779302e82	Merge branch 'master' into skin-scaling-modes	2019-07-29 17:47:07 +09:00
Dean Herbert	c514cbe2b7	Add basic skinning test	2019-07-29 17:27:00 +09:00
Dean Herbert	85e6ac156f	Merge branch 'fix-zero-length-hash' into skinning-test	2019-07-29 16:58:35 +09:00
Dean Herbert	cb17007fa7	Fix zero-length hash models incorrectly creating a unique hash	2019-07-29 16:57:19 +09:00
Dean Herbert	c14c3ba8ec	Move database isolation logic to OsuTestScene for easier reuse	2019-07-29 16:57:02 +09:00
Dan Balasescu	0dc25d7a35	Merge branch 'master' into exit-multi-from-null	2019-07-29 13:52:26 +09:00
David Zhao	26fc782de9	Don't exit if screenstack is null	2019-07-29 10:35:51 +09:00
Max Hübner	316b11d08b	use single line if-statement	2019-07-28 20:36:21 +02:00
Dean Herbert	262284d095	Merge branch 'master' into truncate-long-usernames-in-private-chat	2019-07-29 02:47:49 +09:00
Dean Herbert	663f34d3d8	Remove width specifications	2019-07-29 02:47:26 +09:00
Dean Herbert	088c04a20f	Revert "Fix BackButton handling escape before all other elements (#5440)" ... This reverts commit 17a6563f4c.	2019-07-28 23:38:55 +09:00
Max Hübner	f7b9ddb48c	combine Text and TextBold	2019-07-28 12:40:21 +02:00
Max Hübner	df8d4d8966	add truncation to base class	2019-07-28 12:16:32 +02:00
Max Hübner	c6d4ce0f8a	revert truncation in derived class	2019-07-28 12:14:06 +02:00
iiSaLMaN	5bf0277fd4	Remove unnecessary quick check ... Not saving for anything	2019-07-28 09:17:13 +03:00
iiSaLMaN	1dd3a66300	Remove unnecessary index resets	2019-07-28 09:16:19 +03:00
David Zhao	bd2fce4bb7	don't use extra container	2019-07-28 13:45:54 +09:00
Dean Herbert	ddb98c705a	Merge branch 'master' into update-follower-count	2019-07-28 12:53:40 +09:00
Dean Herbert	872822035a	Merge branch 'master' into back-button-priority	2019-07-28 12:50:18 +09:00
Max Hübner	edf6453e04	truncate long usernames in private chat	2019-07-27 18:56:37 +02:00
iiSaLMaN	95b568eb46	Remove unnecessary condition	2019-07-27 15:52:30 +03:00
iiSaLMaN	6c580ac9d5	Use while loops instead	2019-07-27 15:52:01 +03:00
Dean Herbert	3571cb96b0	Fix broken merge	2019-07-27 12:56:55 +09:00
David Zhao	57e6c388a1	Merge branch 'master' into carousel-sizing	2019-07-27 11:40:07 +09:00
iiSaLMaN	ba4045a761	Fix transforming mods not working properly ... Hidden, Grow, Deflate, etc..	2019-07-27 00:22:40 +03:00
Dean Herbert	699e366306	Update framework	2019-07-26 20:29:57 +09:00
Salman Ahmed	934439e138	Merge branch 'master' into add-bindable-for-break-times	2019-07-26 12:57:52 +03:00
Dean Herbert	f6f4a08019	Reduce notification span during beatmap imports (#5471) ... Reduce notification span during beatmap imports	2019-07-26 18:49:07 +09:00
Dean Herbert	392e1cbafb	Merge pull request #5456 from peppy/fix-import-select ... Fix beatmap present failing directly after an import	2019-07-26 18:48:49 +09:00
Dean Herbert	5317a8fa0f	Update framework again	2019-07-26 17:50:49 +09:00
Dean Herbert	9ef858806b	Fix existing usage of Path	2019-07-26 17:48:19 +09:00
Dean Herbert	9d080ec249	Update framework	2019-07-26 17:18:56 +09:00
Dean Herbert	9036129aa7	Hide leaderboard mod filter when on details tab (#5473) ... Hide leaderboard mod filter when on details tab Co-authored-by: Dean Herbert <pe@ppy.sh>	2019-07-26 16:07:58 +09:00
Dean Herbert	4d49aad153	Start not visible	2019-07-26 15:51:51 +09:00
Dean Herbert	7fa419a38b	Fix file layout order	2019-07-26 15:49:21 +09:00
iiSaLMaN	4c9e8527d8	Modify global index directly in the for loop ... Moves the global index to a near break if not in a break yet	2019-07-26 09:24:53 +03:00
David Zhao	0f6c6c7de0	consolidate halfheight as well	2019-07-26 15:22:29 +09:00
Joehu	0b6cfec21c	Hide leaderboard mod filter when on details tab	2019-07-25 23:20:56 -07:00
iiSaLMaN	5a94a22314	Add a quick check if we're not in a break with current index	2019-07-26 09:17:39 +03:00
David Zhao	6765e9f7fa	Combine into properties and update for framework changes	2019-07-26 15:13:10 +09:00
Joehu	3b0a482743	Fix font weight of leaderboard mod filter	2019-07-25 23:10:00 -07:00
iiSaLMaN	3fa6804501	Use better loops for moving index ... Easy to read, suggested by peppy	2019-07-26 08:12:32 +03:00
iiSaLMaN	806d41daf4	Add function to reset break index	2019-07-26 08:11:13 +03:00
iiSaLMaN	91fa8a6552	Simplify null and any check	2019-07-26 08:09:18 +03:00
Dean Herbert	53ecb2ae82	Reduce notification span during beatmap imports	2019-07-26 13:48:29 +09:00
Dean Herbert	5f0d633b34	Allow closing chat tabs with middle mouse button (#5447) ... Allow closing chat tabs with middle mouse button Co-authored-by: Dean Herbert <pe@ppy.sh>	2019-07-26 13:31:25 +09:00
Dean Herbert	56b27db7a4	Use "Click" instead of "Action"	2019-07-26 13:17:33 +09:00
Dean Herbert	7ec6ac7b0e	Remove unnecessary override	2019-07-26 13:15:36 +09:00
David Zhao	c89830f3d8	move constants, combine local vars into properties	2019-07-26 13:07:28 +09:00
iiSaLMaN	44895c4b69	Use IReadOnlyList for break periods list	2019-07-26 05:41:10 +03:00
iiSaLMaN	b4c93b1777	Use lookup direction than 2 while loops	2019-07-26 05:11:01 +03:00
iiSaLMaN	a08d54eb06	Remove unnecessary checks	2019-07-26 03:11:59 +03:00
Shane Woolcock	1d6c321e14	Ensure we don't ping-pong nearestBreakIndex between breaks	2019-07-26 08:34:18 +09:30
Shane Woolcock	5e51012800	Rewrite updateBreakTimeBindable	2019-07-25 22:54:05 +09:30
iiSaLMaN	cdda264c49	Use global index and move it to find if break time ... Avoid using iterations	2019-07-25 12:28:21 +03:00
iiSaLMaN	5a55433d6c	Return if breaks are null ... Fixes a test	2019-07-25 11:53:32 +03:00
iiSaLMaN	172a9ce33a	Use a for loop instead of foreach ... avoid allocating an iterator	2019-07-25 11:40:45 +03:00
David Zhao	a9f0dda9d7	Confine positional input	2019-07-25 17:36:13 +09:00
David Zhao	97eb5293a8	Don't depend on parent sizing	2019-07-25 17:32:21 +09:00
iiSaLMaN	9bd66b6e7a	Better xmldoc	2019-07-25 11:27:32 +03:00
iiSaLMaN	69d2f57f4f	Avoid using LINQ	2019-07-25 11:27:01 +03:00
iiSaLMaN	0ea0a10ca4	Expose as IBindable<bool>	2019-07-25 11:26:38 +03:00
iiSaLMaN	7b82d184bd	Add bindable boolean for break times	2019-07-25 11:07:53 +03:00
Dean Herbert	bfaf9d5f41	Remove unnecessary special cases	2019-07-25 16:24:10 +09:00
Dean Herbert	c1b0130857	Add legacy cursormiddle support	2019-07-25 16:23:04 +09:00
Dean Herbert	38e21caa5a	Add legacy hitcircle	2019-07-25 16:10:01 +09:00
Dean Herbert	900d17a4db	Merge branch 'fix-skin-changed-disposal' into add-legacy-hit-animations	2019-07-25 16:09:15 +09:00
Dean Herbert	3ca41b9c0a	Merge branch 'skin-metric-parity' into add-legacy-hit-animations	2019-07-25 16:07:23 +09:00
Dean Herbert	54260e4038	Merge branch 'cache-drawable-hitobject' into add-legacy-hit-animations	2019-07-25 16:05:32 +09:00
Dean Herbert	eb6bda3f08	Cache DrawableHitObject for skinnables to access	2019-07-25 16:03:07 +09:00
Dean Herbert	58feba72a3	Fix scheduled events not running on previous drawables	2019-07-25 15:59:44 +09:00
David Zhao	c4bed0e6d2	Resize BeatmapCarousel, update carouselitem logic	2019-07-25 15:31:21 +09:00
Dean Herbert	46e17646ac	Align slider path size with legacy skins	2019-07-25 14:22:26 +09:00
Dean Herbert	9473f6d3e3	Fix incorrect ratios being applied to playfield / skin elements ... This now matches osu-stable 1:1.	2019-07-25 14:22:22 +09:00
Dean Herbert	a290437286	Fix skin changed events triggering after disposal	2019-07-25 13:55:01 +09:00
Dean Herbert	69844e6c24	Fix beatmap present failing directly after an import	2019-07-25 12:18:18 +09:00
David Zhao	6ef3c71e22	remove unused using	2019-07-25 11:31:46 +09:00
Dean Herbert	7275beaf1a	Remove unnecessary type specification from SkinnableDrawable	2019-07-25 11:20:39 +09:00
David Zhao	e63c97b306	remove unnecessary overrides	2019-07-25 11:20:24 +09:00
David Zhao	bbcc8f0721	Add new container level and unblock footer	2019-07-25 11:11:20 +09:00
Max Hübner	78a8a6490e	close chat tabs with middle mouse button	2019-07-24 17:17:29 +02:00
Dean Herbert	efad9b3150	Merge branch 'master' into skin-scaling-modes	2019-07-24 18:37:31 +09:00
David Zhao	da3dc610ba	revert globalaction changes	2019-07-24 12:52:18 +09:00
David Zhao	263ccfcbcb	Merge remote-tracking branch 'upstream/master' into back-button-priority	2019-07-24 12:50:16 +09:00
David Zhao	38559685a9	proxy backbutton instead	2019-07-24 12:47:41 +09:00
Dean Herbert	2610ee2abb	Update framework	2019-07-23 21:39:10 +09:00
smoogipoo	4e7e2d1d52	Adjust comments	2019-07-23 21:16:09 +09:00
smoogipoo	74b09c72fa	Refactor state updates to convert State into an IBindable	2019-07-23 21:16:09 +09:00
Dan Balasescu	9b526ef61e	Merge branch 'master' into move-state-logic	2019-07-23 20:37:57 +09:00
Dean Herbert	91e21688d8	Make AccentColour a bindable (#5420) ... Make AccentColour a bindable Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2019-07-23 20:37:47 +09:00
Dan Balasescu	0ffac22376	Merge branch 'master' into allow-multiple-debug-instances	2019-07-23 20:30:56 +09:00
Dan Balasescu	bc64c56a26	Merge branch 'master' into remove-text-shadow	2019-07-23 20:16:33 +09:00
David Zhao	8220a51310	Make backbutton handle global input last	2019-07-23 17:59:50 +09:00
Dean Herbert	9665a94f4a	Ignore shift-delete PlatformAction in SearchTextBox (#5372) ... Ignore shift-delete PlatformAction in SearchTextBox Co-authored-by: Dean Herbert <pe@ppy.sh>	2019-07-23 17:11:09 +09:00
Dean Herbert	e81ef4bf33	Rewrite comment	2019-07-23 16:44:19 +09:00
Dean Herbert	340f9a8f8d	Merge branch 'master' into fix-flashlight-depth	2019-07-23 16:37:04 +09:00
Dean Herbert	704fe2d655	Remove text shadow in chat	2019-07-23 16:04:50 +09:00
smoogipoo	5e72ed0d12	Fix potential nullref	2019-07-23 15:35:12 +09:00
David Zhao	4d8e2a78d1	update with new framework changes and update comment	2019-07-23 15:31:09 +09:00
smoogipoo	776757545d	Fix FTB causing flashlight to block vision correctly	2019-07-23 15:17:02 +09:00
Dean Herbert	292bd22f92	Allow multiple instances of osu! when running under debug	2019-07-23 13:38:05 +09:00
David Zhao	3e4ebd3c7a	Merge branch 'master' into shift-delete	2019-07-23 13:25:12 +09:00
David Zhao	e628e44d8e	update comment	2019-07-23 13:25:03 +09:00
Dean Herbert	d5ee4cbc9c	Move TouchDevice mod to new "system" category	2019-07-23 13:14:28 +09:00
Dean Herbert	452b2c8027	Separate GlowingSpriteText from LeaderboardScore into it's own… (#5418) ... Separate GlowingSpriteText from LeaderboardScore into it's own class Co-authored-by: Dean Herbert <pe@ppy.sh>	2019-07-23 12:08:30 +09:00
Dean Herbert	9e34582c17	Merge branch 'master' into separate-glowing-text-from-leaderboardscore	2019-07-23 11:31:47 +09:00
Andrei Zavatski	ffcc1c62af	simplify moving condition	2019-07-22 23:22:39 +03:00
iiSaLMaN	32e9547ce9	Trim whitespace	2019-07-22 23:16:54 +03:00
iiSaLMaN	081355e3d1	Use IHasText and simplify properties	2019-07-22 23:12:09 +03:00
Andrei Zavatski	ee6fed5b33	Use fixed height	2019-07-22 18:17:49 +03:00
Dean Herbert	2f111e6cf4	Fix incorrect corner radius	2019-07-22 23:57:26 +09:00
Dean Herbert	4dc9309a7e	Merge branch 'master' into underscored_link	2019-07-22 23:46:57 +09:00
Dean Herbert	ade661236a	Merge branch 'master' into intro-testing-improvements	2019-07-22 23:44:14 +09:00
Dean Herbert	cdf75b4098	Public before private	2019-07-22 22:14:09 +09:00
Andrei Zavatski	075ca3d8ea	CI fix	2019-07-22 14:47:35 +03:00
Andrei Zavatski	3e95cb9145	Use bindable and disable button	2019-07-22 14:35:18 +03:00
Andrei Zavatski	2a17ed5e18	Merge remote-tracking branch 'refs/remotes/ppy/master' into favourite-beatmap	2019-07-22 14:32:37 +03:00
Dean Herbert	7d3939a838	Merge branch 'master' into fix-triangles-crash	2019-07-22 19:17:51 +09:00
Dean Herbert	07a0df7c4f	Fix bracket precedence	2019-07-22 18:29:04 +09:00
Dean Herbert	a05a6bbb77	Set "Title" as the default grouping/sorting modes in song select (#5396) ... Set "Title" as the default grouping/sorting modes in song select	2019-07-22 18:06:23 +09:00
Dean Herbert	d4d286c988	Add full documentation	2019-07-22 16:08:38 +09:00
Dean Herbert	c3b81bef4a	Flip default to the preferred method going forward	2019-07-22 15:55:38 +09:00
Dean Herbert	be170b4124	Naming and documentation improvements	2019-07-22 15:50:02 +09:00
Dean Herbert	91f86adb66	Move DrawableHitObject state management to base class	2019-07-22 15:07:12 +09:00
smoogipoo	a631aac664	Fix workingbeatmap's disposal potentially null-refing	2019-07-22 15:01:01 +09:00
Dean Herbert	8327452fe1	Make AccentColour a bindable	2019-07-22 14:48:59 +09:00
Dean Herbert	36c557c752	Add null check and simplify scaling conditional logic via switch	2019-07-22 14:43:25 +09:00
Dean Herbert	9d091c96b8	Use cache to ensure correct DrawSize when deciding scaling	2019-07-22 14:43:04 +09:00
Dean Herbert	74c961bcff	Add more flexible skin element confine modes	2019-07-22 14:42:56 +09:00
Andrei Zavatski	de8ac9a428	Simple implementation	2019-07-21 21:41:07 +03:00
iiSaLMaN	affd0b2878	Fix build issues	2019-07-21 12:34:52 +03:00
iiSaLMaN	57fc5cbda8	Fix CI issues	2019-07-21 12:29:06 +03:00
iiSaLMaN	87fb22352c	glowingText -> blurredText	2019-07-21 12:28:55 +03:00
iiSaLMaN	9d7f6abbdd	Remove unnecessary field	2019-07-21 12:18:31 +03:00
iiSaLMaN	ed0ef90613	Separate glowing sprite text into it's own class	2019-07-21 12:14:55 +03:00
Dean Herbert	e76b3e2b40	User property instead of method	2019-07-21 10:42:40 +09:00
iiSaLMaN	842417cf42	Check if selected scope requires API	2019-07-21 03:07:27 +03:00
Dean Herbert	4c592a5e65	Fix TriangleDrawNode crash when aimcount is zero	2019-07-20 22:52:07 +09:00
Dean Herbert	2a94b68ecb	Simplify logic	2019-07-20 22:50:17 +09:00
Dean Herbert	2df279f902	Merge branch 'master' into loading-fix	2019-07-20 22:46:09 +09:00
Dean Herbert	5696d79423	Use TriangleBatch	2019-07-19 23:47:48 +09:00
Dean Herbert	eebfdd8865	Update framework	2019-07-19 23:43:25 +09:00
Dean Herbert	f08d722083	Merge remote-tracking branch 'upstream/master' into triangle-memory-reudction	2019-07-19 23:43:17 +09:00
smoogipoo	066bee3535	Simplify offset calculation	2019-07-19 16:02:33 +09:00
smoogipoo	2a66cf36d5	Merge remote-tracking branch 'Joehuu/master' into requests-limit-usage	2019-07-19 15:33:18 +09:00
smoogipoo	99ab77b926	Add PaginatedWebRequest to handle request pagination	2019-07-19 15:33:09 +09:00
Dean Herbert	024f136d82	Reduce buffer count by one	2019-07-19 14:24:11 +09:00
Dean Herbert	95f36c36c4	Late-initialize vertex batch for safety	2019-07-19 01:52:53 +09:00
Dean Herbert	a23bb3a6b3	Account for headless nulls (but how?)	2019-07-19 01:14:55 +09:00
Dean Herbert	00f1d1b53c	Reduce Triangle drawnode overhead by ~90% ... This was never batching, ever. Pointless memory overhead.	2019-07-19 00:53:00 +09:00
Andrei Zavatski	fa978a47b0	Fix loading animation is no longer present	2019-07-18 15:08:50 +03:00
smoogipoo	f87e9b8017	Remove unnecessary tooltip text	2019-07-18 20:17:19 +09:00
smoogipoo	ca72409dc2	More closely match osu-web styling	2019-07-18 20:16:10 +09:00
Dan Balasescu	85ce44be74	Merge branch 'master' into remove-unnecessary-transforms-1	2019-07-18 18:16:36 +09:00
Dean Herbert	f175f597e7	Update follower count API source	2019-07-18 14:05:57 +09:00
smoogipoo	1ce2b2eace	Set title as default grouping/sorting modes	2019-07-18 13:18:06 +09:00
Dean Herbert	a6ddcd78d4	Fix results screen not showing first tab correctly	2019-07-18 01:08:12 +09:00
Dean Herbert	f1423b8cb5	Add more brackets	2019-07-18 00:03:04 +09:00
Dean Herbert	cc3492f8f2	Update framework	2019-07-18 00:01:38 +09:00
Dean Herbert	3e57fcf5c5	Merge remote-tracking branch 'upstream/master' into cleanup-slider-bodies	2019-07-17 22:11:01 +09:00
Dean Herbert	42b1e1772f	Update framework	2019-07-17 22:07:11 +09:00
Dean Herbert	a079b9c921	Merge pull request #5384 from smoogipoo/fix-direct-ruleset-selector ... Fix direct ruleset selector binding in ctor	2019-07-17 22:02:41 +09:00
Dean Herbert	99bd50a48e	Fix judgement disposals causing huge LOH pressure (#5385) ... Fix judgement disposals causing huge LOH pressure	2019-07-17 22:01:47 +09:00
Dean Herbert	98d0713fa9	Merge branch 'master' into fix-background-blur-safety	2019-07-17 22:01:10 +09:00
Dean Herbert	bee30b18d2	Merge pull request #5381 from peppy/fix-leaderboard-display-crash ... Fix potential crash when displaying leaderbaords	2019-07-17 22:00:45 +09:00
Dan Balasescu	883c090248	Fix disabled state potentially not being set	2019-07-17 20:02:20 +09:00
smoogipoo	9f6ff63634	Fix judgement disposals causing huge LOH pressure	2019-07-17 19:25:41 +09:00
smoogipoo	cca472d412	Fix direct ruleset selector binding in ctor	2019-07-17 19:19:45 +09:00
Dean Herbert	1a19cf0739	Fix 0-length sliders not getting correct lengths (#5033) ... Fix 0-length sliders not getting correct lengths	2019-07-17 18:01:57 +09:00
Dean Herbert	66036508b6	Fix potential crash when displaying leaderbaords	2019-07-17 17:39:04 +09:00
smoogipoo	a9286fee07	Recycle slider paths when the parenting slider dies	2019-07-17 16:20:27 +09:00
smoogipoo	7c5a227fc5	Fix crashes when presenting replays	2019-07-17 14:46:25 +09:00
David Zhao	b95a598338	don't check for shift	2019-07-16 15:12:01 +09:00
Dean Herbert	7634e3cc81	Fix song select iterating over all beatmaps in database unnnecessarily	2019-07-16 14:57:11 +09:00
David Zhao	e789bb37c8	Ignore shift-delete in SearchTextBox	2019-07-16 14:55:41 +09:00
smoogipoo	ed203cb0ff	Delay intial hitobject updates	2019-07-16 13:45:59 +09:00
Joehu	83ffb1d542	Remove unnecessary transforms on top score user section	2019-07-15 14:15:03 -07:00
Andrei Zavatski	9458bca58f	Update usage of requests	2019-07-15 13:37:25 +03:00
Andrei Zavatski	111541fe7a	Use limit in requests	2019-07-15 13:31:57 +03:00
Andrei Zavatski	d62e42ba14	Remove custom link container implementation	2019-07-15 13:09:21 +03:00
Andrei Zavatski	cfb1e0683c	Merge remote-tracking branch 'refs/remotes/ppy/master' into underscored_link	2019-07-15 12:32:02 +03:00
Dean Herbert	d4c1005c7e	Fix incorrect comparison in line updating logic	2019-07-15 15:53:19 +09:00
Dean Herbert	d0c8aaba4e	Override basic equality function too	2019-07-15 15:50:50 +09:00
Dean Herbert	9c1badd2e3	Fix rulesets not matching in dictionary lookups due to missing GetHashCode implementation	2019-07-15 15:42:54 +09:00
Dean Herbert	d92f6c762b	Fix potential nullref	2019-07-15 11:53:16 +09:00
Dean Herbert	12e7668afc	Fix potential cross-thread talk from bindable updates	2019-07-15 11:48:33 +09:00