1355 Commits

• Rewrite selection box computation logic with RectangleF's helper methods
  Salman Ahmed · 2021-05-02 02:51:06 +03:00
  0aa17e7c95
• Use bounding box of blueprint for computing selection box area
  Salman Ahmed · 2021-05-02 02:36:40 +03:00
  07fe99025f
• Refactor SelectionBlueprint and MoveSelectionEvent to work in screen-space coordinates

  Until now, the implementation of the overrides in `SelectionBlueprint`
  have been confusing to the point where I would just implement by
  trial-and-error (or copying from an existing implementation). This was
  due to a combination of using "object" space coordinates
  (ie. the thing the `Blueprint` is operating on) and screen-space coordinates.
  
  This change switches all event related coordinates to screen-space,
  which is how we already handle rotation/scale operations. With the
  introduction of other editor types where the related objects are
  drawables, this also makes a lot more sense.

  Dean Herbert · 2021-04-29 16:10:42 +09:00
  9c62c90cfc
• Change one remaining instance of incorrect terminology in xmldoc
  Dean Herbert · 2021-04-28 13:49:41 +09:00
  e0906daebf
• Move context menu logic to base class
  Dean Herbert · 2021-04-28 13:43:16 +09:00
  4c9e94da2b
• Remove unnecessary newline
  Dean Herbert · 2021-04-28 12:04:48 +09:00
  532ec40395
• Remove duplicated call to initially select blueprint
  Dean Herbert · 2021-04-28 12:03:41 +09:00
  43772f4303
• Rename AllowDeselection to better match use case
  Dean Herbert · 2021-04-28 12:02:55 +09:00
  e4f2e0131c
• Fix incorrect xmldoc in MoveSelectionEvent
  Dean Herbert · 2021-04-28 11:46:52 +09:00
  a9a5809e94
• Remove one more out-of-date comment
  Dean Herbert · 2021-04-28 11:45:36 +09:00
  d0be8f9fb3
• Fix incorrect coordinate space mention in xmldoc
  Dean Herbert · 2021-04-28 11:44:50 +09:00
  bc455005a5
• Remove unnecessary and out-of-place xmldoc
  Dean Herbert · 2021-04-28 11:44:19 +09:00
  61d4eb1777
• Rename region to be more inclusive
  Dean Herbert · 2021-04-28 11:42:22 +09:00
  aa1cb65eaa
• Rename and xmldoc selection completed method
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  42255f8d33
• Remove hitobject terminology from base classes
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  7ec5ea1eb5
• Revert changes to OnBlueprint methods and handle select-on-addition locally
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  ff06a27a12
• Fix binding direction of selected items
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  f97b14a20a
• Make SelectionHandler abstract to ensure things get implemented
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  dd3d8e5d03
• Move model selection handling to base SelectionHandler class
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  32416e4e31
• Allow BlueprintContainer to perform movement without an ISnapProvider
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  eac139ca0e
• Refactor editor selection/blueprint components to be generic
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  f2e56bd306
• Revert "Inherit VisibilityContainer and make duration constant protected"

  This reverts commit c58ef4230d. Uhh, how did I push this..

  Salman Ahmed · 2021-04-26 01:41:42 +03:00
  485da47d89
• Remove protected expose of HandlingMouse setter

  Regardless of `OnDragEnd()`, `OnMouseUp()` will still be called resetting the value of that state back.

  Salman Ahmed · 2021-04-25 20:13:23 +03:00
  b252485e1a
• SelectionBoxDragHandleDisplay -> SelectionBoxDragHandleContainer
  Salman Ahmed · 2021-04-25 20:03:15 +03:00
  7390a12e4b
• Inherit VisibilityContainer and make duration constant protected
  Salman Ahmed · 2021-04-25 20:03:15 +03:00
  c58ef4230d
• Improve English

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Salman Ahmed · 2021-04-25 19:26:53 +03:00
  79e2b232d8
• Replace separated top-centered rotation button with rotation drag handles
  Salman Ahmed · 2021-04-25 10:17:36 +03:00
  a8c460f7df
• Add composite managing display of selection box drag handles
  Salman Ahmed · 2021-04-25 10:17:36 +03:00
  77f7d4c963
• Use colour fade transform for selection box controls

  To become harminous with the fade transforms of the rotation control

  Salman Ahmed · 2021-04-25 10:14:31 +03:00
  ab71782674
• Add property for tracking whether control is during operation
  Salman Ahmed · 2021-04-25 10:14:31 +03:00
  62bcc5f76d
• Add rotation drag handle component
  Salman Ahmed · 2021-04-24 08:00:36 +03:00
  206fc94b8c
• Change inheritance of selection box buttons to base control instead
  Salman Ahmed · 2021-04-24 08:00:29 +03:00
  4bfa9cd6b6
• Abstract base appearence and hover update from drag handles
  Salman Ahmed · 2021-04-24 07:45:53 +03:00
  decd8803bc
• Add simple key based time nudging support to editor
  Dean Herbert · 2021-04-22 18:47:04 +09:00
  a5364b224f
• Ignore movement operations which have no offset
  Dean Herbert · 2021-04-22 18:12:03 +09:00
  1884c18a2c
• Move foreground colour helper into OsuColour
  Bartłomiej Dach · 2021-04-19 18:24:48 +02:00
  0825fc57a9
• Merge branch 'master' into combo-colours-display
  Bartłomiej Dach · 2021-04-19 18:21:57 +02:00
  97573fb11d
• Fix unreadable colour hex code text due to low contrast

  Logic is shared with the timeline blueprints which also have the same
  problem of displaying text on top of a combo colour.
  
  Slightly modified the formula. Seems to yield better results on a
  subjective check.

  Bartłomiej Dach · 2021-04-18 20:44:55 +02:00
  a8027d87b6
• Use full path
  Dean Herbert · 2021-04-18 21:05:23 +09:00
  cfc7664094
• Fix selection box not displaying after pasting a selection in the editor

  Closes #12471.

  Dean Herbert · 2021-04-18 20:28:39 +09:00
  e76565dbc5
• Add border showing selected blueprints in timeline
  Dean Herbert · 2021-04-16 18:16:22 +09:00
  d9d50f0e88
• Merge branch 'master' into fix-potential-deselection-crash
  Dan Balasescu · 2021-04-16 16:27:47 +09:00
  3c8e2b8b32
• Merge pull request #12437 from peppy/fix-editor-placement-commit-false

  Fix placement blueprints not being correctly removed after a rolled back placement

  Dan Balasescu · 2021-04-16 16:25:05 +09:00
  d3acbcced7
• Fix an occasional crash when deleting a HitObject via internal means
  Dean Herbert · 2021-04-16 15:55:33 +09:00
  c59906e925
• Fix placement blueprints not being correctly removed after a rolled back placement
  Dean Herbert · 2021-04-16 14:11:33 +09:00
  119c9b4294
• Fix slider not displaying in timeline during zero-duration placement
  Dean Herbert · 2021-04-16 13:38:55 +09:00
  42c066e6f2
• Move zoom settings back to run in a non-loaded state
  Dean Herbert · 2021-04-16 01:01:03 +09:00
  c2340f1fe8
• Set the timeline's height to a sane non-zero default

  This isn't required but makes the initial appearance animation nicer.

  Dean Herbert · 2021-04-16 00:58:32 +09:00
  15d48a924b
• Merge pull request #12412 from peppy/timeline-adjustments

  Update timeline control point display

  Dean Herbert · 2021-04-15 22:43:26 +09:00
  7cf15fe729
• Simplify ExtendableCircle even more
  Andrei Zavatski · 2021-04-15 15:53:21 +03:00
  71b06d7e61