1355 Commits

• Expose DistanceSpacingMultiplier to distance
  Dean Herbert · 2022-05-05 17:08:53 +09:00
  786c7f14d3
• Rename misleading DistanceSpacing variable
  Dean Herbert · 2022-05-05 17:08:09 +09:00
  de9b3d33eb
• Merge branch 'cache-at-interface'
  Dean Herbert · 2022-05-05 16:52:03 +09:00
  4226583afd
• Merge branch 'snapping-tidy-distance'
  Dean Herbert · 2022-05-05 16:51:32 +09:00
  19cf9dc20b
• Move snap provider caching to interfaces
  Dean Herbert · 2022-05-05 16:44:37 +09:00
  1c6a233cc0
• Add xmldoc for IDistanceSnapProvider and related properties
  Dean Herbert · 2022-05-05 16:25:45 +09:00
  977e6d8a80
• Add xmldoc and rename methods in IPositionSnapProvider for legibility
  Dean Herbert · 2022-05-05 15:58:21 +09:00
  f6fc926f1a
• Add highlighting to the position snap grid edges in addition to centre lines
  Dean Herbert · 2022-05-04 13:49:04 +09:00
  df530cb5ab
• Fix gridline centering and ensure lines are always rendered using a fixed screen-space width
  Dean Herbert · 2022-05-04 13:41:55 +09:00
  0bb90c7b07
• Fix IDE0005 and IDE0034
  Huo Yaoyuan · 2022-05-03 13:09:19 +08:00
  7cf4dabe29
• Add back float cast to distance spacing computation
  Salman Ahmed · 2022-04-29 08:41:37 +03:00
  173a6188eb
• Revert "Convert data type of DistanceSpacing to float"

  This reverts commit 7aaa88cac2.

  Salman Ahmed · 2022-04-29 08:02:07 +03:00
  fef94d49f4
• Move distance spacing application to DistanceSnapGrid
  Salman Ahmed · 2022-04-28 10:54:38 +03:00
  abb88b0907
• Convert data type of DistanceSpacing to float
  Salman Ahmed · 2022-04-28 10:24:36 +03:00
  7aaa88cac2
• Minor cleanup

  Just from reading diff.

  Salman Ahmed · 2022-04-28 07:14:43 +03:00
  2e8372fe90
• Move distancing methods from IPositionSnapProvider to IDistanceSnapProvider
  Salman Ahmed · 2022-04-28 05:48:45 +03:00
  59cf3ff50f
• Move DistanceSpacingMultiplier bindable to its own IDistanceSnapProvider interface
  Salman Ahmed · 2022-04-24 08:33:00 +03:00
  70a93c0e7e
• Merge branch 'master' into osu-distance-spacing
  Salman Ahmed · 2022-04-24 05:23:30 +03:00
  4f8f27a58b
• Use existing web localisation for most hardcoded strings
  Joseph Madamba · 2022-04-20 16:31:11 -07:00
  5e5c8e78a6
• Move SelectionHandler's SelectedItems binding to the base implementation

  Until now it was up to each implementation to connect
  `BlueprintContainer` to its `SelectionHandler`, which didn't make much
  sense at all.

  Dean Herbert · 2022-03-10 23:22:19 +09:00
  68aedd63a7
• Allow tabbing between textboxes in sample point popover
  Bartłomiej Dach · 2022-03-06 01:43:56 +01:00
  e1eeb9c6bb
• Reword popup text to read better (or more vaguely)

  Removed some words but also don't mention "smaller" because it's...
  musically incorrect and also functionally incorrect – entering 1/[8]
  will result in 1/16 also being populated for instance.

  Dean Herbert · 2022-02-28 15:26:50 +09:00
  2be40f36f7
• Remove unused using statement
  Dean Herbert · 2022-02-28 15:24:02 +09:00
  368eadd8d1
• Automatically focus divisor textbox and hide popover after successful change
  Dean Herbert · 2022-02-28 15:23:01 +09:00
  3634e12e66
• Add test coverage for divisor behaviour
  Bartłomiej Dach · 2022-02-27 19:23:02 +01:00
  7de5dad4f0
• Add flow for specifying entirely custom snaps
  Bartłomiej Dach · 2022-02-27 17:55:20 +01:00
  423838a649
• Add flow for changing set of valid divisors between presets
  Bartłomiej Dach · 2022-02-27 15:37:51 +01:00
  d0c01afc2e
• Add simple carousel divisor type selector
  Bartłomiej Dach · 2022-02-27 15:37:51 +01:00
  36137e0619
• Change "distance spacing" multipler type to double

  Avoids losing precision on initial load, causing an unnecessary
  hash change in `EditorChangeHandler`.
  
  Resolves test failures in `TestSceneEditorChangeStates`
  (https://github.com/ppy/osu/runs/5192493482?check_suite_focus=true).

  Salman Ahmed · 2022-02-16 03:28:12 +03:00
  0992bec2c8
• Expose distance spacing in IPositionSnapProvider for updating distance grid

  Alternate method is to expose a `SnapDistancesChanged` event in
  `IPositionSnapProvider` instead, but I chose this way as an analogue to
  `IBeatSnapProvider.BeatDivisor`, which might even make sense to be
  exposed as `BindableBeatDivisor` instead of caching that separately.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  528dc03b8c
• Merge branch 'master' into improve-timeline-zoom
  Dean Herbert · 2022-01-26 03:40:53 +09:00
  bdf215c576
• Reword event handler name and update xmldoc
  Salman Ahmed · 2022-01-25 19:36:19 +03:00
  4169e5592e
• Add support for reading/saving timeline zoom in editor
  Salman Ahmed · 2022-01-25 18:57:39 +03:00
  d1cbdf63f0
• Decrease default timeline zoom to "6 seconds visible" range
  Salman Ahmed · 2022-01-25 10:43:51 +03:00
  5a9524a74e
• Replace TimeSignatures enum with struct for storage of arbitrary meter
  Bartłomiej Dach · 2022-01-22 20:50:31 +01:00
  735414bc49
• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• Add tooltip with relative rotation in degrees to rotation handles
  Bartłomiej Dach · 2022-01-08 20:24:15 +01:00
  d76c674abc
• Move implementation of drag handle operations to concrete classes
  Bartłomiej Dach · 2022-01-08 20:24:00 +01:00
  24d377fddb
• Refactor logic to avoid TimelineSelectionHandler having to block base calls
  Dean Herbert · 2022-01-05 16:56:54 +09:00
  6779503e57
• Add global flip hotkeys
  Dean Herbert · 2022-01-05 16:48:07 +09:00
  866ae3472b
• Remove existing handling of flip hotkeys
  Dean Herbert · 2022-01-05 16:30:42 +09:00
  13cce50fa7
• Fix clear identifier typos
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  98524d60a4
• Improve contrast of timeline blueprint foreground content for pastel combo colours
  Bartłomiej Dach · 2021-12-21 12:54:17 +01:00
  7ab1c0c99d
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Update editor cases where repeat should not be handled
  Dean Herbert · 2021-11-18 13:13:36 +09:00
  7599efac30
• Adjust spacings on sample point piece popover
  Bartłomiej Dach · 2021-11-13 21:59:45 +01:00
  9a19a516f9
• Improve sample bank text box UX in case of multiple selection
  Bartłomiej Dach · 2021-11-13 21:59:44 +01:00
  73ca1d39a2
• Add support for setting sample bank & volume for multiple objects at once
  Bartłomiej Dach · 2021-11-13 21:24:59 +01:00
  3fee6b0938
• Add test coverage for sample control point piece operation
  Bartłomiej Dach · 2021-11-13 18:14:50 +01:00
  9800cd4903
• Adjust difficulty point popover content spacing
  Bartłomiej Dach · 2021-11-12 23:32:12 +01:00
  e1c28ddd76