44 Commits

• Adjust rounding tolerance in distance snap grid ring colour logic
  Bartłomiej Dach · 2025-02-21 12:05:23 +01:00
  a690b0bae9
• Fix distance snap grid colours being off-by-one in certain cases

  Closes https://github.com/ppy/osu/issues/31909.
  
  Previously: https://github.com/ppy/osu/pull/30062.
  
  Happening because of rounding errors - in this case the beat index
  pre-flooring was something like a 0.003 off of a full beat, which would
  get floored down rather than rounded up which created the discrepancy.
  But also we don't want to round *too* far, which is why this
  frankenstein solution has to exist I think. This is probably all
  exacerbated by stable not handling decimal control point start times.
  
  Would add tests if not for the fact that this is like extremely annoying
  to test.

  Bartłomiej Dach · 2025-02-17 10:11:23 +01:00
  8423d9de9b
• Refactor IDistanceSnapProvider to accept slider velocity objects as a reference

  Method signatures are also changed to be a lot more explicit as to what
  inputs they expect.

  Bartłomiej Dach · 2025-02-03 14:00:57 +01:00
  a1185df2eb
• Avoid moving already placed objects temporally when "limit distance snap to current time" is active
  Bartłomiej Dach · 2025-01-31 09:51:13 +01:00
  8718483c70
• Fix distance snap grid using wrong colour when reference object is unsnapped
  Bartłomiej Dach · 2024-09-30 13:36:51 +02:00
  11fc1f9a1c
• Privatise setter
  Bartłomiej Dach · 2023-06-16 16:24:07 +02:00
  28696f595f
• Add setting to limit distance snapping to current time

  As discussed in https://github.com/ppy/osu/discussions/23815#discussioncomment-6124116.

  Dean Herbert · 2023-06-09 15:54:33 +09:00
  78b2e6f3df
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix time snap of sliders not matching when SV is not 1.0x

  This regressed with https://github.com/ppy/osu/pull/20850 because the
  function was used in other places which expect it to factor slider
  velocity into the equation.
  
  Rather than reverting, I've added a new argument, as based on the method
  naming alone it was hard to discern whether SV should actually be
  considered.
  
  The reason for the change in #20850 was to avoid the SV coming in from a
  reference object which may not have a correct SV in the first place. In
  such cases, passing `false` to the function will give the expected
  behaviour.

  Dean Herbert · 2022-11-01 15:12:58 +09:00
  2a88409dfe
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Highlight distance snap grid rings that are close to the current time value
  Dean Herbert · 2022-05-06 18:30:46 +09:00
  69592722f8
• Fix MaxIntervals incorrectly factoring distance spacing multipiler into snap calculation
  Dean Herbert · 2022-05-06 17:09:02 +09:00
  684fef7f8c
• Rename DistanceBetweenTick to be plural
  Dean Herbert · 2022-05-06 15:45:36 +09:00
  32b40bdabf
• Fix end time extent not being accounted for in new snap implementation
  Dean Herbert · 2022-05-05 18:49:12 +09:00
  b9d8b7e413
• Expose DistanceSpacingMultiplier to distance
  Dean Herbert · 2022-05-05 17:08:53 +09:00
  786c7f14d3
• Rename misleading DistanceSpacing variable
  Dean Herbert · 2022-05-05 17:08:09 +09:00
  de9b3d33eb
• Add back float cast to distance spacing computation
  Salman Ahmed · 2022-04-29 08:41:37 +03:00
  173a6188eb
• Revert "Convert data type of DistanceSpacing to float"

  This reverts commit 7aaa88cac2.

  Salman Ahmed · 2022-04-29 08:02:07 +03:00
  fef94d49f4
• Move distance spacing application to DistanceSnapGrid
  Salman Ahmed · 2022-04-28 10:54:38 +03:00
  abb88b0907
• Convert data type of DistanceSpacing to float
  Salman Ahmed · 2022-04-28 10:24:36 +03:00
  7aaa88cac2
• Minor cleanup

  Just from reading diff.

  Salman Ahmed · 2022-04-28 07:14:43 +03:00
  2e8372fe90
• Move DistanceSpacingMultiplier bindable to its own IDistanceSnapProvider interface
  Salman Ahmed · 2022-04-24 08:33:00 +03:00
  70a93c0e7e
• Change "distance spacing" multipler type to double

  Avoids losing precision on initial load, causing an unnecessary
  hash change in `EditorChangeHandler`.
  
  Resolves test failures in `TestSceneEditorChangeStates`
  (https://github.com/ppy/osu/runs/5192493482?check_suite_focus=true).

  Salman Ahmed · 2022-02-16 03:28:12 +03:00
  0992bec2c8
• Expose distance spacing in IPositionSnapProvider for updating distance grid

  Alternate method is to expose a `SnapDistancesChanged` event in
  `IPositionSnapProvider` instead, but I chose this way as an analogue to
  `IBeatSnapProvider.BeatDivisor`, which might even make sense to be
  exposed as `BindableBeatDivisor` instead of caching that separately.

  Salman Ahmed · 2022-02-15 02:21:53 +03:00
  528dc03b8c
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time

  This allows fetching the correct `DifficultyControlPoint` from the
  hitobject. Nothing more.

  Dean Herbert · 2021-09-03 17:11:12 +09:00
  d4e5a612ea
• Adjust timeline ticks to be more visible
  Dean Herbert · 2021-03-19 19:45:00 +09:00
  9be7981e0d
• Change snapping to be screen space coordinate based
  Dean Herbert · 2020-05-20 21:00:29 +09:00
  3354d48a38
• osu-side changes
  smoogipoo · 2020-02-24 20:52:15 +09:00
  6c28fd21c7
• Separate calculation to follow other examples
  smoogipoo · 2020-01-29 15:16:48 +09:00
  391681b7af
• Fix distance snap grid showing incorrect colouring

  Now matches timeline colours (based on timing point).

  Dean Herbert · 2020-01-28 11:59:21 +09:00
  29daabb40a
• Move beat index colour retrieval to static function
  Dean Herbert · 2020-01-27 17:34:40 +09:00
  df665c3a3c
• Move EditorBeatmap construction/conversion to Editor
  smoogipoo · 2019-12-30 14:51:14 +09:00
  8c378dc625
• Refactor distance snap grid to not require hitobjects
  smoogipoo · 2019-12-10 16:00:09 +09:00
  94a298a82d
• Centralise End/StartTime retrieval to extension method
  Dean Herbert · 2019-11-25 19:09:14 +09:00
  709ec1404f
• Initial implementation of limited distance snap
  smoogipoo · 2019-11-06 15:27:48 +09:00
  020b08b450
• Fix distance snap grid test scenes
  smoogipoo · 2019-10-25 17:25:46 +09:00
  ae011e8ee8
• Interface the distance snap provider
  smoogipoo · 2019-10-25 16:50:21 +09:00
  4ca6a5a0cc
• Refactor flow of snapping through HitObjectComposer
  smoogipoo · 2019-10-25 16:40:30 +09:00
  607b4d874a
• Mention coordinate space
  smoogipoo · 2019-10-24 18:24:22 +09:00
  a969914d6e
• Rename grid snapping methods
  smoogipoo · 2019-10-24 18:18:04 +09:00
  d83b9ef0e4
• Implement slider path distance snapping
  smoogipoo · 2019-10-24 18:17:30 +09:00
  f45f17339c
• Show centre point of distance snap grid
  smoogipoo · 2019-10-23 16:58:56 +09:00
  97383b4a37
• Rename grid to DistanceSnap to be more in line with its purpose
  Dean Herbert · 2019-10-17 15:32:02 +09:00
  f92331531c