Bartłomiej Dach 7c4dd812b6 Refactor beatmap attribute methods ...

This change refactors `GetAdjustedDisplayDifficulty()` and
`GetBeatmapAttributesToDisplay()` in two ways:

- Both methods now accept `IBeatmapInfo` instead of
  `IBeatmapDifficultyInfo`. This is done in order to make mania key
  count display to work, wherein `IBeatmapDifficultyInfo` is not enough
  to calculate the final key count.

- `GetAdjustedDisplayDifficulty()` now applies all
  `IApplicableToDifficulty` mods itself. I did this after noticing that
  every real consumer of this method had to do that themselves for very
  little reason.

7c4dd812b6 · 2025-07-30 14:06:34 +02:00

History

..

Components

Refactor beatmap attribute methods

2025-07-30 14:06:34 +02:00

Triangles

Move skinnable interface specification to non-abstract classes

2024-03-08 10:23:46 +08:00

ArgonProSkin.cs

Add support for Argon hitsounds

2024-03-08 21:43:18 +09:00

ArgonSkin.cs

Convert gameplay leaderboard to skinnable component

2025-04-24 13:10:30 +02:00

BeatmapSkinProvidingContainer.cs

Expand explanation in inline comment

2024-07-05 10:09:06 +09:00

DefaultLegacySkin.cs

Change ResourceStore provided to Skin to be a fallback, not replacement

2023-11-16 20:19:01 +09:00

DefaultSkinComponentsContainer.cs

Simplify and rename SkinnableTargetComponentsContainer

2023-02-15 17:30:21 +09:00

FontAdjustableSkinComponent.cs

Remove unnecessary skin settings descriptions

2025-06-30 12:00:21 +03:00

GlobalSkinColours.cs

Apply nullability to skinning support classes

2022-11-09 13:59:13 +09:00

GlobalSkinnableContainerLookup.cs

Component -> Lookup

2024-08-23 14:48:50 +09:00

GlobalSkinnableContainers.cs

Move GlobalSkinnableContainers to global scope

2024-08-22 18:46:07 +09:00

IAnimationTimeReference.cs

Add support for limiting skin texture/animation dimensions

2023-09-03 02:21:47 +03:00

IPooledSampleProvider.cs

Warm up pool with argon-specific drum samples

2023-07-05 18:44:27 +09:00

ISerialisableDrawable.cs

Remove SupportsClosestAnchor for the time being

2024-08-09 15:30:21 +09:00

ISerialisableDrawableContainer.cs

Remove unused method

2024-04-19 20:36:24 +09:00

ISkin.cs

Fix incorrect colour fallback handling

2024-08-06 15:43:39 +09:00

ISkinComponentLookup.cs

Rename GameplaySkinComponentLookup -> SkinComponentLookup

2024-08-22 18:46:03 +09:00

ISkinSource.cs

Reword and fix typos in some new xmldoc

2023-02-16 15:27:30 +09:00

ISkinTransformer.cs

Fix sprite dropdown not showing resources from non-legacy skins during gameplay

2022-09-22 18:53:43 +09:00

LegacyAccuracyCounter.cs

Fix legacy sprite texts not matching stable with respect to fixed width

2023-10-27 20:14:39 +02:00

LegacyBeatmapSkin.cs

Component -> Lookup

2024-08-23 14:48:50 +09:00

LegacyColourCompatibility.cs

Apply nullability to skinning support classes

2022-11-09 13:59:13 +09:00

LegacyDefaultComboCounter.cs

Revert default combo counter code to pre-abstractification (and nuke eldritch abstract entity)

2024-09-11 11:44:59 +02:00

LegacyFont.cs

Apply nullability to skinning support classes

2022-11-09 13:59:13 +09:00

LegacyHealthDisplay.cs

Fix incorrect sizing of legacy health display "ki" markers

2025-04-08 13:52:07 +09:00

LegacyJudgementPieceNew.cs

Revert "Remove dead code" (mostly)

2024-01-29 19:43:40 +09:00

LegacyJudgementPieceOld.cs

Adjust slider tick / end misses to show slightly longer

2024-01-31 17:41:26 +09:00

LegacyKeyCounter.cs

Sanitise font sizes / weights

2024-08-06 15:17:43 +09:00

LegacyKeyCounterDisplay.cs

Fix legacy key counter's background being visible when intended to be hidden

2024-08-06 16:12:00 +09:00

LegacyKiaiFlashingDrawable.cs

Fix incorrect application layer causing completely discoloured circles

2023-01-11 19:29:17 +09:00

LegacyManiaSkinConfiguration.cs

Add support for legacy osu!mania barline height and colour spec

2025-02-28 15:13:13 +09:00

LegacyManiaSkinConfigurationLookup.cs

Clarify purpose of helper lookup entries in osu!mania skinning

2025-05-01 06:30:32 +03:00

LegacyManiaSkinDecoder.cs

Add support for legacy osu!mania barline height and colour spec

2025-02-28 15:13:13 +09:00

LegacyNoteBodyStyle.cs

Add comment regarding unused enum members in LegacyNoteBodyStyle

2023-02-13 17:43:52 +09:00

LegacyRankDisplay.cs

Add support for rank change SFX to LegacyRankDisplay and debouncing

2025-06-12 14:42:29 +09:00

LegacyRollingCounter.cs

Apply NRT to all simple auxiliary skin classes

2023-01-26 17:53:04 +09:00

LegacyScoreCounter.cs

Fix legacy sprite texts not matching stable with respect to fixed width

2023-10-27 20:14:39 +02:00

LegacySkin.cs

Fix beatmap skin sample lookups falling back to non-custom sample banks if the custom sample bank sample was not found

2025-06-27 13:00:50 +02:00

LegacySkinDecoder.cs

Apply NRT to all simple auxiliary skin classes

2023-01-26 17:53:04 +09:00

LegacySkinExtensions.cs

Fix potential texture corruption when cropping gameplay textures of weird aspet ratios

2023-10-31 17:36:23 +09:00

LegacySkinTransformer.cs

Add back removed xmldoc

2024-08-08 16:36:54 +09:00

LegacySongProgress.cs

Update usage of CircularProgress.Current

2024-03-06 12:13:10 +08:00

LegacySpriteText.cs

Use zero baseline for legacy sprite text display

2024-08-15 13:07:42 +09:00

LegacyTextureLoaderStore.cs

Update ImageSharp usages

2024-03-06 12:13:12 +08:00

MaxDimensionLimitedTextureLoaderStore.cs

Update ImageSharp usages

2024-03-06 12:13:12 +08:00

PausableSkinnableSound.cs

Partial everything

2022-11-27 00:00:27 +09:00

PoolableSkinnableSample.cs

Bring back and make use of clearPreviousSamples()

2023-03-23 18:46:48 +01:00

RealmBackedResourceStore.cs

Add inline comments for iOS locals

2024-09-26 16:48:42 +09:00

ResourceStoreBackedSkin.cs

Fix one more new inspection in EAP 2025

2025-01-20 15:00:35 +09:00

RulesetSkinProvidingContainer.cs

Fix classic fallback not having a transformer (and only add if required)

2024-07-04 20:17:39 +09:00

SerialisableDrawableExtensions.cs

Update HasFlag usages

2024-07-03 00:19:04 +09:00

SerialisedDrawableInfo.cs

Update HasFlag usages

2024-07-03 00:19:04 +09:00

Skin.cs

Fix deserialise failing with some old skins

2024-08-23 20:44:45 +09:00

SkinComboColourLookup.cs

Apply nullability to skinning support classes

2022-11-09 13:59:13 +09:00

SkinComponentLookup.cs

Rename GameplaySkinComponentLookup -> SkinComponentLookup

2024-08-22 18:46:03 +09:00

SkinConfigManager.cs

Apply nullability to skinning support classes

2022-11-09 13:59:13 +09:00

SkinConfiguration.cs

Simplify input overlay text colour decode (and fix incorrect default)

2024-07-24 14:53:01 +02:00

SkinCustomColourLookup.cs

Apply NRT to all simple auxiliary skin classes

2023-01-26 17:53:04 +09:00

SkinImporter.cs

Write new name to skin.ini when renaming skin via settings

2025-07-11 15:18:20 +02:00

SkinInfo.cs

Store layout version in SkinLayoutVersion instead and refactor migration code

2024-07-01 08:30:37 +03:00

SkinLayoutInfo.cs

Rename SkinComponentsContainer to SkinnableContainer

2024-08-22 17:42:50 +09:00

SkinManager.cs

Write new name to skin.ini when renaming skin via settings

2025-07-11 15:18:20 +02:00

SkinnableContainer.cs

Remove requirement of base calls to ensure user skin container layouts are retrieved

2024-08-22 19:14:30 +09:00

SkinnableDrawable.cs

Partial everything

2022-11-27 00:00:27 +09:00

SkinnableSound.cs

Fix old looping samples not stopping when replacing a SkinnableSound's Samples

2024-10-22 14:35:21 +02:00

SkinnableSprite.cs

Remove unnecessary skin settings descriptions

2025-06-30 12:00:21 +03:00

SkinnableSpriteText.cs

Partial everything

2022-11-27 00:00:27 +09:00

SkinProvidingContainer.cs

Fix nullability failure

2024-07-04 20:17:40 +09:00

SkinReloadableDrawable.cs

Add xmldoc for new method and reorder methods in SkinReloadableDrawable

2023-03-16 15:58:42 +09:00

SkinTransformer.cs

Revert "Update GetTexture signature rather than creating new overload"

2023-09-19 03:21:19 +03:00

SkinUtils.cs

Apply nullability to skinning support classes

2022-11-09 13:59:13 +09:00

TrianglesSkin.cs

Fix TriangleSkin not always returning a container for GlobalSkinnableContainerLookup

2025-04-26 05:14:36 +09:00

UnsupportedSkinComponentException.cs

Remove LookupName from base ISkinComponentLookup

2022-11-09 17:46:43 +09:00

UserSkinComponentLookup.cs

Remove requirement of base calls to ensure user skin container layouts are retrieved

2024-08-22 19:14:30 +09:00