Dean Herbert
d9d0629157
Fix code quality inspection (weird one)
2023-10-16 15:16:10 +09:00
Dean Herbert
4f1546c474
Rename PerfectBonusNote to NotePerfectBonus
2023-10-16 15:14:28 +09:00
Dean Herbert
3f09ed396f
Fix legacy skin body piece dimming when it shouldn't
2023-10-16 15:11:33 +09:00
Dean Herbert
1a957364ae
Add empty hit windows on PefectBonusNote
2023-10-16 14:58:49 +09:00
Dean Herbert
43f619f92a
Add DisplayResult flag and remove unnecessary AlwaysPresent
2023-10-16 14:57:58 +09:00
Dean Herbert
14fedffcc1
Fix MissForcefully not considering the bonus object
2023-10-16 14:53:36 +09:00
Dean Herbert
7c49843411
Fix various tests
2023-10-16 14:21:33 +09:00
Dean Herbert
e85c039722
Adjust method flow to hopefully be more legible
2023-10-16 13:31:14 +09:00
Dean Herbert
ddbda69751
Remove nullability of bonusNote
2023-10-16 13:14:58 +09:00
Dean Herbert
850950ba61
Add note about why SmallBonus is not listed in GetValidHitResults
2023-10-13 17:36:30 +09:00
Dean Herbert
125f28219d
Fix hodl tail notes not correctly handling nested bonus judgement
2023-10-13 17:36:19 +09:00
Dean Herbert
94b64044e0
Add nested bonus judgement to DrawableNote for perfect bonus score
2023-10-13 17:01:48 +09:00
Dean Herbert
3787348448
Change Perfect judgement to not give extra score
2023-10-13 16:29:02 +09:00
Dean Herbert
7c36848eb1
Merge pull request #25104 from bdach/make-realm-key-binding-action-suck-less
...
Refactor key binding panel for easier usage
2023-10-13 14:27:07 +09:00
Dean Herbert
549a6581b0
Merge branch 'master' into make-realm-key-binding-action-suck-less
2023-10-13 13:53:24 +09:00
Dean Herbert
9289c47cd4
Tidy up GlobalActionContainer a bit
2023-10-13 13:47:51 +09:00
Dean Herbert
aabed8b6e5
Merge pull request #25093 from Joehuu/mod-switch-tiny-extended-info
...
Add extended info support to tiny mod switches
2023-10-13 13:40:24 +09:00
Bartłomiej Dach
edec10204e
Merge pull request #25096 from peppy/show-total-bonus
...
Show maximum bonus statistics on results screen
2023-10-12 20:29:28 +02:00
Bartłomiej Dach
c2e92cbb70
Refactor key binding panel leveraging new helper methods
2023-10-12 15:03:29 +02:00
Bartłomiej Dach
1c784c9abe
Add API for retrieving global key bindings per section
2023-10-12 14:24:21 +02:00
Bartłomiej Dach
2a0e4c364d
Add method to unmap RealmKeyBinding.Action to actual enum-typed value
2023-10-12 14:17:26 +02:00
Dean Herbert
45db4ab412
Merge pull request #25100 from bdach/large-tick-mania-begone
...
Remove remaining usages of `LargeTick{Hit,Miss}` in mania
2023-10-12 19:13:10 +09:00
Bartłomiej Dach
34bab38e80
Fix judgement counter test failure due to exploiting mania ruleset
...
Large ticks are not a thing in mania anymore, so the judgement counter
tests began to fail as `LargeTickHit` is no longer a valid hit result
in that ruleset.
2023-10-12 11:34:59 +02:00
Bartłomiej Dach
a42e75452e
Remove remaining usages of LargeTickHit in mania
2023-10-12 11:16:51 +02:00
Dean Herbert
d2044fc2cc
Merge pull request #25082 from peppy/test-scene-background
...
Remove test scene background stack and use new `ChangeBackgroundColour`
2023-10-12 14:57:34 +09:00
Dean Herbert
5bb73632c4
Show maximum bonus statistics on results screen
...
Addresses https://github.com/ppy/osu/discussions/25088 .
2023-10-12 14:55:16 +09:00
Dean Herbert
194ad9650d
Remove test scene background stack and use new ChangeBackgroundColour method
2023-10-12 14:08:31 +09:00
Dean Herbert
29eba3c58a
Update framework
2023-10-12 14:08:31 +09:00
Dean Herbert
f26e3afd29
Merge pull request #25062 from smoogipoo/remove-hold-note-ticks
...
Remove osu!mania hold note ticks
2023-10-12 13:55:50 +09:00
Dean Herbert
52255b15f0
Merge pull request #25092 from bdach/key-binding-row-cleanups
...
Clean up `KeyBindingRow` and related classes
2023-10-12 13:38:52 +09:00
Joseph Madamba
764f641bc9
Add extended info support to tiny mod switches
2023-10-11 12:47:12 -07:00
Bartłomiej Dach
712564ea4f
Enable NRT in KeyBindingsSubsection
2023-10-11 20:03:31 +02:00
Bartłomiej Dach
063623b4e6
Merge branch 'master' into remove-hold-note-ticks
2023-10-11 19:47:51 +02:00
Bartłomiej Dach
041318e3e8
Assign red colour to ComboBreak hit result
...
For a judgement result to show up on the colour hit error meter, it has
to be two things: be scorable, and not be bonus.
`ComboBreak` happens to meet both of those criteria - it impacts score
indirectly via decreasing the combo portion, and isn't bonus. Therefore
it would show up on the colour hit error meter, but because
`OsuColour.ForHitResult()` wasn't handling it explicitly, it was
painting the result in light blue, which isn't ideal for a miss type
judgement. Therefore, use red instead.
There is possibly an argument to be made that this judgement should not
show up on the colour hit error meter at all, but I think it's actually
okay for it to be this way. In any case it doesn't appear to be anything
so major as to warrant blocking the hold note tick removal at this time.
2023-10-11 19:44:46 +02:00
Bartłomiej Dach
3f29f27cd4
Assign empty hit windows to HoldNoteBody
...
It's not a timed object, so following precedent, it should have empty
hitwindows.
This is not actually just aesthetics; several components check whether a
hitobject has empty hitwindows to determine whether to include it on
various HUD displays and results screen components where timed objects
are explicitly involved.
2023-10-11 19:40:55 +02:00
Bartłomiej Dach
797109c05c
Enable NRT in KeyBindingRow
2023-10-11 08:50:00 +02:00
Bartłomiej Dach
0b2b065383
Add xmldoc
2023-10-11 08:50:00 +02:00
Bartłomiej Dach
7ac874d17a
Use init-only properties where applicable
2023-10-11 08:49:58 +02:00
Bartłomiej Dach
1acc02405e
Reorder KeyBindingRow members
2023-10-11 08:18:59 +02:00
Bartłomiej Dach
eeb5409733
Merge pull request #25081 from peppy/song-bar-less-black
...
Reduce black fill of song bar in tournament UI back to reasonable levels
2023-10-10 22:28:50 +02:00
Bartłomiej Dach
969c1b0812
Merge pull request #25074 from peppy/fix-argon-health-bar-flash
...
Fix argon health bar not completing flash animation correctly
2023-10-10 22:28:30 +02:00
Bartłomiej Dach
6f5f3a1ef4
Merge branch 'master' into fix-argon-health-bar-flash
2023-10-10 20:03:20 +02:00
Bartłomiej Dach
66c12e5269
Merge pull request #25083 from peppy/fix-preview-point-incorrect
...
Fix default preview point being incorrect on old beatmaps
2023-10-10 19:54:14 +02:00
Dean Herbert
b9dbc8139b
Merge branch 'master' into fix-argon-health-bar-flash
2023-10-11 00:20:08 +09:00
Bartłomiej Dach
d701e88a08
Merge pull request #25076 from peppy/fix-argon-health-bar-perf
...
Ensure health displays don't pile up transforms when off-screen
2023-10-10 16:33:32 +02:00
Bartłomiej Dach
0c64fe7eaa
Merge pull request #25079 from peppy/fix-player-startup-stop
...
Fix multiplayer not correctly pausing the track on initialisation
2023-10-10 16:30:35 +02:00
Dean Herbert
b9dadc52b7
Adjust comment to match current behaviour
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-10-10 22:54:19 +09:00
Dean Herbert
e2e28ef0ca
Remove comment regarding inlined delegate
2023-10-10 22:12:20 +09:00
Dean Herbert
682aa06acf
Remove JudgementResult from Miss/Flash as it is not used
2023-10-10 22:10:44 +09:00
Dan Balasescu
a1a46e58fc
Move validation to DHO.ApplyResult()
2023-10-10 21:42:37 +09:00
