h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-26 16:12:54 +08:00
Code Issues Releases Wiki Activity

Rename PerfectBonusNote to NotePerfectBonus

Browse Source
This commit is contained in:
Dean Herbert 2023-10-16 15:14:26 +09:00
parent 3f09ed396f
commit 4f1546c474
No known key found for this signature in database
6 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
osu.Game.Rulesets.Mania/Objects/Drawables/DrawableNote.cs
View File

@ -40,7 +40,7 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
private Drawable headPiece;
private DrawablePerfectBonusNote bonusNote;
private DrawableNotePerfectBonus perfectBonus;
public DrawableNote()
: this(null)
@ -94,7 +94,7 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
{
if (!HitObject.HitWindows.CanBeHit(timeOffset))
{
bonusNote.TriggerResult(false);
perfectBonus.TriggerResult(false);
ApplyResult(r => r.Type = r.Judgement.MinResult);
}
@ -107,13 +107,13 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
result = GetCappedResult(result);
bonusNote.TriggerResult(result == HitResult.Perfect);
perfectBonus.TriggerResult(result == HitResult.Perfect);
ApplyResult(r => r.Type = result);
}
public override void MissForcefully()
{
bonusNote.TriggerResult(false);
perfectBonus.TriggerResult(false);
base.MissForcefully();
}
@ -141,23 +141,23 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
{
switch (hitObject)
{
case DrawablePerfectBonusNote bonus:
AddInternal(bonusNote = bonus);
case DrawableNotePerfectBonus bonus:
AddInternal(perfectBonus = bonus);
break;
}
}
protected override void ClearNestedHitObjects()
{
RemoveInternal(bonusNote, false);
RemoveInternal(perfectBonus, false);
}
protected override DrawableHitObject CreateNestedHitObject(HitObject hitObject)
{
switch (hitObject)
{
case PerfectBonusNote bonus:
return new DrawablePerfectBonusNote(bonus);
case NotePerfectBonus bonus:
return new DrawableNotePerfectBonus(bonus);
}
return base.CreateNestedHitObject(hitObject);

6
osu.Game.Rulesets.Mania/Objects/Drawables/DrawablePerfectBonusNote.cs → osu.Game.Rulesets.Mania/Objects/Drawables/DrawableNotePerfectBonus.cs
View File

@ -3,16 +3,16 @@
namespace osu.Game.Rulesets.Mania.Objects.Drawables
{
public partial class DrawablePerfectBonusNote : DrawableManiaHitObject<PerfectBonusNote>
public partial class DrawableNotePerfectBonus : DrawableManiaHitObject<NotePerfectBonus>
{
public override bool DisplayResult => false;
public DrawablePerfectBonusNote()
public DrawableNotePerfectBonus()
: this(null!)
{
}
public DrawablePerfectBonusNote(PerfectBonusNote hitObject)
public DrawableNotePerfectBonus(NotePerfectBonus hitObject)
: base(hitObject)
{
}

2
osu.Game.Rulesets.Mania/Objects/Note.cs
View File

@ -18,7 +18,7 @@ namespace osu.Game.Rulesets.Mania.Objects
{
base.CreateNestedHitObjects(cancellationToken);
AddNested(new PerfectBonusNote { StartTime = StartTime });
AddNested(new NotePerfectBonus { StartTime = StartTime });
}
}
}

6
osu.Game.Rulesets.Mania/Objects/PerfectBonusNote.cs → osu.Game.Rulesets.Mania/Objects/NotePerfectBonus.cs
View File

@ -7,12 +7,12 @@ using osu.Game.Rulesets.Scoring;
namespace osu.Game.Rulesets.Mania.Objects
{
public class PerfectBonusNote : ManiaHitObject
public class NotePerfectBonus : ManiaHitObject
{
public override Judgement CreateJudgement() => new PerfectBonusNoteJudgement();
public override Judgement CreateJudgement() => new NotePerfectBonusJudgement();
protected override HitWindows CreateHitWindows() => HitWindows.Empty;
public class PerfectBonusNoteJudgement : ManiaJudgement
public class NotePerfectBonusJudgement : ManiaJudgement
{
public override HitResult MaxResult => HitResult.SmallBonus;
}

2
osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyBodyPiece.cs
View File

@ -126,7 +126,7 @@ namespace osu.Game.Rulesets.Mania.Skinning.Legacy
switch (hitObject)
{
// Ensure that the hold note is also faded out when the head/tail/any tick is missed.
// Importantly, we filter out unrelated objects like DrawablePerfectBonusNote.
// Importantly, we filter out unrelated objects like DrawableNotePerfectBonus.
case DrawableHoldNoteTail:
case DrawableHoldNoteHead:
case DrawableHoldNoteBody:

2
osu.Game.Rulesets.Mania/UI/Column.cs
View File

@ -109,7 +109,7 @@ namespace osu.Game.Rulesets.Mania.UI
TopLevelContainer.Add(HitObjectArea.Explosions.CreateProxy());
RegisterPool<Note, DrawableNote>(10, 50);
RegisterPool<PerfectBonusNote, DrawablePerfectBonusNote>(10, 50);
RegisterPool<NotePerfectBonus, DrawableNotePerfectBonus>(10, 50);
RegisterPool<HoldNote, DrawableHoldNote>(10, 50);
RegisterPool<HeadNote, DrawableHoldNoteHead>(10, 50);
RegisterPool<TailNote, DrawableHoldNoteTail>(10, 50);